mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

re-close with comment

Browse source
This commit is contained in:
Joey Hess 2023-03-06 12:25:39 -04:00
parent 433608753a
commit efd5bfa72d
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf.mdwn
View file

@ -118,3 +118,5 @@ Git Annex is great. I use it several times a week with my multigigabyte backups,
> Utility.RawFilePath.getFileStatus instead. \[\[done\]\] --[[Joey]] > Utility.RawFilePath.getFileStatus instead. \[\[done\]\] --[[Joey]]
>> Sorry, I had to reopen the bug as Joey's commit didn't quite compile. See page comments for details. --[[jkniiv]] >> Sorry, I had to reopen the bug as Joey's commit didn't quite compile. See page comments for details. --[[jkniiv]]
>>> Should be fully fixed now. [[done]] --[[Joey]]

22
doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf/comment_3_c46e7c7f3870b54563eb8e94d451fded._comment Normal file
View file

@ -0,0 +1,22 @@
[[!comment format=mdwn
username="joey"
subject="""comment 3"""
date="2023-03-06T16:17:37Z"
content="""
That's great news about the test suite in a deep directory. That was a
longstanding problem indeed and a good indication it's fully supporting
long filenames now.
I often mix up fromRawFilePath/toRawFilePath. Luckily the compiler will
notice. Should be fixed now.
As for converting the whole `watchDir` to RawFilePath, there is probably
not much benefit in doing that in such windows-specific code, but the goal
is to do such a conversion in as much of git-annex as possible, since it is
faster on unix to use RawFilePath end-to-end.
Doing it is as simple as juggling the use of fromRawFilePath/toRawFilePath
as the compiler allows, while converting code to use functions from
Utility.RawFilePath or System.FilePath.ByteString or that otherwise
use RawFilePath. I think you would be capable of that for sure!
"""]]