From efd5bfa72dc68eb414a678f76d7b002f2ace98dd Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 6 Mar 2023 12:25:39 -0400 Subject: [PATCH] re-close with comment --- ..._fails_starting_from_commit_54ad1b4cf.mdwn | 2 ++ ..._c46e7c7f3870b54563eb8e94d451fded._comment | 22 +++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf/comment_3_c46e7c7f3870b54563eb8e94d451fded._comment diff --git a/doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf.mdwn b/doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf.mdwn index fa97db76a0..3a84a49494 100644 --- a/doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf.mdwn +++ b/doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf.mdwn @@ -118,3 +118,5 @@ Git Annex is great. I use it several times a week with my multigigabyte backups, > Utility.RawFilePath.getFileStatus instead. \[\[done\]\] --[[Joey]] >> Sorry, I had to reopen the bug as Joey's commit didn't quite compile. See page comments for details. --[[jkniiv]] + +>>> Should be fully fixed now. [[done]] --[[Joey]] diff --git a/doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf/comment_3_c46e7c7f3870b54563eb8e94d451fded._comment b/doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf/comment_3_c46e7c7f3870b54563eb8e94d451fded._comment new file mode 100644 index 0000000000..efc9c195c9 --- /dev/null +++ b/doc/bugs/windows_build_fails_starting_from_commit_54ad1b4cf/comment_3_c46e7c7f3870b54563eb8e94d451fded._comment @@ -0,0 +1,22 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 3""" + date="2023-03-06T16:17:37Z" + content=""" +That's great news about the test suite in a deep directory. That was a +longstanding problem indeed and a good indication it's fully supporting +long filenames now. + +I often mix up fromRawFilePath/toRawFilePath. Luckily the compiler will +notice. Should be fixed now. + +As for converting the whole `watchDir` to RawFilePath, there is probably +not much benefit in doing that in such windows-specific code, but the goal +is to do such a conversion in as much of git-annex as possible, since it is +faster on unix to use RawFilePath end-to-end. + +Doing it is as simple as juggling the use of fromRawFilePath/toRawFilePath +as the compiler allows, while converting code to use functions from +Utility.RawFilePath or System.FilePath.ByteString or that otherwise +use RawFilePath. I think you would be capable of that for sure! +"""]]