clarify absPathFrom

The repo path is typically relative, not absolute, so
providing it to absPathFrom doesn't yield an absolute path.
This is not a bug, just unclear documentation.

Indeed, there seem to be no reason to simplifyPath here, which absPathFrom
does, so instead just combine the repo path and the TopFilePath.

Also, removed an export of the TopFilePath constructor; asTopFilePath
is provided to construct one as-is.

Database/Keys.hs

@@ -188,7 +188,7 @@ getAssociatedFiles' sk = readDb $ do
 	l <- select $ from $ \r -> do
 		where_ (r ^. AssociatedKey ==. val sk)
 		return (r ^. AssociatedFile)
-	return $ map (TopFilePath . unValue) l
+	return $ map (asTopFilePath . unValue) l
 
 {- Gets any keys that are on record as having a particular associated file.
  - (Should be one or none but the database doesn't enforce that.) -}

Git/FilePath.hs

@@ -13,7 +13,8 @@
 {-# LANGUAGE CPP #-}
 
 module Git.FilePath (
-	TopFilePath(..),
+	TopFilePath,
+	getTopFilePath,
 	fromTopFilePath,
 	toTopFilePath,
 	asTopFilePath,
@@ -32,9 +33,9 @@ import qualified System.FilePath.Posix
 newtype TopFilePath = TopFilePath { getTopFilePath :: FilePath }
 	deriving (Show)
 
-{- Returns an absolute FilePath. -}
+{- Path to a TopFilePath, within the provided git repo. -}
 fromTopFilePath :: TopFilePath -> Git.Repo -> FilePath
-fromTopFilePath p repo = absPathFrom (repoPath repo) (getTopFilePath p)
+fromTopFilePath p repo = combine (repoPath repo) (getTopFilePath p)
 
 {- The input FilePath can be absolute, or relative to the CWD. -}
 toTopFilePath :: FilePath -> Git.Repo -> IO TopFilePath

Utility/Path.hs

@@ -60,7 +60,7 @@ simplifyPath path = dropTrailingPathSeparator $
 {- Makes a path absolute.
  -
  - The first parameter is a base directory (ie, the cwd) to use if the path
- - is not already absolute.
+ - is not already absolute, and should itsef be absolute.
  -
  - Does not attempt to deal with edge cases or ensure security with
  - untrusted inputs.