Revert "Unset IFS in shell scripts in the linux standalone build and OSX app."
This reverts commit 24125e8dc4
.
yoh has a better patch I see
This commit is contained in:
parent
24125e8dc4
commit
79187a6eaf
18 changed files with 0 additions and 43 deletions
|
@ -1,26 +0,0 @@
|
|||
[[!comment format=mdwn
|
||||
username="joey"
|
||||
subject="""comment 2"""
|
||||
date="2020-07-24T18:17:12Z"
|
||||
content="""
|
||||
Hmm, so runshell has some things like
|
||||
|
||||
for lib in $(cat "$base/libdirs"); do
|
||||
GIT_ANNEX_LD_LIBRARY_PATH=...
|
||||
|
||||
Which, with an unusual IFS, probably set the environment variable to
|
||||
something bogus. Which seems the kind of thing that could break things
|
||||
badly enough to segfault.
|
||||
|
||||
I have so far not been able to reproduce it, I tried:
|
||||
|
||||
tar zxvf ~/src/git-annex/tmp/git-annex-standalone-amd64.tar.gz
|
||||
cd git-annex.linux/
|
||||
IFS=$'\013' ./git-annex version
|
||||
|
||||
But this may involve the system the standalone build is used in, if the
|
||||
problem is this is breaking its isolation from that system. So might need a
|
||||
particular version skew between the two.
|
||||
|
||||
I've applied the obvious changes, so please verify the fix.
|
||||
"""]]
|
Loading…
Add table
Add a link
Reference in a new issue