mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

comment

Browse source
This commit is contained in:
Joey Hess 2021-03-30 12:48:43 -04:00
parent 773752b040
commit 4459e04117
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
doc/bugs/sync_--content_succeeds_w__47__o_fetching_all_files/comment_1_9581f8135c6eb2ed2135f83a266e5306._comment Normal file
View file

@ -0,0 +1,27 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2021-03-30T16:07:30Z"
content="""
I don't think the `git-annex sync` documentation says in what situation
it will exit nonzero, so the extent this is really a bug is debatable.
The general rule is that, if git-annex looks at a file or other item,
decides it needs to take some action, and then that action fails, it will
later exit nonzero. And sync does behave that way: When it determines a
file is not in any of the remotes it's syncing with, it does not try to
download it from anywhere, so no action fails.
The counterargument to that would be by analogy to `git-annex get`
which does exit nonzero when no available remotes contain
a file (because it acts on every file that's not already present).
We could say that sync is currently behaving more like `git-annex get --from
foo` which skips files not on the specified remote, and that it's
doing it even when no particular remotes are specified, and that it would
be better, when no particular remotes are specified, for it to behave like
`git-annex get`.
I don't know if most users would come up with this analogy though..
I also wonder if you would not be better off just using `git-annex get`
if you want to check exit status based on if all files are present.
"""]]