mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

avoid stageJournal escaping withOtherTmp

Browse source 
This is only done for correctness sake; I don't see any way that it
would have caused a problem here. The jlog file escaped withOtherTmp
so another process could swoop in and delete it, but the file is only
used as a buffer for a list of filenames, and its handle gets rewound
and they're read back out, which will still work even if it's already
been deleted.

The only reason I didn't just pre-delete the file and keep the handle
open is I'm not sure that works on all OS's (eg Windows). If there was
a problem that this fixed it might involve an OS that doesn't support
deleting an open file or something like that.
This commit is contained in:
Joey Hess 2019-05-07 11:57:12 -04:00
parent ce83783fcc
commit 2a41712ef1
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/withOtherTmp_file_escapes.mdwn
View file

@ -18,5 +18,5 @@ This is a fairly new problem because the code to have other processes
cleanup stale othertmp files was only added a couple months back.
I audited other uses of withOtherTmp, and the only other problem I found is
similar, in Annex.Branch.stageJournal.
similar, in Annex.Branch.stageJournal. Fixed that one.
--[[Joey]]