mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

bug report

Browse source
This commit is contained in:
Joey Hess 2019-05-07 11:40:45 -04:00
parent 09c2516487
commit ce83783fcc
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 32 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
doc/bugs/withOtherTmp_file_escapes.mdwn Normal file
View file

@ -0,0 +1,22 @@
This was reported with concurrent processes, I think probably during a `git
annex add` but not sure:
git-annex: .git/annex/othertmp/inge59014-3: getFileStatus: does not exist (No such file or directory)
failed
git-annex: .git/annex/othertmp/ingest-assemble_den59014-8: removeLink: does not exist (No such file or directory)
failed
From the "ingest" in the name, these files are from
`Annex.Ingest.lockDown'`, which uses `withOtherTmp`, hard links the file
into the temp directory, and then returns a LockedDown that includes the
temp filepath. So, it's escaped the locking that `withOtherTmp` does, and
another process can clean up the temp files at the wrong point in time.
This will need some significant code reworking to fix.
This is a fairly new problem because the code to have other processes
cleanup stale othertmp files was only added a couple months back.
I audited other uses of withOtherTmp, and the only other problem I found is
similar, in Annex.Branch.stageJournal.
--[[Joey]]

10
doc/forum/git-annex_parallel_invocation_and_the_git-annex_branch/comment_7_ae5fb82005702e9b5ed14fa37f80a91a._comment Normal file
View file

@ -0,0 +1,10 @@
[[!comment format=mdwn
username="joey"
subject="""comment 7"""
date="2019-05-07T15:39:54Z"
content="""
[[bugs/withOtherTmp_file_escapes]]
I don't think you need to use the same filesystem, but it will be slower
when git-annex can't hard link and has to fall back to copying.
"""]]