push location log updating up to callers of download

Prep for move --to --from, which needs to download from a src repo
without updating the location log for the local repo, before sending the
content on to the dest repo.

Note that caller of download' already update the log themselves.
See previous commit a422a056f2
that pushed it up to download from getViaTmpFrom.

(Also removed in passing a debug print + readline that I accidentially
committed last week on this branch.)

Sponsored-by: Dartmouth College's DANDI project
This commit is contained in:
Joey Hess 2023-01-23 13:45:26 -04:00
parent 8c349b8802
commit 1abd457e98
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 8 additions and 7 deletions

View file

@ -29,7 +29,6 @@ import Annex.Notification as X
import Annex.Content import Annex.Content
import Annex.Perms import Annex.Perms
import Annex.Action import Annex.Action
import Logs.Location
import Utility.Metered import Utility.Metered
import Utility.ThreadScheduler import Utility.ThreadScheduler
import Annex.LockPool import Annex.LockPool
@ -73,7 +72,7 @@ alwaysUpload u key f sd d a _witness = guardHaveUUID u $
-- Download, supporting canceling detected stalls. -- Download, supporting canceling detected stalls.
download :: Remote -> Key -> AssociatedFile -> RetryDecider -> NotifyWitness -> Annex Bool download :: Remote -> Key -> AssociatedFile -> RetryDecider -> NotifyWitness -> Annex Bool
download r key f d witness = logStatusAfter key $ download r key f d witness =
case remoteAnnexStallDetection (Remote.gitconfig r) of case remoteAnnexStallDetection (Remote.gitconfig r) of
Nothing -> go (Just ProbeStallDetection) Nothing -> go (Just ProbeStallDetection)
Just StallDetectionDisabled -> go Nothing Just StallDetectionDisabled -> go Nothing

View file

@ -1,6 +1,6 @@
{- git-annex command {- git-annex command
- -
- Copyright 2010, 2013 Joey Hess <id@joeyh.name> - Copyright 2010-2023 Joey Hess <id@joeyh.name>
- -
- Licensed under the GNU AGPL version 3 or higher. - Licensed under the GNU AGPL version 3 or higher.
-} -}
@ -13,6 +13,7 @@ import Annex.Transfer
import Annex.NumCopies import Annex.NumCopies
import Annex.Wanted import Annex.Wanted
import qualified Command.Move import qualified Command.Move
import Logs.Location
cmd :: Command cmd :: Command
cmd = withAnnexOptions [jobsOption, jsonOptions, jsonProgressOption, annexedMatchingOptions] $ cmd = withAnnexOptions [jobsOption, jsonOptions, jsonProgressOption, annexedMatchingOptions] $
@ -115,7 +116,6 @@ getKey' key afile = dispatch
either (const False) id <$> Remote.hasKey r key either (const False) id <$> Remote.hasKey r key
| otherwise = return True | otherwise = return True
docopy r witness = do docopy r witness = do
liftIO $ print "read line"
void $ liftIO $ getLine
showAction $ "from " ++ Remote.name r showAction $ "from " ++ Remote.name r
download r key afile stdRetry witness logStatusAfter key $
download r key afile stdRetry witness

View file

@ -19,6 +19,7 @@ import Annex.Transfer
import Logs.Presence import Logs.Presence
import Logs.Trust import Logs.Trust
import Logs.File import Logs.File
import Logs.Location
import Annex.NumCopies import Annex.NumCopies
import qualified Data.ByteString.Char8 as B8 import qualified Data.ByteString.Char8 as B8
@ -258,7 +259,8 @@ fromPerform' present src removewhen key afile = do
else dispatch removewhen deststartedwithcopy =<< get else dispatch removewhen deststartedwithcopy =<< get
where where
get = notifyTransfer Download afile $ get = notifyTransfer Download afile $
download src key afile stdRetry logStatusAfter key .
download src key afile stdRetry
dispatch _ deststartedwithcopy False = do dispatch _ deststartedwithcopy False = do
logMoveCleanup deststartedwithcopy logMoveCleanup deststartedwithcopy