2015-05-18 18:16:49 +00:00
|
|
|
{- Windows lock files, using lock pools.
|
|
|
|
-
|
|
|
|
- Copyright 2015 Joey Hess <id@joeyh.name>
|
|
|
|
-
|
|
|
|
- License: BSD-2-clause
|
|
|
|
-}
|
|
|
|
|
|
|
|
module Utility.LockPool.Windows (
|
2015-10-08 18:27:37 +00:00
|
|
|
P.LockFile,
|
2015-05-18 18:16:49 +00:00
|
|
|
LockHandle,
|
|
|
|
lockShared,
|
|
|
|
lockExclusive,
|
|
|
|
dropLock,
|
|
|
|
waitToLock,
|
|
|
|
) where
|
|
|
|
|
|
|
|
import qualified Utility.LockFile.Windows as F
|
|
|
|
import qualified Utility.LockPool.STM as P
|
|
|
|
import Utility.LockPool.LockHandle
|
2015-08-03 19:49:35 +00:00
|
|
|
import Utility.LockPool.STM (LockFile, LockMode(..))
|
2015-05-18 18:16:49 +00:00
|
|
|
|
|
|
|
{- Tries to lock a file with a shared lock, which allows other processes to
|
|
|
|
- also lock it shared. Fails if the file is exclusively locked. -}
|
|
|
|
lockShared :: LockFile -> IO (Maybe LockHandle)
|
Fix shared lock file FD leak.
This fixes behavior in this situation:
l1 <- lockShared Nothing "lck"
l2 <- lockShared Nothing "lck"
dropLock l1
dropLock l2
Before, the lock was dropped upon the second dropLock call, but the fd
remained open, and would never be closed while the program was running.
Fixed by a rather round-about method, but it should work well enough.
It would have been simpler to open open the shared lock once, and not open
it again in the second call to lockShared. But, that's difficult to do
atomically.
This also affects Windows and PID locks, not just posix locks.
In the case of pid locks, multiple calls to waitLock within the same
process are allowed because the side lock is locked using a posix lock,
and so multiple exclusive locks can be taken in the same process. So,
this change fixes a similar problem with pid locks.
l1 <- waitLock (Seconds 1) "lck"
l2 <- waitLock (Seconds 1) "lck"
dropLock l1
dropLock l2
Here the l2 side lock fd remained open but not locked,
although the pid lock file was removed. After this change, the second
dropLock will close both fds to the side lock, and delete the pidlock.
2016-03-01 19:31:39 +00:00
|
|
|
lockShared file = tryMakeLockHandle P.lockPool file
|
|
|
|
(\p f -> P.tryTakeLock p f LockShared)
|
|
|
|
(\f -> fmap mk <$> F.lockShared f)
|
2015-05-18 18:16:49 +00:00
|
|
|
|
|
|
|
{- Tries to take an exclusive lock on a file. Fails if another process has
|
|
|
|
- a shared or exclusive lock.
|
|
|
|
-
|
|
|
|
- Note that exclusive locking also prevents the file from being opened for
|
|
|
|
- read or write by any other process. So for advisory locking of a file's
|
|
|
|
- content, a separate LockFile should be used. -}
|
|
|
|
lockExclusive :: LockFile -> IO (Maybe LockHandle)
|
Fix shared lock file FD leak.
This fixes behavior in this situation:
l1 <- lockShared Nothing "lck"
l2 <- lockShared Nothing "lck"
dropLock l1
dropLock l2
Before, the lock was dropped upon the second dropLock call, but the fd
remained open, and would never be closed while the program was running.
Fixed by a rather round-about method, but it should work well enough.
It would have been simpler to open open the shared lock once, and not open
it again in the second call to lockShared. But, that's difficult to do
atomically.
This also affects Windows and PID locks, not just posix locks.
In the case of pid locks, multiple calls to waitLock within the same
process are allowed because the side lock is locked using a posix lock,
and so multiple exclusive locks can be taken in the same process. So,
this change fixes a similar problem with pid locks.
l1 <- waitLock (Seconds 1) "lck"
l2 <- waitLock (Seconds 1) "lck"
dropLock l1
dropLock l2
Here the l2 side lock fd remained open but not locked,
although the pid lock file was removed. After this change, the second
dropLock will close both fds to the side lock, and delete the pidlock.
2016-03-01 19:31:39 +00:00
|
|
|
lockExclusive file = tryMakeLockHandle P.lockPool file
|
2016-03-05 16:32:06 +00:00
|
|
|
(\p f -> P.tryTakeLock p f LockExclusive)
|
Fix shared lock file FD leak.
This fixes behavior in this situation:
l1 <- lockShared Nothing "lck"
l2 <- lockShared Nothing "lck"
dropLock l1
dropLock l2
Before, the lock was dropped upon the second dropLock call, but the fd
remained open, and would never be closed while the program was running.
Fixed by a rather round-about method, but it should work well enough.
It would have been simpler to open open the shared lock once, and not open
it again in the second call to lockShared. But, that's difficult to do
atomically.
This also affects Windows and PID locks, not just posix locks.
In the case of pid locks, multiple calls to waitLock within the same
process are allowed because the side lock is locked using a posix lock,
and so multiple exclusive locks can be taken in the same process. So,
this change fixes a similar problem with pid locks.
l1 <- waitLock (Seconds 1) "lck"
l2 <- waitLock (Seconds 1) "lck"
dropLock l1
dropLock l2
Here the l2 side lock fd remained open but not locked,
although the pid lock file was removed. After this change, the second
dropLock will close both fds to the side lock, and delete the pidlock.
2016-03-01 19:31:39 +00:00
|
|
|
(\f -> fmap mk <$> F.lockExclusive f)
|
2015-05-18 18:16:49 +00:00
|
|
|
|
|
|
|
{- If the initial lock fails, this is a BUSY wait, and does not
|
|
|
|
- guarentee FIFO order of waiters. In other news, Windows is a POS. -}
|
2015-05-22 17:50:37 +00:00
|
|
|
waitToLock :: IO (Maybe lockhandle) -> IO lockhandle
|
2015-05-18 18:16:49 +00:00
|
|
|
waitToLock = F.waitToLock
|
2015-11-12 20:28:11 +00:00
|
|
|
|
|
|
|
mk :: F.LockHandle -> FileLockOps
|
|
|
|
mk h = FileLockOps
|
|
|
|
{ fDropLock = F.dropLock h
|
|
|
|
}
|