No description
Find a file
Pedro Pontes d5d1fa8290 fix: use appropriate site instance for cross-site nav's (#15821)
* fix: use Chromium's determined new site instance as candidate when navigating.

When navigating to a new address, consider using Chromium's determined site instance
for the new page as it should belong to an existing browsing instance when the
navigation was triggered by window.open().

fixes 8100.

* Revert "fix: use Chromium's determined new site instance as candidate when navigating."

This reverts commit eb95f935654a2c4d4457821297670836c10fdfd5.

* fix: delegate site instance creation back to content when sandboxed.

* fix: ensure site isolation is on

* test: adapt ut for cross-site navigation

* fix: register pending processes during a navigation.

* refactor: dont call loadURL for a window constructed from an existing webContents.

* test: add sandboxed affinity UT's.

* fix: check affinity before deciding if to force a new site instance.

* chore: adapt subsequent patch.

* refactor: constify logically const methods.

* fix: do not reuse site instances when navigation redirects cross-site.

* test: ensure localStorage accessible after x-site redirect.

* test: adapt localStorage acess denied UT for site isolation.

* fix: do not send render-view-deleted for speculative frames.

* chore: amend tests after rebase.

* test: add ut for webContents' render-view-deleted emission

* fix: introduce current-render-view-deleted for current RVH's deletions.

Revert render-view-deleted to being emitted with any RVH's deletion.
current-render-view-deleted is emitted only when the RVH being deleted
is the current one.

* refactor: style and comments fixed.
2018-12-05 17:03:39 +09:00
.circleci build: Enable arm embedded builtins (#15939) 2018-12-04 11:17:12 +09:00
.github chore: update pr template for no-notes (#15137) 2018-10-12 19:24:19 -07:00
.vsts chore: add GN linting (#14678) 2018-10-03 18:03:26 -05:00
atom fix: use appropriate site instance for cross-site nav's (#15821) 2018-12-05 17:03:39 +09:00
build build: fix native_mksnapshot build (#15770) 2018-11-21 15:19:19 -05:00
buildflags refactor: move color_chooser out of chromium_src (#15091) 2018-10-12 10:53:46 +11:00
chromium_src feat: add support for DesktopCapturerSource.appIcon 2018-12-04 15:42:49 +09:00
components/pepper_flash fix: linking pepper flash on Linux 2018-10-09 14:38:00 -07:00
default_app fix: make windowMenu role correct on MacOS (#15930) 2018-12-03 11:52:46 -08:00
docs docs: remove methods invoking the callback repeatedly from promisification.md (#15951) 2018-12-04 13:45:55 -08:00
docs-translations update references to renamed i18n repo 2018-03-02 12:05:49 -08:00
lib fix: use appropriate site instance for cross-site nav's (#15821) 2018-12-05 17:03:39 +09:00
manifests refactor: printing implementation (#15143) 2018-11-09 14:42:34 +11:00
native_mate chore: fix v8 deprecation warnings 2018-12-03 20:07:43 +05:30
npm fix: explicitly set windowsHide to the old node default (#15469) 2018-11-01 10:53:11 +11:00
patches fix: use appropriate site instance for cross-site nav's (#15821) 2018-12-05 17:03:39 +09:00
script chore: move getCurrentBranch to a util file (#15921) 2018-12-03 13:28:10 -08:00
spec fix: use appropriate site instance for cross-site nav's (#15821) 2018-12-05 17:03:39 +09:00
tools fix: restore missing .lproj directories (#15721) 2018-11-15 09:30:45 -08:00
vendor chore: temporarily use submodule and gn DEPS for requests/boto 2018-10-06 22:07:10 +13:00
.clang-format Add clang-format config file. 2016-10-04 22:42:49 +02:00
.dockerignore ci: migrate libcc's Dockerfile to electron and update it (#14786) 2018-09-25 15:30:22 -04:00
.env.example clarify purpose of .env.example 2018-07-11 12:55:15 -07:00
.eslintrc.json chore(eslint): add extension to .eslintrc file (#15020) 2018-10-08 14:21:34 -05:00
.gitattributes chore: force patches to be checked out with LF line endings (#14789) 2018-09-26 02:04:32 +12:00
.gitignore refactor: eliminate brightray (#15240) 2018-10-24 12:49:10 +02:00
.gitmodules chore: temporarily use submodule and gn DEPS for requests/boto 2018-10-06 22:07:10 +13:00
.remarkrc add remark lint to ensure fenced codeblocks are formatted properly. 2017-11-20 14:05:47 +08:00
appveyor.yml build: use different directory for generated breakpad symbols (#15716) 2018-11-14 12:47:01 -08:00
BUILD.gn feat: add media access APIs for macOS Mojave (#15624) 2018-12-04 07:54:13 -08:00
CODE_OF_CONDUCT.md Change Contact Emails (#12278) 2018-03-15 04:37:40 +09:00
CONTRIBUTING.md add docs/development/README.md (#12373) 2018-03-20 15:36:48 -04:00
DEPS chore: roll DEPS 70.0.3538.110 2018-12-03 20:07:44 +05:30
Dockerfile ci: migrate libcc's Dockerfile to electron and update it (#14786) 2018-09-25 15:30:22 -04:00
Dockerfile.arm32v7 ci: use ubuntu 18.04 for arm testing (#14988) 2018-10-05 09:29:32 -05:00
Dockerfile.arm64v8 ci: Trigger an arm test on VSTS after CircleCI build (#14898) 2018-10-04 12:01:16 -04:00
electron_paks.gni fix: prevent bluetooth device list from growing without bound (#15805) 2018-11-28 11:36:00 -05:00
electron_resources.grd native_desktop_media_list.h depends on //chrome/app:generated_resources 2018-10-09 14:38:00 -07:00
electron_strings.grdp refactor: printing implementation (#15143) 2018-11-09 14:42:34 +11:00
filenames.gni fix: security: don't allow arbitrary methods to be invoked on webContents via IPC (#15919) 2018-12-04 16:12:21 +01:00
LICENSE Update license year 2018-01-01 00:51:40 +01:00
package-lock.json chore: update package-lock.json 2018-12-03 20:07:38 +05:30
package.json chore: remove electabul (#15954) 2018-12-04 20:50:37 -08:00
README.md docs: add Azure Pipelines status (#15455) 2018-10-29 12:18:34 -04:00
SECURITY.md Change Contact Emails (#12278) 2018-03-15 04:37:40 +09:00
VERSION Bump v4.0.0-nightly.20181010 2018-10-10 06:38:01 -07:00
vsts-arm-test-steps.yml ci: Renable ffmpeg and mksnapshot tests on Azure Devops (#15800) 2018-11-30 11:17:01 -05:00
vsts-arm32v7.yml ci: use ubuntu 18.04 for arm testing (#14988) 2018-10-05 09:29:32 -05:00
vsts-arm64v8.yml ci: Trigger an arm test on VSTS after CircleCI build (#14898) 2018-10-04 12:01:16 -04:00
vsts.yml ci: Renable ffmpeg and mksnapshot tests on Azure Devops (#15800) 2018-11-30 11:17:01 -05:00

Electron Logo

CircleCI Build Status AppVeyor Build Status Azure Pipelines Build Status devDependency Status Join the Electron Community on Slack

📝 Available Translations: 🇨🇳 🇹🇼 🇧🇷 🇪🇸 🇰🇷 🇯🇵 🇷🇺 🇫🇷 🇹🇭 🇳🇱 🇹🇷 🇮🇩 🇺🇦 🇨🇿 🇮🇹. View these docs in other languages at electron/i18n.

The Electron framework lets you write cross-platform desktop applications using JavaScript, HTML and CSS. It is based on Node.js and Chromium and is used by the Atom editor and many other apps.

Follow @ElectronJS on Twitter for important announcements.

This project adheres to the Contributor Covenant code of conduct. By participating, you are expected to uphold this code. Please report unacceptable behavior to coc@electronjs.org.

Installation

To install prebuilt Electron binaries, use npm. The preferred method is to install Electron as a development dependency in your app:

npm install electron --save-dev [--save-exact]

The --save-exact flag is recommended for Electron prior to version 2, as it does not follow semantic versioning. As of version 2.0.0, Electron follows semver, so you don't need --save-exact flag. For info on how to manage Electron versions in your apps, see Electron versioning.

For more installation options and troubleshooting tips, see installation.

Quick start & Electron Fiddle

Use Electron Fiddle to build, run, and package small Electron experiments, to see code examples for all of Electron's APIs, and to try out different versions of Electron. It's designed to make the start of your journey with Electron easier.

Alternatively, clone and run the electron/electron-quick-start repository to see a minimal Electron app in action:

git clone https://github.com/electron/electron-quick-start
cd electron-quick-start
npm install
npm start

Resources for learning Electron

Programmatic usage

Most people use Electron from the command line, but if you require electron inside your Node app (not your Electron app) it will return the file path to the binary. Use this to spawn Electron from Node scripts:

const electron = require('electron')
const proc = require('child_process')

// will print something similar to /Users/maf/.../Electron
console.log(electron)

// spawn Electron
const child = proc.spawn(electron)

Mirrors

Documentation Translations

Find documentation translations in electron/i18n.

Community

Info on reporting bugs, getting help, finding third-party tools and sample apps, and more can be found in the support document.

License

MIT

When using the Electron or other GitHub logos, be sure to follow the GitHub logo guidelines.