mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1
electron/atom/browser
History
Shelley Vohr bfcce8aa27
 refactor: pass MessageBox params as a struct (#18732) 
Historically, we've been passing in all MessageBox parameters individually, which makes augmenting or improving MessageBox functionality challenging because to change or add even one argument requires a huge cascade of argument changes that leaves room for errors.

For other file dialog related APIs, we use a struct (DialogSettings), and so this PR takes a similar approach and refactors MessageBox parameters into a struct (MessageBoxSettings) which we then use to simplify argument passing and which will enable us to more quickly iterate and improve upon functionality in the future.
2019-06-14 08:26:25 -07:00
..
api refactor: pass MessageBox params as a struct (#18732) 2019-06-14 08:26:25 -07:00
lib chore: convert base::Bind instances across some files (#18112) 2019-05-03 08:49:26 +09:00
loader build: enable gn check for //electron:electron_lib (#17100) 2019-03-05 10:38:55 +05:30
mac fix: correct isDownloadable docs to match impl (#18720) 2019-06-12 10:54:14 -07:00
media chore: bump chromium to 2a7aff41ce73adc0eeee67d364989 (master) (#18505) 2019-06-03 20:44:12 -07:00
net feat: migrate protocol module to NetworkService (Part 12) (#18726) 2019-06-12 08:37:06 +09:00
notifications fix: remove lingering data when notifications autodismiss on Windows 7 (#18401) 2019-06-12 08:39:25 +09:00
osr refactor: mojofy autofill (#18723) 2019-06-12 15:08:22 -07:00
printing chore: node_includes header no longer needs to be at the end of the list (#17090) 2019-03-11 17:13:43 -07:00
resources Bump v7.0.0-nightly.20190613 2019-06-13 08:32:58 -07:00
ui refactor: pass MessageBox params as a struct (#18732) 2019-06-14 08:26:25 -07:00
win refactor: eliminate brightray (#15240) 2018-10-24 12:49:10 +02:00
atom_blob_reader.cc chore: convert more module and helper files from bind (#18069) 2019-05-02 08:32:33 -07:00
atom_blob_reader.h feat: promisify session.getBlobData() (#17303) 2019-03-14 08:11:01 -07:00
atom_browser_client.cc fix: use crashpad on Windows (#18483) 2019-06-13 15:42:21 +09:00
atom_browser_client.h fix: use crashpad on Windows (#18483) 2019-06-13 15:42:21 +09:00
atom_browser_context.cc chore: bump chromium to 2a7aff41ce73adc0eeee67d364989 (master) (#18505) 2019-06-03 20:44:12 -07:00
atom_browser_context.h refactor: Enable network service (Part 1) (#17431) 2019-03-26 10:10:48 +09:00
atom_browser_main_parts.cc chore: bump chromium to bd6aad6a4b37dad7aae42fec349e9 (master) (#18626) 2019-06-04 17:27:07 -07:00
atom_browser_main_parts.h chore: bump chromium to bd6aad6a4b37dad7aae42fec349e9 (master) (#18626) 2019-06-04 17:27:07 -07:00
atom_browser_main_parts_mac.mm chore: bump chromium to bd6aad6a4b37dad7aae42fec349e9 (master) (#18626) 2019-06-04 17:27:07 -07:00
atom_browser_main_parts_posix.cc chore: convert more module and helper files from bind (#18069) 2019-05-02 08:32:33 -07:00
atom_download_manager_delegate.cc fix: update the FileSelectHelper to support the new promise API (#18288) 2019-05-14 15:46:53 -07:00
atom_download_manager_delegate.h fix: update the FileSelectHelper to support the new promise API (#18288) 2019-05-14 15:46:53 -07:00
atom_gpu_client.cc feat: support ELECTRON_DEFAULT_ERROR_MODE in the GPU process (#17728) 2019-04-30 12:45:48 -04:00
atom_gpu_client.h feat: support ELECTRON_DEFAULT_ERROR_MODE in the GPU process (#17728) 2019-04-30 12:45:48 -04:00
atom_javascript_dialog_manager.cc refactor: pass MessageBox params as a struct (#18732) 2019-06-14 08:26:25 -07:00
atom_javascript_dialog_manager.h Give the JS dialog manager the alerting frame. 2018-06-19 11:49:42 +10:00
atom_navigation_throttle.cc refactor: remove WebContents::CreateFrom (#15241) 2018-10-19 17:52:07 +09:00
atom_navigation_throttle.h feat: add will-redirect (#13866) 2018-09-16 01:42:43 +10:00
atom_paths.h Fix atom::PATH_END so it's greater than PATH_START. (#18339) 2019-05-21 15:35:01 +09:00
atom_permission_manager.cc feat: provide the frame URL with permission requests and checks (#18757) 2019-06-13 11:11:43 -07:00
atom_permission_manager.h feat: provide the frame URL with permission requests and checks (#18757) 2019-06-13 11:11:43 -07:00
atom_quota_permission_context.cc Fix includes in AtomQuotaPermissionContext 2018-06-19 11:49:41 +10:00
atom_quota_permission_context.h Fix includes in AtomQuotaPermissionContext 2018-06-19 11:49:41 +10:00
atom_speech_recognition_manager_delegate.cc Remove content::SpeechRecognitionResult 2018-10-09 14:38:00 -07:00
atom_speech_recognition_manager_delegate.h Remove content::SpeechRecognitionResult 2018-10-09 14:38:00 -07:00
atom_web_ui_controller_factory.cc refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
atom_web_ui_controller_factory.h Change CreateWebUIControllerForURL() to return a unique_ptr 2018-10-09 14:38:00 -07:00
auto_updater.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
auto_updater.h clang-format atom files 2018-04-18 20:48:45 -04:00
auto_updater_mac.mm chore: add clang-format and limited linting for Objective-C sources (#18104) 2019-05-02 21:05:37 +09:00
browser.cc chore: make util::Promise a move-only type (#17071) 2019-02-21 12:32:44 +00:00
browser.h feat: allow resigning current NSUserActivity (#18659) 2019-06-06 22:16:03 -07:00
browser_linux.cc feat: add native emoji picker (#17359) 2019-03-14 13:39:52 -07:00
browser_mac.mm feat: allow resigning current NSUserActivity (#18659) 2019-06-06 22:16:03 -07:00
browser_observer.h chore: make BrowserObserver a CheckedObserver 2018-12-03 20:07:38 +05:30
browser_process_impl.cc GetNetCaptureModeFromCommandLine moved to net 2019-05-21 12:11:15 -07:00
browser_process_impl.h chore: bump chromium to 2a7aff41ce73adc0eeee67d364989 (master) (#18505) 2019-06-03 20:44:12 -07:00
browser_win.cc feat: allow setting working directory in app.setUserTasks() / app.setJumpList() (#18148) 2019-05-13 19:17:12 +03:00
child_web_contents_tracker.cc content: Fix WebContentsUserData for usage across components. 2019-02-14 23:59:21 +05:30
child_web_contents_tracker.h content: Fix WebContentsUserData for usage across components. 2019-02-14 23:59:21 +05:30
common_web_contents_delegate.cc fix: HTML fullscreen request for sub frames (#18736) 2019-06-13 14:02:56 -07:00
common_web_contents_delegate.h fix: HTML fullscreen request for sub frames (#18736) 2019-06-13 14:02:56 -07:00
common_web_contents_delegate_mac.mm Revert "feat: upgrade to Chromium 72.0.3626.52 (#16334)" 2019-01-22 12:01:04 -08:00
common_web_contents_delegate_views.cc fix: enable autofill popups on mac (#16308) 2019-02-11 09:38:58 -10:00
cookie_change_notifier.cc refactor: create request context from network context (#14656) 2018-10-04 13:08:56 -05:00
cookie_change_notifier.h refactor: create request context from network context (#14656) 2018-10-04 13:08:56 -05:00
fake_location_provider.cc fix: opt into location services once device service has been started (#14253) 2018-08-23 08:51:46 -07:00
fake_location_provider.h Port //services/device/geolocation to network::SimpleURLLoader 2018-10-09 14:38:00 -07:00
feature_list.cc refactor: initialize feature list earlier (#17922) 2019-04-23 15:18:12 -07:00
feature_list.h refactor: initialize feature list earlier (#17922) 2019-04-23 15:18:12 -07:00
font_defaults.cc Use base::size rather than arraysize 2019-02-14 23:59:22 +05:30
font_defaults.h fix: match Chrome's font fallback behavior (#15486) 2018-11-08 10:51:51 -04:00
io_thread.cc chore: bump chromium to 2a7aff41ce73adc0eeee67d364989 (master) (#18505) 2019-06-03 20:44:12 -07:00
io_thread.h chore: bump chromium to 2a7aff41ce73adc0eeee67d364989 (master) (#18505) 2019-06-03 20:44:12 -07:00
javascript_environment.cc Manual follow-up rename in comments and variable names. 2019-05-16 18:47:42 -07:00
javascript_environment.h fix: add microtask runner and fix promise test (#15071) 2018-10-16 02:26:47 +11:00
login_handler.cc chore: bump chromium to 1e9f9a24aa12 (master) (#17880) 2019-04-20 10:20:37 -07:00
login_handler.h chore: bump chromium to 1e9f9a24aa12 (master) (#17880) 2019-04-20 10:20:37 -07:00
microtasks_runner.cc fix: add microtask runner and fix promise test (#15071) 2018-10-16 02:26:47 +11:00
microtasks_runner.h fix: add microtask runner and fix promise test (#15071) 2018-10-16 02:26:47 +11:00
native_browser_view.cc refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
native_browser_view.h refactor: mojofy draggable regions (#18536) 2019-06-03 10:43:04 -07:00
native_browser_view_mac.h refactor: mojofy draggable regions (#18536) 2019-06-03 10:43:04 -07:00
native_browser_view_mac.mm chore: add clang-format and limited linting for Objective-C sources (#18104) 2019-05-02 21:05:37 +09:00
native_browser_view_views.cc feat: flexible autoresize for BrowserViews (#16184) 2019-01-31 11:07:19 +09:00
native_browser_view_views.h feat: flexible autoresize for BrowserViews (#16184) 2019-01-31 11:07:19 +09:00
native_window.cc content: Fix WebContentsUserData for usage across components. 2019-02-14 23:59:21 +05:30
native_window.h refactor: mojofy draggable regions (#18536) 2019-06-03 10:43:04 -07:00
native_window_mac.h fix: respect minimizable/closable for customButtonsOnHover (#18425) 2019-05-28 10:23:16 -07:00
native_window_mac.mm chore: bump chromium to bd6aad6a4b37dad7aae42fec349e9 (master) (#18626) 2019-06-04 17:27:07 -07:00
native_window_observer.h feat: implement 'app-command' events for browser history navigation keys on Linux (#15441) 2018-12-05 09:35:59 -08:00
native_window_views.cc refactor: mojofy draggable regions (#18536) 2019-06-03 10:43:04 -07:00
native_window_views.h chore: bump chromium to 964c4bca8de5c320534d95606c861 (master) (#18440) 2019-05-28 13:18:10 -07:00
native_window_views_win.cc fix: leave space for autohide taskbar for frameless maximized window (#18321) 2019-05-20 19:50:03 -05:00
node_debugger.cc fix: ensure the inspector agent is shutdown before cleaning up the node env (#18028) 2019-04-30 15:44:40 -07:00
node_debugger.h fix: ensure the inspector agent is shutdown before cleaning up the node env (#18028) 2019-04-30 15:44:40 -07:00
pref_store_delegate.cc refactor: create request context from network context (#14656) 2018-10-04 13:08:56 -05:00
pref_store_delegate.h refactor: create request context from network context (#14656) 2018-10-04 13:08:56 -05:00
relauncher.cc PathService -> base::PathService 2018-10-04 00:12:54 +02:00
relauncher.h Correctly quotes the argv on Windows 2016-06-02 21:10:39 +09:00
relauncher_linux.cc fix relaunch on linux (#14975) 2018-10-04 18:41:37 -05:00
relauncher_mac.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
relauncher_win.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
session_preferences.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
session_preferences.h clang-format atom files 2018-04-18 20:48:45 -04:00
special_storage_policy.cc Handle deleting cookies with session-only policy in network service 2018-10-09 14:38:00 -07:00
special_storage_policy.h Handle deleting cookies with session-only policy in network service 2018-10-09 14:38:00 -07:00
unresponsive_suppressor.cc Replace DialogScope with UnresponsiveSuppressor 2016-07-11 15:29:03 +09:00
unresponsive_suppressor.h Replace DialogScope with UnresponsiveSuppressor 2016-07-11 15:29:03 +09:00
web_contents_permission_helper.cc chore: bump chromium to 2a7aff41ce73adc0eeee67d364989 (master) (#18505) 2019-06-03 20:44:12 -07:00
web_contents_permission_helper.h chore: remove last instances of base::Bind (#18178) 2019-05-29 13:02:15 -07:00
web_contents_preferences.cc fix: set nativeWindowOpen when sandboxed (#18273) 2019-05-27 02:44:54 +02:00
web_contents_preferences.h fix: set nativeWindowOpen when sandboxed (#18273) 2019-05-27 02:44:54 +02:00
web_contents_zoom_controller.cc refactor: convert C++ enums to C++11 enum classes (#18087) 2019-05-03 14:11:41 -04:00
web_contents_zoom_controller.h refactor: convert C++ enums to C++11 enum classes (#18087) 2019-05-03 14:11:41 -04:00
web_dialog_helper.cc chore: remove last instances of base::Bind (#18178) 2019-05-29 13:02:15 -07:00
web_dialog_helper.h fix: correctly support the webkitdirectory input attr (#18343) 2019-05-21 11:18:22 -05:00
web_view_guest_delegate.cc AttachToOuterWebContentsFrame => AttachInnerWebContents 2019-03-08 15:13:12 -08:00
web_view_guest_delegate.h fix: use OOPIF for webview tag (#13869) 2018-08-16 15:57:40 -07:00
web_view_manager.cc [chromium-style] auto variable type must not deduce to a raw pointer type 2018-04-19 11:10:52 -07:00
web_view_manager.h clang-format atom files 2018-04-18 20:48:45 -04:00
window_list.cc [chromium-style] auto variable type must not deduce to a raw pointer type 2018-04-19 11:10:52 -07:00
window_list.h Add IsEmpty helper and remove GetInstance public usage 2017-04-11 09:09:17 -07:00
window_list_observer.h chore: make BrowserObserver a CheckedObserver 2018-12-03 20:07:38 +05:30
zoom_level_delegate.cc chore: convert more files away from base::Bind (#18121) 2019-05-03 12:08:41 -07:00
zoom_level_delegate.h refactor: move media/net from brightray to atom (#15288) 2018-10-19 14:51:43 -04:00