electron/shell
trop[bot] 9ebeeb40ac
fix: don't do self-destroy in LibnotifyNotification::Dismiss() (#41708)
Callers of Notification::Dismiss() assume that the notification
instance is not deleted after the call, but this was not the case
for LibnotifyNotification:
- Destroy() would get `this` deleted.
- notify_notification_close() in portal environment triggers
LibnotifyNotification::OnNotificationClosed(), and finally calls
Destroy()

This patch removes all Destroy() in Dismiss(), and adds a boolean
to tell whether notify_notification_close() is running, to avoid crash
under portal environment.

Fixes #40461.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: taoky <me@taoky.moe>
2024-03-28 12:09:59 +01:00
..
app chore: update src_preload_function_for_environment.patch (#41505) 2024-03-04 10:16:56 -05:00
browser fix: don't do self-destroy in LibnotifyNotification::Dismiss() (#41708) 2024-03-28 12:09:59 +01:00
common test: add test and api_feature definition for chrome.scripting.globalParams (#41700) 2024-03-27 10:21:04 +01:00
renderer chore: bump chromium to 124.0.6359.0 (30-x-y) (#41606) 2024-03-15 18:13:55 -04:00
services/node fix: destroy NodeService message pipe last (#41277) 2024-02-09 22:44:35 +01:00
utility chore: remove unused std includes (#38767) 2023-06-14 11:07:18 -07:00