mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: destroy NodeService message pipe last (#41277)

Browse source 
refactor: destroy NodeService message pipe last
This commit is contained in:
Shelley Vohr 2024-02-09 22:44:35 +01:00 • committed by GitHub
parent c894645ac6
commit 4ded4d16a8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
shell/services/node/node_service.h
View file

@ -61,6 +61,12 @@ class NodeService : public node::mojom::NodeService {
void Initialize(node::mojom::NodeServiceParamsPtr params) override;
private:
// This needs to be initialized first so that it can be destroyed last
// after the node::Environment is destroyed. This ensures that if
// there are crashes in the node::Environment destructor, they
// will be propagated to the exit handler.
mojo::Receiver<node::mojom::NodeService> receiver_{this};
bool node_env_stopped_ = false;
const std::unique_ptr<NodeBindings> node_bindings_;
@ -73,8 +79,6 @@ class NodeService : public node::mojom::NodeService {
// depends-on: js_env_'s isolate
std::shared_ptr<node::Environment> node_env_;
mojo::Receiver<node::mojom::NodeService> receiver_{this};
};
} // namespace electron