electron/shell/browser/notifications/linux
trop[bot] 0ffafbc295
test: ensure sender-pid hint is set in Linux notifications (#43949)
test: expect a `sender-pid` hint in Linux notifications.

This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.

This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.

By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 13:09:32 -05:00
..
libnotify_notification.cc test: ensure sender-pid hint is set in Linux notifications (#43949) 2024-09-25 13:09:32 -05:00
libnotify_notification.h fix: don't do self-destroy in LibnotifyNotification::Dismiss() (#41691) 2024-03-27 10:53:23 +01:00
notification_presenter_linux.cc refactor: NotificationPresenter::Create() returns a std::unique_ptr<> (#43804) 2024-09-19 22:11:48 -05:00
notification_presenter_linux.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00