electron/shell/browser/notifications
trop[bot] 0ffafbc295
test: ensure sender-pid hint is set in Linux notifications (#43949)
test: expect a `sender-pid` hint in Linux notifications.

This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.

This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.

By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 13:09:32 -05:00
..
linux test: ensure sender-pid hint is set in Linux notifications (#43949) 2024-09-25 13:09:32 -05:00
mac refactor: NotificationPresenter::Create() returns a std::unique_ptr<> (#43804) 2024-09-19 22:11:48 -05:00
win refactor: NotificationPresenter::Create() returns a std::unique_ptr<> (#43804) 2024-09-19 22:11:48 -05:00
notification.cc refactor: put empty virtual function definitions in header (#43285) 2024-08-12 09:56:51 +02:00
notification.h refactor: put empty virtual function definitions in header (#43285) 2024-08-12 09:56:51 +02:00
notification_delegate.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
notification_presenter.cc refactor: prefer std::ranges over begin() and end() (#43482) 2024-08-26 14:37:56 -04:00
notification_presenter.h refactor: NotificationPresenter::Create() returns a std::unique_ptr<> (#43804) 2024-09-19 22:11:48 -05:00
platform_notification_service.cc refactor: put empty virtual function definitions in header (#43285) 2024-08-12 09:56:51 +02:00
platform_notification_service.h refactor: put empty virtual function definitions in header (#43285) 2024-08-12 09:56:51 +02:00