electron/brightray/browser/media
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
media_capture_devices_dispatcher.cc format previously misses .cc files 2018-04-17 21:56:12 -04:00
media_capture_devices_dispatcher.h [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
media_device_id_salt.cc REVIEW: Move MediaDeviceIDSalt from ProfileIOData to ProfileImpl. 2017-11-24 10:58:15 +09:00
media_device_id_salt.h Remove unused includes 2017-05-19 08:46:15 -07:00
media_stream_devices_controller.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
media_stream_devices_controller.h Remove unused includes 2017-05-19 08:46:15 -07:00