Commit graph

39 commits

Author SHA1 Message Date
Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
Jeremy Apthorp
e6695cf2ec [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
Shelley Vohr
49c8c31220
format previously misses .cc files 2018-04-17 21:56:12 -04:00
Shelley Vohr
284aca68c0
clang-format brightray 2018-04-17 21:46:27 -04:00
deepak1556
16d96a6ef2 Force MediaCaptureDevicesDispatcher to be created on UI thread 2017-12-07 09:47:32 +05:30
Ales Pergl
7613afe6d7 Disabled DCHECKs that fail when running tests 2017-12-01 17:55:22 +01:00
Aleksei Kuzmin
b81ae1c36f REVIEW: Move MediaDeviceIDSalt from ProfileIOData to ProfileImpl.
https://codereview.chromium.org/2820163002
2017-11-24 10:58:15 +09:00
Kevin Sawicki
d7321ed980 Add brightray prefix to include paths from within brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37 Fix build/include_alpha linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
f193b2b2a6 Fix build/include_what_you_use linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
bb4a61c7ff Remove unused includes 2017-05-19 08:46:15 -07:00
Kevin Sawicki
2ece711c2e Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
Cheng Zhao
70ffec1134 There is no content::MEDIA_ENUMERATE_DEVICES anymore 2017-01-23 15:14:38 +09:00
deepak1556
dbf4e52e05 persist media device id salt across sessions 2016-12-03 16:47:31 +05:30
Cheng Zhao
4f3e9df055 Merge remote-tracking branch 'origin/master' into chrome52 2016-07-21 05:34:20 -06:00
Haojian Wu
1d1dd6301a Don't use auto to static variables. 2016-07-10 15:38:34 +02:00
Haojian Wu
0cf7454d4b Modernize to C++11 : use auto. 2016-07-10 13:12:33 +02:00
Haojian Wu
7474e5ec28 Modernize to C++11 : NULL => nullptr 2016-07-10 12:30:17 +02:00
Cheng Zhao
4e9782897c Update to API changes of Chrome 52 2016-07-04 15:06:05 +09:00
Cheng Zhao
851ef398fb Adapt to changes of Chrome 51 API changes 2016-05-23 10:59:07 +09:00
Paul Betts
18a75b5124 Renamed enum in MediaStreamDeviceRequest 2016-03-07 22:38:48 -08:00
Cheng Zhao
75d0bc848d Update to API changes of Chrome 47 2015-12-07 19:55:01 +08:00
Cheng Zhao
95d28c398e Update cpplint 2015-06-05 12:07:27 +08:00
Cheng Zhao
56a1691588 MEDIA_LOOPBACK_AUDIO_CAPTURE renamed to MEDIA_DESKTOP_AUDIO_CAPTURE 2015-03-08 20:04:25 -07:00
Cheng Zhao
2c81fb4719 Fix compilation warnings due to API changes 2014-12-09 22:39:44 -08:00
Cheng Zhao
f809fef22d OVERRIDE => override 2014-10-23 11:10:39 +08:00
Cheng Zhao
5bec155c81 Adapt to API changes of Chrome 38 2014-10-11 16:38:27 +08:00
Cheng Zhao
09678cc485 Clean the callback after executed 2014-10-01 15:18:34 +08:00
Cheng Zhao
ea28f518d3 Add handling of user media requests 2014-10-01 11:07:29 +08:00
Cheng Zhao
f05199d4e4 Don't be too strict on media requests. 2014-08-11 23:22:49 +08:00
Adam Roben
918f38e13f Fix long line 2014-06-27 11:59:01 -04:00
Adam Roben
3a71958e16 Update MediaStreamDevicesController for Chrome 35
See https://codereview.chromium.org/180633008
2014-06-27 11:54:27 -04:00
Adam Roben
e003cc9a0a Update MediaCaptureDevicesDispatcher for Chrome 35
See https://codereview.chromium.org/183743021
2014-06-27 11:54:27 -04:00
Adam Roben
7b47a6152d Fix cpplint errors in media_capture_devices_dispatcher.cc 2013-11-17 19:14:08 -05:00
Adam Roben
6aec3006e6 Fix whitespace/comment errors 2013-11-17 18:56:07 -05:00
Adam Roben
1f1f93465b Make MediaStreamDevicesController::Accept/Deny public again
Clients rely on this.
2013-10-07 17:04:40 -04:00
Adam Roben
d1623535e8 Update browser/media/* for Chrome 30
I took the latest versions of these files from chrome/browser/media,
then pared them down to remove all Chrome-isms and uses of UI to prompt
the user about allowing access to devices.
2013-10-07 16:31:58 -04:00
Adam Roben
c2623d2bdc Fix typos 2013-07-31 11:52:21 -07:00
Adam Roben
2595335045 Enable navigator.webkitGetUserMedia()
The code came from chrome/browser/media, but was simplified to remove
dependencies on other parts of chrome/ and to always allow the media stream
request.
2013-07-31 11:08:45 -07:00