electron/atom/app
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
resources/mac Implement login helper to manage login item in Mac App Store build 2017-11-17 10:53:09 +09:00
atom_content_client.cc build: [m67] enable widevine support (#14519) 2018-09-11 20:24:04 +02:00
atom_content_client.h Check for key system support using new mojo service KeySystemSupport 2018-06-19 11:49:42 +10:00
atom_library_main.h clang-format atom files 2018-04-18 20:48:45 -04:00
atom_library_main.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
atom_login_helper.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
atom_main.cc chore: fix more chromium-style errors in windows code (#13487) 2018-06-28 14:20:11 -07:00
atom_main.h Remove All Rights Reserved after GitHub copyright 2014-10-31 11:17:05 -07:00
atom_main_delegate.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_main_delegate.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_main_delegate_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
command_line_args.cc Remove command line argument black-list (#13039) 2018-05-22 11:51:03 -05:00
command_line_args.h clang-format atom files 2018-04-18 20:48:45 -04:00
node_main.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
node_main.h clang-format atom files 2018-04-18 20:48:45 -04:00
uv_task_runner.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
uv_task_runner.h Fix up #includes to work with both GYP and GN 2018-05-10 13:38:40 -07:00