Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings ( #14583 )
...
* chore: fix cpplint 'include_what_you_use' warnings
Typically by including <memory>, <utility> etc.
* chore: fix 'static/global string constant' warning
Use C style strings instead of std::string.
Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
/home/charles/electron/electron-gn/src/electron/script/cpplint.js
* refactor: remove global string variables.
Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.
The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
* fix: initializer error introduced in last commit
* fix: remove WIP file that was included by accident
* fix: include order
* fix: include order
* fix: include order
* fix: include order, again
2018-09-12 19:25:56 -05:00
Robo
f76a8c7b24
build: [m67] enable widevine support ( #14519 )
...
* build: [m67] enable widevine support
* fix: remove plugin cache reset hack
It was added in (#8907 ) to make widevine cdm shows up in
navigator.plugins, since widevine support is no longer
enabled by a plugin it can be removed safely.
2018-09-11 20:24:04 +02:00
Aleksei Kuzmin
7589555cec
inspector: stop dragging platform pointer
...
https://github.com/nodejs/node/commit/296fd57324
2018-09-11 20:24:03 +02:00
Aleksei Kuzmin
ca28b39d9c
Rename buildflag_headers for consistency
...
https://chromium-review.googlesource.com/975990
https://chromium-review.googlesource.com/c/chromium/src/+/988132
2018-09-11 20:21:32 +02:00
Robo
c7c95fab2f
build: [gn] widevine cdm support behind flag ( #14423 )
...
* build: [gn] widevine cdm support behind flag
* build: [gyp] link cdm_support in the component build
2018-09-05 16:00:37 -05:00
Jeremy Apthorp
9af9634f7d
chore: remove unused process_type variable ( #13823 )
2018-07-26 23:25:54 -07:00
Jeremy Apthorp
d6af3bfcd2
chore: fix more chromium-style errors in windows code ( #13487 )
...
Finding more chromium-style linting errors as I build more of the windows code :)
2018-06-28 14:20:11 -07:00
Samuel Attard
b7d00e26bf
Default LoadV8Snapshot changed in C66
...
CR Ref: https://chromium-review.googlesource.com/c/chromium/src/+/859577
2018-06-19 11:49:46 +10:00
deepak1556
77f427acc8
Check for key system support using new mojo service KeySystemSupport
...
https://chromium-review.googlesource.com/c/chromium/src/+/834764
2018-06-19 11:49:42 +10:00
Aleksei Kuzmin
5e320994f4
Remove content/linux_sandbox dependence on content_switches.h
...
https://chromium-review.googlesource.com/734265
2018-06-19 11:49:41 +10:00
Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00
Aleš Pergl
93bee69266
Remove command line argument black-list ( #13039 )
...
* Remove command line argument black-list
Instead block all arguments following a URL.
* Updated tests
2018-05-22 11:51:03 -05:00
John Kleinschmidt
fe7947da90
Merge pull request #12805 from electron/update-blacklist-switches
...
update command-line backlist switches
2018-05-14 13:31:26 -04:00
Jeremy Apthorp
73ac019882
Fix up #includes to work with both GYP and GN
2018-05-10 13:38:40 -07:00
Charles Kerr
1b8b73ce71
update command-line backlist switches
...
part of the diff comes from the fact that we've bumped
to a new version of libcc.
another part comes from adding network_switch_list.h, whose
switch definitions follow a slightly different format.
2018-05-02 20:58:22 -05:00
Shelley Vohr
12a57ff1c2
clang-format objc files ( #12673 )
2018-04-20 11:47:04 -07:00
Jeremy Apthorp
6c26bb1cf8
[chromium-style] destructors of ref-counted objects should be private
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
e6695cf2ec
[chromium-style] override / virtual warnings
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Shelley Vohr
53bdf22c85
clang-format atom files
2018-04-18 20:48:45 -04:00
Robo
65e8199a93
Enable plznavigate aka browser side navigation ( #12535 )
...
* enable plznavigate code path
* AtomBrowserClient::GetGeolocationApiKey returns the right default
* use IsLoadingToDifferentDocument to identify top level navigation in mainFrame
* use candidate site instance when available
* spec: don't test httpReferrer option for file origin
* update libcc ref
* affinity: only group same site in this mode
* plznavigate: don't emit did-get-response-details event for blob scheme
2018-04-06 16:22:52 +09:00
deepak1556
4b39d17e5f
move pdf viewer behind feature flag
2018-03-20 10:13:17 +03:00
deepak1556
6de49f515e
FIXME: Disbale browser side navigation aka PlzNavigate
2018-03-20 10:13:15 +03:00
Samuel Attard
ed992ae6a1
trackable_object has moved to base namespace
2018-03-20 10:08:57 +03:00
Ales Pergl
94299f6cd8
Fixed Mac build when enable_run_as_node==false
2018-03-09 13:33:04 +01:00
Cheng Zhao
b9ab2fe0fb
Disable stack dumping for 32bit ARM
2018-02-23 10:22:00 +09:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
Aleksei Kuzmin
8c0c1e4ded
media: Replace ENABLE_PEPPER_CDMS buildflag with ENABLE_LIBRARY_CDMS
...
https://chromium-review.googlesource.com/582309
2018-02-23 10:21:23 +09:00
Charles Kerr
402201ac39
Fix cppcheck warnings ( #11883 )
...
* remove unused variable
* limit scope of variable 'ret'
* pass shared_ptr<SkBitmap> by reference
* silence warning: value reassign before read
* fix oops
* don't refer to 'response' after std::move()ing it
* make the linter happy
2018-02-14 02:21:46 -06:00
shelley vohr
fae71f9987
Merge pull request #11880 from nitsakh/better-ipc-logging
...
Add ability to log atom ipc messages
2018-02-12 09:20:37 -05:00
universeroc
069c6187cf
Fix #11893 Remove unused member variable content_client_ ( #11894 )
2018-02-12 08:07:12 -06:00
Nitish Sakhawalkar
e19e2b9242
Address review comments
2018-02-11 10:25:11 -08:00
Nitish Sakhawalkar
5194288fce
Add ability to log atom ipc messages
2018-02-09 18:01:14 -08:00
Charles Kerr
e51c78f10c
fix oops
...
because compiling before pushing is for wusses
2018-01-31 22:25:57 -07:00
Charles Kerr
1106cde687
fix oops
2018-01-31 17:40:11 -07:00
Charles Kerr
09a2c80443
use std::binary_search to search switch blacklist
2018-01-31 17:36:06 -07:00
Charles Kerr
8405fe763e
Make a copy-paste recipe for rebuilding the blacklist
2018-01-31 17:35:34 -07:00
Samuel Attard
ce361a12e3
Use case-insensitive switch comparisons
2018-01-31 17:35:09 -07:00
Cheng Zhao
b5d5eca224
Make use of sorted order to speed up searching
2018-01-25 14:42:56 +09:00
Aleš Pergl
868e792572
Make run-as-node mode optional ( #11701 )
2018-01-23 18:17:15 -05:00
Aleš Pergl
c49cb29ddf
Disallow launching unknown apps via browser client.
...
CVE-2018-1000006
2018-01-22 16:49:30 -06:00
deepak1556
1b30cac372
Don't delay node module initialization
2018-01-02 16:37:11 +09:00
deepak1556
e30131f30b
Initialize isolate holder in standalone node mode
2018-01-02 16:37:07 +09:00
Cheng Zhao
c0c2461245
Do not create duplicate V8Platform in NodeDebugger
2017-12-22 20:29:09 +09:00
Cheng Zhao
c0e9dbcc00
Merge pull request #11144 from dittos/mas-login-helper-again
...
Re-land MAS login helper (w/ regression fix)
2017-11-27 17:02:57 +09:00
Ales Pergl
531472bad4
Create a TaskScheduler
when initializing run-as-node mode.
...
It fixes crashes when V8 tries to execute background tasks via the TaskScheduler.
2017-11-24 10:58:53 +09:00
Aleksei Kuzmin
11fa935359
Introduce TaskRunner::RunsTasksInCurrentSequence()
...
https://codereview.chromium.org/2823103003
2017-11-24 10:58:16 +09:00
Ted Kim
8184cbfb06
Implement login helper to manage login item in Mac App Store build
2017-11-17 10:53:09 +09:00
Alexey Kuzmin
8657169017
Revert "Implement login helper to manage login item in Mac App Store build"
2017-11-16 19:05:13 +03:00