7582aca4ed
Inject custom workflow
2024-11-27 20:01:20 +00:00
Charles Kerr
10e0ce0692
fix: modernize-use-nodiscard clang-tidy warnings (32-x-y backport) ( #44846 )
...
fix: modernize-use-nodiscard clang-tidy warnings (#44808 )
2024-11-27 12:42:14 -06:00
trop[bot]
d1639ccb79
refactor: use base::Extend in AddAdditionalSchemes() ( #44865 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-27 10:10:02 -06:00
Charles Kerr
7a3182a139
fix: modernize-use-using clang-tidy warnings (32-x-y backport) ( #44847 )
...
fix: modernize-use-using clang-tidy warnings (#44806 )
2024-11-26 22:10:20 -06:00
Charles Kerr
e9da87822f
fix: clang-tidy performance-inefficient-vector-operation warnings (32-x-y backport) ( #44848 )
...
fix: clang-tidy `performance-inefficient-vector-operation` warnings (#44743 )
* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()
* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
2024-11-26 19:13:57 -06:00
trop[bot]
4a3b3a6aee
fix: remove unused local variables ( #44824 )
...
* chore: remove unused local non-trivial variable relaunch_executable
became unused in June 2016 in 0d066de572a08926
2024-11-24 11:54:07 -06:00
trop[bot]
6626557902
refactor: remove unnecessary constructor code ( #44826 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-24 11:53:51 -06:00
John Kleinschmidt
85a0240b5c
test: fixup visibility tests ( #44802 )
...
* test: ensure all webContents are closed
* test: ensure all webContents are closed
* test: fixup api-web-request-spec.ts
2024-11-23 11:21:38 +01:00
trop[bot]
433a7b69e3
docs: update new GitHub issue link ( #44809 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-11-22 16:51:00 -06:00
trop[bot]
63cb4f4481
fix: big endian bug in V8 serialization ( #44795 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-22 13:30:58 -05:00
trop[bot]
85a3ed32d9
fix: ensure context-menu emitted for draggable regions ( #44798 )
...
* fix: ensure context-menu emitted for draggable regions
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: address suggestions from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-22 10:11:29 -05:00
electron-roller[bot]
d004ed620a
chore: bump node to v20.18.1 (32-x-y) ( #44779 )
...
* chore: bump node in DEPS to v20.18.1
* chore: update patches
* lib: remove lib/internal/idna.js
https://github.com/nodejs/node/pull/55050
* buffer: fix out of range for toString
https://github.com/nodejs/node/pull/54553
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-22 09:36:58 -05:00
trop[bot]
3137994b4a
fix: performance-no-automatic-move clang-tidy warnings ( #44772 )
...
* fix: performance-no-automatic-move in GetLogFileName()
remove `const` from log_filename.
Warning fixed by this commit:
../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move]
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: performance-no-automatic-move in GetBundleResourcePath()
remove `const` from request_relative_path.
Warning fixed by this commit:
electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-22 10:23:05 +01:00
Charles Kerr
0e001fc45a
fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h (32-x-y) ( #44747 )
...
fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h (#44705 )
fix: AutofillPopup warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
refactor: reduce #indclude scope in autofill_popup.h and autofill_popup_view.h
2024-11-22 10:22:27 +01:00
trop[bot]
71240835ba
test: run script to help target discovery and reduce flakes ( #44765 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2024-11-20 17:59:11 -06:00
trop[bot]
2dc26e481c
chore: cherry-pick 2ca6d60a from chromium ( #44760 )
...
* chore: cherry-pick 2ca6d60a from chromium
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-11-20 15:50:52 -08:00
trop[bot]
d9d6ba180c
fix: bugprone-narrowing-conversions warnings in NativeImage ( #44739 )
...
* fix: bugprone-narrowing-conversions warning in NativeImage::memory_usage_
- fix signed / unsigned math by using base/numerics/safe_conversions
- make memory_usage_ an int64_t so it can safely take the size_t
returned by computeByteSize()
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-20 11:15:22 -06:00
trop[bot]
6cc9aa57fe
fix: tooltips in WCO caption buttons ( #44758 )
...
fix: tooltips in WCO capton buttons
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-20 15:34:54 +01:00
Robo
c90509c2bc
fix: utility process exit code for graceful termination ( #44749 )
2024-11-20 23:23:10 +09:00
Charles Kerr
ee66bf9381
chore: remove use of banned absl::optional ( #44513 ) ( #44745 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5805666
2024-11-20 10:14:01 +01:00
trop[bot]
42c88eba7c
fix: destroy url loader wrapper when JS env exits ( #44730 )
...
* fix: destroy url loader wrapper when JS env exits
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Revert "fix: destroy url loader wrapper when JS env exits"
This reverts commit 419151a98a16814ea63e9abc197c6ae27f48128c.
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Revert "Revert "fix: destroy url loader wrapper when JS env exits""
This reverts commit 4b401b03c62aca79498660f995825491ae52f179.
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* fix: double free of JSChunkedDataPipeGetter
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* fix: crash on process exit after stream completes
Co-authored-by: deepak1556 <hop2deep@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-11-19 22:08:28 +01:00
trop[bot]
50edc9bfe2
fix: improve single-pixel resize handling on Windows ( #44724 )
...
* fix: improve single-pixel resize handling
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update spec/api-browser-window-spec.ts
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update shell/browser/native_window_views.cc
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-19 10:58:06 -05:00
trop[bot]
313f9030d2
fix: utilityProcess pid should be undefined after exit ( #44693 )
...
fix: utilityProcess pid should be undefined after exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-18 13:43:23 -06:00
Basit
a6a0c4cb6d
fix: crash when generating shortcut text for super accelerator (32-x-y) ( #44623 )
...
* fix: crash when generating shortcut text for super accelerator (#44341 )
* chore: update patch
---------
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-15 14:11:29 -05:00
Pedro Pontes
a85c2d1c1e
chore: cherry-pick 1 changes from 0-M131 ( #44648 )
...
chore: [32-x-y] cherry-pick 1 changes from 0-M131
* 923797bac925 from chromium
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-15 10:20:34 -05:00
John Kleinschmidt
8f88aae33c
fix: WebContentsView removal should compare directly ( #44672 )
...
fix: `WebContentsView` removal should compare directly (#44656 )
* fix: WebContentsView removal should compare directly
* fixup view comparision
* chore: use erase_if
* Apply review suggestions
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-15 13:09:42 +01:00
trop[bot]
43885b94d0
build: fix python warnings "SyntaxWarning: invalid escape sequence '\w'" ( #44659 )
...
* fix: SyntaxWarning: invalid escape sequence '\w'
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove some unused imports
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: E711 warning 'Comparison to should be '
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-14 07:28:13 -06:00
BILL SHEN
39a24d96fc
fix: add theme data source for devtools.(32-x-y) ( #44639 )
...
fix: add theme data source for devtools.
2024-11-14 12:45:08 +01:00
Pedro Pontes
45d4f25099
chore: cherry-pick 1 changes from 3-M130 ( #44645 )
...
chore: [32-x-y] cherry-pick 1 changes from 3-M130
* e699ac35ac6c from chromium
2024-11-13 17:35:21 -08:00
trop[bot]
85289c8218
fix: WCO buttons hidden on Linux in fullscreen ( #44642 )
...
Closes https://github.com/electron/electron/issues/44569 .
Fixes an issue where the WCO buttons were hidden on Linux in fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-13 15:59:29 -05:00
trop[bot]
7dd1fc92d4
test: exercise fuller globalShortcut matrix ( #44626 )
...
test: test fuller globalShortcut matrix
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-13 19:36:10 +01:00
trop[bot]
f06f6d565e
fix: segfault when moving WebContentsView between BrowserWindows ( #44615 )
...
* fix: segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: actually enable fix
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-12 11:42:42 -05:00
trop[bot]
bcd7ac5481
chore: remove executable flag from docs/api/app.md file permissions ( #44577 )
...
chore: set docs/api/app.md file permissions to 644
md files should not be executable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-05 12:01:40 -05:00
Robo
b0f22f7ed4
chore: backport editcontext ime input alignment fixes ( #44572 )
...
Refs https://issues.chromium.org/issues/351029417
2024-11-05 10:22:46 -06:00
trop[bot]
2f524dfb1d
fix: remove use of banned std::to_string() ( #44561 )
...
Use base::NumberToString() instead
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-04 20:31:08 -06:00
trop[bot]
555c368052
docs: capitalize POSIX and Windows correctly ( #44557 )
...
* docs: capitalize POSIX correctly
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* docs: capitalize Windows correctly
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-04 17:02:14 -05:00
John Kleinschmidt
aa02f3db47
build: add new status to verify if all the required gha jobs have run ( #44555 )
...
build: add new status to verify if all the required gha jobs have run (#44432 )
(cherry picked from commit 1c1eb3e19dad1c60dc8926542ce9bbb3a71735f9)
2024-11-04 16:41:40 -05:00
trop[bot]
6a9f44f867
build: remove unused lint package ( #44532 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-11-04 09:06:02 -05:00
Robo
fb6faaab69
chore: add process memory limit details in parition_alloc oom handler ( #44512 )
...
chore: backport b5b8e05a8 from chromium
2024-11-04 20:49:06 +09:00
trop[bot]
6d94e1a436
docs: fix apostrophe typo "Electrons" -> "Electron's" ( #44538 )
...
s/Electrons/Electron's/
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-03 09:33:24 -06:00
trop[bot]
2e33636033
refactor: remove unused C string ToV8() gin converter ( #44523 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-02 13:56:55 -05:00
trop[bot]
faa1910ffe
perf: use v8::String::NewFromUtf8Literal in ToV8() gin converter ( #44518 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-01 16:56:09 -05:00
trop[bot]
c1069f778e
docs: add custom titlebar example ( #44508 )
...
* docs: add custom titlebar example
* docs: add links and other small edits
* docs: add panel window docs
* docs: remove panel example
* docs: specify expected emphasis style
* docs: responding to feedback
* docs: fix section names in links
* docs: rework baseWindow note
* docs: making window customization its own section
* responding to feedback
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Anny Yang <anny@electronjs.org>
2024-11-01 14:02:42 -04:00
trop[bot]
201629f206
build: handle out of disk space on source cache ( #44493 )
...
* build: handle out of disk space on source cache
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* build: add cron job to free up source cache disk space
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-31 16:45:08 -05:00
trop[bot]
85272b00a4
fix: EventSource undefined in Renderer/Worker ( #44497 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-31 16:44:00 -05:00
Pedro Pontes
6356cdf49f
chore: backport 1 change from 2-M130 ( #44484 )
2024-10-31 15:24:23 -04:00
Pedro Pontes
e492fba70d
chore: cherry-pick 3 changes from 1-M130 ( #44482 )
...
chore: [32-x-y] cherry-pick 3 changes from 1-M130
* 153d4e84e5d1 from v8
* d9893f4856af from v8
* 8c4edae5e34d from chromium
2024-10-31 14:46:18 -04:00
trop[bot]
310319b00a
perf: remove isolate scope from DidProcessTask() ( #44472 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-31 11:30:10 +01:00
trop[bot]
9b15acb514
docs: fix win.setContentView() arg type ( #44479 )
...
fix: setContentView type
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-30 16:25:57 -04:00
trop[bot]
318a8dcd22
docs: fix win.getContentView() return type ( #44465 )
...
docs: fix win.getContentView() return type
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-29 16:59:55 -04:00
