e017f01544
Inject custom workflow
/ Build tarball (push) Successful in 47m29s
2024-10-18 11:01:30 +00:00
trop[bot]
00e5d0ad56
fix: ensure utilityProcess only emits one 'exit' event ( #44267 )
...
fix: ensure utilityProcess only emits one exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-16 15:04:26 +02:00
Keeley Hammond
1ab051bb69
chore: cherry-pick 2 changes from 3-M129 ( #44232 )
...
* chore: [31-x-y] cherry-pick 2 changes from 3-M129
* 9542895cdd3d from v8
* 81155a8f3b20 from v8
* chore: update patches
2024-10-14 22:10:02 -05:00
Charles Kerr
48b962898d
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (31-x-y) ( #44215 )
...
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (#44185 )
2024-10-13 20:04:33 +02:00
Charles Kerr
dce705efc0
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44149 ) ( #44216 )
...
fixup e8948397
2024-10-13 20:04:18 +02:00
trop[bot]
e206378680
fix: clang variable configuration in generated node headers ( #44202 )
...
* fix: clang variable configuration in generated node headers
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: restore value in common.gypi
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 14:52:49 -04:00
trop[bot]
4ccf4fa97d
ci: don't call datadog test logging on forks ( #44194 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 09:42:10 -04:00
trop[bot]
d262568f77
ci: add datadog test logging ( #44165 )
...
* ci: add datadog test logging
(cherry picked from commit 394ea2979fda0c1551df5d5bdf7c13b57d9be181)
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* ci: only upload to datadog when running tests
(cherry picked from commit c3200d8f1540f78c25673a4a9d9af3b8506f9474)
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-10 10:21:38 +02:00
trop[bot]
dbfe4742d5
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() ( #44168 )
...
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 19:36:05 -05:00
trop[bot]
478defb15c
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() ( #44172 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 16:47:48 -05:00
electron-roller[bot]
ba88433eb3
chore: bump node to v20.18.0 (31-x-y) ( #44115 )
...
* chore: bump node in DEPS to v20.18.0
* chore: update patches
* src: improve buffer.transcode performance
https://github.com/nodejs/node/pull/54153
(cherry picked from commit 669984dafcb698716fc02a03e4cf027767a6ec59)
(cherry picked from commit 4b76e4e4937219b8aad665b8c83fb912528ab304)
* chore: update patches
(cherry picked from commit 1f3019564967486104c289025cc68830b7aeb266)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-09 09:53:12 -04:00
Samuel Attard
ba6d9291d2
build: add import/order eslint rule ( #44108 )
...
build: add import/order eslint rule (#44085 )
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-03 15:21:54 -07:00
trop[bot]
6da785fd10
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (31-x-y) ( #44100 )
...
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (#44053 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 20:46:47 -05:00
trop[bot]
daca2d327f
fix: remove use of deprecated API base::Hash() ( #44101 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 20:46:26 -05:00
trop[bot]
f7159b6898
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (31-x-y) ( #44104 )
...
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (#44067 )
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 19:13:48 -05:00
trop[bot]
8e1e4541af
build: fix relative file read during npm publish ( #44090 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-10-01 17:19:43 -07:00
Samuel Attard
01e64d3932
build: cleanup release scripts, separate cli entrypoints from logic ( #44083 )
...
build: cleanup release scripts, separate cli entrypoints from logic (#44058 )
* build: cleanup release scripts, separate cli entrypoints from logic
* build: use repo/org constants
2024-10-01 14:08:20 -07:00
Samuel Attard
075a297347
build: ensure consistent usage of getRepo ( #44079 )
2024-10-01 13:27:02 -07:00
Samuel Attard
5bdaa42b01
build: update some build dependencies ( #44071 )
...
* build: update some build dependencies (#43882 )
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
* build: s/colors/chalk
* build: node 20 on windows
2024-10-01 13:14:08 -07:00
trop[bot]
9222396159
fix: ensure correct WebContents when checking PDFReadyToPrint (31-x-y) ( #44010 )
2024-10-01 18:32:31 +02:00
trop[bot]
a0802f7ce6
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (31-x-y) ( #44036 )
...
* fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (#44014 )
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use string_view.rfind() instead of base::RSplitStringOnce()
base::RSplitStringOnce() does not exist in Chromium 128
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-01 12:17:16 -04:00
Samuel Attard
9ee51dbe92
build: convert all release scripts to typescript ( #44061 )
...
* build: convert all release scripts to typescript (#44035 )
* build: convert all release scripts to typescript
* fix test imports
* build: fix version bumper export
* refactor: use as const
* spec: fix bad type spec
* build: use ts-node to spawn the version-bumper (#44057 )
Missed this in the tsification, we should probably call this via API instead of spawning a sub-proc?
2024-10-01 08:49:36 -07:00
trop[bot]
0a4b0de4f7
fix: ensure SetPluginCanSave updated in PDFs ( #44020 )
...
fix: ensure SetPluginCanSave updated in PDFs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-30 14:52:14 +02:00
trop[bot]
c895d45a6d
ci: write test logging to console on Windows ( #44006 )
...
test: write logging to console on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-29 10:13:04 +02:00
trop[bot]
60e0355b73
fix: remove resize listener when BrowserWindow closed ( #43999 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-27 14:46:03 -04:00
trop[bot]
6010fda0c7
perf: build g_dgettext domain name at compile time ( #43986 )
...
perf: build GettextPackage name at compile time
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 18:59:06 -05:00
trop[bot]
514fc26eb2
fix: replace deprecated libnotify API calls ( #43982 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 17:08:12 -05:00
dependabot[bot]
af9969a3ff
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.27.0 ( #43907 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](6c661ce588...37ebaef184
2024-09-26 11:56:20 -04:00
trop[bot]
328afb8a09
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43981 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 10:55:35 -05:00
trop[bot]
a66e01b555
test: add tests dbus notification images ( #43965 )
...
Provide a NativeImage icon in the notification tests and then inspect
the DBus message payload's `image_data` hint to see if it's correct.
This adds test coverage for LibnotifyNotification::Show() and for
GdkPixbufFromSkBitmap().
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 09:56:22 -04:00
trop[bot]
e99de2b5c6
test: ensure sender-pid hint is set in Linux notifications ( #43951 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 14:02:07 -05:00
trop[bot]
6c1233a7d2
fix: close all open sheets before closing window on macOS ( #43953 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <beutner.john@gmail.com>
2024-09-25 13:09:40 -05:00
dependabot[bot]
3c7a49fdb1
build(deps): bump actions/upload-artifact from 4.3.1 to 4.4.0 ( #43910 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.1 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.1...50769540e7f4bd5e21e526ee35c689e35e0d6874 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 12:14:21 -05:00
trop[bot]
d241d1f3b3
refactor: remove C-style void arg type for no-arg functions ( #43942 )
...
refactor: remove C-style void arg type for no-arg functions (#43884 )
A small cleanup to remove use of the C-style function declaration idiom.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 12:13:22 -05:00
dependabot[bot]
1495f01e2e
build(deps): bump mikefarah/yq from 4.40.7 to 4.44.3 ( #43909 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.40.7 to 4.44.3.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bb66c9c872...bbdd97482f
2024-09-25 11:45:58 -05:00
trop[bot]
ad82142eb0
fix: detach native view when its removed from parent on macOS ( #43924 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cezary Kulakowski <cezary@openfin.co>
2024-09-25 13:17:47 +02:00
trop[bot]
a5f4f08a9e
fix: crash when focusing WebView webContents ( #43933 )
...
fix: crash when focusing WebView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-25 06:17:06 -05:00
trop[bot]
d8e3555e01
fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() ( #43929 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 11:21:44 +02:00
Charles Kerr
f15fea8d03
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (31-x-y) ( #43926 )
...
* fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (#43803 )
* empty commit
2024-09-25 11:21:15 +02:00
dependabot[bot]
615825f40e
build(deps): bump dsanders11/project-actions from 1.2.0 to 1.3.0 ( #43906 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](82e99438bd...eb760c4889
2024-09-24 16:06:34 -05:00
dependabot[bot]
67590867c1
build(deps): bump actions/setup-node from 4.0.2 to 4.0.4 ( #43908 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...0a44ba7841
2024-09-23 23:26:21 -07:00
trop[bot]
f387325079
fix: EyeDropper working in devtools (31-x-y) ( #43895 )
...
fix: EyeDropper working in devtools (#43685 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-23 22:36:18 -07:00
Samuel Attard
4e5de0ca44
build: add support for fetching github token from sudowoodo ( #43888 )
...
build: add support for fetching github token from sudowoodo (#43808 )
* build: add support for fetching github token from sudowoodo
* chore: update release notes cache for tests
* build: support nightlies repo correctly
* build: post token
2024-09-23 13:56:29 -07:00
Shelley Vohr
2cc8a33f11
fix: createWindow shouldn't load URL for webContents ( #43878 )
2024-09-23 21:55:17 +02:00
dependabot[bot]
ec63fbf0b1
build(deps): bump actions/download-artifact from 4.1.7 to 4.1.8 ( #43845 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](65a9edc588...fa0a91b85d
2024-09-23 06:55:47 -07:00
dependabot[bot]
5aaf470e78
build(deps): bump actions-cool/issues-helper from 3.3.3 to 3.6.0 ( #43843 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.3.3 to 3.6.0.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](275328970d...a610082f8a
2024-09-23 06:55:31 -07:00
dependabot[bot]
a164109d50
build(deps): bump actions/checkout from 4.1.1 to 4.1.7 ( #43839 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...692973e3d937129bcbf40652eb9f2f61becf3332 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:54:12 -07:00
dependabot[bot]
6652a3e05c
build(deps): bump dsanders11/github-app-commit-action from 1.1.0 to 1.5.0 ( #43833 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.1.0 to 1.5.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](1dd0a2d22c...43de6da2f4
2024-09-23 06:50:46 -07:00
dependabot[bot]
7fdf729ca2
build(deps): bump github/codeql-action from 3.24.0 to 3.26.8 ( #43831 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.0 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e8893c57a1...294a9d9291
2024-09-23 06:49:52 -07:00
trop[bot]
334a3fbea6
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43812 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add a DCHECK to confirm the BigBuffer is full
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-20 08:48:00 -05:00
