John Kleinschmidt
fded6e7d0b
Merge pull request #13639 from torycl/torycl/current-master-libcc
...
chore: use current master of libcc to include recent patches
2018-07-12 08:18:31 -04:00
Felix Rieseberg
deedf6c3f4
feat: Add isCurrentlyAudible() to WebContents ( #13614 )
...
* 🔧 Add isCurrentlyAudible() to WebContents
* ❤️ Implement feedback, use await to wait for event
* 👷 Add missing imports
2018-07-12 21:35:11 +10:00
Tomas Rycl
d352e6dc9e
Using current master of libcc to include recent patches
2018-07-12 10:39:28 +02:00
Cheng Zhao
e90c4abc0d
Merge pull request #13603 from electron/fix-remote
...
fix: guard against double-freeing remote references
2018-07-12 11:10:22 +09:00
Cheng Zhao
4cdb1b8fc3
fix double-freeing remote references
...
After the page does navigations, garbage collection can still happen in
the old context. This commit changes to store references to remote objects
by _pages_, instead of by _WebContents_.
2018-07-12 10:44:26 +09:00
Cheng Zhao
9cbbb2a6c4
add API to return an unique ID for page
2018-07-12 10:44:26 +09:00
Jeremy Apthorp
bdceea6aca
fix: enable spell checking, which broke in upgrade to ch66
...
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.
Added the first (!) test for spellchecking, too.
Fixes #13608 .
[1]: 03563dd163
2018-07-11 10:27:56 -07:00
Jeremy Apthorp
6fbec9d5a9
chore: [gn] support MAS build
2018-07-11 10:25:07 -07:00
Samuel Attard
addac43bbc
fix: remember the render_process_id when permission requests occur on the IO thread ( #13621 )
...
Fixes #13620
2018-07-11 12:21:47 -05:00
John Kleinschmidt
376094fc0c
Merge pull request #13515 from nornagon/gn-linux
...
chore: [gn] fix linux build
2018-07-11 08:02:42 -04:00
Jeremy Apthorp
9241645a4b
build: [gn] depend on /gtk instead of /gtk3
...
(We still depend on gtk3, just via one extra layer of abstraction. The
/gtk target itself depends on /gtk3.)
2018-07-10 13:42:41 -07:00
Jeremy Apthorp
62f62264da
build: [gn] move crashpad to mac-only
2018-07-10 13:42:40 -07:00
Jeremy Apthorp
1e1adef9b6
build: [gn] use clang and custom stdlib when building node on linux
2018-07-10 13:42:36 -07:00
Jeremy Apthorp
d4cf3cee22
build: [gn] use platform-appropriate shlib_suffix when building node
2018-07-10 13:42:33 -07:00
Jeremy Apthorp
99ecbfbd3b
build: [gn] use consistent node configuration between gyp and build
2018-07-10 13:42:29 -07:00
John Kleinschmidt
4ebe71655b
Merge pull request #13597 from electron/release-updates
...
build: Updates to the release process
2018-07-10 11:40:04 -04:00
Jeremy Apthorp
3a58545a59
chore: replace _ASSERT with DCHECK in toast.cc ( #13598 )
...
_ASSERT was triggering errors about unused values when in debug mode
2018-07-10 08:01:26 -07:00
John Kleinschmidt
2040095b96
Move github release checking to node.js
...
Our upload script was relying on an old python script to find the GitHub release for uploading.
2018-07-10 09:40:24 -04:00
John Kleinschmidt
90339b7260
Update to run new AppVeyor jobs
...
AppVeyor builds got split into two jobs, `electron-x64` and `electron-ia32`
2018-07-10 09:40:24 -04:00
John Kleinschmidt
bc2ea0e705
Merge pull request #13540 from electron/breakpad-compat
...
chore: breakpad #include compatibility between GN and GYP
2018-07-10 08:30:56 -04:00
Tomas Rycl
9b6a37ead7
test: Better path compare than just strings ( #13548 )
...
* Better path comparision than just strings
* Linter fix
* Resolving paths first to always obtain absolute path so path.relative() can work
* Using assert.ok which better fits the test
* No need to resolve parameters of path.resolve
* Added assertion to type of returned path for download item
2018-07-10 21:38:11 +10:00
Cheng Zhao
0ec4ad288d
fix: fallback to FullSizeContentView for frameless window on mac ( #13599 )
...
fix: draggable regions not working on macOS
2018-07-10 11:43:42 +10:00
Jeremy Apthorp
810909425e
chore: breakpad #include compatibility between GN and GYP
2018-07-09 16:53:06 -07:00
John Kleinschmidt
28d4f7f25a
Update to latest libchromiumcontent ( #13594 )
2018-07-10 09:49:00 +10:00
Shelley Vohr
ab7a90e82f
feat: ability to apply patch to clang-format errors ( #13576 )
...
* feat: ability to apply patch to clang-format errors
* improve error message formatting
* fix line length linting error
2018-07-09 10:26:10 -05:00
Cheng Zhao
35b867ff7d
Fix failed devtools tests due to fs.statSyncNoException not working ( #13584 )
...
* Revert "spec: disable the i18nString test"
This reverts commit 86c79653de
.
* update node to fix fs.statSyncNoException
2018-07-09 09:38:48 -05:00
John Kleinschmidt
17fc7bb9fd
Merge pull request #13567 from electron/nightly-release-notifications
...
ci: Add/update slack notifications for nightly builds
2018-07-06 15:20:29 -04:00
Jeremy Apthorp
f50f8e3f3d
chore: [gn] fix CSP warning in debugger API test ( #13541 )
...
There's an attempt to suppress the warning in `spec/static/main.js`, which
sets `process.env.ELECTRON_DISABLE_SECURITY_WARNINGS`. However, it sets the
variable too late in the boot process: by the time that line in main.js has
run, a child zygote has already been booted. `test.py` works around this by
setting that environment variable outside of the test process, to ensure that
it gets propagated to all children.
I've been running the GN tests directly with `./out/Default/electron
electron/spec`, rather than through the wrapper script, and the
`api-debugger-spec.js` tests were failing, because they depend on a particular
log message being the first one emitted, and the CSP warning was causing that
test to fail, since it wasn't being correctly suppressed.
Instead of writing another wrapper script, this just fixes the underlying thing
that the warning is complaining about, which I think is reasonable because the
test's pass/fail depends on this specific behaviour.
2018-07-06 15:01:33 -04:00
John Kleinschmidt
368da14581
Add/update slack notifications
...
Add slack notifications for CircleCI nightly releases
Update VSTS slack notifications to match other platforms.
2018-07-06 10:23:31 -04:00
Cheng Zhao
dd46b3ec85
Merge pull request #13562 from electron/fix-devtools
...
Fix devtools not functioning well
2018-07-06 10:11:43 +09:00
Cheng Zhao
86c79653de
spec: disable the i18nString test
...
It is failed because of fs.statSyncNoException, I'll fix it in another
PR.
2018-07-06 09:07:56 +09:00
Cheng Zhao
56c24406d6
spec: enable back devtools tests
2018-07-06 09:07:56 +09:00
Cheng Zhao
61ea03ed2d
fix: update devtools url
2018-07-06 09:07:56 +09:00
Cheng Zhao
705bbd31e9
add stubs for new devtools messages
2018-07-06 09:07:56 +09:00
Cheng Zhao
29ff9873f4
implement devtools showItemInFolder message
2018-07-06 09:07:56 +09:00
John Kleinschmidt
5aa136a23d
run test.py with --rebuild_native_modules ( #13570 )
...
Fixes script\verify-ffmpeg crash
2018-07-05 16:53:11 -05:00
Cheng Zhao
cb6ab4de20
fix: update libcc to fix private APIs in mas build ( #13529 )
2018-07-03 11:24:43 +09:00
Hari Juturu
eb223f8bc3
Enable webview in sandbox renderer ( #13435 )
...
* Enable webview in sandbox renderer
Security: Inherit embedder prefs onto webview
* cache lastwebprefs
2018-07-03 02:06:26 +10:00
Shelley Vohr
42d173b343
spec: convert menu specs to expect ( #13485 )
...
* spec: convert menu-item spec to expect
* spec: convert menu spec to expect
2018-06-30 00:25:28 -07:00
Maxine Whitely
6cf68f8247
fix: tray setContextMenu crash ( #13513 )
...
Co-authored-by: Zhuo Lu <sethlu@mintkit.net>
Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>
2018-06-29 14:48:26 -07:00
Jeremy Apthorp
67673cbf7f
chore: fix chromium-style errors in native_mate
...
Also clang-format some stuff.
2018-06-29 12:01:09 -07:00
Jeremy Apthorp
180b41ab73
chore: [gn] use merged-in native_mate
2018-06-29 12:01:09 -07:00
Jeremy Apthorp
3d4487ccfd
Merge pull request #13463 from electron/remove_wtl
...
refactor: Using win32 file open api instead of WTL
2018-06-29 10:00:50 -07:00
Jeremy Apthorp
1186f082db
chore: [gn] roll libcc & node deps ( #13508 )
2018-06-29 09:24:58 -07:00
Jeremy Apthorp
9525c94b5e
chore: [gn] remove now-meaningless skia-related #defines ( #13496 )
...
`SK_SUPPORT_LEGACY_GETTOPDEVICE` was removed in [Jan 2017](https://chromium.googlesource.com/skia/+/76467a11a0aa4ba15f0f2e3ee078ba9b6ecbaa91 )
`SK_SUPPORT_LEGACY_SAFESIZE64` was removed in [Oct 2017](https://chromium.googlesource.com/skia/+/3bd0fece5fadd522c2e8c1b0ca9934d7455d9ccd )
2018-06-29 08:36:20 -07:00
Zac Walker
05096f8a65
Removed WTL include folder
2018-06-29 13:26:46 +02:00
Cheng Zhao
e42c6d3eb7
fix the crash when loading site with jquery ( #13475 )
2018-06-29 09:42:04 +09:00
Jeremy Apthorp
8ad3a2cc42
chore: [gn] add electron_app target for windows ( #13491 )
...
This allows building electron.exe on windows 🎉
2018-06-28 14:58:43 -07:00
Jeremy Apthorp
59fb4eccb4
chore: [gn] link against debug node when in debug mode ( #13490 )
...
This is required on Windows, because in Debug mode, C++ stdlib containers have a different size to when in Release mode, so the code in `node.dll` thought that `node::Environment` was a different size to the code in `electron.exe`, which uh, caused problems.
It should also make debugging through node a bit easier on all platforms.
2018-06-28 14:42:09 -07:00
Jeremy Apthorp
733e495e91
chore: use full path for ui_unscaled_resources.h ( #13492 )
...
This is the path that resolves in Chromium, it also works fine in the gyp build.
2018-06-28 14:41:37 -07:00