* chore: bump chromium in DEPS to 139.0.7205.0
* 6543986: Mac: decouple deserializing and applying sandbox policy
Refs 6543986
* 6580079: Reland 'Remove the third-party blocking feature'
Refs 6580079
* 6505716: guest-contents: Add components/guest_contents
Refs 6505716
* 6572556: Move LogMessageManager out of gpu_service_impl.cc.
Refs 6572556
* 6566111: Change UtilityProcessHost to manage its instance internally
Refs 6566111
* 6550237: Rename ReconnectEventObserver to ConnectionChangeObserverClient
Refs 6550237
* 6565918: Validate path is valid UTF8 in SelectFileDialogLinuxPortal
Refs 6565918
* 6579713: Remove base::NotFatalUntil::M130 usage
6566111: Change UtilityProcessHost to manage its instance internally
Refs
65797136566111
* chore: update chromium patches
* chore: update remaining patches
* fixup! 6566111: Change UtilityProcessHost to manage its instance internally Refs 6566111
* 6577970: Remove superfluous includes for base/strings/stringprintf.h in headers
Refs 6577970
* 6568811: Add FunctionCall structured metrics event for DevTools
Refs 6568811
* [PDF Ink Signatures] Support PdfAnnotationsEnabled policy
6558970
* build: disable libcxx modules for rbe
* chore: bump chromium in DEPS to 139.0.7217.0
* chore: bump chromium in DEPS to 139.0.7218.0
* chore: update patches
fix_use_delegated_generic_capturer_when_available.patch was updated to handle a small change:
6582142: Use content::Create*Capturer in DesktopCaptureDevice. | 6582142
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* 6594615: Change Chromium's deployment target to macOS 12
6594615
Updated the assertion message to match the docs structure now too. I removed the callout to the supported versions doc because it has moved and doesn't contain minimum platform version information.
* 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_
6606232
|NativeWindow::GetContentMinimumSize| and |NativeWindow::GetContentMaximumSize| may be good opportunities for a refactor now.
* add squirrel.mac patch for removed function
This was triggered by the macOS 12.0 deployment upgrade change.
See: https://developer.apple.com/documentation/coreservices/1444079-uttypeconformsto?language=objc
* 6582142: Use content::Create*Capturer in DesktopCaptureDevice.
6582142
* 6579732: Two minor API "quality of life" cleanups in OSCrypt Async
6579732
* chore: add include for base::SingleThreadTaskRunner
Not sure what change caused this, I expect it would be a removed include somewhere else, but it's likely not important to track down.
* chore: update libcxx filenames
* chore: update CI build-tools commit target for macOS SDK 15.4
The following change uses an API that was added in the macOS 15.4 SDK. Support for that SDK version was added later than the current build-tools commit target.
6575804: Use a quick-and-dirty solution to avoid glitching with paste-and-go | 6575804
See: https://developer.apple.com/documentation/appkit/nspasteboard/accessbehavior-swift.enum?language=objc
* fixup! 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_ 6606232
* chore: bump chromium in DEPS to 139.0.7220.0
* chore: update patches
Minor changes due to:
6613978: pwa: let events fall through in the transparent area of TopContainerView | 6613978
6614778: Refactor auto pip tab observer for Android support | 6614778
* 6543986: Mac: decouple deserializing and applying sandbox policy
6543986
The DecodeVarInt and DecodeString functions look benign from a MAS perspective. I suspect they were patched out to avoid "unused function" errors. Their complements for encoding are unpatched, supporting this idea.
The code that uses these functions was refactored out of the section that we patch out. Instead of patching out that new function, I decided to treat it the same as the serialization function that is unpatched.
* chore: bump chromium in DEPS to 139.0.7222.0
* chore: bump chromium in DEPS to 139.0.7224.0
* chore: bump chromium in DEPS to 139.0.7226.0
* chore: bump chromium in DEPS to 139.0.7228.0
* chore: update patches
* Don't use static variable for UseExternalPopupMenus
6534657
* Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59
6607589
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* revert Don't use static variable for UseExternalPopupMenus
* tls: remove deprecated tls.createSecurePair and SecurePair
https://github.com/nodejs/node/pull/57361
* Revert "Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59"
This reverts commit 33e1436a0c598ffa8cd308d08de481ed9cd22168.
* test: cleanup api-desktop-capturer-spec.ts
* test: more cleanup of api-desktop-capturer-spec.ts
* chore: debug dcheck error in webrtc on linux
* fixup patch
* add debugging to desktop capturer spec
* test: fixup api-desktop-capturer-spec.ts for linux
* chore: remove debugging patch
* Revert "fixup! 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_ 6606232"
This reverts commit 32e75651c14512572d322e819c98ab1469663bb6.
* Revert "6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_"
This reverts commit 89c51aa1c7771fd7f1d634486bc77f493f1d2ea9.
* [views] Remove DesktopWindowTreeHostWin::window_enlargement_
6606232
Reverting as we need this functionality for now.
* fixup: remove patch that was accidentally added back
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
* fixup! refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
* chore: bump chromium in DEPS to 138.0.7180.0
* 6546797: Add a metric for the overall success of the "safe storage" item retrieval.
Refs 6546797
* 6548078: extensions: Fix TODO in ScriptInjectionTracker for desktop Android
Refs 6548078
* 6544950: Revert "FSA: Only normalize the hardcoded rules once during initialization"
Refs 6544950
* chore: bump chromium in DEPS to 138.0.7181.0
* chore: update patches
* fix: correctly clamp HSL shift values between 0 and 1
* chore: bump DEPS to 138.0.7183.0
* 6553142: Remove SelectFileDialogLinuxKde | 6553142
* chore: update patches
* chore: bump chromium in DEPS to 138.0.7184.0
* chore: bump chromium in DEPS to 138.0.7186.0
* chore: bump chromium in DEPS to 138.0.7190.0
* chore: update patches
* 6547778: Remove some superfluous //ui/gfx includes from //chrome headers | 6547778
* 6556022: Reland FSA: Only normalize the hardcoded rules once during initialization | 6556022
* fix: remove pdf_extension_util::AddAdditionalData
4099130
This was removed 2 years ago in Chrome.
* fix: provide BrowserContext to pdf_extension_util::AddAdditionalData
6558173
* fixup! 6556022: Reland FSA: Only normalize the hardcoded rules once during initialization | 6556022
* fix: pass in navigation throttle registry
6536175
* fixup! 6556022: Reland "FSA: Only normalize the hardcoded rules once during initialization" | 6556022
This partially reverts commit 20d709dd15ba0ff332e24ee314149d642dc5d47c.
* 6545984: corner-shape: render dashed & dotted borders
Refs 6545984
* Update corner smoothing expected images
* Apply "future" revert commit to fix windows build
> Reason for revert: Multiple eng reporting that this is causing build failures due to too-long pathnames, with no immediate feasible workaround
This issue also affects our CI builds.
Problematic CL in current roll: 6494836: [webgl] Add stub WebGL[2]RenderingContextWebGPU | 6494836
"Future" revert CL: 6565622: Revert "[webgl] Add stub WebGL[2]RenderingContextWebGPU" | 6565622
This patch should automatically disappear when we roll the revert.
* 6533919: win: don't add WS_CAPTION style to popup windows
6533919
This mirrors the change made earlier to the code ours is based on: 6374074: [headless] Provide headless aware window metrics on Windows | 6374074
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
Co-authored-by: clavin <clavin@electronjs.org>
* feat: add menu item role `palette` and `header`
* adds comments
* refactors new role items to new item types
* docs: custom type
* docs: note types only available on mac 14+
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* refactor: make NativeWindow::is_modal_ const
* refactor: make NativeWindow::title_bar_style_ const and private
* refactor: make NativeWindow::has_client_frame() protected
refactor: make NativeWindow::transparent() protected
* refactor: make NativeWindow::enable_larger_than_screen() protected
* refactor: make NativeWindow::has_frame_ const
* fixup! refactor: make NativeWindow::has_client_frame() protected
fix: GetExpandedWindowSize()
* refactor: remove unnecessary downcast in MenuViews::PopupAt()
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostLinux ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopNativeWidgetAura ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostWin ctor
* refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
* fixup! refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
fix: tyop
* refactor: use in-class member initialization for NativeWindow::widget_
* refactor: make NativeWindow::transparent_ const
refactor: make NativeWindow::enable_larger_than_screen_ const
* chore: make linter happy after rebase
* refactor: use base::circular_deque in ResolveProxyHelper
* refactor: use base::circular_deque in GetExtraCrashKeys()
refactor: reduce visibility of kMaxCrashKeyValueSize
This change is to match Chromium's usage advice from
base/containers/README.md: `base:circular_deque` is preferred over
`std::deque` to provide consistent performance across platforms.
refactor: make NativeWindow::pending_transitions a base::queue
Follow the base/containers/README.md advice that "Chromium code should
always use `base::circular_deque` or `base::queue` in preference to
`std::deque` or `std::queue` due to memory usage and platform variation."
GTK >= 3.90.0 removed support for menuitem icons. When Electron is
built with GTK >= 3.90.0, our code builds these icons and then throws
them away unused. Instead, let's just not build them.
Our gtk_util::GdkPixbufFromSkBitmap utility uses BGRAToRGBA and is
expensive to call.
The GlobalMenuBar used to hold a raw_ptr reference to its NativeWindow;
but since it doesn't use it & only wants the gfx::AcceleratedWidget info,
let's remove the NativeWindowViews reference.
AFAICT, GlobalMenuBarX11::window_ has never been used
* refactor: make TrackableObject::weak_map_id() constexpr
refactor: make BaseWindow::GetID() inline and constexpr
* refactor: make NativeWindow::window_id() constexpr too
* refactor: use x11_util::IsX11() in BuildSubmenuFromModel()
* refactor: use x11_util::IsX11() in ElectronDesktopWindowTreeHostLinux::OnBoundsChanged()
* refactor: use skia_can_fall_back_to_x11 in x11_util::IsX11()
it is identical in practice to electron_can_call_x11 and does not require a Chromium patch
* chore: remove introduce_ozoneplatform_electron_can_call_x11_property.patch
* refactor: use ui::GetOzonePlatformId() to test for x11
* feat: enable innerWidth and innerHeight for window open
* update comment for added special innerWidth and innerHeight
* update 100 min spec requirement handling
* update testing to include getContentSize
* update macOS min requirement handling
* adjust refactored consts
* update const values from nativewindowviews
Fixes https://github.com/electron/electron/issues/45990
We previously made a change in https://github.com/electron/electron/pull/45868
to fix content protection being lost on hide and re-show. However, this
cause a breaking change where protected windows were made opaque black
instead of being hidden as before. This overrides relevant methods in
ElectronDesktopWindowTreeHostWin to restore the previous behavior.
without regressing the original issue.
* refactor: use ValueOrDefault() in electron_api_web_contents.cc
* refactor: use ValueOrDefault() in electron_api_url_loader.cc
* refactor: use ValueOrDefault() in electron_download_manager_delegate.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in electron_url_loader_factory.cc
* refactor: use ValueOrDefault() in electron_browser_context.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in blink_converter.cc
* feat: add ValueOrDefault() to PersistentDictionary
* empty commit
* refactor: use ValueOrDefault() in blink_converter.cc
* refactor: inline the rectangle base::Value::Dict
* refactor: remove has_scroll temporary
---------
Co-authored-by: Deepak Mohan <hop2deep@gmail.com>
* refactor: do not use native_widget_private() in NativeWindowViews::SetContentProtection()
refactor: do not use native_widget_private() in NativeWindowViews::IsContentProtected()
* refactor: do not use native_widget_private() in NativeWindowViews::Show()
* chore: remove native_widget_private #include from native_window_views_win
Not needed since Feb 2025: 9199d5c6
