Shelley Vohr
ce91f050d4
feat: allow macOS tray to maintain position ( #48076 )
2025-08-21 10:41:30 +02:00
trop[bot]
4b46b6e2f2
feat: add {get|set}AccentColor
on Windows ( #48017 )
...
* feat: add setAccentColor on Windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: unify GetSystemAccentColor
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: remove redundant parsing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fixup documentation
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/browser-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/base-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-11 11:17:43 -04:00
trop[bot]
4f426daeca
feat: Use DIR_ASSETS path to locate resource bundles ( #47951 )
...
* feat: Use DIR_ASSETS path to locate resource bundles
Co-authored-by: Will Anderson <andersonw@dropbox.com>
* Use DIR_ASSETS for calculating ASAR relative paths
Co-authored-by: Will Anderson <andersonw@dropbox.com>
* Add test to verify 'assets' matches parent dir of 'exe'
Co-authored-by: Will Anderson <andersonw@dropbox.com>
* Add Mac-specific test for assets path (but it is failing)
Co-authored-by: Will Anderson <andersonw@dropbox.com>
* test: Update app.getPath('assets') to expect an exception on Mac
Co-authored-by: Will Anderson <andersonw@dropbox.com>
* docs: Update docs for 'assets' path to indicate that it's only available on Windows + Linux
Co-authored-by: Will Anderson <andersonw@dropbox.com>
* fix: Don't define 'assets' mapping on macOS
Co-authored-by: Will Anderson <andersonw@dropbox.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Will Anderson <andersonw@dropbox.com>
2025-08-06 19:40:07 +02:00
trop[bot]
e83b0f6c23
feat: add app.getRecentDocuments()
( #47923 )
...
feat: add app.getRecentDocuments()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-06 19:35:15 +02:00
Calvin
e845d20789
fix: corner smoothing feature gate crash (37-x-y) ( #47792 )
...
fix: corner smoothing feature gate crash (#47759 )
2025-07-16 12:03:26 -07:00
trop[bot]
52bba3fb5f
docs: fix broken sentence in crashReporter.start() documentation ( #47777 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Pratyush <116508117+pratstick@users.noreply.github.com>
2025-07-16 15:58:08 +02:00
trop[bot]
dac83d743b
docs: improve win.setContentProtection()
docs ( #47762 )
...
* docs: improve win.setContentProtection() docs
Co-authored-by: Milan Burda <milan.burda@gmail.com>
* docs: update Windows display affinity value
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
* docs: update Windows behavior description
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
* Revert "docs: update Windows behavior description"
This reverts commit 6d1942c53a4951b985643432d64cf79df26b2d34.
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
* Revert "docs: update Windows display affinity value"
This reverts commit c15363e75d271100a437387e4512f084cb8d3cf9.
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-07-16 09:52:54 +02:00
trop[bot]
1754c55c05
docs: fix --experimental-network-inspection
spelling ( #47573 )
...
doc: fix `--experimental-network-inspection` spelling
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-06-26 16:38:14 +02:00
trop[bot]
75cda9e16b
feat: support customizing window accent color on Windows ( #47537 )
...
* fix: support window accent color in frameless windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: allow customization
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/structures/base-window-options.md
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-25 20:41:42 +02:00
trop[bot]
713030b21a
feat: add menu item role palette
and header
( #47245 )
...
* feat: add menu item role `palette` and `header`
Co-authored-by: Gellert Hegyi <gellihegyi@gmail.com>
* adds comments
Co-authored-by: Gellert Hegyi <gellihegyi@gmail.com>
* refactors new role items to new item types
Co-authored-by: Gellert Hegyi <gellert@poolside.ai>
* docs: custom type
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* docs: note types only available on mac 14+
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Gellert Hegyi <gellihegyi@gmail.com>
Co-authored-by: Gellert Hegyi <gellert@poolside.ai>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2025-06-23 19:54:53 -04:00
trop[bot]
cfa2efe0c2
feat: add support for --no-experimental-global-navigator ( #47418 )
...
chore: add support for --no-experimental-global-navigator
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-06-23 12:21:38 +02:00
trop[bot]
2f1dfc73ac
feat: support HIDDevice.collections
( #47483 )
...
* feat: support HIDDevice.collections
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/structures/hid-device.md
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-18 20:47:06 +02:00
trop[bot]
32599dda44
docs: mention kwallet6
command line option ( #47437 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-06-10 18:37:12 -05:00
trop[bot]
e90404be7d
docs: no class inheritance ( #47433 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2025-06-10 13:12:24 +02:00
trop[bot]
b494ae62ba
feat: [net] add "priority" option to net.request ( #47321 )
...
document the default value of priority option
Update the priority test to not use the httpbin.org as server
Fixed the lint errors
Fixed the build error
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Zeeker <13848632+zeeker999@users.noreply.github.com>
2025-06-10 10:28:46 +02:00
trop[bot]
3fdb77abf1
feat: allow intercepting mouse events ( #47364 )
...
* feat: allow intercepting mouse events
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: add specs
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update spec/api-web-contents-spec.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-05 15:47:42 +02:00
trop[bot]
2e2d1f1612
feat: expose win.isContentProtected()
( #47310 )
...
* feat: expose win.isContentProtected()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: remove stray _isContentProtected
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-05 15:46:57 +02:00
trop[bot]
c68389ad98
docs: update link to runAsNode
fuse ( #47376 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2025-06-05 15:20:35 +02:00
trop[bot]
95212a539b
docs: correct 'select-bluetooth-device' requirement ( #47336 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-03 10:53:54 +02:00
trop[bot]
ab78c8a295
docs: add documentation for ImageView
( #47297 )
...
* docs: Add documentation for ImageView
* docs: Add ImageView main process module list in README.md
* test: Add some basic tests for ImageView
* test: Fill out Window embedding tests to better reflect how someone might use an ImageView
* docs: Add notes about using ImageView as a splash screen
* docs: Update ImageView example to show a more complete splash screen example
* docs: Remove view resizing logic since the ImageView automatically gets resized
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Will Anderson <andersonw@dropbox.com>
2025-05-30 13:48:13 +02:00
trop[bot]
917e95433a
docs: add note on DIP and DPI ( #47121 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2025-05-15 17:16:33 -05:00
trop[bot]
f1562543a3
feat: add support for --experimental-network-inspection
( #47031 )
...
* feat: add support for `--experimental-network-inspection`
Co-authored-by: Aman Karmani <aman@tmm1.net>
* docs: fix minor formatting issues
visible on both GH[1] and the docs site[2]
[1] https://github.com/electron/electron/blob/main/docs/api/command-line-switches.md#nodejs-flags
[2] https://www.electronjs.org/docs/latest/api/command-line-switches#--inspect-brkhostport
Co-authored-by: Aman Karmani <aman@tmm1.net>
* docs: add entry for new nodejs flag
Co-authored-by: Aman Karmani <aman@tmm1.net>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Aman Karmani <aman@tmm1.net>
2025-05-14 16:03:02 -05:00
trop[bot]
ec83c1303c
feat: enable secondary label for macOS menu ( #47042 )
...
* feat: enable secondary label for macOS menu
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
* Update shell/browser/ui/cocoa/electron_menu_controller.mm
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
* fix for lint
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
* update docs for sublabel
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
2025-05-14 16:02:32 -05:00
trop[bot]
434f77e6c1
docs: unify [!NOTE] structure ( #47048 )
...
* docs: unify [!NOTE] structure
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
* Update docs/api/command-line.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update docs/api/browser-window.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update docs/api/download-item.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update docs/api/global-shortcut.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* revert line break
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2025-05-09 17:46:11 -05:00
trop[bot]
8189b01987
docs: use correct heading level for API function ( #46941 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2025-05-05 16:28:15 -05:00
trop[bot]
d783f134d9
feat: support dip <-> screen conversion on Linux X11 ( #46895 )
...
feat: support dip <-> screen conversion on Linux
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-02 19:08:50 -05:00
trop[bot]
620f3a57dd
docs: clarified usage of createFromPath() ( #46898 )
...
* docs: clarified usage of createFromPath()
Co-authored-by: Yuri <rarescrap@gmail.com>
* Update docs/api/native-image.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Yuri <rarescrap@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Yuri <rarescrap@gmail.com>
2025-05-02 13:19:52 +02:00
Charles Kerr
3f3c297c7a
fix: enable some tests that were accidentally disabled ( #46816 )
...
* test: add platform test on visibleOnAllWorkspaces tests
visibleOnAllWorkspaces is not supported on Windows
* test: do not skip visibleOnAllWorkspaces tests on Windows
That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.
* fix: nested it() calls in visibleOnAllWorkspaces specs
* chore: make the process.platform test simpler
* fix: tests that were not run in api-app-spec due to nested it()
* fix: tests that were not run in api-browser-window-spec due to nested it()
* chore: annotate disabled test
* fix: enable `autoHideMenuBar` tests on Linux and Windows (#46818 )
* fix: enable autoHideMenuBar tests
* docs: mark autoHideMenuBar as supported on Linux, Windows
2025-04-28 12:32:57 -05:00
Charles Kerr
686ae47696
refactor: remove redundant NativeImage::GetBitmap() ( #46696 )
...
* refactor: remove redundant NativeImage::GetBitmap()
* docs: mark NativeImage.getBitmap() as deprecated
* have getBitmap() emit a deprecation warning
* docs: update obsolete refefence to getBitmap()
* test: update obsolete refefences to getBitmap()
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2025-04-23 11:00:43 +02:00
Keeley Hammond
a9b2ec514b
fix: fallback to old MacOS context menu behavior if no frame is present ( #46595 )
...
* fix: fallback to old MacOS context menu behavior if no frame is present
Co-authored-by: georgexu99 <georgexu99@electronjs.org>
Co-authored-by: erickzhao <erickzhao@electronjs.org>
Co-authored-by: clavin <calvin@electronjs.org>
* docs: add additional option for focusedFrame
* fix: handle frame found, but no view update from rfh
* fix: fix conditional
Co-authored-by: Calvin <clavin@users.noreply.github.com>
---------
Co-authored-by: georgexu99 <georgexu99@electronjs.org>
Co-authored-by: erickzhao <erickzhao@electronjs.org>
Co-authored-by: clavin <calvin@electronjs.org>
Co-authored-by: Calvin <clavin@users.noreply.github.com>
2025-04-11 10:15:35 -04:00
Shelley Vohr
446d0769ed
feat: expose nativeTheme.shouldUseDarkColorsForSystemIntegratedUI
( #46438 )
...
feat: expose shouldUseDarkColorsForSystemIntegratedUI
Closes https://github.com/electron/electron/issues/46429 .
Refs https://github.com/electron/electron/pull/19735 .
This PR adds a new API `shouldUseDarkColorsForSystemIntegratedUI` to the
`nativeTheme` module. This API returns a boolean indicating whether the
system is using dark colors for system integrated UI elements. This is
useful for applications that want to adapt their UI to match the system
theme, especially for those that use system integrated UI elements like
the shell theme or taskbar appearance.
2025-04-10 12:08:29 +02:00
Yuri
de407e82b7
docs: updated tray doc with tooltip removing ( #46515 )
...
added tooltip removing doc
2025-04-09 11:50:08 -04:00
Charles Kerr
a6875c732c
docs: note that titleBarOverlay.symbolColor
is supported on Linux ( #46492 )
...
docs: note that titleBarOverlay.symbolColor is supported on Linux
this is supported via OpaqueFrameView
2025-04-07 11:10:54 +02:00
electron-roller[bot]
9c019b6147
chore: bump chromium to 136.0.7095.0 (main) ( #46118 )
...
* chore: bump chromium in DEPS to 136.0.7076.0
* chore: bump chromium in DEPS to 136.0.7077.0
* 6368856: Migrate absl variant.h and utility.h in content (part 2/2) | https://chromium-review.googlesource.com/c/chromium/src/+/6368856
* 6356528: Clean up LegacyRenderWidgetHostHWND code | https://chromium-review.googlesource.com/c/chromium/src/+/6356528
* chore: export patches
* 6339113: [Viewport Segments] Add CDP commands to override Viewport Segments without overriding other device properties. | https://chromium-review.googlesource.com/c/chromium/src/+/6339113
* 6352169: [DevTools][MultiInstance] Support new tab in another window on Android | https://chromium-review.googlesource.com/c/chromium/src/+/6352169
* 6368856: Migrate absl variant.h and utility.h in content (part 2/2) | https://chromium-review.googlesource.com/c/chromium/src/+/6368856
* 6360858:Clickiness: Wire response from URLLoader to DB, add e2e tests| https://chromium-review.googlesource.com/c/chromium/src/+/6360858
* chore: bump chromium in DEPS to 136.0.7079.0
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7081.0
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7083.0
* 6361987: Remove double-declaration with gfx::NativeView and gfx::NativeWindow | https://chromium-review.googlesource.com/c/chromium/src/+/6361987
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7087.0
* chore: export patches
* fix: include node patch for missing AtomicsWaitEvent
https://chromium-review.googlesource.com/c/chromium/src/+/6385540
* build: add depot_tools python to path
* fix: cppgc init and unregistering v8 isolate
https://chromium-review.googlesource.com/c/v8/v8/+/6333562
CppGc is now initialized earlier so Node can skip reinitializing it.
Additionally, gin::IsolateHandle was attempting to destruct an already destructed
v8::Isolate upon electron::JavaScriptEnvironment destruction. By removing the call
to NodePlatform::UnregisterIsolate, this fixes the crash on app shutdown.
* fix: unregister isolate after destruction
See code comment.
* chore: bump chromium in DEPS to 136.0.7095.0
* chore: sync patches
* fix: add script_parsing::ContentScriptType parameter
https://chromium-review.googlesource.com/c/chromium/src/+/6298395
* fix: migrate content::BrowserAccessibilityState methods
https://chromium-review.googlesource.com/c/chromium/src/+/6401437
https://chromium-review.googlesource.com/c/chromium/src/+/6383275
* feat: enableHappyEyeballs option for host resolver
https://chromium-review.googlesource.com/c/chromium/src/+/6332599
* fix: add new cookie exclusion reason
https://chromium-review.googlesource.com/c/chromium/src/+/6343479
* fix: add new url loader method
https://chromium-review.googlesource.com/c/chromium/src/+/6337340
* fix: add new cppgc header file for electron_node headers
https://chromium-review.googlesource.com/c/v8/v8/+/6348644
* fix: disable CREL on Linux ARM64
https://chromium-review.googlesource.com/q/I3a62f02f564f07be63173b0773b4ecaffbe939b9
* fixup! fix: add new cppgc header file for electron_node headers https://chromium-review.googlesource.com/c/v8/v8/+/6348644
* chore: update corner smoothing patch
* fixup! chore: update corner smoothing patch
* chore: disable NAN weak tests
These two tests are incompatible with a V8 change that disallows running JS code from a weak finalizer callback.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/4733273
* test: fix task starvation in node test
A V8 change makes these contexts get collected in a task that is posted
and run asynchronously. The tests were synchronously GC'ing in an
infinite loop, preventing the task loop from running the task that would
GC these contexts.
This change should be upstreamed in some way.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/4733273
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
2025-04-03 19:02:49 -05:00
Charles Kerr
5a6f1ede6a
feat!: remove support for ProtocolResponse.session null value ( #46264 )
...
BREAKING CHANGE
This was deprecated in f7ba0d3b
& is now being removed for Electron 37.
2025-04-01 08:52:12 -05:00
Shelley Vohr
9c4720766d
fix: UtilityProcess.fork
crash before app ready ( #46380 )
...
fix: UtilityProcess.fork crash before app ready
2025-04-01 13:42:03 +02:00
Shelley Vohr
5da75c4a97
feat: support system-context-menu
on Linux ( #45848 )
...
feat: support system-context-menu on Linux
2025-04-01 11:00:39 +02:00
Calvin
09135443a0
feat: Corner Smoothing CSS rule (Reland) ( #46278 )
...
* feat: Corner Smoothing CSS rule (Reland)
Reland of #45185
* Fix patch conflicts
* fixup! Fix patch conflicts
* Update expected image
The dashed border is subtly different. The new version is correct and the old one was incorrect.
2025-03-31 11:22:23 -05:00
Samuel Attard
49aba471dc
feat: add support for associating a Menu with a WebFrameMain ( #45138 )
...
* feat: add support for associating a Menu with a WebFrameMain
This allows certain OS level features to activate such as Writing Tools, Autofill.. and Services.
There appears to be a bug in macOS where the responder chain isn't traversed if the menu is not popped up using an event, as such we spoof a fake mouse event at the write coordinates in the right window and use that to open the menu.
* build: fix build on non-mac
* build: oops missed a header
* fix: safely handle optional T* by checking nullptr too
* build: fix gn check and build errors
* docs: suggested changes
* feat: default `frame` to `window.webContents.mainFrame` when possible
* fix: avoid deref nullptr view
* Revert "feat: default `frame` to `window.webContents.mainFrame` when possible"
This reverts commit 2e888368199317d67f6ad931a7e9eff0295c4b1b.
* fix: lint
* Remove redundant scoped objects
This code, including the comments, matches almost exactly the behavior of this argument to the function.
* Add ScopedPumpMessagesInPrivateModes patch
* More null pointer safety
---------
Co-authored-by: clavin <clavin@electronjs.org>
2025-03-28 11:50:07 -07:00
Shelley Vohr
d2c2261c58
fix: hard crash on invalid command line switches ( #46004 )
...
* fix: hard crash on invalid command line switch
* Update docs/api/command-line.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
* chore: feedback from review
* docs: Add breaking change note
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-03-26 08:14:03 -05:00
Charles Kerr
f7ba0d3b4b
docs: deprecate setting ProtocolResponse.session to null ( #46131 )
...
* docs: deprecate setting ProtocolResponse.session to null
* docs: mark null ProtocolResponse.session as deprecated in struct docs
* Update docs/breaking-changes.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
2025-03-25 10:04:21 -05:00
Calvin
abaef13c0b
fix: Revert "feat: Corner Smoothing CSS rule" ( #46231 )
...
Revert "feat: Corner Smoothing CSS rule (#45185 )"
This reverts commit b75e802280
.
2025-03-24 20:36:49 +01:00
Calvin
b75e802280
feat: Corner Smoothing CSS rule ( #45185 )
...
* feat: Corner Smoothing
* Patch Blink to add CSS rule and Painting
* Add `system-ui` keyword
* Add `cornerSmoothingCSS` web preference
* Add tests
* Documentation
* fixup! Documentation
* fix: initialize smoothness value
* Use a 1.0 scale factor in tests
* Fix tests for CI
* Fix tests
* fixup! Merge branch 'main' into clavin/corner-smoothing
* Add code docs
* Document `system-ui` keyword values
* Address review comments
* fixup! Address review comments
* Address review comments
* Update patch to address upstream changes
The patch went from 694 lines to 505 lines, which is a 27.2% smaller!
* fixup! Update patch to address upstream changes
2025-03-24 11:46:12 -04:00
Shelley Vohr
9ec14b91e7
feat: add BrowserWindow.isSnapped()
( #46079 )
...
* feat: add BrowserWindow.isSnapped() on Windows
* docs: mark _Readonly_
2025-03-24 12:09:14 +01:00
Erik Moura
e9082ea57a
docs: fix capitalization for InputEvent.modifiers
( #46130 )
2025-03-23 16:38:15 -05:00
Shelley Vohr
603057b198
fix: remove File.path
from types ( #46005 )
2025-03-21 08:40:49 +01:00
Shelley Vohr
86cc9f626f
fix: APNS token ids are lowercase ASCII ( #46101 )
2025-03-20 07:57:50 +01:00
Niklas Wenzel
bf1d377e08
docs: use optional chaining for app.dock
( #46119 )
...
docs: use optional chaining for app.dock
2025-03-19 18:34:03 -05:00
Niklas Wenzel
71f3ff6bf2
docs: fix types of app.dock
( #46073 )
2025-03-18 13:14:08 +01:00
Sam Maddock
afca4e271e
feat: ServiceWorkerMain.scriptURL ( #45863 )
...
feat: serviceWorker.scriptURL
2025-03-14 21:00:13 -04:00