mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: enable some tests that were accidentally disabled (#46816)

Browse source 
* test: add platform test on visibleOnAllWorkspaces tests

visibleOnAllWorkspaces is not supported on Windows

* test: do not skip visibleOnAllWorkspaces tests on Windows

That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.

* fix: nested it() calls in visibleOnAllWorkspaces specs

* chore: make the process.platform test simpler

* fix: tests that were not run in api-app-spec due to nested it()

* fix: tests that were not run in api-browser-window-spec due to nested it()

* chore: annotate disabled test

* fix: enable `autoHideMenuBar` tests on Linux and Windows (#46818)

* fix: enable autoHideMenuBar tests

* docs: mark autoHideMenuBar as supported on Linux, Windows
This commit is contained in:
Charles Kerr 2025-04-28 12:32:57 -05:00 • committed by GitHub
parent 062d3a6168
commit 3f3c297c7a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 31 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/api/base-window.md
View file

@ -398,7 +398,7 @@ A `View` property for the content view of the window.
A `string` (optional) property that is equal to the `tabbingIdentifier` passed to the `BrowserWindow` constructor or `undefined` if none was set.
#### `win.autoHideMenuBar`
#### `win.autoHideMenuBar` _Linux_ _Windows_
A `boolean` property that determines whether the window menu bar should hide itself automatically. Once set, the menu bar will only show when users press the single `Alt` key.

2
docs/api/browser-window.md
View file

@ -499,7 +499,7 @@ A `Integer` property representing the unique ID of the window. Each ID is unique
A `string` (optional) property that is equal to the `tabbingIdentifier` passed to the `BrowserWindow` constructor or `undefined` if none was set.
#### `win.autoHideMenuBar`
#### `win.autoHideMenuBar` _Linux_ _Windows_
A `boolean` property that determines whether the window menu bar should hide itself automatically. Once set, the menu bar will only show when users press the single `Alt` key.

4
docs/api/structures/base-window-options.md
View file

@ -58,8 +58,8 @@
`false` on macOS. This option is not configurable on other platforms.
* `disableAutoHideCursor` boolean (optional) - Whether to hide cursor when typing.
Default is `false`.
* `autoHideMenuBar` boolean (optional) - Auto hide the menu bar unless the `Alt`
key is pressed. Default is `false`.
* `autoHideMenuBar` boolean (optional) _Linux_ _Windows_ - Auto hide the menu bar
unless the `Alt` key is pressed. Default is `false`.
* `enableLargerThanScreen` boolean (optional) _macOS_ - Enable the window to
be resized larger than screen. Only relevant for macOS, as other OSes
allow larger-than-screen windows by default. Default is `false`.

6
spec/api-app-spec.ts
View file

@ -84,7 +84,7 @@ describe('app module', () => {
});
describe('app name APIs', () => {
it('with properties', () => {
describe('with properties', () => {
it('returns the name field of package.json', () => {
expect(app.name).to.equal('Electron Test Main');
});
@ -98,7 +98,7 @@ describe('app module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('returns the name field of package.json', () => {
expect(app.getName()).to.equal('Electron Test Main');
});
@ -988,7 +988,7 @@ describe('app module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('can set accessibility support enabled', () => {
expect(app.isAccessibilitySupportEnabled()).to.eql(false);

47
spec/api-browser-window-spec.ts
View file

@ -2102,13 +2102,14 @@ describe('BrowserWindow module', () => {
});
ifdescribe(process.platform === 'win32')('Fullscreen state', () => {
it('with properties', () => {
describe('with properties', () => {
it('can be set with the fullscreen constructor option', () => {
w = new BrowserWindow({ fullscreen: true });
expect(w.fullScreen).to.be.true();
});
it('does not go fullscreen if roundedCorners are enabled', async () => {
// FIXME: this test needs to be fixed and re-enabled.
it.skip('does not go fullscreen if roundedCorners are enabled', async () => {
w = new BrowserWindow({ frame: false, roundedCorners: false, fullscreen: true });
expect(w.fullScreen).to.be.false();
});
@ -2186,7 +2187,7 @@ describe('BrowserWindow module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('can be set with the fullscreen constructor option', () => {
w = new BrowserWindow({ fullscreen: true });
expect(w.isFullScreen()).to.be.true();
@ -2361,10 +2362,10 @@ describe('BrowserWindow module', () => {
});
});
describe('autoHideMenuBar state', () => {
ifdescribe(process.platform !== 'darwin')('autoHideMenuBar state', () => {
afterEach(closeAllWindows);
it('for properties', () => {
describe('for properties', () => {
it('can be set with autoHideMenuBar constructor option', () => {
const w = new BrowserWindow({ show: false, autoHideMenuBar: true });
expect(w.autoHideMenuBar).to.be.true('autoHideMenuBar');
@ -2380,7 +2381,7 @@ describe('BrowserWindow module', () => {
});
});
it('for functions', () => {
describe('for functions', () => {
it('can be set with autoHideMenuBar constructor option', () => {
const w = new BrowserWindow({ show: false, autoHideMenuBar: true });
expect(w.isMenuBarAutoHide()).to.be.true('autoHideMenuBar');
@ -5434,7 +5435,7 @@ describe('BrowserWindow module', () => {
afterEach(closeAllWindows);
describe('movable state', () => {
it('with properties', () => {
describe('with properties', () => {
it('can be set with movable constructor option', () => {
const w = new BrowserWindow({ show: false, movable: false });
expect(w.movable).to.be.false('movable');
@ -5450,7 +5451,7 @@ describe('BrowserWindow module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('can be set with movable constructor option', () => {
const w = new BrowserWindow({ show: false, movable: false });
expect(w.isMovable()).to.be.false('movable');
@ -5468,7 +5469,7 @@ describe('BrowserWindow module', () => {
});
ifdescribe(process.platform === 'darwin')('documentEdited state', () => {
it('with properties', () => {
describe('with properties', () => {
it('can be changed', () => {
const w = new BrowserWindow({ show: false });
expect(w.documentEdited).to.be.false();
@ -5477,7 +5478,7 @@ describe('BrowserWindow module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('can be changed', () => {
const w = new BrowserWindow({ show: false });
expect(w.isDocumentEdited()).to.be.false();
@ -5508,7 +5509,7 @@ describe('BrowserWindow module', () => {
});
describe('native window title', () => {
it('with properties', () => {
describe('with properties', () => {
it('can be set with title constructor option', () => {
const w = new BrowserWindow({ show: false, title: 'mYtItLe' });
expect(w.title).to.eql('mYtItLe');
@ -5522,7 +5523,7 @@ describe('BrowserWindow module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('can be set with minimizable constructor option', () => {
const w = new BrowserWindow({ show: false, title: 'mYtItLe' });
expect(w.getTitle()).to.eql('mYtItLe');
@ -5538,7 +5539,7 @@ describe('BrowserWindow module', () => {
});
describe('minimizable state', () => {
it('with properties', () => {
describe('with properties', () => {
it('can be set with minimizable constructor option', () => {
const w = new BrowserWindow({ show: false, minimizable: false });
expect(w.minimizable).to.be.false('minimizable');
@ -5554,7 +5555,7 @@ describe('BrowserWindow module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('can be set with minimizable constructor option', () => {
const w = new BrowserWindow({ show: false, minimizable: false });
expect(w.isMinimizable()).to.be.false('movable');
@ -5640,7 +5641,7 @@ describe('BrowserWindow module', () => {
});
ifdescribe(process.platform === 'win32')('maximizable state', () => {
it('with properties', () => {
describe('with properties', () => {
it('is reset to its former state', () => {
const w = new BrowserWindow({ show: false });
w.maximizable = false;
@ -5654,7 +5655,7 @@ describe('BrowserWindow module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('is reset to its former state', () => {
const w = new BrowserWindow({ show: false });
w.setMaximizable(false);
@ -5767,7 +5768,7 @@ describe('BrowserWindow module', () => {
});
ifdescribe(process.platform === 'darwin')('fullscreenable state', () => {
it('with functions', () => {
describe('with functions', () => {
it('can be set with fullscreenable constructor option', () => {
const w = new BrowserWindow({ show: false, fullscreenable: false });
expect(w.isFullScreenable()).to.be.false('isFullScreenable');
@ -5834,7 +5835,7 @@ describe('BrowserWindow module', () => {
});
ifdescribe(process.platform === 'darwin')('isHiddenInMissionControl state', () => {
it('with functions', () => {
describe('with functions', () => {
it('can be set with ignoreMissionControl constructor option', () => {
const w = new BrowserWindow({ show: false, hiddenInMissionControl: true });
expect(w.isHiddenInMissionControl()).to.be.true('isHiddenInMissionControl');
@ -5854,7 +5855,7 @@ describe('BrowserWindow module', () => {
// fullscreen events are dispatched eagerly and twiddling things too fast can confuse poor Electron
ifdescribe(process.platform === 'darwin')('kiosk state', () => {
it('with properties', () => {
describe('with properties', () => {
it('can be set with a constructor property', () => {
const w = new BrowserWindow({ kiosk: true });
expect(w.kiosk).to.be.true();
@ -5875,7 +5876,7 @@ describe('BrowserWindow module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('can be set with a constructor property', () => {
const w = new BrowserWindow({ kiosk: true });
expect(w.isKiosk()).to.be.true();
@ -6174,7 +6175,7 @@ describe('BrowserWindow module', () => {
});
describe('closable state', () => {
it('with properties', () => {
describe('with properties', () => {
it('can be set with closable constructor option', () => {
const w = new BrowserWindow({ show: false, closable: false });
expect(w.closable).to.be.false('closable');
@ -6190,7 +6191,7 @@ describe('BrowserWindow module', () => {
});
});
it('with functions', () => {
describe('with functions', () => {
it('can be set with closable constructor option', () => {
const w = new BrowserWindow({ show: false, closable: false });
expect(w.isClosable()).to.be.false('isClosable');
@ -6208,7 +6209,7 @@ describe('BrowserWindow module', () => {
});
describe('hasShadow state', () => {
it('with properties', () => {
describe('with properties', () => {
it('returns a boolean on all platforms', () => {
const w = new BrowserWindow({ show: false });
expect(w.shadow).to.be.a('boolean');