deepak1556
19de41b764
BrowserClient::CanCreateWindow is no longer called on the IO thread
...
https://codereview.chromium.org/2821473002
2017-12-07 09:47:32 +05:30
Charles Kerr
5fa29fcf58
Merge pull request #11329 from electron/remove-classes-key
...
fix: Properly cleanup in `removeAsDefaultProtocolClient`
2017-12-06 17:31:50 -06:00
Ales Pergl
7a73b1d523
Fixed crash in atom::api::SpellCheckClient
...
The class didn't save the V8 context for the spell checking JS function. When
it later tried to call the JS function and there was no active context, V8
crashed.
I also optimized the spell checking loop by introducing `SpellCheckScope` and
reusing the V8 handles throughout the whole loop.
2017-12-06 14:50:20 +01:00
Cheng Zhao
9c109daa4b
Merge pull request #11168 from sethlu/fix-icns-color
...
fix: Update icns
2017-12-06 14:45:36 +09:00
Thiago de Arruda
897712359f
Implement powerMonitor "suspend"/"resume" events for Linux.
2017-12-05 08:12:44 -03:00
Cheng Zhao
24b3ee3a4a
Revert some unnecessary changes
2017-12-05 16:50:25 +09:00
Cheng Zhao
cb3a9c69ab
Add a SessionPreferences to manage session related data
...
By design the BrowserClient should not be aware of the api:: classes.
2017-12-05 15:59:15 +09:00
Cheng Zhao
776e8afa2b
Coding style changes
2017-12-05 11:50:06 +09:00
Samuel Attard
e535ba4808
Don't know why we suddenly need this, but hey :/
2017-12-05 11:35:54 +09:00
Samuel Attard
d1aded2831
Appease the almighty linter
2017-12-05 11:35:53 +09:00
Samuel Attard
d9359d8b6c
s/global/session in constants
2017-12-05 11:35:53 +09:00
Samuel Attard
3b80ee0655
Move global preload implementation to be session based
2017-12-05 11:35:53 +09:00
Samuel Attard
448ccc261d
Use const references
2017-12-05 11:35:27 +09:00
Samuel Attard
0ddd078aaf
Add ability to set global preload scripts
2017-12-05 11:35:27 +09:00
Cheng Zhao
d598aa1a67
Merge pull request #11300 from electron/external-devtools
...
Add API to set arbitrary WebContents as devtools
2017-12-05 10:35:49 +09:00
Felix Rieseberg
d4275b144b
🔧 Linter fascism
2017-12-04 10:46:53 -08:00
Felix Rieseberg
f62e0a4ed4
🔧 Make it actually work
2017-12-04 10:30:20 -08:00
Felix Rieseberg
b4b729609a
🔪 Delete classes key if empty
2017-12-01 17:39:54 -08:00
Ales Pergl
dadfbd3a4f
Reset embedder_zoom_controller_
before assigning new one
2017-12-01 17:55:22 +01:00
Ales Pergl
fd7af5c1d9
Don't call ui::SetAtomArrayProperty
with an empty vector (fails DCHECK)
2017-12-01 17:55:22 +01:00
Ales Pergl
7613afe6d7
Disabled DCHECKs that fail when running tests
2017-12-01 17:55:22 +01:00
Ales Pergl
8357a33d81
Don't leak the taskbar object, reuse it instead
2017-12-01 17:55:21 +01:00
deepak1556
903a5b5100
fix dcheck comparison between unsigned long vs int
2017-12-01 17:55:21 +01:00
Cheng Zhao
6b408de884
Allow using docked devtools for webview
2017-12-01 11:56:58 +09:00
Cheng Zhao
5e4914700e
Enable using external WebContents as devtools
2017-12-01 10:35:23 +09:00
Zeke Sikelianos
aab35073ee
Merge pull request #11255 from electron/fix-11245
...
Enable nativeImage module addRepresentation() tests
2017-11-30 10:48:11 -08:00
Aleksei Kuzmin
b9ed7380aa
Explicitly set alpha type of bitmaps with JPEG data to opaque
...
Actually fixes #11245 .
2017-11-30 17:56:32 +01:00
Thiago de Arruda
68bceb9575
Fix race condition in event_subscriber.h
2017-11-29 12:57:47 -03:00
Zhuo Lu
c274312a3a
Update submenu's title
2017-11-28 19:38:07 -08:00
Cheng Zhao
0dc094fffc
Do not change logic on highlighing
2017-11-28 17:37:58 +09:00
Cheng Zhao
d1ebce0395
Remove unused methods
2017-11-28 17:31:13 +09:00
Cheng Zhao
590578c187
Cache the attributed string
2017-11-28 17:26:09 +09:00
Cheng Zhao
eab3342065
Fix the detection of ANSI code
2017-11-28 16:36:07 +09:00
Cheng Zhao
c9acccaddc
Fix memory leak in ANSCI parsing code
...
We do not have ARC enabled.
2017-11-28 16:36:07 +09:00
Cheng Zhao
4ded79801f
Remove unused code in NSColor+Hex.h
2017-11-28 16:10:24 +09:00
Cheng Zhao
08f30e4ca6
Add license for the vendored files
...
Checked the original files and they were compatible with MIT.
2017-11-28 15:38:42 +09:00
Cheng Zhao
edede7f33f
Fix cpplint warning
2017-11-28 15:36:45 +09:00
Sebastien Bramille
a4905b3c95
Lint
2017-11-28 15:34:13 +09:00
Sebastien Bramille
e8b0897ea1
Fix margin
2017-11-28 15:34:13 +09:00
Sebastien Bramille
71cfb7441c
Update header file
2017-11-28 15:34:13 +09:00
Sebastien Bramille
9f89bd8d8e
Add isHighlighted method
2017-11-28 15:34:13 +09:00
Sebastien Bramille
6a1cfafbd8
Clean
2017-11-28 15:34:13 +09:00
Sebastien Bramille
85f254316c
Add logic
2017-11-28 15:34:13 +09:00
Sebastien Bramille
d722d20974
Use NSString+ANSI on the Menu title
2017-11-28 15:34:13 +09:00
Sebastien Bramille
1d807c552e
Add NSString+ANSI class
2017-11-28 15:34:13 +09:00
Cheng Zhao
124667c29b
Merge pull request #11227 from emmkimme/Fix_10470_sandbox_preload
...
🐞 #10470 - prevent from loading preload in each iframe context
2017-11-28 15:25:34 +09:00
Cheng Zhao
b161a4f515
Merge pull request #11166 from sethlu/openrecent
...
feat: Recent documents menu item
2017-11-28 10:55:14 +09:00
Zhuo Lu
104d307a4a
Use base::scoped_nsobject
2017-11-27 17:26:23 +09:00
Zhuo Lu
8fa3e71ce4
Format code
2017-11-27 17:26:22 +09:00
Zhuo Lu
4934685f53
Declare with static
2017-11-27 17:26:22 +09:00
Zhuo Lu
0c4e425872
Do not autorelease global variables
2017-11-27 17:26:22 +09:00
Zhuo Lu
dcdc3621ac
Rename roles
2017-11-27 17:26:22 +09:00
Zhuo Lu
1ab4504e94
No need to make visible
2017-11-27 17:26:22 +09:00
Zhuo Lu
cf73fb737f
Small optimization
2017-11-27 17:26:22 +09:00
Zhuo Lu
3e6e327711
Remove redundant menu item
...
Already addressed with role: clearrecent
2017-11-27 17:26:22 +09:00
Zhuo Lu
5d44dbaf54
Redesign recent documents role API
...
- For more flexibility in designing the recent documents menu, now there can be one menu item (known issue: you may specify more but AppKit doens't display more than one) in the submenu list, rather than separating the labels with a tab.
- Also added is the role `clearrecent` that can be given to a menu item that can clear the recent documents.
2017-11-27 17:26:22 +09:00
Zhuo Lu
828d233f2a
Rollback duplicated feature
2017-11-27 17:26:22 +09:00
Zhuo Lu
0b9cea334f
Specify "Clear Menu" through label option
...
Like a bit of a hack right now, conforming to the existing menu item definition
2017-11-27 17:26:22 +09:00
Zhuo Lu
8b720c120d
Hide "Open Recent" in xib
2017-11-27 17:26:22 +09:00
Zhuo Lu
4da2eb9366
Introduce openrecent role
...
- Does not yet accept any options except label--"Clear Menu" can't be modified through exposed node API
- If `openrecent` is present across multiple menu items, the last seen will be visible in the main menu due to that it is designed to behave like a singleton
2017-11-27 17:26:22 +09:00
Zhuo Lu
0ba2fa5cba
Use else if
2017-11-27 17:26:22 +09:00
Zhuo Lu
f0bff74995
Add "Open Recent" submenu to default
2017-11-27 17:26:22 +09:00
Cheng Zhao
c0e9dbcc00
Merge pull request #11144 from dittos/mas-login-helper-again
...
Re-land MAS login helper (w/ regression fix)
2017-11-27 17:02:57 +09:00
shelley vohr
c18afc924b
Merge pull request #10213 from electron/upgrade-to-chromium-61
...
[WIP] Upgrade to Chromium 61
2017-11-24 10:17:52 +01:00
Charles Kerr
fcc8e0924e
Merge pull request #11097 from brenca/resizable-win-fix
...
Fix resizable property not working when taskbar was resized
2017-11-24 10:04:43 +01:00
Cheng Zhao
a34d45d8c4
Fix uninitialized NodePlatform
2017-11-24 10:58:53 +09:00
Cheng Zhao
3138c85218
Fix linking problem with NodePlatform
2017-11-24 10:58:53 +09:00
deepak1556
ed4482d7a0
Fix node_debugger api changes
...
* _debugWaitConnect => _breakFirstLine
* Use default thread pool size specified by node.cc
2017-11-24 10:58:53 +09:00
Aleksei Kuzmin
1cf95d2a26
Use node::NodePlatform instead of v8::platform in atom::NodeDebugger
2017-11-24 10:58:53 +09:00
Ales Pergl
f3c32647af
Sanitized notification delegate implementation
...
I made `brightray::NotificationDelegate` back into just an interface and
extracted the implementation used by `PlatformNotificationService`, so that
the main process notification implementation can inherit only the interface.
2017-11-24 10:58:53 +09:00
Ales Pergl
531472bad4
Create a TaskScheduler
when initializing run-as-node mode.
...
It fixes crashes when V8 tries to execute background tasks via the TaskScheduler.
2017-11-24 10:58:53 +09:00
Ales Pergl
334b39ef1e
Fixed build issues
2017-11-24 10:58:53 +09:00
deepak1556
a0be734ccb
Fix client certificate private key handling api
2017-11-24 10:58:53 +09:00
Gellert Hegyi
a47497bf18
adds extra param for ui compositor creation
2017-11-24 10:58:53 +09:00
Gellert Hegyi
5d79dbc9a1
upgrades offscreen rendering to latest chromium
2017-11-24 10:58:53 +09:00
Tomas Rycl
e321a4a433
Setting raw pointer to nullptr as default so it can be detected as noninitialized
2017-11-24 10:58:53 +09:00
Tomas Rycl
69cd33395a
Fixed crash on startup on Windows
2017-11-24 10:58:53 +09:00
Aleksei Kuzmin
fe9ae41f98
Use gtk_toggle_button_get_active()
2017-11-24 10:58:53 +09:00
Samuel Attard
797a58bee0
Result of RunMenuAt is now void, no need to ignore it
2017-11-24 10:58:17 +09:00
Tomas Rycl
a723e5a4c5
Fixed moved cert x509 function issue on Windows
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
89c1b8043f
Do not use SkBitmap.deepCopyTo()
, it was removed
...
Copy of the `sk_tool_utils::copy_to()` is used instead.
Probsbly we should use the function itself.
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
9326ce8cfd
allocator: rename use_experimental_allocator_shim to use_allocator_shim
...
https://codereview.chromium.org/2902043007
2017-11-24 10:58:17 +09:00
Birunthan Mohanathas
4e859b4718
Remove "async" option from menu.popup()
...
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
338604239d
Cleanup MenuRunner API
...
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
14eb2af876
Give CustomButton a focus painter.
...
https://chromium-review.googlesource.com/c/chromium/src/+/516824
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
e0d7b7d0fc
Clean up views::Background.
...
https://chromium-review.googlesource.com/c/chromium/src/+/520702
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
93b3d8cb49
Changed top/bottom & left/right border parameters on BoxLayout to take single gfx::Insets parameter.
...
https://chromium-review.googlesource.com/c/chromium/src/+/515902
2017-11-24 10:58:17 +09:00
Tony Ganch
59550b203f
Include objbase.h only for Windows
2017-11-24 10:58:17 +09:00
Tony Ganch
513d4fd225
Remove usage of X11AtomCache
...
See https://codereview.chromium.org/2914103002/
2017-11-24 10:58:17 +09:00
Tony Ganch
da04cbd4d8
Rename set_background to SetBackground
2017-11-24 10:58:17 +09:00
Tony Ganch
d7e4e8d6cc
Rename GetPrefferedSize to CalculatePrefferedSize
...
See https://chromium-review.googlesource.com/c/chromium/src/+/516542
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
7f5fbb04e2
Migrate from ScopedComPtr::CreateInstance() to CoCreateInstance in chrome/...
...
https://codereview.chromium.org/2894483002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
79e59a88b4
Rename ScopedComPtr::Receive to ScopedComPtr::GetAddressOf
...
https://codereview.chromium.org/2870263002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
485e43636b
Rename ScopedComPtr::get() to ScopedComPtr::Get()
...
https://codereview.chromium.org/2824773002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
1073c9b1ed
Fix compilation of atom/browser/api/atom_api_app.cc
...
Refactor client cert private key handling.
https://codereview.chromium.org/2898573002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
8c40854983
Move handling of DraggableRegionsChanged notification from "view" to "frame".
...
https://codereview.chromium.org/2929493003
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
624b63a1ca
Move "atom/common/node_includes.h" to the end of the includes list
...
https://github.com/electron/electron/issues/10363
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
56e7867455
Move IconURLs method from WebFrame to WebLocalFrame
...
https://codereview.chromium.org/2918903002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
fe662ccbdc
Remove obsolete Blink popup blocker.
...
https://chromium-review.googlesource.com/c/chromium/src/+/512347
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
5fb0f005c5
Convert SpellCheckPanel SpellCheckPanelHost IPC to mojo
...
https://chromium-review.googlesource.com/c/chromium/src/+/515323
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
d817e23050
[c++11 library] Remove ScopedVector
...
https://bugs.chromium.org/p/chromium/issues/detail?id=554289
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
75b41102ef
Remove unused includes
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
a9eb0cbec0
Ban raw pointers to ref-counted types on base::Bind
...
https://chromium-review.googlesource.com/c/chromium/src/+/549537
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
edb7bc6572
Make BlobReader create its own file TaskRunner.
...
https://chromium-review.googlesource.com/c/chromium/src/+/570945
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
47d683f0ad
DevTools: do not set visible size while emulating in case of device mode.
...
https://chromium-review.googlesource.com/c/chromium/src/+/572222
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
6c7ad3ac58
Remove the dependence on BrowserThread::FILE for
...
https://codereview.chromium.org/2944313003
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
b29c485ec4
Consolidate PowerSaveBlocker and WakeLock inside Device Service.
...
https://chromium-review.googlesource.com/c/chromium/src/+/563159
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
e4d9e12ee5
Use blink::WebLocalFrame instead of blink::WebFrame
...
Move GetDocument method from WebFrame to WebLocalFrame.
https://codereview.chromium.org/2928033002
Move MainWorldScriptContext accessor/method from WebFrame to WebLocalFrame.
https://codereview.chromium.org/2923053002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
61797b7802
Move GetDocument method from WebFrame to WebLocalFrame.
...
https://codereview.chromium.org/2928033002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
7608a0489c
Network Traffic Annotation added to DownloadURLParams.
...
https://chromium-review.googlesource.com/c/530307
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
e926473e5a
Partial revert of Provide WebContents::CreateParams to tab helpers.
...
https://chromium-review.googlesource.com/c/571285
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
9566904838
Speech recognition: Use BindOnce / OnceCallback / OnceClosure where applicable
...
https://chromium-review.googlesource.com/c/565762
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
5831a5ffa1
Refactor client cert private key handling.
...
https://codereview.chromium.org/2898573002
2017-11-24 10:58:16 +09:00
Tony Ganch
f694b64d71
FIXME: DesktopNotificationDelegate has been removed
...
Related CL: https://codereview.chromium.org/2906883003
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
2c063f93ff
Remove raw base::DictionaryValue::Set
...
https://codereview.chromium.org/2911033002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
370476c4af
Remove unused RenderViewObserver methods.
...
https://chromium-review.googlesource.com/c/506027
`DidCreateDocumentElement()` observer method was removed.
So I have to use a different approach to check if a document element
has already been created on a web page.
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
1127452429
PlzNavigate: make NavigationResourceHandler a LayeredResourceHandler
...
https://codereview.chromium.org/2847443002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
a72a08bccc
Convert iOS to use X509CertificateBytes.
...
https://codereview.chromium.org/2864133002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ea8e113b19
SkBitmap and SkPixelRef no longer need lock/unlock
...
https://codereview.chromium.org/2823003002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ea4a36039a
Add Keyboard Latency UMA Metrics.
...
https://codereview.chromium.org/2756893002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
f03ca53af5
Add blink::WebInputEvent::IsPinchGestureEventType().
...
https://codereview.chromium.org/2861373004
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
650902c656
Renamed LoadCommittedDetails.is_in_page to is_same_document.
...
https://codereview.chromium.org/2841833002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
90b0984a14
Add missing IWYU message_loop.h includes.
...
https://codereview.chromium.org/2876013002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
e2a224c4e6
Remove rendundant WebLocalFrame parameter in various plugin code.
...
https://codereview.chromium.org/2855123003
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
11fa935359
Introduce TaskRunner::RunsTasksInCurrentSequence()
...
https://codereview.chromium.org/2823103003
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
f2bcdab037
Provide WebContents::CreateParams to tab helpers.
...
https://codereview.chromium.org/2894973002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
971002a197
Switch to using scoped_ptr with UserData
...
https://codereview.chromium.org/2815913005
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ee9a547985
Service CreateNewWindow on the UI thread with a new mojo interface
...
https://codereview.chromium.org/2821473002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ba6e8b4dff
Merge ResourceRequestBodyImpl and ResourceRequestBody.
...
https://codereview.chromium.org/2954343005
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
b77b67bfbe
Remove client_certs from SSLCertRequestInfo.
...
https://codereview.chromium.org/2838243002
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
ba2f33d629
Remove base::Value::GetAsBinary
...
https://codereview.chromium.org/2839753005
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
f847291272
[blink] Unique pointers in Platform.h
...
https://codereview.chromium.org/2846843002
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
7ad524fa34
Make base::DictionaryValue::Set* return pointers
...
https://codereview.chromium.org/2850773002
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
58e0771e47
Remove base::Value::Get{Buffer,Size}
...
https://codereview.chromium.org/2841623003
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
132029ea32
Move components/display_compositor to components/viz/display_compositor
...
https://codereview.chromium.org/2873243002
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
2bb95ce41e
Update chrome_version.h
2017-11-24 10:58:15 +09:00
Cheng Zhao
f8adaed763
Merge pull request #11208 from electron/mips64el
...
Add support for mips64el
2017-11-24 10:54:19 +09:00
Heilig Benedek
bb5eecc16c
Use SizeConstraints instead of window events
2017-11-23 21:25:25 +01:00
Heilig Benedek
ca76dda6a6
remove incorrect checks
2017-11-23 21:25:25 +01:00
Heilig Benedek
7a7f1ee711
dont resize on taskbar resize if resizable is false
2017-11-23 21:25:25 +01:00
Emmanuel Kimmerlin
5f658de19f
🐛 #10470 - prevent to load preload in each iframe context
2017-11-23 09:20:52 +01:00
Felix Rieseberg
3cb062b3d6
🔧 BrowserView.getAllViews()
2017-11-22 16:58:32 -08:00
Cheng Zhao
4f9c5310a9
Fix compiler warning when building with gcc
2017-11-21 21:47:51 +09:00
Charles Kerr
dba9181611
Merge pull request #11164 from electron/nstitlebar-hidden
...
fix: Explicitally set "setTitlebarAppearsTransparent"
2017-11-21 07:51:47 +01:00
Cheng Zhao
cb98ed8674
Merge pull request #11176 from electron/proxy-crash-race
...
Avoid proxy handler race condition crash
2017-11-20 20:15:02 +09:00
Cheng Zhao
3cc8330998
Merge branch 'master' into ahmedmohamedali-master
2017-11-20 11:04:47 +09:00
Matt Crocker
efaf7a6b85
Avoid race condition where login handler webcontents becomes null
2017-11-19 14:08:11 -08:00
Zhuo Lu
367f7f123d
Update icns
2017-11-19 00:33:33 -08:00
Felix Rieseberg
daad465fcd
🔧 Eh, let's do it for all the types
2017-11-18 20:19:22 -08:00
Felix Rieseberg
e3b6271806
🔧 setTitlebarAppearsTransparent=YES
2017-11-18 20:00:01 -08:00