John Kleinschmidt
5aa136a23d
run test.py with --rebuild_native_modules ( #13570 )
...
Fixes script\verify-ffmpeg crash
2018-07-05 16:53:11 -05:00
Cheng Zhao
cb6ab4de20
fix: update libcc to fix private APIs in mas build ( #13529 )
2018-07-03 11:24:43 +09:00
Hari Juturu
eb223f8bc3
Enable webview in sandbox renderer ( #13435 )
...
* Enable webview in sandbox renderer
Security: Inherit embedder prefs onto webview
* cache lastwebprefs
2018-07-03 02:06:26 +10:00
Shelley Vohr
42d173b343
spec: convert menu specs to expect ( #13485 )
...
* spec: convert menu-item spec to expect
* spec: convert menu spec to expect
2018-06-30 00:25:28 -07:00
Maxine Whitely
6cf68f8247
fix: tray setContextMenu crash ( #13513 )
...
Co-authored-by: Zhuo Lu <sethlu@mintkit.net>
Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>
2018-06-29 14:48:26 -07:00
Jeremy Apthorp
67673cbf7f
chore: fix chromium-style errors in native_mate
...
Also clang-format some stuff.
2018-06-29 12:01:09 -07:00
Jeremy Apthorp
180b41ab73
chore: [gn] use merged-in native_mate
2018-06-29 12:01:09 -07:00
Jeremy Apthorp
3d4487ccfd
Merge pull request #13463 from electron/remove_wtl
...
refactor: Using win32 file open api instead of WTL
2018-06-29 10:00:50 -07:00
Jeremy Apthorp
1186f082db
chore: [gn] roll libcc & node deps ( #13508 )
2018-06-29 09:24:58 -07:00
Jeremy Apthorp
9525c94b5e
chore: [gn] remove now-meaningless skia-related #defines ( #13496 )
...
`SK_SUPPORT_LEGACY_GETTOPDEVICE` was removed in [Jan 2017](https://chromium.googlesource.com/skia/+/76467a11a0aa4ba15f0f2e3ee078ba9b6ecbaa91 )
`SK_SUPPORT_LEGACY_SAFESIZE64` was removed in [Oct 2017](https://chromium.googlesource.com/skia/+/3bd0fece5fadd522c2e8c1b0ca9934d7455d9ccd )
2018-06-29 08:36:20 -07:00
Zac Walker
05096f8a65
Removed WTL include folder
2018-06-29 13:26:46 +02:00
Cheng Zhao
e42c6d3eb7
fix the crash when loading site with jquery ( #13475 )
2018-06-29 09:42:04 +09:00
Shelley Vohr
9489401e7d
spec: convert smaller specs to expect
2018-06-28 15:40:30 -07:00
Jeremy Apthorp
8ad3a2cc42
chore: [gn] add electron_app target for windows ( #13491 )
...
This allows building electron.exe on windows 🎉
2018-06-28 14:58:43 -07:00
Jeremy Apthorp
59fb4eccb4
chore: [gn] link against debug node when in debug mode ( #13490 )
...
This is required on Windows, because in Debug mode, C++ stdlib containers have a different size to when in Release mode, so the code in `node.dll` thought that `node::Environment` was a different size to the code in `electron.exe`, which uh, caused problems.
It should also make debugging through node a bit easier on all platforms.
2018-06-28 14:42:09 -07:00
Jeremy Apthorp
733e495e91
chore: use full path for ui_unscaled_resources.h ( #13492 )
...
This is the path that resolves in Chromium, it also works fine in the gyp build.
2018-06-28 14:41:37 -07:00
Jeremy Apthorp
475eef01c3
chore: [gn] copy node.dll in addition to node.dll.lib ( #13489 )
...
On Windows, you need to link against the `.lib` but the `.dll` needs to be next to the `.exe` at runtime, so we need to copy both.
2018-06-28 14:25:56 -07:00
Jeremy Apthorp
6492732631
chore: [gn] fix link errors relating to static members ( #13488 )
...
I'm not 100% sure why this is working in the gyp build, but I was getting link errors with these variables being defined in the headers.
2018-06-28 14:25:26 -07:00
Jeremy Apthorp
d6af3bfcd2
chore: fix more chromium-style errors in windows code ( #13487 )
...
Finding more chromium-style linting errors as I build more of the windows code :)
2018-06-28 14:20:11 -07:00
Shelley Vohr
003a92e099
refactor: remove deprecated GetAs methods ( #13425 )
...
* refactor: remove deprecated GetAs methods
* restructure URLRequestAsyncAsarJob on win
* fix: add string conversion header
2018-06-27 14:52:48 -07:00
Shelley Vohr
fa0704665f
test: temporarily disable failing specs ( #13470 )
2018-06-27 14:15:24 -07:00
Jeremy Apthorp
4f8acb0cdd
docs: add link to Chromium windows debugging docs
...
I found this tidbit in particular helpful:
```sh
> devenv /debugexe out\Debug\chrome.exe <options to Chromium can go here>
```
2018-06-27 23:06:30 +02:00
Samuel Attard
92588be2bd
refactor: add promise helper and change whenReady to be native impl ( #13115 )
...
* Add promise helper and change whenReady to be native impl
* remove commented code
* add GetInner helper to dedupe promise code
* add Promise.reject helper to be consistent with JS
* fix linting
* update promise impl per feedback
* remove param name from unused isolate
* Use non-depreceated resolvers for promises
* Add thread dchecks for promise helper, intiialize promise pointer to nullptr
2018-06-27 16:06:08 -05:00
Shelley Vohr
e9971173d4
fix: inline vector allocation ( #13449 )
...
* fix: inline vector allocation
* remove size_t static cast
2018-06-27 12:57:10 -07:00
zacwalk
9db76394f7
Link gdi from gyp
2018-06-27 20:58:37 +02:00
Zac Walker
8151c90c6b
Fix warnings as error fixes.
2018-06-27 16:28:12 +02:00
Zac Walker
f122c44b07
Using win32 file open dialogs instead of WTL
2018-06-27 13:09:18 +02:00
Samuel Attard
28d148b475
docs: add native_mate to source code directory structure doc ( #13451 )
2018-06-27 17:46:14 +10:00
Shelley Vohr
f9e2ec43d0
fix: deprecate properties in app.getAppMetrics() ( #13446 )
...
* fix: deprecate properties in app.getAppMetrics()
* address feedback from review
* fix deprecated property location
* simplify test
2018-06-26 23:47:01 -07:00
Milan Burda
08ccc2d624
refactor: rpc-server.js cleanup ( #13420 )
...
* refactor: don't declare variables C-style in JavaScript
* refactor: use new constructor(...args) in rpc-server.js
2018-06-27 11:00:05 +10:00
Cheng Zhao
44aad039c6
fix: do not expose Node's external strings ( #13438 )
2018-06-27 10:18:09 +10:00
Shelley Vohr
1dde9492c9
refactor: remove deprecated CreateWithCopiedBuffer ( #13436 )
...
* refactor: remove deprecated CreateWithCopiedBuffer
* fix: add missing vector includes
* fix std::vector<char> allocation
2018-06-26 15:08:27 -07:00
Jeremy Apthorp
39e6943f1e
chore: [gn] changes to BUILD.gn for windows ( #13434 )
...
Grab basket of changes needed to get the `electron_lib` target building on Windows with GN.
2018-06-26 22:58:20 +02:00
Jeremy Apthorp
4b60efcaf8
chore: [gn] fix WTL include paths and namespace include ( #13433 )
...
As of libchromiumcontent#576, the WTL namespace isn't included by
default in the GN build.
2018-06-26 22:57:40 +02:00
Jeremy Apthorp
2d9a491771
chore: [gn] correct library paths for node on windows ( #13429 )
...
For some reason the windows node build needs `.dll` on the ends of these libraries, and also needs to be linked against `dbghelp`.
Additionally, copy the `WHOLEARCHIVE` hacks from common.gypi, which was doing the same thing.
2018-06-26 22:57:05 +02:00
Alexey Kuzmin
f4039d82c3
spec: rewrite and enable a webview's disableguestresize attr test ( #13428 )
2018-06-26 08:38:04 -07:00
Jeremy Apthorp
4255384abc
chore: [gn] remove vendor/ from windows include paths ( #13432 )
2018-06-26 15:03:56 +10:00
Jeremy Apthorp
418c4e170c
chore: [gn] only define WIN32_LEAN_AND_MEAN if not already defined ( #13430 )
...
Chromium's GN build already defines `WIN32_LEAN_AND_MEAN` and `NOMINMAX` (see [build/config/win/BUILD.gn](dbe762aaff/build/config/win/BUILD.gn (515)
) in chrome), so we don't need to define them ourselves. Left as #ifndefs so as not to break the gyp build.
2018-06-26 02:00:50 +02:00
Jeremy Apthorp
78bc1081fd
chore: fix some more warnings in windows build ( #13431 )
...
Remove an unused function and fix an int type comparison warning. Only showed up when building with GN.
2018-06-26 02:00:20 +02:00
Jeremy Apthorp
6f91af9343
chore: fix various chromium-style errors in windows ( #13394 )
...
These errors weren't previously picked up because the GN build wasn't running on Windows.
2018-06-25 22:30:00 +02:00
Shelley Vohr
1c64ac8c41
fix: repair fs.statSyncNoException throwing exceptions ( #13390 )
2018-06-23 00:01:28 -07:00
Samuel Attard
a96fc9170c
Merge pull request #13379 from electron/native-mate-in-electron
...
Merge native_mate into electron/electron
2018-06-23 02:00:58 +10:00
John Kleinschmidt
1c4d20eb94
Merge pull request #13322 from electron/pepper_flash_feature
...
build: move pepper flash behind feature flag
2018-06-22 11:58:10 -04:00
John Kleinschmidt
a971cbf57d
Merge pull request #13377 from electron/chromium-style-win
...
chore: fix chromium-style errors in windows code
2018-06-22 11:46:29 -04:00
John Kleinschmidt
8b6d4b6f0e
Merge pull request #13376 from electron/gn-windows-deps
...
chore: [gn] fix DEPS to work on windows
2018-06-22 10:53:36 -04:00
Samuel Attard
d068ff3afb
fix linting
2018-06-22 13:43:39 +10:00
Samuel Attard
daa64e21f6
rename back to expected values
2018-06-22 11:42:55 +10:00
Samuel Attard
ea4a497442
move native_mate script to the electron scripts dir
2018-06-22 11:38:36 +10:00
Samuel Attard
b6f063d954
update paths for native_mate
2018-06-22 11:36:03 +10:00
Samuel Attard
8b31886c77
remove native_mate submodule
2018-06-22 11:35:14 +10:00