trop[bot]
f119e4cc4b
chore: make macOS release builds higher priority to skip the queue ( #15284 )
...
Release builds should be run before branch builds on our limited macOS
infra.
Refs: https://docs.microsoft.com/en-us/rest/api/vsts/build/builds/queue?view=vsts-rest-4.1#queuepriority
2018-10-19 09:12:21 -07:00
trop[bot]
00489e6106
fix: make release-artifact-cleanup executable (backport: 3-0-x) ( #15272 )
...
* fix: make release-artifact-cleanup executable
* fix misc issues in cleanup script
2018-10-18 20:27:53 -07:00
trop[bot]
a7c34b8a0a
fix: Convert to lower case in upload symbols script (backport: 3-0-x) ( #15261 )
...
* fix: Convert to lower case in upload symbols script
* fix: Convert to lower case in upload symbols script
2018-10-18 19:17:15 -07:00
trop[bot]
906436f31b
fix: loading of devtools extensions on startup (backport: 3-0-x) ( #15264 )
...
* Fix loading of devtools extensions on startup
The persisted DevTools Extensions were not being loaded correctly at startup. The `addDevToolsExtension` function was not defined when it was being called. An error was being thrown and ignored, so the whole thing would fail silently. I moved the code to load the extensions to the end of the event handler, so now it works.
* fixup: remove trailing spaces to unblock CI
* fixup: add logging when the Electron Enable Logging env var is set
* Fix linter error on undefined srcDirectory
* fixup: catch exception when loading extension
* Revert "fixup: catch exception when loading extension"
This reverts commit 42c2cf95bcaab8abfc5fbecbe4365d3adfe36d5b.
2018-10-18 19:13:01 -07:00
Electron Bot
b208fcbf0d
Bump v3.0.5
2018-10-18 17:03:53 -07:00
Samuel Attard
6899ac9bde
Revert "Bump v3.0.5"
...
This reverts commit 72c033299f
.
2018-10-18 23:46:35 +11:00
Electron Bot
72c033299f
Bump v3.0.5
2018-10-17 22:56:11 -07:00
Samuel Attard
7fb6b3bda8
Revert "build: enable PIE when compiling Linux builds, fix #14961 . ( #15152 )"
...
This reverts commit 70d4644742
.
2018-10-18 14:09:34 +11:00
Samuel Attard
1d79840025
Revert "build: enable BIND_NOW when compiling Linux builds, fix #15149 . ( #15153 )"
...
This reverts commit 049381c6ac
.
2018-10-18 14:09:19 +11:00
Samuel Attard
07deaaa502
Revert "Bump v3.0.5"
...
This reverts commit 259f0a62e8
.
2018-10-18 14:08:56 +11:00
Electron Bot
259f0a62e8
Bump v3.0.5
2018-10-17 19:33:27 -07:00
Samuel Attard
4f78df9cfa
Revert "Bump v3.0.5"
...
This reverts commit b2be093bd3
.
2018-10-18 13:26:20 +11:00
Electron Bot
b2be093bd3
Bump v3.0.5
2018-10-17 10:28:20 -07:00
Roller Bot
4f666bb6ac
chore: bump libcc (3-0-x) ( #15201 )
...
* chore: bump libcc submodule to c110392d8556a6428679328f9075b3f4fb54aa3c
* chore: bump libcc in DEPS to c110392d8556a6428679328f9075b3f4fb54aa3c
2018-10-18 00:54:31 +11:00
trop[bot]
12f75832b8
add width to webview iframe ( #15204 )
2018-10-17 11:54:43 +09:00
Cheng Zhao
6f54d58e2a
Merge pull request #15192 from electron/window-open-warn-leak-3-0-x
...
chore: warn memory leak when using nativeWindowOpen with nodeIntegration (3-0-x)
2018-10-17 11:54:21 +09:00
Cheng Zhao
8716f718a9
fix: print warning after DOM is created
2018-10-17 10:42:02 +09:00
Cheng Zhao
714f3ffd29
chore: warn memory leak when using nativeWindowOpen with nodeIntegration
2018-10-16 20:12:53 +09:00
Cheng Zhao
4a5d2117ba
fix: do not enable node integration in child window if not enabled ( #15108 )
2018-10-16 18:10:31 +09:00
Nitish Sakhawalkar
5cb50b0e33
fix: Menu accelerators not working Unity ( #15181 )
2018-10-16 14:46:51 +11:00
Kevin Lynagh
7283b78aa2
fix: simpleFullscreen window should be on top of other OS X menu bars. ( #15183 )
...
If an app has no menu bar (because `app.dock.hide()` has been called),
OS X will still render the menu bar of the previously-focused app.
This commit ensures simpleFullscreen windows will be drawn on top of
that menu bar by setting their level to NSPopUpMenuWindowLevel while
simpleFullscreen mode is active.
Ref: #11468
2018-10-16 13:51:14 +11:00
#DeleteGithub
049381c6ac
build: enable BIND_NOW when compiling Linux builds, fix #15149 . ( #15153 )
...
We've hardened Linux builds by enabling PIE and RELRO,
and should continue to try hardening Linux builds by
enabling BIND_NOW. With both RELRO and BIND_NOW enabled,
we can stop all GOT overwrite attacks. The same hardening
option has been enabled in official Chrome/Chromium
builds since more than five years ago.
This helps to improve the security of a whole range of
applications built upon Electron, including sensetive ones
such as Signal-Desktop.
Signed-off-by: Tom Li <tomli@tomli.me>
2018-10-16 11:44:35 +11:00
Andy Dill
22597474e0
fix: preserve background color through reload (backport: 3-0-x) ( #15175 )
...
* fix: preserve background color through reload
* fix: only set backgroundColor on top-level frames
2018-10-15 12:56:05 -07:00
trop[bot]
760def6147
fix: Memory > Profiles > Load in DevTools ( #15155 )
2018-10-14 10:59:04 -07:00
#DeleteGithub
70d4644742
build: enable PIE when compiling Linux builds, fix #14961 . ( #15152 )
...
PIE allows an application to utilize the full benefits of ASLR
to prevent itself from exploitations, but it was disabled for
all released versions of Electron (3.0 and prior).
Currently, PIE is already enabled since 9294fac but enabling it
for all released version is still an ongoing work (#14961 ). This
patch backports PIE to the 3.0.x branch.
Signed-off-by: Tom Li <tomli@tomli.me>
2018-10-14 12:47:55 +11:00
Shelley Vohr
f6b7f547bb
fix: natively implement LoginItems methods ( #15128 )
...
* fix: natively implement LoginItems methods
* fix flaky spec on MAS builds
2018-10-12 20:50:03 -07:00
trop[bot]
9bb3701f7e
spec: re-enable app.getAppMetric API ( #15123 )
2018-10-12 10:30:56 -07:00
trop[bot]
d7fe65b9bd
docs: app.getLoginItemStatus -> app.getLoginItemSettings ( #15113 )
2018-10-13 01:19:23 +11:00
Charles Kerr
eb8546c8d1
fix: check dbus response for null before use. ( #15033 )
...
* fix: backport #15030 to fix #14958 dbus crash
* chore: re-enable power spec tests
* chore: undo changes made to power monitor tests.
The Linux failures on that are gone in master / 4-0-x. Whatever
resolved it there is unrelated to this PR's changes, so I'm not
going to block this fix on an unrelated issue.
2018-10-11 22:40:22 -07:00
Electron Bot
6719f66d5a
Bump v3.0.4
2018-10-10 20:51:33 -07:00
Roller Bot
b78fb5aa93
chore: bump libcc (3-0-x) ( #15072 )
...
* chore: bump libcc submodule to 42e375e8b0bf4d7e030237adbb9cf7122d9f3246
* chore: bump libcc in DEPS to 42e375e8b0bf4d7e030237adbb9cf7122d9f3246
2018-10-11 14:42:45 +11:00
Shelley Vohr
502b0b988e
fix: handle shortcuts by default if no WebPreferences object exists ( #15066 )
2018-10-11 13:37:55 +11:00
trop[bot]
3d8af9d279
fix: Lifetime of auth_info_ in login handler ( #15044 )
2018-10-10 12:59:27 +11:00
trop[bot]
524bb99948
fix: Check minSize constraints before resizing (backport: 3-0-x) ( #15038 )
2018-10-09 10:52:00 -07:00
trop[bot]
8f743e6fbe
Backport of #14648 ( #15032 )
2018-10-09 09:47:29 -04:00
Electron Bot
6c085cda74
Bump v3.0.3
2018-10-06 16:31:11 -07:00
trop[bot]
73935bc5dd
fix: support ASAR in fs.copyFile ( #14953 )
2018-10-04 09:23:19 +10:00
Cheng Zhao
bf928ee443
fix: use white background for non-OSR renderer by default ( #14934 )
2018-10-03 13:41:37 +09:00
trop[bot]
ee6de82c08
fix: check guest view's devtools window size ( #14928 )
2018-10-03 09:31:34 +09:00
trop[bot]
8d362150e0
fix: Disable new fade animation for BrowserViews ( #14913 )
2018-10-02 13:17:36 +10:00
Shelley Vohr
385b08881e
fix: roll node deps for fs event patch ( #14864 )
2018-09-29 09:17:33 +10:00
trop[bot]
5cd24a4e81
fix: enable key accelerator flags for Windows and Linux (backport: 3-0-x) ( #14859 )
...
* Fix Accelerator Flags for Windows and Linux
* Lint fix
* Lint whitespace
2018-09-28 10:01:28 -07:00
Electron Bot
9ab77adc94
Bump v3.0.2
2018-09-27 13:32:27 -07:00
trop[bot]
d808423975
docs: correct key code reqs for accel doc ( #14824 )
2018-09-27 12:50:14 +10:00
Electron Bot
3979315517
Bump v3.0.1
2018-09-26 17:07:12 -07:00
Shelley Vohr
35cb671529
fix: get background color from GtkMenuBar#menubar ( #14812 )
2018-09-26 10:03:33 -07:00
Roller Bot
0f291f9d63
chore: bump libcc (3-0-x) ( #14809 )
...
* chore: bump libcc submodule to ecc87483bace2bce628bf5d02a73514ffa95f4bf
* chore: bump libcc in DEPS to ecc87483bace2bce628bf5d02a73514ffa95f4bf
2018-09-26 10:02:41 -07:00
trop[bot]
8574a55bd8
fix: inconsistent titleBarStyle on transparent fullscreen ( #14790 )
2018-09-25 12:03:54 -07:00
trop[bot]
05a429075e
docs: clarify allowable background colors for BrowserWindow transparency (backport: 3-0-x) ( #14781 )
...
* docs: clarify allowable colors for transparency
* fix alpha value specification
2018-09-24 09:40:00 -07:00
Alexey Kuzmin
7eb1c3fb1b
fix: initialize tracing controller before starting platform (3-0-x) ( #14503 )
...
* fix: initialize tracing controller before starting platform
* chore: roll node
2018-09-21 10:23:57 -05:00