Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	02c7b92095 
 
						 
						
							
							
								
								
								chore: Bind=>BindRepeating for constructors ( #17924 )  
							
							 
							
							
							
						 
						
							2019-04-24 11:29:59 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Nitish Sakhawalkar 
								
							 
						 
						
							
							
								
							
							
	e77d065875  
						 
						
							
							
								
								
								chore: node_includes header no longer needs to be at the end of the list ( #17090 )  
							
							 
							
							... 
							
							
							
							Until one of the latest version of node, the definition of the DISALLOW_COPY_AND_ASSIGN macro in node was different than in chromium. That is no longer the case, so just undefining the macro in node_includes.h works. 
							
						 
						
							2019-03-11 17:13:43 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Robo 
								
							 
						 
						
							
							
								
							
							
	5afb7dc715  
						 
						
							
							
								
								
								refactor: load electron builtin modules with process._linkedBinding ( #17247 )  
							
							 
							
							... 
							
							
							
							* refactor: load electron builtin modules with process._linkedBinding
NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are
removed in https://github.com/nodejs/node/pull/25829 . This changes
uses the alternative available without any functionality change.
* chore: roll node 
							
						 
						
							2019-03-08 10:29:52 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	544d8a423c 
 
						 
						
							
							
								
								
								feat: allow MenuItems to work optionally when hidden ( #16853 )  
							
							 
							
							... 
							
							
							
							* feat: allow MenuItems to work optionally when hidden
* fix: actually include forward_declaration 
							
						 
						
							2019-02-28 17:00:54 +00:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Jeremy Apthorp 
								
							 
						 
						
							
							
								
							
							
	d01db5a656  
						 
						
							
							
								
								
								migrate to non-deprecated v8 functions  
							
							 
							
							... 
							
							
							
							https://bugs.chromium.org/p/v8/issues/detail?id=8238 
https://bugs.chromium.org/p/v8/issues/detail?id=7295 
https://chromium-review.googlesource.com/c/v8/v8/+/1352273  
							
						 
						
							2019-01-22 10:32:03 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	535d264497  
						 
						
							
							
								
								
								fix: [UI] Resolve method conflict between MenuModel, SimpleMenuModel::Delegate  
							
							 
							
							... 
							
							
							
							https://chromium-review.googlesource.com/c/chromium/src/+/1230581  
							
						 
						
							2018-12-03 20:07:39 +05:30  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Heilig Benedek 
								
							 
						 
						
							
							
								
							
							
	0242818f39  
						 
						
							
							
								
								
								feat: add registerAccelerator flag to allow menu items to optionally skip accelerator registration ( #15723 )  
							
							 
							
							... 
							
							
							
							* feat: add registerAccelerator flag to allow menu items to skip registration
* docs: add docs for registerAccelerator
* docs: re-add accidentally removed line 
							
						 
						
							2018-11-26 10:43:55 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Heilig Benedek 
								
							 
						 
						
							
							
								
							
							
	aa6f7a5d9f  
						 
						
							
							
								
								
								fix: don't append Shift modifier text twice to accelerators ( #15400 )  
							
							 
							
							... 
							
							
							
							* fix: don't append Shift modifier text twice to accelerators
* style: use the new way of creating patches
* test: add menu item accelerator display tests
* fix: allocate accelerator on the stack
* fix: adjust tests to match expected behavior on mac 
							
						 
						
							2018-10-31 10:13:44 -04:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	2337237d58  
						 
						
							
							
								
								
								Refactoring: use C++11 class member variable initialization  
							
							 
							
							
							
						 
						
							2018-05-22 00:18:38 +02:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	c6f4bbd143 
 
						 
						
							
							
								
								
								also format missing .cc files  
							
							 
							
							
							
						 
						
							2018-04-18 20:48:45 -04:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									shelley vohr 
								
							 
						 
						
							
							
								
							
							
	0e5b6f9300  
						 
						
							
							
								
								
								Upgrade to node v9.3.0 ( #11507 )  
							
							 
							
							... 
							
							
							
							* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565 
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085 
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538 
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700  
							
						 
						
							2018-02-23 10:22:00 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	dc62e51ba4  
						 
						
							
							
								
								
								Fix the cyclic reference in menu delegate ( #11967 )  
							
							 
							
							... 
							
							
							
							* Fix the cyclic reference in menu delegate
* Fix menu tests due to delegate change 
							
						 
						
							2018-02-20 10:11:35 -06:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	bef4c84799 
 
						 
						
							
							
								
								
								turn class into observer  
							
							 
							
							
							
						 
						
							2018-01-27 10:40:50 -05:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	3399480304 
 
						 
						
							
							
								
								
								first pass at menu event emission  
							
							 
							
							
							
						 
						
							2018-01-27 09:35:58 -05:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	46330ac2a9  
						 
						
							
							
								
								
								Remove the closed event of Menu  
							
							 
							
							... 
							
							
							
							The callback of Menu.popup does more things, and there is actually no
request for the closed event. 
							
						 
						
							2018-01-01 17:22:07 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Heilig Benedek 
								
							 
						 
						
							
							
								
							
							
	c586806609  
						 
						
							
							
								
								
								fix flash menu being unresponsive to commands  
							
							 
							
							
							
						 
						
							2017-12-20 15:40:07 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	6a023dc4fe  
						 
						
							
							
								
								
								Add Menu.closePopup API on macOS  
							
							 
							
							
							
						 
						
							2017-02-22 10:30:28 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	8c3232dc56  
						 
						
							
							
								
								
								Every native class now gets a name  
							
							 
							
							
							
						 
						
							2016-08-02 19:28:12 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	cb19efe49c  
						 
						
							
							
								
								
								Pass FunctionTemplate in BuildPrototype  
							
							 
							
							
							
						 
						
							2016-08-02 18:08:12 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	8f62e79243  
						 
						
							
							
								
								
								GetConstructor now returns FunctionTemplate  
							
							 
							
							
							
						 
						
							2016-08-02 17:20:58 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	8cd4612fe0  
						 
						
							
							
								
								
								Get rid of Constructor class  
							
							 
							
							
							
						 
						
							2016-08-02 17:02:04 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	1505a46ed0  
						 
						
							
							
								
								
								Do not rely on Constructor to call Init  
							
							 
							
							... 
							
							
							
							This makes it deterministic when the JavaScript is initialized, which
can make our logic more clear. 
							
						 
						
							2016-08-02 15:15:40 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Haojian Wu 
								
							 
						 
						
							
							
								
							
							
	fab02809c6  
						 
						
							
							
								
								
								Modernize to C++11: NULL => nullptr.  
							
							 
							
							... 
							
							
							
							No functional change. 
							
						 
						
							2016-07-10 11:57:04 +02:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	6381f44f26  
						 
						
							
							
								
								
								mac: Pass useDefaultAccelerator to getAcceleratorForCommandId  
							
							 
							
							
							
						 
						
							2016-07-07 11:50:19 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	8d08e215b2  
						 
						
							
							
								
								
								Add "event" parameter for "click" handler of MenuItem  
							
							 
							
							
							
						 
						
							2016-06-22 11:22:14 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	60d2cb8a84  
						 
						
							
							
								
								
								Remove the isolate parameter of GetWrapper  
							
							 
							
							
							
						 
						
							2016-04-25 10:19:25 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	2ae52d0ff4  
						 
						
							
							
								
								
								Make Wrappable a template class  
							
							 
							
							
							
						 
						
							2016-04-25 10:17:54 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	984462be44  
						 
						
							
							
								
								
								Remove Menu::Popup  
							
							 
							
							
							
						 
						
							2016-01-22 11:59:08 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	ca77c95c6d  
						 
						
							
							
								
								
								No more need to override Menu::Popup  
							
							 
							
							
							
						 
						
							2016-01-22 11:27:17 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	6795bd1d96  
						 
						
							
							
								
								
								Do not manually manage native resources  
							
							 
							
							... 
							
							
							
							We should rely on the destructor to cleanup everything, instead of
putting them in the Destroy method. 
							
						 
						
							2015-12-03 15:38:43 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	d56b34de3b  
						 
						
							
							
								
								
								Make sure all native resources get freed on exit  
							
							 
							
							
							
						 
						
							2015-11-04 18:21:03 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	d830badc57  
						 
						
							
							
								
								
								Add role property for MenuItem  
							
							 
							
							
							
						 
						
							2015-09-02 09:42:17 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	4b9ff309ec  
						 
						
							
							
								
								
								Add our own MenuModel class  
							
							 
							
							
							
						 
						
							2015-08-10 12:39:05 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	2ff104d012  
						 
						
							
							
								
								
								Move callback converter from native mate to electron  
							
							 
							
							
							
						 
						
							2015-08-07 19:35:35 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	197a9b4165  
						 
						
							
							
								
								
								Remove calls to v8::Isolate::GetCurrent  
							
							 
							
							... 
							
							
							
							It is generally a bad thing to do since we might have multiple Isolates. 
							
						 
						
							2015-06-23 17:22:14 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	47e9deeb9a  
						 
						
							
							
								
								
								Remove Menu::AttachToWindow  
							
							 
							
							... 
							
							
							
							It makes the logic more complex without any benefit 
							
						 
						
							2015-06-04 15:32:33 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	d78efe7c22  
						 
						
							
							
								
								
								Use Local instead of Handle  
							
							 
							
							
							
						 
						
							2015-05-22 19:11:22 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	e81baf759a  
						 
						
							
							
								
								
								Enable setting icon of menu item  
							
							 
							
							
							
						 
						
							2015-02-13 12:11:50 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	b28a241dbf  
						 
						
							
							
								
								
								Simplify the code to call delegate method  
							
							 
							
							
							
						 
						
							2015-02-13 11:47:22 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Joao Moreno 
								
							 
						 
						
							
							
								
							
							
	46e6b5ec3e  
						 
						
							
							
								
								
								Allow positioning the context menu  
							
							 
							
							
							
						 
						
							2014-11-26 13:54:05 +01:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	b6b6fc3bfd  
						 
						
							
							
								
								
								Remove All Rights Reserved after GitHub copyright  
							
							 
							
							... 
							
							
							
							Closes  #762  
							
						 
						
							2014-10-31 11:17:05 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	6dc01945af  
						 
						
							
							
								
								
								Make Accelerator a standalone JS type.  
							
							 
							
							... 
							
							
							
							This makes menu and global-shortcut share the same code on accelerator. 
							
						 
						
							2014-08-05 00:03:58 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	365638f1d5  
						 
						
							
							
								
								
								win: Remove dead menu code.  
							
							 
							
							
							
						 
						
							2014-07-21 11:23:01 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	8d4211bd3a  
						 
						
							
							
								
								
								win: Fix compilation errors for chrome35.  
							
							 
							
							
							
						 
						
							2014-07-11 12:19:01 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	3c892b8591  
						 
						
							
							
								
								
								views: Make acceleratros work.  
							
							 
							
							
							
						 
						
							2014-07-04 16:54:10 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	61db17412c  
						 
						
							
							
								
								
								Use views to implement NativeWindow and MessageBox on Linux.  
							
							 
							
							
							
						 
						
							2014-07-04 01:30:36 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	ba46f2c820  
						 
						
							
							
								
								
								Use new context aware module API in builtin modules.  
							
							 
							
							
							
						 
						
							2014-06-29 20:48:44 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	cd4c5d976b  
						 
						
							
							
								
								
								Adapt to API changes of Chromium and node.  
							
							 
							
							
							
						 
						
							2014-06-28 22:33:00 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	58ccb27792  
						 
						
							
							
								
								
								There is no more node_isolate.  
							
							 
							
							
							
						 
						
							2014-06-28 19:49:55 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	e0e1d45859  
						 
						
							
							
								
								
								Rename string16 to base::string16.  
							
							 
							
							
							
						 
						
							2014-06-28 19:49:22 +08:00