Shelley Vohr
ee2c3607ad
fix patch output filename ( #12742 )
2018-04-27 21:43:04 -04:00
Shelley Vohr
21e5a2e071
Add clang-format script and precommit hook ( #12651 )
...
* add second arg to hook
* fix clang-format script
* remove format script
* help
* first pass at only checking formatting for changed files
* ensure clang-format only runs against changes
* add quiet option for print output
* fix script outputs for clang-format
* wrap conditional for exit error
* remove cpplint include ordering from brightray
* fix python style errors
* add clang-format to linting
* fix var error and add mm extension
* fix diff checking for commit hook
* show incorrectly formatted lines when linting fails
* don't try to check formatting for deleted files
2018-04-27 13:01:12 -04:00
Zeke Sikelianos
cc98bd6b6d
Merge pull request #12662 from electron/prevent-default
...
Stop overwriting prevent_default if default wasn't prevented
2018-04-26 12:12:18 -07:00
Jeremy Apthorp
dd7e0f80fe
Turn off visual zoom by default ( #12679 )
2018-04-26 10:27:35 -05:00
Jeremy Apthorp
1a64b9f0c2
Disable navigating on drag/drop ( #12655 )
...
* Disable navigating on drag/drop
* Add a WebPreferences option to re-enable navigate on drag/drop
2018-04-26 10:23:27 -05:00
bughit
4fcd178c36
expose WebFrame#routingId ( #12614 )
...
* expose WebFrame#routingId and pass it to WebContents frame specific events along with frameProcessId; add WebContets.did-start-navigation event
* fix compilation error on ia32 Windows
2018-04-26 19:17:55 +09:00
Cheng Zhao
152422af81
Merge pull request #12696 from electron/mac-use-widget
...
Refactor NativeWindow (Part 9): Use views::Widget on macOS
2018-04-26 15:49:49 +09:00
Cheng Zhao
cf70267871
remove unnecessary overrides
2018-04-26 09:48:12 +09:00
Cheng Zhao
5e48dd9d45
be aware of views::Widget's layer
2018-04-25 15:10:29 +09:00
Cheng Zhao
39242c978f
fix failed BrowserWindow tests
2018-04-25 15:10:29 +09:00
Cheng Zhao
75a624434c
refactor: use views::Widget on macOS
2018-04-25 15:10:29 +09:00
Shelley Vohr
7c4964fae6
revert to more graceful template structure check ( #12699 )
2018-04-24 11:21:26 -04:00
Tatsuya Hiroishi
9c65abd746
handle remote exception ( #12694 )
...
* add cause property to exception in callFunction
* update exceptionToMeta function
* add sender argument
* and cause property to return value
* update exception convert in metaToValue function
* add from and cause properties to the exception error
* unit test for remote exception
2018-04-24 08:40:19 -04:00
Nitish Sakhawalkar
2579071b98
Deprecate did-get-response-details and did-get-redirect-request ( #12615 )
...
* Deprecate webContents events did-get-response-details and did-get-redirect-request.
* Update guest view files
* Update webview tag docs and update specs
* Update deprecate.event function
* Update comment
* Update more
* Update documentation for other deprecated event
2018-04-23 14:46:12 -05:00
Leo MG Nesfield (LMGN)
975964f9f0
Not required. ( #12682 )
...
VS Code automatically executes from the `windows` object on win32.
2018-04-23 11:13:46 -05:00
James Wheare
bf2b4814e0
[docs] app.isDefaultProtocolClient is available on Linux now ( #12674 )
2018-04-23 01:16:43 +10:00
Shelley Vohr
12a57ff1c2
clang-format objc files ( #12673 )
2018-04-20 11:47:04 -07:00
Paul Frazee
94236bf4eb
Create automated-testing-with-a-custom-driver.md ( #12446 )
...
* Create automated-testing-with-a-custom-driver.md
* Update automated-testing-with-a-custom-driver.md
* Add 'Automated Testing with Custom Driver' to ToC
* Update automated-testing-with-a-custom-driver.md
2018-04-20 12:39:13 -04:00
Shelley Vohr
f9ee24f8f0
Merge pull request #12627 from vijaypushkin/patch-1
...
Corrected the name of Capitalization Styles
2018-04-20 09:49:28 -04:00
Cheng Zhao
28b85762fd
Merge pull request #12660 from electron/mac-views
...
Refactor NativeWindow (Part 8): Prepare work for using views::Widget on macOS
2018-04-20 21:31:28 +09:00
Robo
ff571f3b5d
Part I: Move from base::Bind to base::BindOnce and remove unneeded base::Passed ( #12661 )
2018-04-20 19:55:05 +09:00
Cheng Zhao
aa5c80f8a6
Fix new clang warnings
2018-04-20 19:26:20 +09:00
Cheng Zhao
c44279bb10
Move AtomNSWindow to a new file
2018-04-20 19:26:20 +09:00
Cheng Zhao
569967ac21
Move QLPreviewPanelDataSource to AtomNSWindowDelegate
2018-04-20 19:17:08 +09:00
Cheng Zhao
f6a7e5ea23
Move NSTouchBarDelegate to AtomNSWindowDelegate
2018-04-20 19:15:45 +09:00
Cheng Zhao
8e9667d86c
Manage AtomTouchBar in NativeWindow instead of AtomNSWindow
2018-04-20 19:15:01 +09:00
Cheng Zhao
ce54fd334d
Move AtomNSWindowDelegate to a new file
2018-04-20 19:12:17 +09:00
Cheng Zhao
1c6c75da4f
Merge the logic of managing ViewsDelegate
2018-04-20 19:10:37 +09:00
Cheng Zhao
9bc79f840e
mac: Override NativeWidgetMac
2018-04-20 19:10:37 +09:00
Cheng Zhao
37a7df49d6
mac: Provide ViewsDelegate
2018-04-20 19:10:37 +09:00
Alexey Kuzmin
fcc82ebd35
Add "app.whenReady()" ( #12652 )
...
* Make "chai-as-promised" avaialble in tests
* Add "app.whenReady()"
Closes #9561 .
2018-04-20 17:09:23 +10:00
Shelley Vohr
c7a0b419a9
Merge pull request #12669 from electron/MarshallOfSound-patch-1
...
Add last known working electron version
2018-04-20 00:25:36 -04:00
Samuel Attard
032b7c68d8
Add last known working electron version
2018-04-20 14:23:01 +10:00
Cheng Zhao
55e2dbdbc8
Merge pull request #12647 from nornagon/chromium-style
...
Fix a bunch of chromium-style errors
2018-04-20 08:15:51 +09:00
deepak1556
6d0ac6593c
[chromium-style] Complex class/struct needs an explicit out-of-line copy constructor.
2018-04-19 11:12:58 -07:00
deepak1556
30f1d0991b
enable chromium style checker plugin for electron and brightray targets
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
7c5fcecbec
Build mac code with -Wunguarded-availability -Wobjc-missing-property-sythesis
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
eb7ccf8afa
Bring mac code into conformance with -Wobjc-missing-property-synthesis
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f3c00e96aa
Bring mac code into conformance with -Wunguarded-availability
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
27cee90e5e
[chromium-style] move methods out of headers
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f1587da480
[chromium-style] out-of-line default constructors and destructors
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
6c26bb1cf8
[chromium-style] destructors of ref-counted objects should be private
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
e6695cf2ec
[chromium-style] override / virtual warnings
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Shelley Vohr
667c43398c
Merge pull request #12650 from electron/clang-format-chromium-src
...
clang-format chromium_src
2018-04-19 08:37:02 -04:00
Birunthan Mohanathas
cd407d1c3f
Stop overwriting prevent_default if default wasn't prevented
...
This didn't actually cause any issues because there is only one listener
for the affected methods right now. Should we have added more, the last
called observer would have overwritten `prevent_default`. Lets only set
it when necessary to avoid this footgun in the future.
2018-04-19 12:45:21 +02:00
Cheng Zhao
6c9f3066fd
Merge pull request #12637 from electron/expose-toplevel-window
...
Refactor NativeWindow (Part 7): Expose TopLevelWindow in JavaScript
2018-04-19 14:52:04 +09:00
Cheng Zhao
7473b612c5
Make Menu API accept TopLevelWindow
2018-04-19 13:08:37 +09:00
Cheng Zhao
1340b17424
Do not return TopLevelWindow in BrowserWindow.getAllWindows
2018-04-19 13:08:37 +09:00
Cheng Zhao
e38f511737
Make BrowserWindow inheirt TopLevelWindow in JS
2018-04-19 13:08:37 +09:00