Haojian Wu
ee1f3acf7b
Don't use anonymous namespace in header file.
...
Anonymous namespace should be forbidden in header files even for the
forward declarations:
* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.
Consider the following "foo.h":
```cpp
namespace { class Foo; }
class Bar {
public:
Foo* getFoo();
Foo* foo;
}
```
If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
2017-04-01 08:57:34 +02:00
Kevin Sawicki
21956071e6
Fix compilation issue
2017-03-24 09:52:37 -07:00
Kevin Sawicki
2ece711c2e
Format line length to 80 instead of 100
2017-03-23 15:47:30 -07:00
Kevin Sawicki
be0c0e278a
Remove cpplint errors
2017-03-23 12:48:27 -07:00
Cheng Zhao
a749a3dd2a
Fix Debug building on Windows
2017-01-26 16:09:45 +09:00
Cheng Zhao
03e2250638
Fix building under linux
2016-08-04 16:40:13 +09:00
Cheng Zhao
1a80cb22b7
Show label for offscreen webview
2016-08-04 16:35:09 +09:00
Kevin Sawicki
22b3b69e17
Return focus state of window web view when available
2016-07-12 14:03:08 -07:00
Cheng Zhao
851ef398fb
Adapt to changes of Chrome 51 API changes
2016-05-23 10:59:07 +09:00
deepak1556
a01f8ba739
notify devtools opened and closed once per lifetime
2016-05-12 19:16:13 +05:30
Cheng Zhao
c205ab0944
Fix tooltip can not show outside window
2015-10-04 22:15:01 +08:00
Cheng Zhao
c30f458d4f
Add IsDevToolsViewFocused method
2015-09-15 11:04:46 +08:00
Cheng Zhao
90125c44e3
Fix API changes on Linux
2015-09-02 17:29:30 +08:00
Robo
1f65b47e8e
allow updating devtools title in undocked mode
2015-08-07 14:30:49 +05:30
Cheng Zhao
3826e8864a
Fix a compiler warning
2015-07-01 06:50:07 +00:00
Cheng Zhao
f9dc87ba97
Add InspectableWebContentsViewDelegate
2015-06-25 12:29:34 +08:00
Cheng Zhao
d1e70e7826
Add InspectableWebContents::GetDevToolsWebContents
2015-06-05 14:33:37 +08:00
Cheng Zhao
95d28c398e
Update cpplint
2015-06-05 12:07:27 +08:00
Cheng Zhao
4e14c8634b
Fix building on Windows
2015-03-18 12:55:02 +08:00
Cheng Zhao
167995119a
Use current exe's icon as default window icon.
...
Fixes atom/atom-shell#863 .
2015-01-15 15:30:04 -08:00
Cheng Zhao
ff0afc688d
Fix devtools window can not minimize
...
Closes atom/atom-shell#941 .
2015-01-04 22:32:49 -08:00
Cheng Zhao
06eff5cd8c
linux: Add a way to set WM_CLASS for devtools window
2014-11-24 16:03:55 +08:00
Cheng Zhao
601ee75bcf
linux: Use native window frame for devtools
...
Fixes atom/atom-shell#646 .
2014-11-06 19:08:41 +08:00
Cheng Zhao
c4aebe3ba1
No need to write "virtual" when we have "override"
2014-11-06 19:08:41 +08:00
Frank Hale
513d84cd3e
Make devtools window maximizable
2014-11-03 11:10:14 -05:00
Cheng Zhao
f809fef22d
OVERRIDE => override
2014-10-23 11:10:39 +08:00
Cheng Zhao
a6627a7286
Add a method in InspectableWebContentDelegate to set icon for devtools window.
2014-09-09 15:29:35 +08:00
Cheng Zhao
f013a98920
views: Use new devtools resizing strategy.
2014-09-01 20:09:08 +08:00
Cheng Zhao
dca1c51b32
Fix API changes of Chrome37.
2014-08-31 18:43:01 +08:00
Cheng Zhao
760f7ed24f
Fix "warning: field 'widget_' is uninitialized when used here".
2014-08-09 09:34:06 +08:00
Cheng Zhao
9821cd1f58
web_contents_view.h has been hidden from user.
2014-07-27 11:27:04 +00:00
Cheng Zhao
a318b1c5d1
views: Use DesktopNativeWidgetAura for menu view.
2014-07-14 15:56:04 +08:00
Cheng Zhao
9d4e977c01
win: Fix window frame on detached window.
2014-07-12 21:26:29 +08:00
Cheng Zhao
0f5b427648
Always shows window frame except for maximized window on Unity.
2014-07-12 11:45:24 +08:00
Cheng Zhao
a080d2c5bb
Remove GetNativeView() when compiled with views toolkit.
2014-07-11 23:32:00 +08:00
Cheng Zhao
4b57e1f4f8
Warn about using GetNativeView() in views.
2014-07-11 23:14:20 +08:00
Cheng Zhao
a5bb24284e
views: Follow WidgetDelegateView's convention on deleting self.
...
It could avoid invoking WidgetDelegate's methods when the delegate has been
deleted as a view.
2014-07-09 11:08:17 +08:00
Cheng Zhao
7a196933bb
views: Don't leak ViewsDelegate.
2014-07-09 10:26:01 +08:00
Cheng Zhao
651ebdde65
views: Remember bounds of devtools window.
2014-07-09 10:26:01 +08:00
Cheng Zhao
4fb4b2d7ba
views: Implement undocked devtools.
2014-07-09 10:26:01 +08:00
Cheng Zhao
e574bf6d0f
views: Initial docked devtools implementation.
2014-07-09 10:26:01 +08:00
Cheng Zhao
4048d491f0
views: Use chromium's custom frame view.
2014-07-09 10:26:01 +08:00
Cheng Zhao
bad7b95ed7
Add ViewsDelegate, required when using views::Widget on aura.
2014-07-09 10:26:01 +08:00
