trop[bot]
ecc00f149f
fix: prevent gc monitor 2nd pass crash ( #47165 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: reito <cnschwarzer@qq.com>
2025-05-20 11:55:54 -05:00
electron-roller[bot]
791235b15b
chore: bump node to v22.15.1 (37-x-y) ( #47104 )
...
* chore: bump node in DEPS to v22.15.1
* chore: fixup patch indices
* src: fix error handling on async crypto operations
https://github.com/nodejs-private/node-private/pull/709
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-20 13:32:53 +02:00
trop[bot]
692d648edb
refactor: NativeWindows should prefer widget() over GetWidget() for internal use ( #47155 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-19 18:52:14 -05:00
trop[bot]
bbb6aabe41
fix: explicit microtask scope DCHECK condition ( #47140 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
2025-05-19 21:01:05 +02:00
trop[bot]
cc302c2f07
perf: don't create unused menuitem icons ( #47129 )
...
GTK >= 3.90.0 removed support for menuitem icons. When Electron is
built with GTK >= 3.90.0, our code builds these icons and then throws
them away unused. Instead, let's just not build them.
Our gtk_util::GdkPixbufFromSkBitmap utility uses BGRAToRGBA and is
expensive to call.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-16 08:47:16 -05:00
trop[bot]
b6779056f2
test: fix desktopCapturer mocha syntax ( #47113 )
...
do not nest `it` calls in desktopCapturer specs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-16 02:32:22 -05:00
trop[bot]
d7990ca180
refactor: decouple NativeWindowViews and GlobalMenuBarX11 ( #47119 )
...
The GlobalMenuBar used to hold a raw_ptr reference to its NativeWindow;
but since it doesn't use it & only wants the gfx::AcceleratedWidget info,
let's remove the NativeWindowViews reference.
AFAICT, GlobalMenuBarX11::window_ has never been used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-15 19:39:05 -05:00
trop[bot]
7cb5a46b66
refactor: make TrackableObject::weak_map_id() constexpr ( #47115 )
...
* refactor: make TrackableObject::weak_map_id() constexpr
refactor: make BaseWindow::GetID() inline and constexpr
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make NativeWindow::window_id() constexpr too
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-15 19:38:34 -05:00
trop[bot]
917e95433a
docs: add note on DIP and DPI ( #47121 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2025-05-15 17:16:33 -05:00
trop[bot]
7db9671420
chore: bump chromium to 138.0.7178.0 (37-x-y) ( #47106 )
...
* chore: bump chromium in DEPS to 138.0.7178.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6351556: [source-phase-imports] Support Wasm Source Phase Imports
Refs 63515566509682
2025-05-15 16:47:39 -04:00
trop[bot]
a3d19d7a99
fix: opening package paths as directory on macOS ( #47108 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-05-15 16:11:05 -04:00
trop[bot]
f1562543a3
feat: add support for --experimental-network-inspection ( #47031 )
...
* feat: add support for `--experimental-network-inspection`
Co-authored-by: Aman Karmani <aman@tmm1.net>
* docs: fix minor formatting issues
visible on both GH[1] and the docs site[2]
[1] https://github.com/electron/electron/blob/main/docs/api/command-line-switches.md#nodejs-flags
[2] https://www.electronjs.org/docs/latest/api/command-line-switches#--inspect-brkhostport
Co-authored-by: Aman Karmani <aman@tmm1.net>
* docs: add entry for new nodejs flag
Co-authored-by: Aman Karmani <aman@tmm1.net>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Aman Karmani <aman@tmm1.net>
2025-05-14 16:03:02 -05:00
trop[bot]
bf54b8d709
feat: enable innerWidth and innerHeight for window open ( #47039 )
...
feat: enable innerWidth and innerHeight for window open (#46749 )
* feat: enable innerWidth and innerHeight for window open
* update comment for added special innerWidth and innerHeight
* update 100 min spec requirement handling
* update testing to include getContentSize
* update macOS min requirement handling
* adjust refactored consts
* update const values from nativewindowviews
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
2025-05-14 16:02:46 -05:00
trop[bot]
ec83c1303c
feat: enable secondary label for macOS menu ( #47042 )
...
* feat: enable secondary label for macOS menu
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
* Update shell/browser/ui/cocoa/electron_menu_controller.mm
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
* fix for lint
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
* update docs for sublabel
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
2025-05-14 16:02:32 -05:00
trop[bot]
ec1b0f4923
refactor: remove CreateViewForWidget patch ( #47084 )
...
* refactor: remove CreateViewForWidget patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: rm unintended osr change
Co-authored-by: deepak1556 <hop2deep@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-05-14 16:01:44 -05:00
trop[bot]
be5b02386d
chore: bump chromium to 138.0.7177.0 (37-x-y) ( #47085 )
...
* chore: bump chromium in DEPS to 138.0.7177.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6530423: [WebContents] Fix IsNeverComposited() calls during initialization
Refs 65304236512551
2025-05-14 13:55:23 -04:00
trop[bot]
df8ed0acc3
refactor: use kKeyModifiers in IsAltModifier() ( #47089 )
...
We probably didn't use this before because IsAltModifier() was written
two years before the KeyModifiers mask was added upstream in 98ec378a.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-14 12:53:59 -05:00
trop[bot]
8de0bb5bc3
chore: bump chromium to 138.0.7175.0 (37-x-y) ( #47078 )
...
* chore: bump chromium in DEPS to 138.0.7166.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 138.0.7166.2
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
650837364709246502977649368864887556428707651412165141216531585651225364287076508373
2025-05-14 10:07:45 -04:00
trop[bot]
25c7f0017a
fix: white window flicker on window creation ( #47051 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-11 15:00:11 -05:00
trop[bot]
546d9f4ba6
fix: webview crash on focus ( #47036 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-09 17:46:53 -05:00
trop[bot]
434f77e6c1
docs: unify [!NOTE] structure ( #47048 )
...
* docs: unify [!NOTE] structure
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
* Update docs/api/command-line.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update docs/api/browser-window.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update docs/api/download-item.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update docs/api/global-shortcut.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* revert line break
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2025-05-09 17:46:11 -05:00
trop[bot]
ace7ef4316
fix: restore previous Windows screenshotting ( #47033 )
...
Fixes https://github.com/electron/electron/issues/45990
We previously made a change in https://github.com/electron/electron/pull/45868
to fix content protection being lost on hide and re-show. However, this
cause a breaking change where protected windows were made opaque black
instead of being hidden as before. This overrides relevant methods in
ElectronDesktopWindowTreeHostWin to restore the previous behavior.
without regressing the original issue.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-09 13:10:44 -04:00
trop[bot]
0e9c0d8c04
fix: use-after-move of bus connection in xdg portal detection ( #47023 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-05-09 09:39:17 -05:00
trop[bot]
8f37d42241
build: move release script to new hasher function ( #46993 )
...
build: move to new hasher function
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
2025-05-09 09:38:19 +02:00
trop[bot]
3d836267ed
refactor: use gin_helper::Dictionary::ValueOrDefault() ( #47014 )
...
refactor: use `gin_helper::Dictionary::ValueOrDefault()` (#46982 )
* refactor: use ValueOrDefault() in electron_api_web_contents.cc
* refactor: use ValueOrDefault() in electron_api_url_loader.cc
* refactor: use ValueOrDefault() in electron_download_manager_delegate.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in electron_url_loader_factory.cc
* refactor: use ValueOrDefault() in electron_browser_context.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in blink_converter.cc
* feat: add ValueOrDefault() to PersistentDictionary
* empty commit
* refactor: use ValueOrDefault() in blink_converter.cc
* refactor: inline the rectangle base::Value::Dict
* refactor: remove has_scroll temporary
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-09 09:36:47 +02:00
trop[bot]
440cdec061
build: update hasher return value ( #47011 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2025-05-09 09:36:35 +02:00
trop[bot]
4eea6e4974
build: remove deps_add_v8_object_setinternalfieldfornodecore.patch ( #46998 )
...
chore: remove deps_add_v8_object_setinternalfieldfornodecore.patch
This was a Node 20-specific workaround that's no longer needed in Node 22.
Xref: https://github.com/nodejs/node/pull/49874 .
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-08 15:34:41 -05:00
trop[bot]
2c6f713d72
refactor: reduce use of NativeWidgetPrivate ( #47006 )
...
* refactor: do not use native_widget_private() in NativeWindowViews::SetContentProtection()
refactor: do not use native_widget_private() in NativeWindowViews::IsContentProtected()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: do not use native_widget_private() in NativeWindowViews::Show()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove native_widget_private #include from native_window_views_win
Not needed since Feb 2025: 9199d5c6
2025-05-08 15:33:43 -05:00
trop[bot]
057437f739
test: enable hasShadow tests on Linux ( #47001 )
...
refactor: enable hasShadow tests on Linux
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-08 09:37:26 -05:00
trop[bot]
b59a7ef2c3
refactor: Node.js temporary "explicit" microtask policy scope pattern ( #46991 )
...
refactor: Node.js explicit microtask scope pattern
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
2025-05-08 01:06:31 -05:00
trop[bot]
069c9a9e1f
chore: bump chromium to 138.0.7165.0 (37-x-y) ( #46985 )
...
* chore: bump chromium in DEPS to 138.0.7165.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6492127: Add new less invasive context menu mode for mobile interesttarget
6492127
2025-05-07 20:01:39 -05:00
trop[bot]
5602efb2b6
fix: printing when no mediaSize specified ( #46971 )
...
fix: printing when no mediaSize specified
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-07 09:36:17 +02:00
trop[bot]
839590eb90
chore: bump chromium to 138.0.7164.0 (37-x-y) ( #46964 )
...
* chore: bump chromium in DEPS to 138.0.7164.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6508870: Add missing PermissionType mapping and remove default case.
6508870
2025-05-07 09:35:56 +02:00
trop[bot]
c9d1615b19
refactor: add gin_helper::Dictionary::ValueOrDefault() ( #46969 )
...
* feat: add gin_helper::Dictionary::ValueOrDefault()
A convenience function for using a default value if the
specified key isn't present in the dictionary.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use ValueOrDefault() in native_window.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use ValueOrDefault() in native_window_mac.mm
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use ValueOrDefault() in native_window_views.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use ValueOrDefault() in electron_api_native_image.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-06 19:11:30 -05:00
trop[bot]
4597f4ba9e
refactor: pass gfx::ResizeEdge by value ( #46960 )
...
refactor: pass gfx::ResizeEdge by value
It is an enum class, so no reason to pass by reference
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-06 16:08:57 -05:00
trop[bot]
2cf774b2b8
test: test menu rendering accelerators ( #46965 )
...
* test: test menu rendering accelerators
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update spec/api-menu-spec.ts
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-06 15:56:36 -05:00
trop[bot]
3029cdb4dd
fix: crash on macOS dialog after window-all-closed ( #46952 )
...
fix: crash on dialog after window-all-closed
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-06 17:29:14 +02:00
trop[bot]
6bd6180703
fix: allowed dialog file types with one filter ( #46946 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-06 16:10:25 +02:00
electron-roller[bot]
cd023b54f5
chore: bump node to v22.15.0 (37-x-y) ( #46869 )
...
* chore: bump node in DEPS to v22.15.0
* inspector: fix GN build
https://github.com/nodejs/node/pull/56798
* test: search cctest files
https://github.com/nodejs/node/pull/56791
* crypto: fix missing OPENSSL_NO_ENGINE guard
https://github.com/nodejs/node/pull/57012
* test,crypto: make tests work for BoringSSL
https://github.com/nodejs/node/pull/57021
* module: use synchronous hooks for preparsing in import(cjs)
https://github.com/nodejs/node/pull/55698
* deps: update simdjson to 3.12.0
https://github.com/nodejs/node/pull/56874
* build: remove explicit linker call to libm on macOS
https://github.com/nodejs/node/pull/56901
* test: make eval snapshot comparison more flexible
https://github.com/nodejs/node/pull/57020
* src: allow embedder customization of OOMErrorHandler
https://github.com/nodejs/node/pull/57325
* src: do not pass nullptr to std::string ctor
https://github.com/nodejs/node/pull/57354
* src: lock the isolate properly in IsolateData destructor
https://github.com/nodejs/node/pull/57031
* chore: shrink --trace-atomics-wait patch
* chore: fixup patch indices
* build: fix GN build failure
https://github.com/nodejs/node/pull/57013
* crypto: expose security levels
https://github.com/nodejs/node/pull/56601
* zlib: add zstd support
https://github.com/nodejs/node/pull/52100
* test: move crypto related common utilities in common/crypto
https://github.com/nodejs/node/pull/56714
* cli: move --trace-atomics-wait to eol
https://github.com/nodejs/node/pull/52747
* test: disable test-https-client-renegotiation-limit
BoringSSL doesn't support caller-initiated renegotiation - see
https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-06 10:29:19 +02:00
Charles Kerr
7dfa2b92fb
refactor: remove some NativeWindow public API (37-x-y) ( #46934 )
...
refactor: remove some `NativeWindow` public API (#46919 )
* refactor: make NativeWindow::titlebar_overlay_height_ private
* refactor: make NativeWindow::set_has_frame() protected
* refactor: remove NativeWindow::background_material()
It's only used once, in NativeWindow, so use |background_material_| directly.
* refactor: remove NativeWindow::vibrancy()
It's only used once, in a NativeWindow method, so use |vibrancy_| directly.
* refactor: unfriend api::BrowserView
It was added in Oct 2022 by 23d4a25184ac2b
2025-05-06 09:51:08 +02:00
trop[bot]
8189b01987
docs: use correct heading level for API function ( #46941 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2025-05-05 16:28:15 -05:00
trop[bot]
0c683552ec
chore: bump chromium to 138.0.7160.0 (37-x-y) ( #46938 )
...
* chore: bump chromium in DEPS to 138.0.7158.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 138.0.7160.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6509206: Move Keychain UI suppression code into apple_keychain.cc
650920664890366506662649981164879266494942
2025-05-05 16:05:40 -05:00
trop[bot]
018e2f6a31
refactor: devirtualize NativeWindow methods ( #46931 )
...
* refactor: devirtualize NativeWindow::SetSize()
refactor: devirtualize NativeWindow::GetSize()
refactor: devirtualize NativeWindow::SetPosition()
refactor: devirtualize NativeWindow::GetPosition()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: devirtualize NativeWinodw::SetMinimumSize()
refactor: devirtualize NativeWinodw::GetMinimumSize()
refactor: devirtualize NativeWinodw::SetMaximumSize()
refactor: devirtualize NativeWinodw::GetMaximumSize()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: devirtualize NativeWindow::SetSheetOffset()
refactor: devirtualize NativeWindow::GetSheetOffsetX()
refactor: devirtualize NativeWindow::GetSheetOffsetY()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: devirtualize NativeWindow::GetContentMinimumSize()
refactor: devirtualize NativeWindow::GetContentMaximumSize()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-05 20:39:50 +02:00
trop[bot]
3c8d971c53
refactor: simplify NativeWindow::FullScreenTransitionState ( #46929 )
...
* refactor: make NativeWindow::fullscreen_transition_state_ private
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: add NativeWindow::is_transitioning_fullscreen() helper
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unused NativeWindow::fullscreen_transition_state()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: replace NativeWindow::set_fullscreen_transition_state() with NativeWindow::set_is_transitioning_fullscreen()
refactor: remove unused NativeWindow::FullScreenTransitionState
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-05 13:26:41 -04:00
trop[bot]
258762929f
refactor: add NativeWindow::FromWidget() helper ( #46928 )
...
refactor: add NativeWindow::FromWidet() helper
refactor: make kElectronNativeWindowKey a protected field
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-05 13:02:47 -04:00
trop[bot]
01994637e8
fix: xdg portal version detection for file dialogs on linux ( #46922 )
...
* chore: use dbus thread for portal version detection
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Update shell/browser/ui/file_dialog_linux_portal.cc
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-05 20:59:34 +09:00
trop[bot]
0810fe54d4
chore: bump chromium to 138.0.7156.0 (37-x-y) ( #46913 )
...
* chore: bump chromium in DEPS to 138.0.7156.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: ICWYU
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Allow SecKeychain and SecItem implementations of AppleKeychain to coexist
6444777
2025-05-02 22:46:54 -05:00
trop[bot]
d783f134d9
feat: support dip <-> screen conversion on Linux X11 ( #46895 )
...
feat: support dip <-> screen conversion on Linux
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-02 19:08:50 -05:00
trop[bot]
bf94f88569
refactor: move IsClosed() and IsClosable() tests into NativeWindow::Close() ( #46907 )
...
refactor: devirtualize NativeWindow::IsClosed()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-02 19:08:28 -05:00
trop[bot]
47e25dfd57
fix: prevent log files being written to current directory on Windows ( #46910 )
...
* fix: prevent log files being written to current directory on Windows
Co-authored-by: Derek Cicerone <derekcicerone@gmail.com>
* Update shell/common/logging.cc
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Derek Cicerone <120135886+derekcicerone@users.noreply.github.com>
* chore: add test
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update includes
Refs 6418805
2025-05-02 19:08:00 -05:00
