Samuel Attard
ad54d38678
fix: use effectiveAppearance to check dark mode on mojave and above ( #18666 )
...
* fix: use effectiveAppearance to check dark mode on mojave and above
* chore: add forward declarations for dark appearance
2019-06-07 12:01:04 -07:00
Electron Bot
164cc43440
chore: bump chromium to bd6aad6a4b37dad7aae42fec349e9 (master) ( #18626 )
...
* chore: bump chromium in DEPS to f200986dfaabd6aad6a4b37dad7aae42fec349e9
* chore: BridgedNativeWidgetImpl was renamed to NativeWidgetMacNSWindowHost
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1640804
* refactor: remove MainMenu.xib as Chromium has removed its dependency on xcode and therefore all xibs
As we set default menus in JS land the default native menu is tiny, just
has a Quit button
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1627242
* chore: update zip manifests
2019-06-04 17:27:07 -07:00
Shelley Vohr
3d8db573d9
fix: reverse dialog cancel bool for openDialog ( #18492 )
2019-05-29 12:37:58 -07:00
Electron Bot
96b32a814c
chore: bump chromium to 964c4bca8de5c320534d95606c861 (master) ( #18440 )
...
* chore: bump chromium in DEPS to 2930eb12d56988c2c80bad2797ab036fe493d4e1
* chore: update patches
* Revert "disable robotjs-based tests"
This reverts commit e56adafc1f
.
* Revert "skip dbus tests (#18409 )"
This reverts commit aea042cc83
.
* Revert "skip more dbus tests"
This reverts commit 68dbef48da
.
* chore: bump chromium in DEPS to fd62da5601399b92effaa32a943fcd96143c8605
* chore: bump chromium in DEPS to 99f87ca22ee6e7ec953defe694771cb68f47a596
* chore: bump chromium in DEPS to d88778435b4cd9a510a63385b6d4ba24674b9774
* chore: update patches
* chore: update ssl_security_state_tab_helper.patch
* Remove content_packaged_services
https://chromium-review.googlesource.com/c/chromium/src/+/1604203
* chore: fix false positive lint error
* views: wireup widget name to crash data
https://chromium-review.googlesource.com/c/chromium/src/+/1626640
* chore: bump chromium in DEPS to ab588d36191964c4bca8de5c320534d95606c861
* roll patches
2019-05-28 13:18:10 -07:00
Jeremy Apthorp
2fcb785d3e
Replace views_bridge_mac with remote_cocoa
...
https://chromium-review.googlesource.com/c/chromium/src/+/1623573
2019-05-22 12:56:21 -07:00
Jeremy Apthorp
ca283c74c9
Merge remote-tracking branch 'origin/master' into roller/chromium-ad1b791122c04bd91b825fbfbdf1ff4da82a0edb-1558011686736
2019-05-21 10:07:17 -07:00
Shelley Vohr
e39c76bfe1
fix: reverse saveDialog cancellation bool ( #18366 )
2019-05-21 10:51:59 -05:00
Nitish Sakhawalkar
cf5224140b
Chrome changed the devtools url
...
chrome-devtools:// to devtools://
28b21a67f0
2019-05-17 16:16:25 -07:00
Nitish Sakhawalkar
aa00b19c92
Update views visible API
...
visible() -> GetVisible() as per c9ecec130e
2019-05-17 16:16:25 -07:00
Nitish Sakhawalkar
2d14a0e90d
Update changed APIs/deps
...
Use brotli by default (36d58dd325
)
Update Mac ui headers (897636c9f8
)
Update AtomBrowserClient::HandleExternalProtocol API (cb656e1fd1
)
2019-05-16 18:47:42 -07:00
Nitish Sakhawalkar
03ee12d13e
Update linux/win menu_bar.h
...
Chromium Commit 6a2f2686a9
2019-05-16 18:47:42 -07:00
Milan Burda
3a5e6f2551
feat: allow setting working directory in app.setUserTasks() / app.setJumpList() ( #18148 )
2019-05-13 19:17:12 +03:00
Shelley Vohr
0ab3d7a0be
fix: crash on systemPreferences.getAccentColor() ( #18144 )
2019-05-07 08:26:34 -07:00
Milan Burda
91e3421525
refactor: use base::size() for array sizes ( #18155 )
2019-05-07 09:19:14 -04:00
Shelley Vohr
0755857a0c
chore: convert more files away from base::Bind ( #18121 )
...
* chore: convert more files away from base::Bind
* use BindOnce for JsAsker
2019-05-03 12:08:41 -07:00
Milan Burda
c25c31e018
refactor: convert C++ enums to C++11 enum classes ( #18087 )
2019-05-03 14:11:41 -04:00
Shelley Vohr
55a7f92297
chore: convert more module and helper files from bind ( #18069 )
2019-05-02 08:32:33 -07:00
Milan Burda
9585818a90
chore: add clang-format and limited linting for Objective-C sources ( #18104 )
2019-05-02 21:05:37 +09:00
Shelley Vohr
f316c8470c
chore: convert session base::Bind instances ( #18038 )
...
Convert instances of base::Bind to base::BindOnce and base::BindRepeating as applicable in the session module as well as in Autofill popups.
2019-05-01 13:45:08 -07:00
Milan Burda
1abe658ef4
chore: clang-format ( #18088 )
...
* chore: clang-format
* chore: remove obsolete native_mate_files.gypi
2019-05-01 12:27:55 -07:00
Electron Bot
2616911f7a
chore: bump chromium to 7dff37844cb3 (master) ( #18059 )
2019-04-30 17:18:22 -07:00
Electron Bot
716cb28430
chore: bump chromium to 1e9f9a24aa12 (master) ( #17880 )
...
* chore: bump chromium in DEPS to 1e9f9a24aa12bea9cf194a82a7e249bd1242ec4f
* chore: update patches
* Make WebContents' theme color a base::Optional<SkColor>
https://chromium-review.googlesource.com/c/chromium/src/+/1540022
* update autofill patch for incorrect header includes
* Move Shell messages to web_test and rename to BlinkTest.
https://chromium-review.googlesource.com/c/chromium/src/+/1525181
* Make PlatformNotificationServiceImpl a KeyedService.
https://chromium-review.googlesource.com/c/chromium/src/+/1336150
* Move MediaPlayerId to its own file.
https://chromium-review.googlesource.com/c/chromium/src/+/1547057
* Remove net/base/completion_callback.h, which is no longer used
https://chromium-review.googlesource.com/c/chromium/src/+/1552821
* AW NS: support file scheme cookies
https://chromium-review.googlesource.com/c/chromium/src/+/1533486
* Remove SecurityInfo and adapt remaining consumers
https://chromium-review.googlesource.com/c/chromium/src/+/1509455
* Remove deprecated type-specific number to string conversion functions
https://chromium-review.googlesource.com/c/chromium/src/+/1545881
* DevTools: Adding new performance histograms for launch of top 4 tools
https://chromium-review.googlesource.com/c/chromium/src/+/1506388
* Update include paths for //base/hash/hash.h
https://chromium-review.googlesource.com/c/chromium/src/+/1544630
* build: Disable ensure_gn_version gclient hook for mac CI checkout
* update patches
* use maybe version of v8::String::NewFromTwoByte
* bump appveyor image version
* fix mac ci hopefully
* Convert enum to enum class for MenuAnchorPosition
https://chromium-review.googlesource.com/c/chromium/src/+/1530508
* use maybe version of ToObject
* RenderViewHost::GetProcess is no longer const
* Unrefcount AuthChallengeInfo
https://chromium-review.googlesource.com/c/chromium/src/+/1550631
* MenuButtonController takes Button rather than MenuButton
https://chromium-review.googlesource.com/c/chromium/src/+/1500935
* add //ui/views_bridge_mac to deps to fix link error
* forward declare views::Button in atom::MenuDelegate
* more v8 patches
* base/{=> hash}/md5.h
https://chromium-review.googlesource.com/c/chromium/src/+/1535124
* gfx::{PlatformFontWin => win}::*
https://chromium-review.googlesource.com/c/chromium/src/+/1534178
* fix v8 patches
* [base] Rename TaskScheduler to ThreadPool
https://chromium-review.googlesource.com/c/chromium/src/+/1561552
* use internal_config_base for bytecode_builtins_list_generator
avoids windows link errors
* FIXME: temporarily disable v8/breakpad integration
* FIXME: temporarily disable prevent-will-redirect test
* FIXME: disable neon on aarch64 pending crbug.com/953815
* update to account for WebCursor refactor
https://chromium-review.googlesource.com/c/chromium/src/+/1562755
* enable stack dumping on appveyor
* Revert "FIXME: disable neon on aarch64 pending crbug.com/953815"
This reverts commit 57f082026be3d83069f2a2814684abf4dc9e7b53.
* fix: remove const qualifiers to match upstream
* fix: remove const qualifiers to match upstream in cc files as well
* don't throw an error when testing if an object is an object
* use non-deprecated Buffer constructor
* Remove net::CookieSameSite::DEFAULT_MODE enum value
https://chromium-review.googlesource.com/c/chromium/src/+/1567955
* depend on modded dbus-native to work around buffer deprecation
https://github.com/sidorares/dbus-native/pull/262
* revert clang roll to fix arm build on linux
* fixup! depend on modded dbus-native to work around buffer deprecation
need more coffee
* update coffee-script
* robustify verify-mksnapshot w.r.t. command-line parameters
* Revert "robustify verify-mksnapshot w.r.t. command-line parameters"
This reverts commit a49af01411f684f6025528d604895c3696e0bc57.
* fix mksnapshot by matching args
* update patches
* TMP: enable rdp on appveyor
* Changed ContentBrowserClient::CreateQuotaPermissionContext() to return scoped_refptr.
https://chromium-review.googlesource.com/c/chromium/src/+/1569376
* Make content::ResourceType an enum class.
https://chromium-review.googlesource.com/c/chromium/src/+/1569345
* fixup! Make content::ResourceType an enum class.
* turn off rdp
* use net::CompletionRepeatingCallback instead of base::Callback<void(int)>
* remove disable_ensure_gn_version_gclient_hook.patch
* copy repeating callback instead of std::move
* fix lint
* add completion_repeating_callback.h include
2019-04-20 10:20:37 -07:00
Heilig Benedek
81bf15877f
fix: port OSR code to new viz compositor codepath ( #17538 )
...
* fix: make OSR work with viz compositor
* fix: update OSR patch
* fix: update patch again
* fix: update viz_osr.patch for macOS
* fix: gn check warnings
* chore: no need to change SoftwareOutputDeviceWinProxy
* chore: add check in case we missed something
* fix: consider scale factor when compare size
* fix: make GPU OSR work
* fix: autofill popups with OSR
* chore: use UNIX line ending for osr_video_consumer
* chore: code is already in defined(OS_MACOSX)
* fix: share same OSR implementation on macOS
This should also fix the crash when there is navigation on macOS.
* test: osr window should not crash after navigation
* fix: make osr work on Mac properly
* fix: software osr on windows
* fix: software osr on Linux
* fix: compilation error introduced with rebase
* fix: split local surface id allocation into two
* Update osr_host_display_client_mac.mm
* chore: update copyright year
* fix: update patch
2019-04-17 14:10:04 -07:00
Samuel Attard
b7b9efa875
fix: handle remote-debugging-port=0 correctly ( #17800 )
...
By default the Chromedriver will send remote-debugging-port=0 to let the
browser choose a free port to listen on. The chosen port is written to
a known file in the user data dir that is passed to the app through the
CLI.
This PR does two things.
1. Correctly passes the USER_DATA_DIR to the remote debugging server so
it knows where to write the file
2. Adds support for --user-data-dir as we did not support that CLI
argument and Chromedriver relies on being able to tell the "browser"
where to write this file.
Fixes #17354
2019-04-16 14:22:51 -04:00
Vlad Hashimoto
258d337cf8
fix: crash when alt key pressed with falsy menu bar visiblity ( #17766 )
2019-04-15 13:54:27 -04:00
Jeremy Apthorp
127b87c713
refactor: mojofy MessageTo and MessageHost ( #17613 )
2019-04-03 14:22:23 -07:00
Samuel Attard
7467e91880
fix: RFH->ExecuteJavascriptForTesting now requires a callback
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1492042
2019-04-02 14:43:04 -07:00
Samuel Attard
74ac80e218
fix: ViewHierarchyChangedDetails moved to the views namespace
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1531481
2019-04-02 14:43:04 -07:00
Samuel Attard
f95de3d6f3
fix: RFH->ExecuteJavascript now requires a callback
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1492042
2019-04-02 14:43:04 -07:00
Robo
6c20c6e668
refactor: Enable network service (Part 1) ( #17431 )
...
* Convert InspectableWebContentsImpl::LoadNetworkResource to SimpleURLLoader
https://bugs.chromium.org/p/chromium/issues/detail?id=721408
* Plumb creation of network context with the service
2019-03-26 10:10:48 +09:00
Cheng Zhao
49f13e38f9
fix: close context menu before popup ( #17474 )
2019-03-21 21:56:22 -07:00
Shelley Vohr
2fb9085e5b
feat: add tray.getTitle() ( #17385 )
...
* feat: add tray.getTitle
* fix spec
2019-03-18 12:40:34 -07:00
Shelley Vohr
961c9a88a8
feat: promisify dialog.showCertificateTrustDialog() ( #17181 )
...
* feat: promisify dialog.showCertificateTrustDialog()
* update promisification doc
2019-03-15 09:02:50 +09:00
Heilig Benedek
14cc8a1808
fix: improve focused menu bar item visibility ( #17291 )
2019-03-12 15:29:45 -07:00
Shelley Vohr
8991c0056e
feat: promisify dialog.showMessageBox() ( #17298 )
...
* feat: promisify dialog.showMessageBox()
* address feedback from review
2019-03-12 11:06:59 -07:00
Samuel Attard
c7a453226d
fix: remove label/image from segment if they are mutated to undefined/null ( #17323 )
2019-03-11 11:13:36 -07:00
deepak1556
ac609a3d78
Remove deprecated override of RegisterDictionaryPref
...
https://chromium-review.googlesource.com/c/chromium/src/+/1459538
2019-03-08 15:04:32 -08:00
deepak1556
59cb0ac32e
Copy base::JSONReader::Read() to ReadDeprecated().
...
https://chromium-review.googlesource.com/c/chromium/src/+/1435715
2019-03-08 15:04:32 -08:00
deepak1556
6f14df039e
[DevTools] Stop passing base::Value to DevToolsManagerDelegate
...
https://chromium-review.googlesource.com/c/chromium/src/+/1459807
2019-03-08 15:04:32 -08:00
Shelley Vohr
6cb7b8d3a4
feat: promisify dialog.showSaveDialog() ( #17054 )
...
* feat: promisify dialog.showSaveDialog()
* address some feedback from review
* filename => filePath
* fix last filename => filePath
2019-03-05 13:48:20 -08:00
Shelley Vohr
e05985145b
feat: promisify dialog.showOpenDialog() ( #16973 )
...
* feat: promisify dialog.showOpenDialog()
* address feedback from review
* address feedback from review
2019-03-05 05:54:48 -08:00
Robo
7936237677
build: enable gn check for //electron:electron_lib ( #17100 )
...
* build: enable gn check for //electron:electron_lib
* ci: add gn check step
* ci: set depot_tools path
* chrome_key_systems_provider.h nogncheck
* chore: fix gn check errors on windows
* chore: gn check //electron:electron_app
2019-03-05 10:38:55 +05:30
Charles Kerr
ed31cfebc9
fix: check for pane focus before removing it. ( #17164 )
...
Fixes #16883 . This bug seems to have been introduced in the #15302 's
menu a11y refactor and is new in 5-0-x.
2019-03-04 09:47:59 -06:00
Shelley Vohr
544d8a423c
feat: allow MenuItems to work optionally when hidden ( #16853 )
...
* feat: allow MenuItems to work optionally when hidden
* fix: actually include forward_declaration
2019-02-28 17:00:54 +00:00
Samuel Attard
e01c3615c4
chore: replace usage of deprecated beginSheetModalForWindow API ( #16994 )
2019-02-27 10:23:17 -08:00
Johann Fuechsl
42aa375497
fix: access of out-of-scope reference in ShowOpenDialog and ShowSaveDialog ( #17126 )
...
In the mac file dialog implementation of show*OpenDialog, a settings
object is passed down to the dialog completion handler.
However at the time the completion handler is invoked, the settings
object is already out-of-scope, resulting in an invalid access to
the security_scoped_bookmarks flag.
The fix is to capture the value of the flag and passing that directly
to the completion handler.
fixes issue #16664
2019-02-27 08:14:04 +00:00
Milan Burda
5e762d6a47
chore: finalize dropping support for OS X Mavericks (version 10.9) ( #17102 )
2019-02-25 17:21:57 +00:00
deepak1556
d7fea1b484
REVIEW: fix possible -Wdeprecated-declarations warnings
2019-02-14 23:59:26 +05:30
deepak1556
3727982217
Delete tab pulsing feature.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1407958
2019-02-14 23:59:25 +05:30
deepak1556
70bbbb84bb
Rename BlendTowardOppositeLuma() to BlendTowardContrastingEndpoint().
...
https://chromium-review.googlesource.com/c/chromium/src/+/1400060
2019-02-14 23:59:25 +05:30