electron/atom/browser/ui
Johann Fuechsl 42aa375497 fix: access of out-of-scope reference in ShowOpenDialog and ShowSaveDialog (#17126)
In the mac file dialog implementation of show*OpenDialog, a settings
object is passed down to the dialog completion handler.
However at the time the completion handler is invoked, the settings
object is already out-of-scope, resulting in an invalid access to
the security_scoped_bookmarks flag.
The fix is to capture the value of the flag and passing that directly
to the completion handler.

fixes issue #16664
2019-02-27 08:14:04 +00:00
..
cocoa chore: finalize dropping support for OS X Mavericks (version 10.9) (#17102) 2019-02-25 17:21:57 +00:00
views Delete tab pulsing feature. 2019-02-14 23:59:25 +05:30
webui feat: Upgrade to Chromium 71.0.3578.98 (#15966) 2019-01-11 17:00:43 -08:00
win Use base::size rather than arraysize 2019-02-14 23:59:22 +05:30
x feat: implement BrowserWindow.moveTop on X11 (#16629) 2019-02-07 12:48:19 -08:00
accelerator_util.cc feat: add registerAccelerator flag to allow menu items to optionally skip accelerator registration (#15723) 2018-11-26 10:43:55 -08:00
accelerator_util.h Remove PlatformAccelerator 2018-10-09 14:38:00 -07:00
atom_menu_model.cc feat: add registerAccelerator flag to allow menu items to optionally skip accelerator registration (#15723) 2018-11-26 10:43:55 -08:00
atom_menu_model.h chore: make BrowserObserver a CheckedObserver 2018-12-03 20:07:38 +05:30
autofill_popup.cc fix: enable autofill popups on mac (#16308) 2019-02-11 09:38:58 -10:00
autofill_popup.h Update OSR code 2018-06-19 11:49:44 +10:00
certificate_trust.h Don't pass the result through 2017-04-04 09:21:15 -04:00
certificate_trust_mac.mm gfx::NativeView is no longer NSView on mac 2019-01-22 10:32:04 -08:00
certificate_trust_win.cc chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00
devtools_manager_delegate.cc feat: Upgrade to Chromium 71.0.3578.98 (#15966) 2019-01-11 17:00:43 -08:00
devtools_manager_delegate.h chore: fix linting 2018-12-03 20:07:41 +05:30
devtools_ui.cc feat: Upgrade to Chromium 71.0.3578.98 (#15966) 2019-01-11 17:00:43 -08:00
devtools_ui.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
drag_util.h Support dragging multiple files 2016-07-03 13:58:31 +09:00
drag_util_mac.mm gfx::NativeView is no longer NSView on mac 2019-01-22 10:32:04 -08:00
drag_util_views.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
file_dialog.h chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00
file_dialog_gtk.cc feat: add file preview for GTK file picker (#16447) 2019-02-13 06:52:14 -10:00
file_dialog_mac.mm fix: access of out-of-scope reference in ShowOpenDialog and ShowSaveDialog (#17126) 2019-02-27 08:14:04 +00:00
file_dialog_win.cc chore: run clang-format 2018-09-19 17:18:10 +02:00
inspectable_web_contents.cc refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents.h feat: add activate option to webContents.openDevTools (#13852) 2018-11-27 18:34:44 +09:00
inspectable_web_contents_delegate.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_impl.cc DevToolsFrontendHost::Create to return unique_ptr instead of raw pointer 2019-02-14 23:59:23 +05:30
inspectable_web_contents_impl.h HandleKeyboardEvent returns bool 2019-01-22 10:32:03 -08:00
inspectable_web_contents_view.h feat: add activate option to webContents.openDevTools (#13852) 2018-11-27 18:34:44 +09:00
inspectable_web_contents_view_delegate.cc refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_view_delegate.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_view_mac.h feat: add activate option to webContents.openDevTools (#13852) 2018-11-27 18:34:44 +09:00
inspectable_web_contents_view_mac.mm feat: add activate option to webContents.openDevTools (#13852) 2018-11-27 18:34:44 +09:00
message_box.h clang-format atom files 2018-04-18 20:48:45 -04:00
message_box_gtk.cc feat: Upgrade to Chromium 71.0.3578.98 (#15966) 2019-01-11 17:00:43 -08:00
message_box_mac.mm REVIEW: fix possible -Wdeprecated-declarations warnings 2019-02-14 23:59:26 +05:30
message_box_win.cc feat: Upgrade to Chromium 71.0.3578.98 (#15966) 2019-01-11 17:00:43 -08:00
tray_icon.cc add getter for ignoreDoubleClickEvents field 2018-05-03 13:49:33 -07:00
tray_icon.h add getter for ignoreDoubleClickEvents field 2018-05-03 13:49:33 -07:00
tray_icon_cocoa.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
tray_icon_cocoa.mm fix: allow Tray with title only (without icon) on Mac (#13851) 2018-08-30 21:16:56 +12:00
tray_icon_gtk.cc refactor: don't use AppIndicatorIcon directly (#15536) 2018-11-06 11:00:37 -08:00
tray_icon_gtk.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
tray_icon_observer.h chore: make BrowserObserver a CheckedObserver 2018-12-03 20:07:38 +05:30
tray_icon_win.cc Remove All Rights Reserved after GitHub copyright 2014-10-31 11:17:05 -07:00