Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00
Thiago de Arruda
6ff111a141
perf: don't use JSON to send the result of ipcRenderer.sendSync
. ( #8953 )
...
* Don't use JSON to send the result of `ipcRenderer.sendSync`.
- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
to wrap/unwrap return values to/from array, instead of
serializing/deserializing JSON.
This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).
A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory. This difference
tends increases with larger buffers.
* Don't base64 encode Buffers
* Don't allocate V8ValueConverter on the heap
* Replace hidden global.sandbox with NodeBindings::IsInitialized()
* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter
* Refactor problematic test to make it more reliable
* Add tests for NaN and Infinity
2018-06-13 17:38:31 +10:00
Milan Burda
2337237d58
Refactoring: use C++11 class member variable initialization
2018-05-22 00:18:38 +02:00
Milan Burda
850051463b
don't use native_mate/compat.h macros ( #12984 )
2018-05-18 09:08:28 +09:00
Milan Burda
6a4d9309b2
Remove unnecessary heap allocations of atom::V8ValueConverter instances ( #12924 )
2018-05-15 09:21:23 -05:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Shelley Vohr
53bdf22c85
clang-format atom files
2018-04-18 20:48:45 -04:00
Shelley Vohr
ca406637af
add converters for base::BindOnce and base::BindRepeating
2018-04-17 18:47:12 -04:00
Shelley Vohr
d722008367
remove unnecessary ptr_util.h include
2018-04-12 22:34:26 -04:00
Shelley Vohr
b05932310b
replace base::MakeUnique with std::make_unique
2018-04-12 08:48:32 -04:00
Jeremy Apthorp
f0d08f4da1
Propagate referrer to new windows ( #12397 )
...
* Propagate referrer to new windows
Fixes #9205
* Rearrange -new-window event arguments for backwards-compatibility
* Plumb referrer policy through guest-window-manager
* Document the Referrer structure and its uses
* Add tests for referrer in new windows
* Docs nits
2018-04-05 18:13:24 -05:00
Samuel Attard
7356be0164
Convert optional webpoint
2018-03-20 10:13:14 +03:00
deepak1556
d846c9006e
Replace somemore uses of SetStringWithoutPathExpansion
2018-02-23 10:21:24 +09:00
deepak1556
fedf1d889b
handle NaN conversion from V8
2018-01-02 16:37:06 +09:00
Aleksei Kuzmin
47d683f0ad
DevTools: do not set visible size while emulating in case of device mode.
...
https://chromium-review.googlesource.com/c/chromium/src/+/572222
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
f03ca53af5
Add blink::WebInputEvent::IsPinchGestureEventType().
...
https://codereview.chromium.org/2861373004
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ba6e8b4dff
Merge ResourceRequestBodyImpl and ResourceRequestBody.
...
https://codereview.chromium.org/2954343005
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
7ad524fa34
Make base::DictionaryValue::Set* return pointers
...
https://codereview.chromium.org/2850773002
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
58e0771e47
Remove base::Value::Get{Buffer,Size}
...
https://codereview.chromium.org/2841623003
2017-11-24 10:58:15 +09:00
Thiago de Arruda
64bfabdeba
Make BindFunctionWith function visible to other modules.
2017-11-13 15:21:22 -03:00
Thiago de Arruda
32113bf7f9
Implement V8 -> C++ conversion of net::HttpResponseHeaders.
2017-11-13 15:20:40 -03:00
Thiago de Arruda
9c04d18387
Modify FillRequestDetails to pass headers dictionary.
2017-11-13 15:19:59 -03:00
Aleksei Kuzmin
627eb30409
The Blink Rename
2017-08-15 16:19:21 +03:00
Tony Ganch
90574160db
Replace x/y in WebMouseEvent with proper getters/setters
2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
cc350efbd8
Remove base::BinaryValue
...
https://codereview.chromium.org/2799093006
2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
3d700ee49f
Remove base::Value::CreateNullValue
...
https://codereview.chromium.org/2792573002
2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
a20f633272
Remove base::StringValue
...
https://codereview.chromium.org/2664753002
2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
7a4ca08a8d
The Blink Rename
2017-08-15 16:19:20 +03:00
Cheng Zhao
0ee2ab8a6e
Fix accessing empty vector in V8FunctionInvoker
2017-07-31 16:47:14 +09:00
Ales Pergl
440b238157
Fixed build issues in debug mode
2017-06-30 12:28:01 +02:00
Cheng Zhao
301ed2d66c
Fix typo when updating code
2017-04-27 16:34:52 +09:00
Cheng Zhao
b3d60bfb3a
Fix building on Linux
2017-04-27 16:34:52 +09:00
Cheng Zhao
481b04358e
Fix blink API changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
6be10ffef2
Fix more API changes due to name changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
50e3bfa764
Fix API changes of base::Value
2017-04-27 16:34:52 +09:00
Cheng Zhao
fc2d62d5cb
Fix API changes of Chrome58
2017-04-27 16:34:52 +09:00
Kevin Sawicki
3e9014c371
Merge pull request #9099 from electron/certificate-trust
...
macOS: Add certificate trust API
2017-04-04 11:17:09 -07:00
joshaber
736d6afe73
As you wish linter
2017-04-04 09:23:30 -04:00
joshaber
0cab8a3322
Put CertFromData in an anon namespace
2017-04-04 09:19:23 -04:00
joshaber
370cf815d9
Get rid of intermediates
and rehydrate from issuerCert
2017-04-03 16:27:53 -04:00
joshaber
b0ef7ddf44
Use better iteration
2017-04-03 15:28:51 -04:00
joshaber
ee7389bb6d
Rename to make VS happy
2017-03-31 22:57:56 -04:00
joshaber
bde2a597f3
Decode all the intermediates
2017-03-31 21:27:49 -04:00
joshaber
69defc5166
Encode all the intermediates
2017-03-31 21:27:33 -04:00
joshaber
302ca8669d
Slightly better conversion
2017-03-31 15:44:47 -04:00
joshaber
141a5ad73f
Maybe this is a valid conversion?
2017-03-31 14:16:26 -04:00
Haojian Wu
8ae91682cb
Lines should be <= 80 characters.
2017-03-31 20:09:13 +02:00
joshaber
deae70de4d
Dummy out the certificate FromV8 converter
2017-03-31 13:53:31 -04:00
Haojian Wu
e8abee9ca9
Replace C-style casts with static_cast.
2017-03-30 23:05:47 +02:00
Cheng Zhao
e496e18f6e
Make Archive thread safe
2017-03-20 12:52:46 -07:00
Cheng Zhao
69df934710
Converter for base::Callback is not thread safe
2017-03-20 12:52:45 -07:00
Thiago de Arruda
a6e4867111
Handle Buffer deserialization in sandboxed renderers
...
In sandboxed renderers we use browserify to provide a node-like environment. The
Buffer class used by browserify is actually just a wrapper around Uint8Array,
but to deserialize Buffer correctly we must expose the class as a hidden value
and use it in V8ValueConverter.
2017-03-16 13:20:09 -03:00
Cheng Zhao
a98e69a80d
Work around the compilation error of v8_value_converter.cc
...
We should apply this patch in future:
0232f57400
%5E%21/
2017-02-06 10:34:29 -08:00
Cheng Zhao
820c0827c0
Fix cpplint warnings
2017-02-06 10:34:29 -08:00
Cheng Zhao
5e43ea227e
purgedSize and purgeableSize are removed by Chrome
2017-02-06 10:34:29 -08:00
Cheng Zhao
6d323dd6fe
web/WebInputEvent.h is moved to platform/WebInputEvent.h
2017-02-06 10:34:29 -08:00
liusy182
2cf6a026d8
fix linting error
2017-02-02 21:16:30 +08:00
liusi
87392ff046
'before-input-event' is missing the code property #8471
2017-02-02 16:23:07 +08:00
Cheng Zhao
497f5a1199
Update files for Chrome 54 API changes
2017-01-19 09:05:59 +02:00
Kevin Sawicki
7842040d9d
Add ToV8 converter for NativeWebKeyboardEvent
2016-12-13 15:54:13 -08:00
Greg Nolle
f767f0f048
Remove unnecessary ConvertToV8 calls.
2016-11-15 15:53:42 -08:00
Greg Nolle
5d028f9163
Expose extra certificate information: full breakdown of issuer and subject principals, as well as full structure of intermediate issuer certificates.
2016-11-15 15:53:42 -08:00
Greg Nolle
446399c3c1
Expose whole certificate chain to verify proc and certificate-error event.
2016-11-15 15:53:42 -08:00
deepak1556
61576c39be
uploadData => uploadRawData
2016-11-11 10:54:01 -08:00
deepak1556
9536ebc0ad
fix build error
2016-11-11 10:54:01 -08:00
deepak1556
a5fd6507a9
set default values in converter
2016-11-11 10:54:01 -08:00
deepak1556
ad5f944185
add spec
2016-11-11 10:53:36 -08:00
deepak1556
0410a184ce
webContents: handle POST navigation for new windows
2016-11-11 10:53:00 -08:00
ali.ibrahim
61278f9ace
Fixing code review issues.
2016-10-25 12:41:01 +02:00
ali.ibrahim
9cc8bfae1c
fixing space formatting issues.
2016-10-14 10:58:16 +02:00
ali.ibrahim
de29f2dde5
Fixing build: removing constness on net::HttpResponseHeaders as otherwise we would need a change in libchromiumcontent.
2016-10-13 17:51:19 +02:00
ali.ibrahim
6f5b0a28c5
Fixing code review issues: function call formatting, renaming JS member variables, refactoring response headers conversion.
2016-10-13 17:14:23 +02:00
Kevin Sawicki
6fac14ad3f
Set key and code on keyboard events
2016-10-10 09:35:43 -07:00
Cheng Zhao
9714348260
Merge pull request #6941 from deepak1556/blob_data_patch
...
protocol: provide blob uuid with uploadData
2016-09-16 17:01:15 +09:00
Cheng Zhao
5ccd0a24e9
Fix compatibility with canScroll
2016-09-14 16:23:01 +09:00
Cheng Zhao
f28e8d7168
Fix API changes of Chrome 53
2016-09-14 16:22:43 +09:00
deepak1556
7b85ca0301
create helper class to read blob data
2016-09-01 08:52:44 +05:30
deepak1556
0fb2339e3d
session: api to retrieve blob data from uuid
2016-09-01 01:01:52 +05:30
deepak1556
2b0f632d51
provide blob uuid from upload data
2016-09-01 01:01:52 +05:30
Kevin Sawicki
8a9776b227
Move IsExternal check to FromV8ValueImpl
2016-08-30 08:51:22 -07:00
Kevin Sawicki
58fc1b7933
Ignore external values when serializing
2016-08-29 10:38:16 -07:00
Kevin Sawicki
4579ec6094
Don't convert values with internal fields
2016-08-29 10:38:16 -07:00
Kevin Sawicki
6285500cdc
Sort includes alphabetically
2016-08-26 15:30:02 -07:00
Kevin Sawicki
50e2e26e4f
Improve cycle detection in V8ValueConverter
2016-08-25 09:26:07 -07:00
Cheng Zhao
47c37d6f51
Merge pull request #6814 from brave/net-converter-fix
...
don't convert a string to an array buffer
2016-08-17 20:44:13 +09:00
bridiver
94c60379d1
don't convert a string to an array buffer
2016-08-13 13:35:23 -07:00
deepak1556
ee298ea0e3
webContents: fix value of contextMenu hasImageContents property
2016-08-12 00:55:20 +05:30
Kevin Sawicki
42a1136c88
Remove HasRealNamedCallbackProperty check
2016-08-08 09:35:40 -07:00
Heilig Benedek
7a471e1ab7
fix UTF character sending as suggested by @zcbenz
2016-08-01 02:14:11 +02:00
Heilig Benedek
af80b9a7df
Fixes not being able to send UTF8 characters anymore
2016-07-31 05:24:28 +02:00
Cheng Zhao
b57665330c
Merge branch 'master' into chrome52
2016-07-21 05:34:36 -06:00
Cheng Zhao
39bd2bee8e
Avoid using CHECK in files using node headesr
...
Node has its own CHECK macro which requires linking with node::Assert.
2016-07-21 16:56:48 +09:00
Cheng Zhao
7d42797c1f
Update node headers including
2016-07-21 00:57:34 -06:00
Anthony Tseng
9e6f623a5c
Using base::HexEncode()
2016-07-19 11:06:56 +08:00
Anthony Tseng
42eb0c3eae
serial number in hex string
2016-07-18 23:42:42 +08:00
Anthony Tseng
02e89d60f1
Use CalculateFingerprint256()
2016-07-14 19:09:11 +08:00
Anthony Tseng
db39867ad9
Add more detail attributes for certificate-error
2016-07-13 22:14:47 +08:00
Haojian Wu
04f9d35312
Modernize to C++11: Use auto
key to improve code readability and maintainability.
2016-07-10 13:11:47 +02:00
Haojian Wu
fab02809c6
Modernize to C++11: NULL => nullptr.
...
No functional change.
2016-07-10 11:57:04 +02:00
Cheng Zhao
d0719e9b4b
Fix cpplint warnings
2016-07-04 19:19:20 +09:00