Move IsExternal check to FromV8ValueImpl
This commit is contained in:
parent
679ee95e8a
commit
8a9776b227
1 changed files with 3 additions and 5 deletions
|
@ -262,6 +262,9 @@ base::Value* V8ValueConverter::FromV8ValueImpl(
|
|||
if (state->HasReachedMaxRecursionDepth())
|
||||
return nullptr;
|
||||
|
||||
if (val->IsExternal())
|
||||
return base::Value::CreateNullValue().release();
|
||||
|
||||
if (val->IsNull())
|
||||
return base::Value::CreateNullValue().release();
|
||||
|
||||
|
@ -415,11 +418,6 @@ base::Value* V8ValueConverter::FromV8Object(
|
|||
child_v8 = v8::Null(isolate);
|
||||
}
|
||||
|
||||
// Ignore external values since calling CreationContext() on them can
|
||||
// crash
|
||||
if (child_v8->IsExternal())
|
||||
continue;
|
||||
|
||||
std::unique_ptr<base::Value> child(
|
||||
FromV8ValueImpl(state, child_v8, isolate));
|
||||
if (!child.get())
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue