Cheng Zhao
53229e3d6c
Fix network delegate race condition ( #12044 )
...
* Fix race condition when getting network delegate
* Remove the evil URLRequestContextGetter::network_delegate
* Move the arguments instead of const referrencing
Safer and more efficient.
2018-02-26 06:23:59 -08:00
deepak1556
5eb0a89579
REVIEW: let browser context manage cookie change sub list
2018-02-23 10:21:24 +09:00
deepak1556
248d572077
REVIEW: Subscribe to cookie store for changes in place of CookieMonsterDelegate
2018-02-23 10:21:23 +09:00
deepak1556
75c17cf846
Use generic base::Value::SetKey
...
Remove base::Value::SetDoubleWithoutPathExpansion
https://chromium-review.googlesource.com/591654
Remove base::Value::SetStringWithoutPathExpansion
https://chromium-review.googlesource.com/592368
Remove base::Value::SetIntegerWithoutPathExpansion
https://chromium-review.googlesource.com/591655
2018-02-23 10:21:23 +09:00
Thiago de Arruda
bc76f35691
Fix protocol filtering of net.request
...
net::URLRequest inherits from base::SupportsUserData, which allows
associating arbitrary data with the request. Use this mechanism as a
condition for filtering requests from custom protocols.
Close #11657
2018-02-16 13:03:53 -05:00
deepak1556
d29c27dc78
REVIEW: obtain mime type from file path only on IO allowed sequence
2018-01-02 16:37:09 +09:00
deepak1556
ebb0e46380
REVIEW: create AtomNetworkDelegate on the IO thread
2018-01-02 16:37:08 +09:00
Cheng Zhao
b2cef31bc0
Revert "Fix race condition when calling JsAsker::BeforeStartInUI"
...
This reverts commit 37317d74adb53afdcb22c85f2d3987fbae290ac7.
2018-01-02 16:37:08 +09:00
Cheng Zhao
6d9b186fa7
Fix race condition when calling JsAsker::BeforeStartInUI
2018-01-02 16:37:07 +09:00
deepak1556
90acb22a58
dont use UI methods on IO thread
2018-01-02 16:37:06 +09:00
deepak1556
a518c5c3c4
derefence weak ptr only on the same sequence runner it was created in
2018-01-02 16:37:06 +09:00
Aleksei Kuzmin
a9eb0cbec0
Ban raw pointers to ref-counted types on base::Bind
...
https://chromium-review.googlesource.com/c/chromium/src/+/549537
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
6c7ad3ac58
Remove the dependence on BrowserThread::FILE for
...
https://codereview.chromium.org/2944313003
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ba2f33d629
Remove base::Value::GetAsBinary
...
https://codereview.chromium.org/2839753005
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
58e0771e47
Remove base::Value::Get{Buffer,Size}
...
https://codereview.chromium.org/2841623003
2017-11-24 10:58:15 +09:00
Thiago de Arruda
a9a9e58b68
Fix random crash on app quit.
...
Move AtomCTDelegate to brightray as RequireCTDelegate and transfer ownership to
brightray::URLRequestContextGetter. This fixes the wrong lifetime assumptions
that result in AtomCTDelegate being used after free in some scenarios.
Close #10051
2017-11-17 12:03:23 -03:00
Thiago de Arruda
5ea3a5886b
Implement {register,intecept}StreamProtocol
...
These new functions are more flexible than the other
{intercept,register}*ProtocoProtocol functions, since it allows the user to
return a node.js stream to feed the data to the protocol handler.
It also allows the user to specify a response header dictionary, which makes it
possible to correctly intercept any request made from renderers.
2017-11-13 16:16:14 -03:00
Thiago de Arruda
6b666b69c0
Implement GetLoadTimingInfo in JsAsker class.
...
This is required to avoid a crash in blink when implementing a custom protocol
handler that deals with redirects.
2017-11-13 15:20:56 -03:00
Paul Frazee
c2d9e082cb
Fix crash in custom protocols caused by bad callback exec
2017-10-25 21:01:53 -05:00
Boik
f40cc5ab54
add error code to session.setCertificateVerifyProc
2017-10-16 17:17:21 +08:00
Boik
d594092675
add a null-pointer check before processing base::SupportsUserData::GetUserData
2017-10-03 12:42:35 +08:00
Cheng Zhao
c34fb146f6
Fix styling
2017-09-13 21:40:29 +09:00
Boik
e66341ec59
add back the missing 'resourceType' property
2017-09-12 21:27:49 +08:00
Boik
a01abd0fee
fix lint-cpp
2017-09-12 20:28:30 +08:00
Boik
2d771674bb
get webContentsId instead
2017-09-12 20:17:11 +08:00
Boik
13d363d1f1
fix lint-cpp
2017-09-12 15:40:35 +08:00
Boik
549c30f9b2
first attempt to track the origin requesters of webRequest events
2017-09-12 15:40:35 +08:00
Aleksei Kuzmin
e16e1e2854
Remove URLRequestJobFactory::IsHandledURL.
...
https://codereview.chromium.org/2783343002
2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
cc350efbd8
Remove base::BinaryValue
...
https://codereview.chromium.org/2799093006
2017-08-15 16:19:20 +03:00
Cheng Zhao
4e2cb549c7
Notify net error asyncronously
...
Notifying net error syncronously would result in crash.
2017-08-02 11:14:06 +09:00
Kevin Sawicki
c43c3b3d80
Revert "protocol: use streaming interface between fetcher and requestjob"
...
This reverts commit 71b5d946e0
.
2017-05-26 09:47:22 -07:00
Kevin Sawicki
43f7520d4f
Add missing brightray prefix
2017-05-19 08:46:15 -07:00
Kevin Sawicki
f556d1924d
Merge pull request #9358 from electron/fetch_job_uaf_patch
...
protocol: use streaming interface between fetcher and requestjob
2017-05-18 09:58:05 -07:00
Kevin Sawicki
ef4bf7ed93
Use status code constant
2017-05-11 15:33:56 -07:00
deepak1556
3c88447be6
protocol: provide default response code for custom request jobs
2017-05-11 15:33:56 -07:00
deepak1556
71b5d946e0
protocol: use streaming interface between fetcher and requestjob
2017-05-11 22:52:49 +05:30
Cheng Zhao
b2b2d8d9a4
Fix crash on exit
2017-04-27 16:34:52 +09:00
Cheng Zhao
6be10ffef2
Fix more API changes due to name changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
50e3bfa764
Fix API changes of base::Value
2017-04-27 16:34:52 +09:00
Cheng Zhao
fc2d62d5cb
Fix API changes of Chrome58
2017-04-27 16:34:52 +09:00
Kevin Sawicki
f5a75c4e87
Merge pull request #9076 from electron/cleanup-cpp
...
Cleanup cpp codebase
2017-04-03 08:30:08 -07:00
Haojian Wu
328cf4789b
Should override the virtual destructor.
2017-03-30 23:19:43 +02:00
Haojian Wu
1b9780035c
Remove redundant calls to smart pointer's get method.
2017-03-30 22:22:40 +02:00
Kevin Sawicki
4441d557a2
Merge pull request #9007 from electron/net_redirect_patch
...
net: allow controlling redirects
2017-03-28 09:31:05 -07:00
deepak1556
3ae62615f4
net: allow controlling redirects
2017-03-28 18:46:21 +05:30
deepak1556
93b444eef9
net: catch source stream creation failure for content encoding
2017-03-23 23:36:05 +05:30
Kevin Sawicki
1e581d6814
Use unique_ptr for passing VerifyRequestParams
2017-02-08 11:59:43 -08:00
Kevin Sawicki
70178adb6e
Use object for verification request
2017-02-08 11:59:43 -08:00
Kevin Sawicki
37db804099
Use NetLogWithSource since BoundNetLog no longer exists
2017-02-08 11:59:43 -08:00
Greg Nolle
e29b64a18a
modify CertVerifier Class
...
* respond to multiple similar verification requests.
* accept net error result as callback response.
2017-02-08 11:59:43 -08:00