Shelley Vohr
36cf548114
change weak ptr ref to strong
2018-02-10 21:04:26 -05:00
Shelley Vohr
3085c78bcf
implement selectFormat selector
2018-02-09 21:38:21 -05:00
Charles Kerr
3710e0e38b
make the linter happier
2018-02-09 19:34:37 -06:00
Charles Kerr
4b766d26df
make the linter happy
2018-02-09 19:29:32 -06:00
Charles Kerr
3f5ce6d74f
fix gtk3 deprecation warnings setting menubar colors
2018-02-09 19:04:59 -06:00
Charles Kerr
b107d3f440
remove icons from messageboxes on gtk
...
Icons are deprecated in GtkMessageBoxes as of GTK+ 3.12. The GNOME HIG no longer shows icons in example dialogs; see https://developer.gnome.org/hig/stable/dialogs.html.en and https://developer.gnome.org/gtk3/stable/GtkMessageDialog.html
2018-02-09 17:53:02 -06:00
Charles Kerr
ffff400236
fix 'GTK_STOCK_*' deprecation warnings
2018-02-09 17:45:34 -06:00
Charles Kerr
e5eeab6e29
fix 'GTK_STOCK_*' deprecation warnings
2018-02-09 09:57:39 -06:00
Shelley Vohr
0fff336481
add accessory view for format picker
2018-02-09 09:08:04 -05:00
Shelley Vohr
3399480304
first pass at menu event emission
2018-01-27 09:35:58 -05:00
Nitish Sakhawalkar
2b4cc0a525
Fix macos Full Screen Toggle menu item label ( #11633 )
2018-01-19 09:27:36 -05:00
Heilig Benedek
f36fda3f5d
don't dereference tooltip_controller if it's null
2018-01-18 20:35:19 +01:00
Heilig Benedek
8d8b8c590d
update calls to use new namespaces
2018-01-18 15:23:38 +01:00
Heilig Benedek
5e198d9dc6
add todo comment
2018-01-18 15:23:38 +01:00
Heilig Benedek
8233890e39
lint fix
2018-01-18 15:23:38 +01:00
Heilig Benedek
c6c618acdb
explicitly hide tooltip on window deactivation
2018-01-18 15:23:38 +01:00
shelley vohr
4f0e1826e5
properly check checkbox state on callback ( #11658 )
2018-01-17 08:51:49 -05:00
Matt Way
5504294a6a
Replaces tracking removal with proper mem management
2018-01-10 10:24:37 +09:00
Matt Way
8df4402722
removed unnecessary braces
2018-01-10 10:24:13 +09:00
Matt Way
638d8219c4
Removed tracking area when removing icon to prevent mouse exit race condition crash
2018-01-10 10:24:11 +09:00
Cheng Zhao
1043f07b42
Fix compilation on Windows
2018-01-02 16:37:11 +09:00
deepak1556
0df464e16a
address review comments
2018-01-02 16:37:09 +09:00
deepak1556
d29c27dc78
REVIEW: obtain mime type from file path only on IO allowed sequence
2018-01-02 16:37:09 +09:00
deepak1556
e072213923
FIXME: dbus ObjectProxy methods should only be invoked on IO allowed sequence
2018-01-02 16:37:09 +09:00
deepak1556
a1592446da
REVIEW: access GetApplicationLocale on sequence that allows IO
2018-01-02 16:37:08 +09:00
Cheng Zhao
c3eadd5b63
mac: Call callback when menu is programmely closed
2018-01-01 16:49:25 +09:00
Cheng Zhao
d7bc127c60
mac: Correctly close popup menu
2018-01-01 15:40:15 +09:00
Cheng Zhao
81527b71ba
Merge pull request #11279 from sethlu/openrecent
...
Update submenu's title at replacement
2017-12-19 15:28:02 +09:00
Ales Pergl
8357a33d81
Don't leak the taskbar object, reuse it instead
2017-12-01 17:55:21 +01:00
Zhuo Lu
c274312a3a
Update submenu's title
2017-11-28 19:38:07 -08:00
Cheng Zhao
0dc094fffc
Do not change logic on highlighing
2017-11-28 17:37:58 +09:00
Cheng Zhao
d1ebce0395
Remove unused methods
2017-11-28 17:31:13 +09:00
Cheng Zhao
590578c187
Cache the attributed string
2017-11-28 17:26:09 +09:00
Cheng Zhao
eab3342065
Fix the detection of ANSI code
2017-11-28 16:36:07 +09:00
Cheng Zhao
c9acccaddc
Fix memory leak in ANSCI parsing code
...
We do not have ARC enabled.
2017-11-28 16:36:07 +09:00
Cheng Zhao
4ded79801f
Remove unused code in NSColor+Hex.h
2017-11-28 16:10:24 +09:00
Cheng Zhao
08f30e4ca6
Add license for the vendored files
...
Checked the original files and they were compatible with MIT.
2017-11-28 15:38:42 +09:00
Cheng Zhao
edede7f33f
Fix cpplint warning
2017-11-28 15:36:45 +09:00
Sebastien Bramille
a4905b3c95
Lint
2017-11-28 15:34:13 +09:00
Sebastien Bramille
e8b0897ea1
Fix margin
2017-11-28 15:34:13 +09:00
Sebastien Bramille
71cfb7441c
Update header file
2017-11-28 15:34:13 +09:00
Sebastien Bramille
9f89bd8d8e
Add isHighlighted method
2017-11-28 15:34:13 +09:00
Sebastien Bramille
6a1cfafbd8
Clean
2017-11-28 15:34:13 +09:00
Sebastien Bramille
85f254316c
Add logic
2017-11-28 15:34:13 +09:00
Sebastien Bramille
d722d20974
Use NSString+ANSI on the Menu title
2017-11-28 15:34:13 +09:00
Cheng Zhao
b161a4f515
Merge pull request #11166 from sethlu/openrecent
...
feat: Recent documents menu item
2017-11-28 10:55:14 +09:00
Zhuo Lu
104d307a4a
Use base::scoped_nsobject
2017-11-27 17:26:23 +09:00
Zhuo Lu
8fa3e71ce4
Format code
2017-11-27 17:26:22 +09:00
Zhuo Lu
4934685f53
Declare with static
2017-11-27 17:26:22 +09:00
Zhuo Lu
0c4e425872
Do not autorelease global variables
2017-11-27 17:26:22 +09:00
Zhuo Lu
dcdc3621ac
Rename roles
2017-11-27 17:26:22 +09:00
Zhuo Lu
1ab4504e94
No need to make visible
2017-11-27 17:26:22 +09:00
Zhuo Lu
cf73fb737f
Small optimization
2017-11-27 17:26:22 +09:00
Zhuo Lu
5d44dbaf54
Redesign recent documents role API
...
- For more flexibility in designing the recent documents menu, now there can be one menu item (known issue: you may specify more but AppKit doens't display more than one) in the submenu list, rather than separating the labels with a tab.
- Also added is the role `clearrecent` that can be given to a menu item that can clear the recent documents.
2017-11-27 17:26:22 +09:00
Zhuo Lu
0b9cea334f
Specify "Clear Menu" through label option
...
Like a bit of a hack right now, conforming to the existing menu item definition
2017-11-27 17:26:22 +09:00
Zhuo Lu
8b720c120d
Hide "Open Recent" in xib
2017-11-27 17:26:22 +09:00
Zhuo Lu
4da2eb9366
Introduce openrecent role
...
- Does not yet accept any options except label--"Clear Menu" can't be modified through exposed node API
- If `openrecent` is present across multiple menu items, the last seen will be visible in the main menu due to that it is designed to behave like a singleton
2017-11-27 17:26:22 +09:00
Zhuo Lu
0ba2fa5cba
Use else if
2017-11-27 17:26:22 +09:00
Aleksei Kuzmin
fe9ae41f98
Use gtk_toggle_button_get_active()
2017-11-24 10:58:53 +09:00
Samuel Attard
797a58bee0
Result of RunMenuAt is now void, no need to ignore it
2017-11-24 10:58:17 +09:00
Tomas Rycl
a723e5a4c5
Fixed moved cert x509 function issue on Windows
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
338604239d
Cleanup MenuRunner API
...
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
14eb2af876
Give CustomButton a focus painter.
...
https://chromium-review.googlesource.com/c/chromium/src/+/516824
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
e0d7b7d0fc
Clean up views::Background.
...
https://chromium-review.googlesource.com/c/chromium/src/+/520702
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
93b3d8cb49
Changed top/bottom & left/right border parameters on BoxLayout to take single gfx::Insets parameter.
...
https://chromium-review.googlesource.com/c/chromium/src/+/515902
2017-11-24 10:58:17 +09:00
Tony Ganch
513d4fd225
Remove usage of X11AtomCache
...
See https://codereview.chromium.org/2914103002/
2017-11-24 10:58:17 +09:00
Tony Ganch
d7e4e8d6cc
Rename GetPrefferedSize to CalculatePrefferedSize
...
See https://chromium-review.googlesource.com/c/chromium/src/+/516542
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
7f5fbb04e2
Migrate from ScopedComPtr::CreateInstance() to CoCreateInstance in chrome/...
...
https://codereview.chromium.org/2894483002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
75b41102ef
Remove unused includes
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
1127452429
PlzNavigate: make NavigationResourceHandler a LayeredResourceHandler
...
https://codereview.chromium.org/2847443002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
a72a08bccc
Convert iOS to use X509CertificateBytes.
...
https://codereview.chromium.org/2864133002
2017-11-24 10:58:16 +09:00
Cheng Zhao
3cc8330998
Merge branch 'master' into ahmedmohamedali-master
2017-11-20 11:04:47 +09:00
Cheng Zhao
7e0593950c
Code style fixes
2017-11-13 16:13:54 +09:00
Heilig Benedek
26daffea9c
use smart pointer for paint_canvas
2017-11-13 15:50:49 +09:00
Heilig Benedek
4b10445c2e
lint fix
2017-11-13 15:50:49 +09:00
Heilig Benedek
193beb57c9
fix datalist element popup position when menu is hidden
2017-11-13 15:50:49 +09:00
Heilig Benedek
f8b3009ebf
restructure code to use web_preferences if possible
2017-11-13 15:50:49 +09:00
Heilig Benedek
71b36ef54d
don't show the dummy window for the rest of the dialogs too on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
13b86598e8
don't show osr dummy window when dialog is shown on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
e39aacb30e
fix a bug that caused a crash when using an offscreen window with detached devtools, related to autofill popups
2017-11-13 15:46:46 +09:00
Ahmed
9b3960fe90
Merge branch 'master' into master
2017-11-08 18:03:55 +01:00
Samuel Attard
bb997c2ea4
Forward declare the scrubber layout
2017-11-08 16:48:08 +13:00
Armagan Amcalar
edd113548a
Make ScrubberItem width dynamic
...
Depending on whether a ScrubberItem has text or an icon, this changeset
calculates the actual width and sizes the TouchBar items accordingly.
Previously, all ScrubberItems, regardless of their content, had a static
width of 50px.
This commit also fixes #10539 .
2017-11-07 00:09:14 +01:00
Ahmed Mohamed Ali
9f3cfa2dbd
Fix crash that happens when the PDF viewer is refreshed.
...
The root cause is the PdfViewerHandler instanceis destroyed but not removed from the list of observer in WebContentsZoomController
2017-10-19 16:27:08 +02:00
Samuel Attard
d350134c4f
Ensure that the touchbar's esape item can be set before setting it
2017-10-10 02:24:49 +11:00
Cheng Zhao
bb71b09452
Fix building on Windows
2017-10-05 11:51:41 +09:00
Cheng Zhao
4342480473
Fix cpplint warnings
2017-10-05 11:49:26 +09:00
Sean Bannigan
0b205019b6
add mouse-move event and click event position for tray
2017-10-05 11:41:08 +09:00
Cheng Zhao
0694334487
Merge pull request #10271 from kaylanm/macos-native-tab-menu-items
...
🍎 Add roles for macOS native tab menu items
2017-09-11 17:41:31 +09:00
Birunthan Mohanathas
511e82de67
Fix missing extension when saving a file without filters
...
Previously, when triggering the save dialog through e.g. `<a download>`
links (e.g. http://jsfiddle.net/koldev/cW7W5/ ), the extension was only
saved if Finder was set to show all extensions by default. We now always
display the extension to make sure that it is saved.
If we want to keep the extension hidden, we could also populate the
allowed file types array with the extension from the default filename,
but that would have interfered with how we set the filters.
2017-09-07 16:48:14 -07:00
Samuel Attard
6b010614e2
Implement moveToApplicationsFolder ( #10142 )
...
* Implement moveToApplicationsFolder
* Fix tabs / spaces
* Fix linting
* Use Browser::Quit, instead of exit
* Update documentation as per feedback
* Fix spec
2017-08-31 10:37:12 -04:00
Cheng Zhao
4febbec102
Fix crash when switching menus in menubar
2017-08-29 14:19:23 +09:00
Michael Kaylan
7741a0e6ad
🍎 Add roles for macOS native tab menu items
...
Fixes #9086 , #10064 .
2017-08-15 11:30:39 -04:00
Catalin Fratila
60b363fa3b
Fixing Windows tray icon content menu - based on chrome/browser/ui/views/status_icons/status_icon_win.cc
2017-08-15 16:19:23 +03:00
Gellert Hegyi
1d10654a22
fixes bitmap to canvas conversion
2017-08-15 16:19:22 +03:00
Kevin Sawicki
9945fc5148
Don't destroy menu delegate until OnMenuClosed fires
2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
4fc2b3e642
Make download item drags look like bookmark
...
https://codereview.chromium.org/2750253002
2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
627eb30409
The Blink Rename
2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
49fbb52b01
Add X509CertificateBytes which uses CRYPTO_BUFFER instead of macOS-native certificate types.
...
https://codereview.chromium.org/2746103003
2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
a20f633272
Remove base::StringValue
...
https://codereview.chromium.org/2664753002
2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
7a4ca08a8d
The Blink Rename
2017-08-15 16:19:20 +03:00
Cheng Zhao
edc2dae496
Make the status string shorter
2017-07-20 22:45:06 +09:00
Cheng Zhao
74df5f84fd
Only update dbus menu when it has been changed
...
The dbus menu implementaion of KDE would send the about-to-show signal
whenever the menu has been changed, resulting in infinite loop on our
side.
2017-07-20 20:50:14 +09:00
Kevin Sawicki
959231f766
Merge pull request #9834 from shubham2892/input-type-file-treating-packaged-app-as-directory
...
Fix treat packaged app as directory
2017-07-18 10:21:07 -07:00
Shubham
b25a1d10a2
🍎 Add treatPackageasDirectory as an option
2017-07-18 10:13:25 -07:00
Kevin Sawicki
1c1cf0d1f2
Merge pull request #9857 from alexeykuzmin/add-enable-osr-flag
...
[WIP] Add enable_osr flag
2017-06-29 12:30:44 -07:00
Kevin Sawicki
06a550b412
Autorelease tracking area
2017-06-28 12:37:31 -07:00
Kevin Sawicki
e44f655503
Merge pull request #9760 from shubham2892/Add-mouse-enter-and-mouse-exit-event-for-Tray
...
Add mouse-enter and mouse-exit events for tray
2017-06-28 12:15:32 -07:00
Kevin Sawicki
d53f07cc20
🎨
2017-06-28 12:13:12 -07:00
Kevin Sawicki
70544440f9
Add location and keyboard modifiers to tray mouse events
2017-06-28 12:10:24 -07:00
Aleksei Kuzmin
da36bdfcc4
Add enable_osr build flag
2017-06-28 18:58:52 +02:00
Kevin Sawicki
bda21216e7
Merge pull request #9743 from electron/number-accelerator-modifier
...
Don't mutate the accelerator character with the shift key if it's a number
2017-06-26 11:20:52 -07:00
Shubham
80e35b6682
🍎 Fix treat packaged app as directory
2017-06-22 17:10:22 -04:00
Samuel Attard
231d4f7581
Use the isdigit helper
2017-06-17 03:52:19 +10:00
Kevin Sawicki
e8911fe48c
Merge pull request #9610 from shubham2892/incorrect-file-extension-with-showSaveDialog-fix
...
Fix incorrect extension when filters is used
2017-06-15 10:29:11 -07:00
Kevin Sawicki
15dd0eb583
Add braces to if statement
2017-06-15 10:27:34 -07:00
Shubham
8dbb8ccbab
add mouse-enter and mouse-exit events for tray
2017-06-14 18:00:29 -04:00
Kevin Sawicki
dae27de504
Merge pull request #9588 from electron/poiru/dialog-default-file-name
...
Use last selected directory when using default file name in dialog.showSaveDialog()
2017-06-14 14:41:45 -07:00
Heilig Benedek
a3ec28ddf3
remove unused includes
2017-06-14 00:49:11 +02:00
Samuel Attard
29dbb93f16
Don't mutate the accelerator character wuth the shift key if it's a number
2017-06-13 20:29:54 +10:00
Heilig Benedek
f8d3b363ea
🎨 lint fix
2017-06-08 09:57:24 +02:00
Heilig Benedek
0f4341da42
add zoom behaviour code from chromium and make pdf viewer use manual zoom behaviour to match chromium
2017-06-08 02:15:17 +02:00
Shubham
c2603aaac2
🎨 Add documentation
2017-06-03 11:48:18 -04:00
Shubham
217ddd629d
🍎 Fix incorrect extension when filters is used
2017-05-28 15:20:22 -04:00
Heilig Benedek
192cd7787b
move popup related code to nativewindow
2017-05-26 03:39:36 +02:00
Birunthan Mohanathas
19555bbab2
Use last selected directory when using default file name in dialog.showSaveDialog()
...
Prior to this change, attempting to use
`dialog.showSaveDialog({ defaultPath: 'foo.png' })` would open the save
dialog to the current directory with the default file name set to
`foo.png`. We now use the last selected directory instead of the current
directory.
Absolute paths are not affected by this change.
2017-05-26 02:18:23 +03:00
gellert
039908a244
various fixes for macos
2017-05-23 11:41:59 +02:00
Heilig Benedek
df911593d8
Fix menubar animations being incorrect in RTL layout
2017-05-21 22:36:10 +02:00
Heilig Benedek
218e28b136
minor fixes and enable datalist elements in OSR
2017-05-21 19:55:19 +02:00
Heilig Benedek
4949531f57
🎨 lint fix
2017-05-19 21:52:18 +02:00
Heilig Benedek
f360104bee
add datalist element view
2017-05-19 21:36:37 +02:00
Kevin Sawicki
de38461a3f
Update NotifyObserversCertDBChanged call to take no arguments
2017-05-10 10:05:48 -07:00
Kevin Sawicki
fb85b26767
Merge remote-tracking branch 'origin/master' into chrome58
2017-05-10 09:42:19 -07:00
Kevin Sawicki
eebae82bc1
Merge pull request #9315 from electron/segmented-control-mode
...
Add mode prop to segmented touch bar control
2017-05-04 14:16:28 -07:00
Kevin Sawicki
110611f242
🎨
2017-05-03 16:22:56 -07:00
Samuel Attard
718dc732ad
Add docs and add isSelected arg
2017-05-03 20:25:50 +10:00
Brendan Forster
e5648072dc
handle untrusted root as well as self-signed
2017-05-02 11:25:51 +10:00
Brendan Forster
14f29e1319
it's 2017 get with the times
2017-04-29 19:29:07 +10:00
Brendan Forster
1ccc2afb03
underscore case all the things
2017-04-29 19:28:42 +10:00
Samuel Attard
225ccab3d2
Add mode prop to segmented touch bar control
2017-04-28 14:50:58 +10:00
Cheng Zhao
8c5fd76286
Fix symbol conflicts in Xlib.h
2017-04-27 16:34:52 +09:00
Cheng Zhao
b3d60bfb3a
Fix building on Linux
2017-04-27 16:34:52 +09:00
Cheng Zhao
b2b2d8d9a4
Fix crash on exit
2017-04-27 16:34:52 +09:00
Cheng Zhao
d85b58fdb5
Fix API changes of FrameSubscriber
2017-04-27 16:34:52 +09:00
Cheng Zhao
481b04358e
Fix blink API changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
6be10ffef2
Fix more API changes due to name changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
50e3bfa764
Fix API changes of base::Value
2017-04-27 16:34:52 +09:00
Brendan Forster
a1599cf881
focus on the self-signed certificate flow here
2017-04-27 15:06:23 +10:00
Brendan Forster
5151107c28
tighten up indenting
2017-04-27 15:01:55 +10:00
Brendan Forster
80212c0ab4
actually validate the chain before adding
2017-04-27 14:44:58 +10:00
