trop[bot]
db72ce78f5
fix: broken transparent window styles on resizable change ( #48501 )
...
* fix: wrong api call
Co-authored-by: zoy <zoy-l@outlook.com>
* fix: consistency of the resize state
Co-authored-by: zoy <zoy-l@outlook.com>
* fix: edge cases
Co-authored-by: zoy <zoy-l@outlook.com>
* chore: add detailed comments
Co-authored-by: zoy <zoy-l@outlook.com>
* fix: lint
Co-authored-by: zoy <zoy-l@outlook.com>
* chore: only windows
Co-authored-by: zoy <zoy-l@outlook.com>
* chore: use transparent
Co-authored-by: zoy <zoy-l@outlook.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: zoy <zoy-l@outlook.com>
2025-10-10 11:36:22 -04:00
trop[bot]
238022c5cd
docs: add note for node_modules for Yarn and pnpm ( #48495 )
...
* Add instructions on using node_modules with Yarn
* update text for pnpm
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2025-10-09 10:31:24 +02:00
trop[bot]
f0a130a70c
docs: clarify postinstall requirements ( #48498 )
...
postinstall
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2025-10-09 10:29:37 +02:00
trop[bot]
f95094c7fd
build: bump version in .nvmrc to 22 ( #48491 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2025-10-08 17:02:34 -04:00
electron-roller[bot]
e630f7b4ba
chore: bump node to v22.20.0 (39-x-y) ( #48382 )
...
* chore: bump node in DEPS to v22.20.0
* chore: fixup patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-10-08 11:53:55 -04:00
trop[bot]
00035f8435
feat: add fileSystem to ses.setPermissionCheckHandler ( #48326 )
...
feat: add fileSystem to ses.setPermissionCheckHandler
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-10-08 10:44:46 +02:00
trop[bot]
ec92fbcd67
fix: set ozone platform for wayland ( #48310 )
...
* fix: set ozone platform for wayland
Co-authored-by: clavin <clavin@electronjs.org>
* whoops, includes. thx charles
Co-authored-by: clavin <clavin@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
2025-10-07 11:27:45 +02:00
trop[bot]
addd12717c
build: fixup chromedriver and mksnapshot ( #48479 )
...
* build: update build tools to get proper exit codes from e build
xref: https://github.com/electron/build-tools/pull/759
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* build: target zips directly
mksnapshot and chromedriver have issues with siso trying to run a separate build and zip step, so just target the zip target
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* build: don't unzip chromedriver and mksnapshot in tests
The contents of these files are not used in testing, so we shouldn't unzip them.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-10-07 11:08:17 +02:00
trop[bot]
3c6b66c0fb
build: handle Metal toolchain being unbundled from Xcode 26 ( #48472 )
...
* chore: add metal patch dir
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
* chore: cherry-pick 2f564f1ca07b from angle (#48465 )
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
* chore: update patch
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
2025-10-06 14:32:28 -07:00
trop[bot]
d122cd6e09
perf: avoid a little extra work in InvokeIpcCallback() ( #48466 )
...
perf: two minor perf refactors in InvokeIpcCallback()
1. Allocate the CallbackScope on the stack instead of the heap
2. Skip a redundant call to node::Environment::GetCurrent()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-10-06 12:10:08 -05:00
trop[bot]
fbc5ff26e2
docs: recommend calling renderer process modules from preload script ( #48461 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-10-04 17:23:34 -05:00
trop[bot]
9310c5261c
docs: clarify optional args in webFrame.executeJavaScript() ( #48458 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-10-04 18:44:42 +02:00
trop[bot]
0a476e8fc5
docs: mention that webUtils should be used via preload script ( #48453 )
...
docs: mention that webUtils should be used via preload script (#45861 )
* docs: mention that webUtils should be used via preload script
* docs: suppress lint errors
* docs: clarify webUtils usage scope
* docs: exclude potentially dangerous alert() in the example code
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: minor change
* docs: make linter happy
* docs: apply suggestion
* docs: apply suggestion
* docs: apply suggestion
* docs: minor change
* docs: minor change
* docs: remove preload line
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kaiichiro Ota <kigh.ota@gmail.com>
2025-10-03 15:47:40 -05:00
trop[bot]
81c17ef684
fix: accentColor set distinguishes the frame ( #48450 )
...
* fix: accentColor set distinguishes the frame
Co-authored-by: zoy <zoy-l@outlook.com>
* chore: invalid change
Co-authored-by: zoy <zoy-l@outlook.com>
* fix: lint
Co-authored-by: zoy <zoy-l@outlook.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: zoy <zoy-l@outlook.com>
2025-10-03 15:31:36 -05:00
trop[bot]
49aa969139
fix: initialze featurelist before parsing features ( #48442 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-10-02 20:58:57 -05:00
trop[bot]
845adc3ea7
docs: update allowed window.open options ( #48443 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-10-02 20:58:25 -05:00
trop[bot]
9d97988c05
fix: snapped window restoring to correct position ( #48438 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-10-03 00:11:53 +02:00
trop[bot]
29d60d9b50
fix: runtime JS error that crashes GetPackageJSON ( #48425 )
...
We overriden the `GetPackageJSON` in Node.js to let us read files
straight from the ASAR file instead of disk. The override works by
providing a JS method with the limitation that it should not throw a
runtime error. However, this invariant was accidentally violated by
`asar.splitPath` that sometimes contrary to its' TypeScript definition
returned `false`.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Fedor Indutny <indutny@signal.org>
2025-10-02 18:16:28 +02:00
trop[bot]
797e534385
docs: fix formatting in asar integrity ( #48432 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2025-10-01 23:41:03 -07:00
trop[bot]
d79810af33
build: add missing copied tarball to cloudstore paths ( #48417 )
...
It's guarunteed that `iojs-*` and `node-*` were the same origin file (we azcopy them) but this was missing in logs and it annoyed me
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sam@electronjs.org>
2025-09-30 18:35:33 +02:00
trop[bot]
918a08f1e4
fix: add missed enum SaveRequestType to PdfViewerPrivate function ( #48404 )
...
fix: add missed SaveRequestType enum to PdfViewerPrivate function
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Bill Shen <15865969+cucbin@users.noreply.github.com>
2025-09-29 20:08:42 +02:00
trop[bot]
c15d8a4a37
fix: MacOS 26 Tahoe - stop overriding private cornerMask API to fix WindowServer GPU load ( #48399 )
...
fix: MacOS 26 Tahoe - stop overriding private cornerMask API to fix WindowServer GPU load (#48376 )
fix: macOS stop overriding private cornerMask API to fix WindowServer GPU load spike
Electron fetched a custom `_cornerMask` for `ElectronNSWindow` to smooth
vibrancy corners. On macOS 15 (Tahoe) that private hook forces the window
shadow to be rendered from a fully transparent surface, causing the
WindowServer GPU load regression. Remove the `cornerMask` property and
the `_cornerMask` override so we stay on Apple’s default shadow path.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: avarayr <7735415+avarayr@users.noreply.github.com>
2025-09-27 10:30:18 -07:00
trop[bot]
aeb4733501
fix: disable NSAutoFillHeuristicController on macOS 26 ( #48393 )
...
fix: disable NSAutoFillHeuristicController on macOS 26 (#48379 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com>
2025-09-27 03:54:01 +09:00
John Kleinschmidt
a59beb5570
test: rerun failed tests individually ( #48386 )
...
test: rerun failed tests individually (#48205 )
* test: rerun failed tests individually
* ci: use screencapture-nag-remover
Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio.
* Revert "chore: test with 1st quadrant of the window"
No longer needed because of the addition of the
screencapture-nag-remover script.
This reverts commit f4a7e04c0b399aa9a85532f2c11fa35ad45bf71c.
* test: fixup navigationHistory flake
* rerun test up to 3 times
2025-09-26 11:43:31 -04:00
trop[bot]
f5617bbc6a
chore: bump chromium to 142.0.7417.0 (39-x-y) ( #48363 )
...
* chore: bump chromium in DEPS to 142.0.7401.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6911185: Reland "Send touch moves async immediately after scroll starts."
https://chromium-review.googlesource.com/c/chromium/src/+/6911185
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6906887: mac: click through content area in main window
https://chromium-review.googlesource.com/c/chromium/src/+/6906887
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6916667: Expose helper to eliminate duplicate recipes.
https://chromium-review.googlesource.com/c/chromium/src/+/6916667
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6909842: Switch LegacyRenderWidgetHostHWND from atlcrack.h to msg_util.h.
https://chromium-review.googlesource.com/c/chromium/src/+/6909842
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6884056: Remove the SecKeychain implementation for the Keychain interface
https://chromium-review.googlesource.com/c/chromium/src/+/6884056
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6904906: Remove `WTF::` in renderer/core/[p-x].*/
https://chromium-review.googlesource.com/c/chromium/src/+/6904906
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6556585: [persistent_cache]: PersistentCache for CodeCache
https://chromium-review.googlesource.com/c/chromium/src/+/6556585
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6904864: Layout: Support abort on the text placeholder layout
https://chromium-review.googlesource.com/c/chromium/src/+/6904864
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fixup patch indices
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: bump chromium in DEPS to 142.0.7402.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* fixup! 6556585: [persistent_cache]: PersistentCache for CodeCache
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fixup patch indices
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6905244: [api] Remove deprecated `GetIsolate`
https://chromium-review.googlesource.com/c/v8/v8/+/6905244
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6897694: Remove NativeTheme::UserHasContrastPreference().
https://chromium-review.googlesource.com/c/chromium/src/+/6897694
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6897477: Remove GetPlatformHighContrastColorScheme() and enum.
https://chromium-review.googlesource.com/c/chromium/src/+/6897477
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6918198: Reland "Rename display::Screen::GetScreen() to display::Screen::Get()"
https://chromium-review.googlesource.com/c/chromium/src/+/6918198
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6907147: [LNA] add use counter for websocket mixed-content issues
https://chromium-review.googlesource.com/c/chromium/src/+/6907147
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6914538: Replace WTF::String with blink::String
https://chromium-review.googlesource.com/c/website/+/6914538
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6892538: [video pip] Allow touchscreen users to toggle live caption
https://chromium-review.googlesource.com/c/chromium/src/+/6892538
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fix patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: bump chromium in DEPS to 142.0.7403.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* build: remove ninja logs
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fixup patch indices
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6920670: [PDF] Change pdf_extension_util to return dictionaries
https://chromium-review.googlesource.com/c/chromium/src/+/6920670
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6917864: Devirtualize and inline various NativeTheme getters.
https://chromium-review.googlesource.com/c/chromium/src/+/6917864
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6920873: [PDF] Simplify PDFDocumentHelperClient::OnSaveURL()
https://chromium-review.googlesource.com/c/chromium/src/+/6920873
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* build: don't kill blink/web_tests
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6923655: Roll libc++ from 954086abf121 to b87b2bb112f8 (4 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/6923655
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6905242: Reland "[CSP] Clarify report-only console messages."
https://chromium-review.googlesource.com/c/chromium/src/+/6905242
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fixup! 6897694: Remove NativeTheme::UserHasContrastPreference().
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: bump chromium in DEPS to 142.0.7405.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6910012: [LNA] Enable LNA enforcement by default
https://chromium-review.googlesource.com/c/chromium/src/+/6910012
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6929444: Combine GetInstanceForXXX() implementations.
https://chromium-review.googlesource.com/c/chromium/src/+/6929444
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6927873: Rename native_widget_types.h -> native_ui_types.h
https://chromium-review.googlesource.com/c/chromium/src/+/6927873
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6853978: Init perfetto really early in WebView
https://chromium-review.googlesource.com/c/chromium/src/+/6853978
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6874886: Use only one picker observer to avoid getting duplicate notifications
https://chromium-review.googlesource.com/c/chromium/src/+/6874886
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fixup patch indices
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: Protocol complex inline dtor
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: bump chromium in DEPS to 142.0.7407.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 142.0.7409.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 142.0.7411.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 142.0.7413.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6927233: Remove NativeTheme "use dark colors" bit.
https://chromium-review.googlesource.com/c/chromium/src/+/6927233
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fixup patch indices
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 6899206: [PermissionOptions] Multi-state permission subscriptions & setting changes
https://chromium-review.googlesource.com/c/chromium/src/+/6899206
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: bump chromium in DEPS to 142.0.7415.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6936895: [headless] Remove headless flag from views::Widget class
https://chromium-review.googlesource.com/c/chromium/src/+/6936895
We should probably followup on this to see if there is a way to do this without reverting this CL.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* 6937023: Reland "Use new DBus type system in dbus_xdg::Request"
https://chromium-review.googlesource.com/c/chromium/src/+/6937023
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* 6944749: Add GN visibility list to //components/os_crypt/sync
https://chromium-review.googlesource.com/c/chromium/src/+/6944749
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Further replace sub_capture_target_version with CaptureVersion
https://chromium-review.googlesource.com/c/chromium/src/+/6935455
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup for lint
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: update filenames.libcxx.gni
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: bump chromium in DEPS to 142.0.7417.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6944136: Reorder NativeTheme headers/.cc files.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944136
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* 6939701: [DSSC][4] Make FSVCI objects aware of their capture-version-source
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6939701
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* 6944404: Remove extraneous callback call
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944404
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* 6936124: [FPF-CI]: Introduce blink::NoiseToken for fingerprinting protection
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6936124
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* chore: update patches
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fixup! 6917864: Devirtualize and inline various NativeTheme getters.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6917864
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* 6937588: Add initial OsSettingsProvider object, supplying caret blink interval.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6937588
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6905242
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* 6907515: Replace SingletonHwndObserver with a CallbackList on SingletonHwnd.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6907515
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* 6910482: [Save to Drive] Implement retry functionality
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6910482
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* Revert "build: remove ninja logs"
This reverts commit 72874740fdfca4101404ce7855e976791cfc79ef.
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com>
* test: fix flakey test picked from PR 48205
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com>
2025-09-24 11:56:54 -04:00
trop[bot]
12ca994b50
docs: mention setContentProtection macOS limitations ( #48366 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-09-23 17:03:50 -05:00
trop[bot]
b3069de952
build: update build tools to get siso for forks fix ( #48346 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-09-18 09:33:20 -04:00
Robo
40fb7621a9
fix: remove unneeded handlescope from JS callbacks ( #48344 )
...
fix: remove unneeded handlescope from JS callbacks (#48318 )
fix: remove handlescope from JS callbacks
2025-09-18 08:47:26 +09:00
Keeley Hammond
93ef8abd99
chore: cherry-pick ec6c18478382 from v8 ( #48336 )
...
* chore: cherry-pick ec6c18478382 from v8
* chore: update patches
2025-09-16 19:09:16 -07:00
trop[bot]
d28e24a6c6
ci: Use Local Execution, Remote Caching (LERC) for fork PRS ( #48325 )
...
cleanup
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-09-16 09:54:28 -04:00
trop[bot]
b7139831fe
refactor: avoid unused inheritance in ServiceWorkerMain ( #48292 )
...
ServiceWorkerMain does not need to inherit from EventEmitterMixin
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-09-10 21:35:28 -05:00
trop[bot]
60826e6c7b
chore: bump chromium to 141.0.7390.7 (39-x-y) ( #48276 )
...
* chore: bump chromium in DEPS to 141.0.7381.3
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 141.0.7382.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 141.0.7384.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 141.0.7386.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* Move devtools_page and chrome_url_overrides handlers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6862700
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Reland "[api] Advance deprecation of GetIsolate"
Refs https://chromium-review.googlesource.com/c/v8/v8/+/6875273
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Move "system integrated UI" concept out of NativeTheme.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6867375
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Reland "[PermissionOptions] Return PermissionResult in callback for requests"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6851838
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Reland "[exit-time-destructors] Enable by default"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6859042
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Revoke Read access after removing file via FileSystemAccess API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6677249
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: IWYU
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Accept an object for `dispatchHttpRequest` params
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6877528
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: IWYU
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Pass navigation UI parameters on EnterFullscreen in EAM
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6874923
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: rm band-aid_over_an_issue_with_using_deprecated_nsopenpanel_api.patch
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Remove unused PreHandleMouseEvent
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6880411
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* 6878583: siso: update to version 1.4.1
https://chromium-review.googlesource.com/c/chromium/src/+/6878583
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Fold native_theme_browser into native_theme.
https://chromium-review.googlesource.com/c/chromium/src/+/6882627
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
https://chromium-review.googlesource.com/c/chromium/src/+/6859042
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: update filenames.libcxx.gni
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: IWYU
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: chore: IWYU
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Remove common_theme.*; place its method in NativeTheme instead.
https://chromium-review.googlesource.com/c/chromium/src/+/6886029
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Better track when WebPreferences need updates for color-related changes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6886797
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 141.0.7390.7
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* 6904664: Reland "Make BrowserContext::GetPath() const"
https://chromium-review.googlesource.com/c/chromium/src/+/6904664
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Restore read access after certain file modification operations
https://chromium-review.googlesource.com/c/chromium/src/+/6861041
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Move "system integrated UI" concept out of NativeTheme.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* 6906096: Remove GetSysSkColor().
https://chromium-review.googlesource.com/c/chromium/src/+/6906096
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Inline implementation of SysColorChangeListener into the lone user.
https://chromium-review.googlesource.com/c/chromium/src/+/6905083
Also 6906096: Remove GetSysSkColor(). | https://chromium-review.googlesource.com/c/chromium/src/+/6906096
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: 6906096: Remove GetSysSkColor()
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-09-08 17:08:42 -04:00
electron-roller[bot]
2da16d779e
chore: bump node to v22.19.0 (39-x-y) ( #48255 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-09-08 09:48:49 +02:00
trop[bot]
c6eec20a7c
build: update spec deps for clean audit ( #48250 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2025-09-03 13:50:49 -07:00
Calvin
fed73040e2
docs: move some planned breaking changes to 39 ( #48236 )
2025-09-01 14:55:11 -07:00
Shelley Vohr
828fd59a72
fix: file-only picker incorrectly allowing some directories ( #48198 )
2025-08-29 13:14:45 -04:00
Shelley Vohr
e892840975
fix: ensure dragging works again after emitting contextmenu event ( #48199 )
2025-08-29 10:37:37 -04:00
Shelley Vohr
7373173e44
fix: showMessageDialog should center dialog to parent ( #48181 )
2025-08-29 09:56:51 +02:00
electron-roller[bot]
5d5e672f17
chore: bump chromium to 141.0.7361.0 (main) ( #48054 )
...
* chore: bump chromium in DEPS to 141.0.7352.0
* chore: update patches
* 6830573: Revert 'Migrate WrappableWithNamedPropertyInterceptor to gin::Wrappable' | https://chromium-review.googlesource.com/c/chromium/src/+/6830573
* chore: bump chromium in DEPS to 141.0.7354.0
* chore: bump chromium in DEPS to 141.0.7356.0
* chore: bump chromium in DEPS to 141.0.7357.0
* chore: bump chromium in DEPS to 141.0.7359.0
* chore: bump chromium in DEPS to 141.0.7361.0
* 6838518: [Mac] Correctly deallocate sandbox error buffers and prevent crash resulting from nullptr assignment | https://chromium-review.googlesource.com/c/chromium/src/+/6838518
* 6850973: Reland "Use base::ByteCount in base::SysInfo." | https://chromium-review.googlesource.com/c/chromium/src/+/6850973
* 6506565: [FPF-CI] Create initial NoiseHash in the browser. | https://chromium-review.googlesource.com/c/chromium/src/+/6506565
* chore: update patches
* fixup! 6850973: Reland "Use base::ByteCount in base::SysInfo." | https://chromium-review.googlesource.com/c/chromium/src/+/6850973
* fixup! 6506565: [FPF-CI] Create initial NoiseHash in the browser. | https://chromium-review.googlesource.com/c/chromium/src/+/6506565
* fix: unsafe buffer warning in fix_properly_honor_printing_page_ranges.patch
* fix: FTBFS in src_remove_dependency_on_wrapper-descriptor-based_cppheap.patch
This change should be upstreamed.
Fixes this error:
../../third_party/electron_node/src/env.cc:606:3: error: no matching function for call to 'Wrap'
606 | v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../v8/include/v8-object.h:1076:14: note: candidate function template not viable: cannot convert argument of incomplete type 'void *' to 'v8::Object::Wrappable *' for 3rd argument
1076 | void Object::Wrap(v8::Isolate* isolate, const v8::Local<v8::Object>& wrapper,
| ^
1077 | v8::Object::Wrappable* wrappable) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../v8/include/v8-object.h:1084:14: note: candidate function template not viable: no known conversion from 'Local<Object>' to 'const PersistentBase<Object>' for 2nd argument
1084 | void Object::Wrap(v8::Isolate* isolate, const PersistentBase<Object>& wrapper,
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../v8/include/v8-object.h:1093:14: note: candidate function template not viable: no known conversion from 'Local<Object>' to 'const BasicTracedReference<Object>' for 2nd argument
1093 | void Object::Wrap(v8::Isolate* isolate,
| ^
1094 | const BasicTracedReference<Object>& wrapper,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
* [v8-init] Access crash key only from main thread | https://chromium-review.googlesource.com/c/chromium/src/+/6827167
* chore: e patches all
* chore: remove chore_restore_some_deprecated_wrapper_utility_in_gin.patch from patches
this remove line got re-added when rebasing roller/chromium/main
* chore: e patches all
* fix: include base/time/time.h when using base::Time
* chore: update patches
* Make --host-rules an alias for --host-resolver-rules.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4867872
* ci: update BUILD_TOOLS_SHA
Refs https://github.com/electron/build-tools/pull/746
* [Fontations] Remove Fontations suffix from font names
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6835930
* temp: debug macOS addon build failure
* Revert "temp: debug macOS addon build failure"
This reverts commit 40bc8abab65dc83e17c4ab97cb6e7522a193fb44.
* test: run tests with Xcode 16.4
* ci: fix tccdb update for macOS 15
* spec: disable opening external application for loadURL
on macOS opening unknown external application will bring
up dialog to choose apps from application store which will
break our other test suites that want to capture screen
for pixel matching.
The loadURL spec that tests bad-scheme://foo is sufficient
that we hit the permission handler for openExternal since
at that point we already know the runtime gave up on handling
the scheme.
* chore: rebase patches
* chore: disable codesiging tests
* ci: update ScreenCaptureApprovals.plist for /bin/bash
* ci: try updating tcc permissions
* ci: update TCC permissions
Refs https://www.rainforestqa.com/blog/macos-tcc-db-deep-dive
* chore: test with 1st quadrant of the window
* chore: adjust for macOS 15 menubar height
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-08-29 12:31:47 +09:00
LZL
e39943bf45
fix: BrowserWindow add the same BrowserView ( #48053 )
...
fix: BrowserWindow add the same BrowserView (#48057 )
2025-08-28 10:31:41 +02:00
David Sanders
f331606e07
build: bump NMV to 140 ( #48196 )
2025-08-27 18:57:00 -07:00
David Sanders
cca55117e4
build: refactor Linux binary stripping to align with upstream ( #47932 )
2025-08-27 18:56:31 -07:00
Erick Zhao
bf29d2f0bd
docs: fix some module headings ( #48177 )
2025-08-27 14:52:26 -07:00
John Kleinschmidt
fea1a2a987
ci: use free GH arm runners ( #47872 )
2025-08-27 10:01:36 -04:00
dependabot[bot]
a51c56aca9
build(deps): bump amannn/action-semantic-pull-request from 6.0.1 to 6.1.1 ( #48175 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 6.0.1 to 6.1.1.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](fdd4d3ddf6...48f256284b )
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-version: 6.1.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-27 13:52:36 +02:00
dependabot[bot]
89f25e6af3
build(deps): bump github/codeql-action from 3.29.10 to 3.29.11 ( #48174 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.29.10 to 3.29.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](96f518a34f...3c3833e0f8 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.11
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-27 13:49:43 +02:00
Robo
e0db4046b2
refactor: allocate gin_helper::internal::Event on cpp heap ( #48161 )
2025-08-27 09:30:50 +09:00
Calvin
3b9130d815
docs: add release timeline for Electron 39 ( #48167 )
2025-08-26 14:19:56 -07:00
Shelley Vohr
52ed4646d9
chore: remove upstream OSR temp fix ( #48162 )
2025-08-26 16:22:45 -04:00
John Kleinschmidt
68098c317f
build: remove no longer needed arg for siso ( #48164 )
...
* build: remove no longer needed arg for siso
* chore: test ffmpeg zip
* build: fix ffmpeg build with siso
* Revert "chore: test ffmpeg zip"
This reverts commit 2bbcc86039eca435b4ab9ced6fd59f761fee2fd5.
2025-08-25 16:46:36 -04:00