Commit graph

638 commits

Author SHA1 Message Date
ali.ibrahim
4eb9fc1bb6 Adding chunked uploading test. 2016-10-12 14:54:29 +02:00
ali.ibrahim
9b94dfcbdc Adding basic http tests, fixing issues in ClientRequest constructor. 2016-10-12 14:54:29 +02:00
ali.ibrahim
42bae9d71d Making the HTTP response a full-fledged Readable stream. 2016-10-12 14:54:27 +02:00
ali.ibrahim
ec1fc5a17b Implementing error, close, finish, abort events management. 2016-10-12 14:54:24 +02:00
ali.ibrahim
42adb2afd4 Fixing lint-js issues. 2016-10-12 14:54:22 +02:00
ali.ibrahim
08947682b0 Implementing abort workflow, emitting error events. 2016-10-12 14:54:21 +02:00
ali.ibrahim
cbbc4376ca Adding support for upload chunked encoding. 2016-10-12 14:54:20 +02:00
ali.ibrahim
9498a5738a Refactoring net module, adding a ClientRequest and IncomingMessage classes. 2016-10-12 14:54:20 +02:00
ali.ibrahim
fcaf9cb031 Some code cleaning. 2016-10-12 14:54:19 +02:00
ali.ibrahim
f7525d7877 Adding support for POST requests. 2016-10-12 14:54:18 +02:00
ali.ibrahim
2b3b41d5f9 Implementing authentication callback. 2016-10-12 14:54:18 +02:00
ali.ibrahim
2d9d4af98d Implementing URLRequest API, getting response body. 2016-10-12 14:54:17 +02:00
ali.ibrahim
81eab9887b Adding URLResponse to emit response events, implementing status code. 2016-10-12 14:54:16 +02:00
ali.ibrahim
7521aeea09 Implement URLRequest::Delegate, handle thread sync. 2016-10-12 14:54:15 +02:00
ali.ibrahim
e8d4abe78f Adding net module and URLRequest class. 2016-10-12 14:54:15 +02:00
Zeke Sikelianos
d4a8a64ba7 Merge pull request #7498 from electron/custom-props-in-menu-item-constructor
Preserve custom properties passed to MenuItem constructor
2016-10-11 14:24:13 -07:00
Zeke Sikelianos
8aaf029e55 remove unused var 2016-10-10 15:38:27 -07:00
Zeke Sikelianos
b575055d7e inherit user-specific MenuItem properties more safely 2016-10-10 14:40:49 -07:00
Zeke Sikelianos
2cd10d339f remove duplicated prop copying 2016-10-10 11:07:01 -07:00
Cheng Zhao
91591f37e6 Merge pull request #7500 from electron/store-crashes-in-configured-temp-dir
Store crash reports in configured temp dir
2016-10-10 10:19:02 +09:00
Samuel Attard
09e5035ab5
Default webPreferences to empty object always 2016-10-07 11:45:13 +11:00
Zeke Sikelianos
b7e078e98d sanitize MenuItem options 2016-10-06 14:37:13 -07:00
Kevin Sawicki
d39182b41a Pass crashes directory instead of product name and temp dir 2016-10-06 10:55:11 -07:00
Kevin Sawicki
16e3991ffa Guard against app.getPath throwing with OS fallback 2016-10-06 10:07:40 -07:00
Kevin Sawicki
883c4b63d0 temp_path -> temp_dir 2016-10-06 09:02:02 -07:00
Kevin Sawicki
0380d3ae50 Pass crashes directory to crash service process 2016-10-06 09:02:02 -07:00
Kevin Sawicki
43702e0f8e Support calling getUploadedReports on unstarted crash reporter 2016-10-06 09:02:02 -07:00
Kevin Sawicki
a0db484510 Use app.getPath directly for temp path 2016-10-06 09:02:02 -07:00
Kevin Sawicki
f282b51c98 🎨 Use ES6 class, destructuring, and let/const 2016-10-06 09:02:01 -07:00
Kevin Sawicki
ac0658bbf1 Use PathService for temp dir path for crashes 2016-10-06 09:02:01 -07:00
Zeke Sikelianos
16b3962b66 preserve custom properties passed to MenuItem constructor 2016-10-05 12:24:08 -07:00
Michael Vasseur
3dd41bc09a Fix errors 2016-10-05 11:46:55 +02:00
Michael Vasseur
9490ec7686 Fix JS Lint issues 2016-10-05 09:47:39 +02:00
Michael Vasseur
a2b3cf95a7 Sets correct openerId in mergeBrowserWindowOptions() to give correct options to 'new-window' event handler 2016-10-05 09:47:39 +02:00
Michael Vasseur
cc7f4fedf6 Rebase with recent changes 2016-10-05 09:47:39 +02:00
Michael Vasseur
3408c8038e Fix indentation 2016-10-05 09:47:38 +02:00
Michael Vasseur
5a4cdcfde1 'new-window' event handlers can return their window when default behavior is prevented 2016-10-05 09:46:54 +02:00
Michael Vasseur
c811188e22 Updated required code to handle missing additional features for popup windows 2016-10-04 14:38:32 +09:00
Kevin Sawicki
24bcf6ac16 Add initial cookie changed event support 2016-09-29 09:16:29 -07:00
Cheng Zhao
734f42b5f9 Merge pull request #7319 from Menci/master
Workaround for electron/electron#5050
2016-09-29 16:42:30 +08:00
Menci
ca68dfe097 🎨 Remove extra semicolon 2016-09-28 06:45:15 +08:00
Cheng Zhao
458c4dd129 Merge branch 'support-chromium-sandbox' of https://github.com/tarruda/electron into tarruda-support-chromium-sandbox 2016-09-27 20:02:23 +08:00
Menci
ef45b67dbf 🐧 🐛 Move the workaround to lib/browser/init.js 2016-09-27 19:19:52 +08:00
Thiago de Arruda
a64978b812 Use the routing id on api::WebContents::GetID
The sandbox option allows multiple webContents in one renderer process, so using
the only the renderer id to identify WebContents instances is no longer an
option.

WebContents::GetID now returns a 64-bit integer, which is composed of both the
process id(high 32), and the RenderViewHost routing id(low 32). Also add a
`GetProcessID` that retrieves the renderer process id, a requirement in some of
our javascript code.
2016-09-27 06:01:47 -03:00
Thiago de Arruda
72154b64ed Embed setup bundle for preload scripts in sandboxed renderers.
Add a gyp target that creates a browserify bundle starting with
`lib/sandboxed_renderer/init.js`, which is embedded into the executable using
the `atom_js2c` target.

The goal of this bundle is to provide a very basic environment for preload
scripts where a `require` function is available.
2016-09-27 06:01:47 -03:00
Thiago de Arruda
695509e267 Add browser side support for reading files from renderer. 2016-09-27 06:01:46 -03:00
Thiago de Arruda
0f7652dc85 Move code that defines ipcRenderer methods into another file. 2016-09-27 06:01:46 -03:00
Thiago de Arruda
06cc9a44fe Add support for native chromium popups on sandboxed renderers.
- Allow `api::Window` instances to be created from existing `api::WebContents`.
- Override `WebContentsCreated` and `AddNewContents` to wrap renderer-created
  `content::WebContents` into `api::WebContents`.
- For `content::WebContents` that should be displayed in new windows, pass the
  wrapped `api::WebContents` object to window manager.
2016-09-27 06:01:46 -03:00
Menci
938b9e897a 🐧 🐛 Workaround for electron/electron#5050
Chromium only show the Tray icon with libappindicator when the env `XDG_CURRENT_DESKTOP`'s value is `Unity`. But under elementaryOS its value is 'Pantheon'.

Set it to `Unity` before app startup make the tray icon show under elementaryOS.
2016-09-23 18:07:43 +08:00
Zeke Sikelianos
56d62ff589 add html doctype 2016-09-22 14:47:20 -07:00
Zeke Sikelianos
62375663ab add type to webview style tag 2016-09-22 14:34:03 -07:00
Cheng Zhao
e3e450613d Merge pull request #7157 from Mossop/moveguest
Allow moving a webcontents to a different webview
2016-09-20 14:28:42 +09:00
Kevin Sawicki
48fd2bd35f binding -> bindings 2016-09-19 09:31:59 -07:00
Felix Rieseberg
29fa48d8c3 🔧 Ensure correct types for commandLine
This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding.
2016-09-19 09:31:59 -07:00
Felix Rieseberg
90bff4d9de 🔧 Ensure correct types for commandLine
This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding.
2016-09-19 09:31:59 -07:00
Cheng Zhao
0ac4b89a0a Merge pull request #7236 from yuya-oc/accelerator-for-redo
Use Ctrl+Y as the accelerator of redo on Windows
2016-09-19 15:53:44 +09:00
Yuya Ochiai
43f955194e 🏁 Use Ctrl+Y as the accelerator of redo on Windows 2016-09-18 17:07:34 +09:00
Kevin Sawicki
e77d7e7f62 🎨 2016-09-16 11:41:53 -07:00
Kevin Sawicki
5d0f3534eb Rethrow binding errors 2016-09-16 11:34:52 -07:00
Kevin Sawicki
eef42770c6 Don't load remote properties until they are accessed 2016-09-14 13:29:49 -07:00
Kevin Sawicki
359ab2f9b3 Only set members when members exist 2016-09-14 10:54:23 -07:00
Cheng Zhao
df3f0a4516 Merge pull request #7175 from bsuh/fix-twitch-navigation
Fix navigation controller
2016-09-13 16:01:00 +09:00
Cheng Zhao
9a56959647 Merge pull request #7140 from liusy182/url-fix
fix a bug in navigation-controller where string is used as object
2016-09-12 14:46:05 +09:00
Brian Suh
5fc1f57fb5 Fix navigation controller
In-page navigation has not actually started if the current entry is
being replaced. Do not set inPageIndex if replaceEntry is true.
2016-09-11 14:46:17 -07:00
Dave Townsend
313b2faa3c Add a guestinstance attribute to webviews reflecting their current guest
instance ID and allowing moving a guest instance to a new webview.
2016-09-09 10:32:05 -07:00
Cheng Zhao
693ba1375b Merge pull request #7146 from electron/resolve-empty-url-values
Tweak how empty URLs are resolved
2016-09-09 19:58:41 +09:00
Kevin Sawicki
daf1eec5ec Use === for string comparison 2016-09-08 17:11:10 -07:00
Kevin Sawicki
1dbaf4987e Don't resolve empty src/preload attribute values 2016-09-08 16:48:30 -07:00
Kevin Sawicki
9829baed46 Open about:blank when window.open is called with no URL 2016-09-08 16:10:21 -07:00
Kevin Sawicki
d476227e16 Remove unneeded return 2016-09-08 10:20:39 -07:00
Kevin Sawicki
902bd0564e Require Buffer explicitly instead of relying on global 2016-09-08 10:17:06 -07:00
liusy182
2c7690be45 simplify logic 2016-09-08 21:36:39 +08:00
liusy182
180a77e671 fix a minor bug in navigation-controller where a string is used as an object 2016-09-08 21:31:42 +08:00
Kevin Sawicki
28b33074cf Setup stdin in both processes on Windows 2016-09-07 14:45:56 -07:00
Cheng Zhao
e561608c0d Merge pull request #7116 from electron/restore-no-asar
Restore process.noAsar in finally block
2016-09-07 16:50:26 +09:00
Kevin Sawicki
46fbb6ed61 Reset process.noAsar in finally block 2016-09-06 13:40:25 -07:00
Kevin Sawicki
b54b74c310 Prevent missing Menu.buildFromTemplate function 2016-09-06 11:31:14 -07:00
Cheng Zhao
f854b27bfb Merge pull request #6867 from electron/remote-function-properties
Allow accessing remote function properties
2016-08-31 17:28:09 +09:00
Kevin Sawicki
01e69353d5 Don't serialize ArrayBuffer as Array 2016-08-24 15:18:42 -07:00
Kevin Sawicki
ec44a5d198 Add tests for setting remote function properties 2016-08-22 17:07:18 -07:00
Kevin Sawicki
666a668d91 Support remote function keys and property descriptors 2016-08-22 17:07:18 -07:00
Kevin Sawicki
d226b7bc6c Use Proxy for accessing properties of remote function 2016-08-22 17:07:18 -07:00
Kevin Sawicki
8b38018ab4 Add helper for including function properties 2016-08-22 17:07:17 -07:00
Kevin Sawicki
3245bb99b2 Only register methods with members 2016-08-22 17:07:17 -07:00
Kevin Sawicki
d333cc5e38 Support remote function properties 2016-08-22 17:07:17 -07:00
Cheng Zhao
faebe5259d Merge pull request #6861 from megahertz/bug_window_location
Apply resolveURL when set a location of a window opened by window.open()
2016-08-17 22:04:46 +09:00
Alexey Prokhorov
16f2702495 Apply resolveURL when set a location of a window opened by window.open() 2016-08-16 16:24:49 +05:00
bridiver
3b11bf5e41 clear the storage for the webContentsId when the render view is deleted 2016-08-15 21:53:58 -07:00
Samuel Attard
5b07e8dd5b
Send isMainFrame as argument to did-navigate-in-page event 2016-08-12 01:27:50 +10:00
Cheng Zhao
01f92a83ab Merge pull request #6780 from electron/update-available-check
Mark update available until restart
2016-08-09 20:44:26 +09:00
Kevin Sawicki
dd6c69c90b Use const instead of var 2016-08-08 13:07:01 -07:00
Kevin Sawicki
49908fd818 Keep update available flag set until restart 2016-08-08 13:03:02 -07:00
Kevin Sawicki
af607f8b67 🎨 function -> => 2016-08-08 11:09:30 -07:00
Kevin Sawicki
bcc372568f Add zoom menu item roles 2016-08-08 11:09:30 -07:00
Milan Burda
edc1a9614c Add macOS specific speaking roles for MenuItem 2016-08-08 00:02:32 +02:00
Cheng Zhao
8c0a033b6f Fix lint errors of using __proto__ 2016-08-02 21:02:28 +09:00
Cheng Zhao
edb573d69e Make WebContents inherit NavigationController 2016-08-02 20:55:56 +09:00
Cheng Zhao
025034127a Set JavaScript APIs on prototype of WebContents 2016-08-02 20:52:07 +09:00
Cheng Zhao
844f32aa36 Set prototype of constructor directly 2016-08-02 20:38:35 +09:00
Cheng Zhao
895b8b47ee Save the prototype of EventEmitter 2016-08-02 18:07:58 +09:00
Cheng Zhao
892026458d Cleanup init.js 2016-08-02 17:45:46 +09:00
Cheng Zhao
6e0cde5b24 All native objects have prototype now 2016-08-02 17:12:17 +09:00
Cheng Zhao
56b1abd64a Merge pull request #6685 from electron/document-contents-zoom
Implement and Document the zoom methods that are mapped to the webContents object
2016-08-02 14:41:09 +09:00
Samuel Attard
a498cf5b79 Fix linting issues 2016-08-02 13:13:17 +10:00
Samuel Attard
e4f6083753 Implement asynchronous versions of getZoomFactor and GetZoomLevel on the webContents object 2016-08-02 13:02:55 +10:00
Gabriel Handford
7bde92deb9 Add isVisible() to app.dock 2016-08-01 15:22:37 -07:00
Cheng Zhao
ffed3e9c0c Move the code to native 2016-08-01 20:11:17 +09:00
Cheng Zhao
d23d9dcf01 Do not garbage collect sessions 2016-08-01 19:35:51 +09:00
Cheng Zhao
1e61743242 Merge pull request #6602 from electron/appusermodelid-remove-spaces
Remove all spaces from potential appUserModelID as it isn't allowed by the spec
2016-07-27 10:53:52 +09:00
Samuel Attard
9f0299cc31 Use better regex to match spaces 2016-07-27 09:38:49 +10:00
Cheng Zhao
8d941a6559 Merge pull request #6566 from electron/win-autoupdater-es6
Move autoUpdater to ES6
2016-07-26 12:46:00 +09:00
Cheng Zhao
b139d5ad1c Merge pull request #6598 from electron/fs-access-asar
Add asar implementation of fs.access/accessSync
2016-07-26 12:42:59 +09:00
Samuel Attard
12dba2cb67 Remove all spaces from potential appUserModelID as it isn't allowed by the spec 2016-07-26 11:44:01 +10:00
Samuel Attard
20e26a9639 Move auto-updater-win to ES6 2016-07-26 11:40:55 +10:00
Feross Aboukhadijeh
d6a7ced32c MenuItem: Use 'Close Window' for 'close' role label
On OS X, the standard label that's used for the 'close' role is 'Close
Window'. You can see this in the default macOS apps from Apple.
2016-07-25 15:13:17 -07:00
Kevin Sawicki
8eca019157 Support paths as Buffers 2016-07-25 11:10:36 -07:00
Kevin Sawicki
30fbe92970 Add asar-supported fs.accessSync implementation 2016-07-25 11:05:18 -07:00
Kevin Sawicki
3ad5504194 Add asar-supported fs.access implementation 2016-07-25 10:50:30 -07:00
Kevin Sawicki
a518c47f4c Use let/const instead of var 2016-07-25 10:43:38 -07:00
Cheng Zhao
9ddb62c42a Use Buffer.from instead of deprecated new Buffer 2016-07-25 16:40:22 +09:00
Cheng Zhao
1c9421bc89 Use ArrayBuffer.isView to detect Buffer and ArrayBuffer 2016-07-25 16:39:09 +09:00
Cheng Zhao
200d09cc70 Merge pull request #6572 from haadcode/master
Add support for TypedArrays in IPC.
2016-07-25 16:22:29 +09:00
Cheng Zhao
751ee53683 Do not throw exception when channel name is "error" 2016-07-24 21:08:25 +09:00
haad
fac330fb50 Fix TypedArray check, add check when instanceof doesn't work for TypedArrays. 2016-07-23 12:43:49 +01:00
haad
2757046e71 Add isTypedArray to Electron exports 2016-07-23 11:30:14 +01:00
haad
e6c8900a18 Fix linting 2016-07-22 20:20:24 +01:00
haad
c717cd9192 🐛 Add support for TypedArrays in IPC.
Fixes https://github.com/electron/electron/issues/2104.
2016-07-22 19:44:19 +01:00
Cheng Zhao
9eacd07eda Merge pull request #6489 from electron/webcontents-static-api
Document static methods on webContents
2016-07-15 11:02:00 +09:00
Cheng Zhao
2791f71c03 webContents is now a public module 2016-07-15 10:59:19 +09:00
Samuel Attard
d42e6b3c1f Fix casing issue on the windows update JS file 2016-07-15 10:05:36 +12:00
Kevin Sawicki
a7badd43d5 Expose getAllWebContents() API 2016-07-14 08:59:49 -07:00
Samuel Attard
84a8c393a8 Fix linting, removes additional semicolon 2016-07-15 00:29:53 +12:00
Samuel Attard
51687e1bc9 Add the getFeedURL API for macOS and Windows 2016-07-15 00:04:48 +12:00
Cheng Zhao
21a2feaf23 Merge pull request #6480 from electron/webcontents-focus
Execute role-based menu items on focused web contents
2016-07-14 12:47:07 +09:00
Kevin Sawicki
72cdba2b8e 🎨 2016-07-13 14:49:25 -07:00
Kevin Sawicki
f9a8bd3ea5 Call role method on focused web contents 2016-07-13 14:16:56 -07:00
Kevin Sawicki
06e595e7cc Add webContents.getFocusedWebContents() 2016-07-13 14:16:56 -07:00
Kevin Sawicki
7877fa7c0a Add webContents.isFocused() 2016-07-13 14:16:56 -07:00
Cheng Zhao
41d2799514 Run background pages in separate partition
This avoids the default partition always being created on startup, so it
gives users a chance to run session.fromParititon.
2016-07-13 16:22:55 +09:00
Cheng Zhao
e653c67153 Move chromeExtensionHandler out of ready handler
This code were in ready handler because we could not require "protocol"
before ready before. It is now safe to move the code out.
2016-07-13 12:23:14 +09:00
Cheng Zhao
400bb8d0f3 Hide in_memory parameter in native interface 2016-07-13 12:23:14 +09:00
Cheng Zhao
06a41cedab Move check of isReady to native code 2016-07-13 12:23:14 +09:00
Cheng Zhao
d739d8772c Move session-created event to app
This follows the convention of other *-created events.
2016-07-13 12:23:14 +09:00
Cheng Zhao
45500701f1 Do not access default session before app is ready 2016-07-13 12:23:14 +09:00
Cheng Zhao
fcd3357fb8 Use Proxy to provide protocol APIs
In this way we can avoid initializing defaultSession when protocol
module is used.
2016-07-13 12:23:14 +09:00
Cheng Zhao
4ebb83e999 Move the warning of registerStandardSchemes to native code 2016-07-13 12:23:14 +09:00
Kevin Sawicki
e02cf5905c Execute command on devtools web contents when focused 2016-07-12 13:24:53 -07:00
Kevin Sawicki
fa36d2e8c6 Add standard edit items to text context menus 2016-07-12 11:54:45 -07:00
Kevin Sawicki
63b98b1ea0 Use const instead of var 2016-07-12 11:31:40 -07:00
Kevin Sawicki
00f82aaffe Only check arrays and objects for cycles 2016-07-11 10:39:45 -07:00