This is useful for checking which processes are sandboxed on OS level.
Regarding creationTime, since the pid can be reused after a process dies, it is useful to use both the pid and the creationTime to uniquely identify a process.
Historically, we've been passing in all MessageBox parameters individually, which makes augmenting or improving MessageBox functionality challenging because to change or add even one argument requires a huge cascade of argument changes that leaves room for errors.
For other file dialog related APIs, we use a struct (DialogSettings), and so this PR takes a similar approach and refactors MessageBox parameters into a struct (MessageBoxSettings) which we then use to simplify argument passing and which will enable us to more quickly iterate and improve upon functionality in the future.
Don't re-enter fullscreen if there is a pending operation,
for subframe fullscreen request `EnterFullScreenModeForTab`
will be called for both the frame in question as well as
the outer webContents hosting it.
* feat: provide the frame URL with permission requests and checks
Also provides a handy isMainFrame property to determine if it is an
iframe making the request
* chore: refactor to use base::Value
* chore: use Set<Type>Key over SetPath
* Initial changes to use crashpad for windows
* Remove crashpad patch
* Report error when failed to connect pipe
* Allow crashpad to communicate with named pipe
* Add patch to make crashpad named pipe work
* Windows also needs crashReporter on main process
* Call SetUnhandledExceptionFilter in node process
Node can also use crash reporter.
* Do not treat node process as browser process
* No more need to manually start crash service
* Use base::StringPrintf for better readbility
* Print error when pipe name not available
* Make sure pipe name is updated
Note that the crashpad may be started after renderer process gets
created.
* Fix some tests
* Update node
* Exclude crashpad files on Linux and MAS
* Fix lint warning
* Remove unused checks
* kCrashpadPipeName is only available on Windows
* Fix uploadToServer tests
* Fix extra params tests
* Fix getCrashesDirectory tests
* Run crashReporter tests on CI
* Style fixes
* Update crashreporter docs
* Rename InitBreakpad to Init
* Add comment for process_type_.empty() and UTF16ToASCII to UTF16ToUTF8.
* Update build.gn include crashpad headers
* Address comment https://github.com/electron/electron/pull/18483#discussion_r290887898
* Avoid using api::WebContents
* Put kRunAsNode in atom_constants
* Remove duplicate settings on upload params
* Fix building on macOS
* Update description for crashpad_pid_check.patch
* Pipe data into HTTP protocol handlers
* Remove unused parameters
* Remove "sending request of http protocol urls" test
Sending request to "http://" in "file://" violates CORS rules and always
fail, before NetworkService somehow Chromium still sent a request even
though the request failed with CORS error, so the test passes while the
test is not valid. With NetworkService no request is sent at all and the
test jsut fails.
So this is an ancient invalid test, as sending http requests have been
fully covered in other tests, I am removing this test.
* chore: bump chromium in DEPS to f200986dfaabd6aad6a4b37dad7aae42fec349e9
* chore: BridgedNativeWidgetImpl was renamed to NativeWidgetMacNSWindowHost
Refs: 1640804
* refactor: remove MainMenu.xib as Chromium has removed its dependency on xcode and therefore all xibs
As we set default menus in JS land the default native menu is tiny, just
has a Quit button
Refs: 1627242
* chore: update zip manifests
* chore: bump chromium in DEPS to 07463d3cd628b037c11f36022cb4c788db4628e3
* chore: update patches
* fix: Don't leak system network context when nw service is disabled
1632494
NetworkService is now deleted by using SequnceLocalStorageSlot
on the IO thread when the service is disabled, which expects
all associated NetworkContexts on that sequence to be destroyed.
* chore: bump chromium in DEPS to 7c16850e7e40990e141f47101b737ec1092175a1
* fix: Destroy all network contexts before primary network context
* Simplify out-of-process service registration
1615882
* [ThreadPool] Rename base::ThreadPool to base::ThreadPoolInstance
1634851
* chore: update patches
* fix: -Winconsistent-missing-override warnings
* chore: bump chromium in DEPS to 93ebfaccc12715df1d5426797998eed0932f7ae1
* Change CreateBrowserMainParts to return unique_ptrs
1632532
* chore: update patches
* chore: bump chromium in DEPS to e656555ffb87bdd05e248d0a3ef9dd9d3433e17b
* chore: bump chromium in DEPS to 111e7a8d2e3ae9d70e535009d6afb066ac906063
* chore: bump chromium in DEPS to 9b6b84670d32a7aff41ce73adc0eeee67d364989
* chore: update patches
* chore: remove ShouldInterceptResourceAsStream as it is removed upstream
Refs: 1639597
* chore: remove ResourceDispatcherHostCreated as it is removed upstream
Refs: 1610892
* chore: CreateWithStrongBinding --> CreateWithSelfOwnedReceiver
Refs: 1636722
* chore: rename all blink media enums
Refs: 1639237
* chore: add accidentally removed patch content back
* chore: allow conditional disable of the site instance override patches at runtime
* feat: add app.allowRendererProcessReuse property to allow runtime disable of site instance overrides
spec: add tests for the new allowRendererProcessReuse property
feat: add console warnings / errors for loading non context-aware native modules
* Only error if the patch is disabled
* Warn all the time, this will ship in Electron 7
* chore: remove last instances of base::Bind
* MessageBoxCallback is a OnceCallback
* convert permission helepr cbs to Once
* convert ResponseCallback to Once
