Ben Gotow
d492ff45d5
Rename up/down => begin/end
2016-01-21 16:31:09 -08:00
Ben Gotow
bd2252ea55
Extend NativeWindow to track touch-based scroll events on OS X
...
In N1, we want to implement the famous "swipe to archive" action on threads in the user's inbox. Chrome exposes `scroll` and `wheel` events, but these aren't sufficient to implement the interaction because the element needs to "snap" when the user lifts their fingers from the trackpad, not when they / we stop receiving `wheel` / `scroll` events. These events may stop before the user lifts their fingers, or continue after the user has lifted their fingers if they had enough momentum for the gesture to continue.
This exposes BrowserWindow `scroll-touch-down` and `scroll-touch-up`, which fire immeditaely when the user touches two fingers to the trackpad, and again when the user lifts their fingers. Combined with the existing wheel event should allow for "swipe-to-archive" and other similar interactions.
Note: This is only implemented on Mac OS X and the events don't fire unless you're using a trackpad!
Related: #1486 , #2683 , https://github.com/nylas/N1/issues/541
2016-01-21 09:40:21 -08:00
Kevin Sawicki
16b4b58de1
e -> error
2016-01-21 09:32:21 -07:00
Kevin Sawicki
b1f679ff6d
Clean up semicolon lint errors
2016-01-21 09:32:21 -07:00
Kevin Sawicki
70bcb0ac5a
Clean up no-unused-vars lint errors
2016-01-21 09:32:21 -07:00
Kevin Sawicki
4f4456bde8
Clean up indent eslint errors
2016-01-21 09:32:21 -07:00
Kevin Sawicki
45ddbb6d67
Clean up no-unreachable lint errors
2016-01-21 09:32:21 -07:00
Cheng Zhao
40557083f0
Merge pull request #4164 from deepak1556/menu_toggle_crash_patch
...
browser: fix crash when switching to sibling menu from submenus
2016-01-20 15:32:53 -07:00
Kevin Sawicki
8140adb6bc
Remove trailing whitespace
2016-01-20 09:43:32 -07:00
Robo
65325dc63f
browser: fix crash when switching to sibling menu from submenus
2016-01-20 10:54:12 +05:30
Kevin Sawicki
517dce443b
Remove unused errorMessage reference
2016-01-19 11:02:12 -08:00
Cheng Zhao
3b62ce7fa6
modules.exports => module.exports
2016-01-16 14:26:01 +08:00
Cheng Zhao
775e475d5c
Merge pull request #4131 from etiktin/add_is_DWM_enabled
...
Add API for checking if DWM composition (Aero Glass) is enabled
2016-01-16 14:16:22 +08:00
Cheng Zhao
25afcf2673
Merge pull request #4121 from atom/format-coffee-helpers
...
Format leftover CoffeeScript helpers
2016-01-16 13:24:26 +08:00
Eran Tiktin
83b36ce40b
Add API for checking if AeroGlass/DWM is enabled
...
Resolves #1020
2016-01-16 06:27:44 +02:00
Cheng Zhao
712f11a9a3
Merge pull request #4112 from evgenyzinoviev/resize-animate-pr
...
Animate window resizing on OS X
2016-01-16 12:12:00 +08:00
Cheng Zhao
b132c0dde8
Update brightray, close #4124
2016-01-16 11:43:46 +08:00
Eran Tiktin
85449e953e
Fix Windows crash when trying to free asar fd
2016-01-16 03:48:07 +02:00
Kevin Sawicki
0fe539f2c3
Remove unneeded semicolon
2016-01-15 15:30:07 -08:00
Kevin Sawicki
ae20292322
Add missing {
2016-01-15 15:30:07 -08:00
Kevin Sawicki
f830af49c2
Use ES6 style class
2016-01-15 15:30:01 -08:00
Kevin Sawicki
5fc671f522
Add back v8Util binding
2016-01-15 14:29:36 -08:00
Kevin Sawicki
aab2821122
Use ES6 style class
2016-01-15 14:28:12 -08:00
Kevin Sawicki
aab1568682
Use ES6 style class
2016-01-15 14:16:38 -08:00
Kevin Sawicki
02f055b784
Use ES6 style class
2016-01-15 14:12:57 -08:00
Kevin Sawicki
caf7cf5582
Use const instead of var
2016-01-15 11:46:52 -08:00
Kevin Sawicki
79f1029d59
Remove unneeded .constructor segments
2016-01-15 10:29:00 -08:00
Kevin Sawicki
34030d7b2b
Use util.inherits instead of CoffeeScript's extend function
2016-01-15 10:17:45 -08:00
Kevin Sawicki
2b95aeba3c
Declare vars one per line
2016-01-15 10:17:45 -08:00
Kevin Sawicki
2833db78ad
Use [].inclues where appropriate
2016-01-15 10:17:45 -08:00
Kevin Sawicki
c2d473cf65
Remove unneeded [].indexOf fallback
2016-01-15 10:17:45 -08:00
Kevin Sawicki
741d148776
Add missing semicolon
2016-01-15 10:09:19 -08:00
Kevin Sawicki
b119704ea9
Use 2 space indent instead of 3
2016-01-15 10:05:35 -08:00
evgenyzinoviev
64f310168c
code style fix
2016-01-15 17:40:42 +01:00
evgenyzinoviev
b75dccb0be
arguments handing rewritten, doc updated
2016-01-15 17:31:31 +01:00
Cheng Zhao
63278aeec2
Merge pull request #4118 from Ivshti/patch-1
...
Ensure we close FD on Windows
2016-01-15 23:58:57 +08:00
Cheng Zhao
0937144849
Merge pull request #4111 from evgenyzinoviev/movable
...
Added an option to prevent a window from being moved on OS X
2016-01-15 23:24:22 +08:00
Ivo Georgiev
7586078d0a
Ensure we close FD on Windows
2016-01-15 16:54:29 +02:00
Cheng Zhao
9ccc7ee30d
Small ajustments on lifetime of webContents
2016-01-15 16:36:35 +08:00
Cheng Zhao
c10c419f1d
No need to call sender.callbacks.remove
...
The IDWeakMap automatically removes the key when object is garbage
collected.
2016-01-15 16:36:35 +08:00
Cheng Zhao
3875b30fcf
Merge pull request #4109 from atom/const
...
[WIP] Use `const` for requires
2016-01-15 16:32:07 +08:00
Cheng Zhao
39225ac5ec
Bump v0.36.4
2016-01-15 14:27:19 +08:00
evgenyzinoviev
2598b00b41
Animate window resizing on OS X
2016-01-15 05:59:58 +01:00
evgenyzinoviev
cda88db77c
Added option to prevent a window from being moved on OS X
2016-01-15 03:58:57 +01:00
Jessica Lord
003de0debe
Clean up variable declarations
2016-01-14 18:07:29 -08:00
Jessica Lord
5a4a8e1fa7
🔥 stray ref
2016-01-14 17:03:55 -08:00
Jessica Lord
ae2893ceaa
Inline var
2016-01-14 15:44:33 -08:00
Jessica Lord
5412ecdcc1
Use const
2016-01-14 14:52:05 -08:00
Jessica Lord
ab8908a4af
Use const
2016-01-14 14:41:46 -08:00
Jessica Lord
1779701445
Use const
2016-01-14 14:40:12 -08:00
