mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1
21082 commits 1 branch 410 tags 2.1 GiB
Commit graph

830 commits

Author SHA1 Message Date
leethomas
ba26a4b4e6 🍎 fix #3864 where saving a file causes a crash if file extension array is empty 2015-12-30 13:26:38 -08:00
Nishanth Shanmugham
2bbf86c524 tray: Support file-drop from OS X Dock 
A long-standing Apple bug does not call `prepareForDragOperation:sender`
for file drag-and-drop operations from the Dock. So we manually
call our custom `handleDrop:sender` for all drag-and-drop cases (that
is, from the Dock and from Finder).

References to the bug in question:
- http://stackoverflow.com/q/9534543/3309046
- http://openradar.appspot.com/radar?id=1745403

However, we still need to return YES from `prepareForDragOperation:sender`,
otherwise the "drag failed" animation occurs. For the same reason, we also
return YES from `performDragOperation:sender`.
 2015-12-29 03:27:59 -06:00
Cheng Zhao
e8b5a6dedf Merge pull request #3718 from atom/chrome47-linux 
Port Chrome47 on Linux
 2015-12-08 10:14:27 +08:00
Paul Betts
af28900189 Fix up Chrome47 changes 2015-12-07 13:27:05 -08:00
Paul Betts
3931ebb7ef Fix up Windows build errors 2015-12-07 10:02:06 -08:00
Cheng Zhao
73e7773d84 Update to API changes of Chrome 47 2015-12-07 19:56:23 +08:00
Cheng Zhao
615ce45849 win: Implement menu parameter 2015-12-02 19:58:10 +08:00
Cheng Zhao
3cdd0f35c7 mac: Implement menu parameter 2015-12-02 19:05:22 +08:00
Cheng Zhao
2fba05b5e7 Add menu parameter for Tray.popUpContextMenu 2015-12-02 18:43:11 +08:00
Cheng Zhao
87546bd4f8 Merge pull request #3479 from bengotow/tray-resizing 
Fix sizing of Mac OS X tray icon after image change
 2015-11-18 18:49:15 +08:00
Ben Gotow
9c69416e32 Fix sizing of Mac OS X tray icon after image change 
- Consolidate logic that applies view dimensions into a function
- Use `NSVariableStatusItemLength` instead of trying to sync status item width
- Use modern Obj-C syntax `@[], @{}` in a few places
- Recompute view bounds after updating image in `setImage:`
 2015-11-17 13:43:55 -08:00
Nishanth Shanmugham
d1e8e71e3f Tray: Add drag-end and drop events 2015-11-10 10:02:50 -06:00
Nishanth Shanmugham
8a296f82a0 Tray: Remove extra qualification in header 2015-11-05 19:02:24 -06:00
Nishanth Shanmugham
818892d474 Tray: Add drag-entered and drag-exited events 2015-11-05 18:46:49 -06:00
mgarciaisaia
4013b652ff 🏁🐛 Buffer overflows in tooltips 
Fixes #3290.
 2015-11-04 15:34:58 +08:00
Cheng Zhao
c9b53a6e8b Merge pull request #3240 from atom/reland-win-remove-wildcard-extension 
Reland win remove wildcard extension
 2015-10-27 20:52:43 +08:00
Haojian Wu
f69bafd48a Win: Fix adding '.*' to filename in callback. 2015-10-27 20:15:43 +08:00
Haojian Wu
fa24e15d8b Win: Remove adding '*.*' to file name in a save dialog. 2015-10-27 20:15:20 +08:00
Cheng Zhao
dacd921a04 Revert "Win: Remove adding default file filter(*.*) in a save dialog." 
This reverts commit 00493f64b7.
 2015-10-27 14:58:44 +08:00
Cheng Zhao
3042f604cc Merge pull request #3234 from atom/win-remove-default-filter 
Win: Remove adding default file filter(*.*) in a save dialog.
 2015-10-27 14:30:35 +08:00
Haojian Wu
00493f64b7 Win: Remove adding default file filter(*.*) in a save dialog. 2015-10-27 13:10:34 +08:00
Brandon Cash
60b14d03e9 Fix: tray NotfiyDropFiles typo 2015-10-18 00:32:13 -05:00
Cheng Zhao
3b1ee994e2 views: Remove hack on setting min/max size for frameless window 2015-10-05 20:37:08 +08:00
Cheng Zhao
a76ea00249 views: Implement NativeWindow::SetSizeConstraints 2015-10-05 20:07:20 +08:00
Cheng Zhao
2b9b4c6789 Merge pull request #2979 from etiktin/fix_calculating_min_max_4_frameless 
Fix calculating min/max size in frameless view
 2015-10-05 15:10:27 +08:00
Eran Tiktin
c34c123b33 Make it work only on Windows 
Limiting the solution to Windows only.
 2015-10-05 04:01:25 +03:00
Cheng Zhao
add9c38023 linux: Enable force showing menubar 
This is for debugging purpose.
 2015-10-04 16:33:03 +08:00
Eran Tiktin
aea1f8aebb Fix calculating min/max size in frameless views 
The minimum and maximum size that frameless windows had used, was
incorrect. It included the border, so when it was called it actually
added that to the size, so window increased in size. The fix makes sure
that the view will use the frameless size.

This fixes #2945 and partially fixes #1806 (it also refers to some other
issues with hidpi which might still exist).
 2015-10-03 22:09:57 +03:00
Eran Tiktin
6dcc752f67 Set default extension in Windows file dialog 
On Windows when you open the save dialog and switch the filter, the
extension is supposed to change accordingly. It didn't happen with the
existing code, since the existing code didn't set the default extension
(should be set to the first filter).

This resolves #2915.
 2015-09-28 02:12:47 +03:00
Cheng Zhao
9b1fa04988 win: Fix building 2015-09-24 12:01:57 +08:00
Paul Betts
b0e5039951 Fix initializer 2015-09-23 11:26:57 -07:00
Paul Betts
22e6f15795 Remove GUID from Shell_NotifyIcon calls 
https://github.com/atom/electron/issues/2468#issuecomment-142684129 has
the details
 2015-09-23 11:20:26 -07:00
Cheng Zhao
84ce441fb6 Add converters for WebInputEvent 2015-09-18 13:33:06 +08:00
Cheng Zhao
53b9d61831 Fix building on Windows 2015-09-03 20:07:29 +08:00
Cheng Zhao
4254eb279f Fix API changes on Linux 2015-09-03 17:50:23 +09:00
Cheng Zhao
45491ca7ab Fix API changes 2015-09-03 17:50:23 +09:00
Cheng Zhao
d830badc57 Add role property for MenuItem 2015-09-02 09:42:17 +08:00
Cheng Zhao
3e5449561f Merge pull request #2595 from atom/mac-tray-quick-click 
mac: make tray's behavior more official when getting clicked quickly multiple times.
 2015-08-26 17:18:51 +08:00
Haojian Wu
2b051e3884 mac: make tray's behavior more official when getting clicked quickly 
multiple times.
 2015-08-26 16:28:22 +08:00
Cheng Zhao
da10df3a9a Merge pull request #2556 from etiktin/fix_msg_box_no_close_btn 
Fix message box missing a close button on Windows
 2015-08-25 13:57:24 +08:00
Eran Tiktin
9232620023 Fixed comment spacing 2015-08-22 04:26:09 +03:00
Eran Tiktin
b1406fbad9 Fix no close button in message box on Windows 
This resolves #2293.
 2015-08-22 04:20:52 +03:00
Haojian Wu
5f663dbf0a mac: make * extension filter works. 2015-08-21 12:15:20 +08:00
Haojian Wu
c566ba575f Linux: make * extension filter works. 2015-08-21 12:13:33 +08:00
Paul Betts
0efdb448b6 Merge pull request #2509 from atom/fix-win-tray 
Correct generation of GUID on Windows.
 2015-08-17 09:02:21 -07:00
Haojian Wu
763dcc545d Correct generation of GUID on Windows. 2015-08-17 13:20:36 +08:00
Cheng Zhao
33eadad139 popContextMenu => popUpContextMenu 2015-08-10 13:00:15 +08:00
Cheng Zhao
225140bd64 win: Don't emit right-clicked event when there is menu attached 2015-08-10 12:52:55 +08:00
Cheng Zhao
58dee04d5c mac: Redraw icon when menu is closed 2015-08-10 12:52:35 +08:00
Cheng Zhao
4b9ff309ec Add our own MenuModel class 2015-08-10 12:39:05 +08:00