mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
28302 commits 1 branch 183 tags 5.3 GiB
Commit graph

28302 commits

This branch
This branch
All branches
Author SHA1 Message Date
trop[bot]
d025ecfa6b
fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app (#43547) 
When an electron app is launched by another app ensure that the
XDG_ACTIVATION_TOKEN env var is read and used for activation using
xdg_activation_v1 protocol.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Orko Garai <orko@igalia.com>
 2024-09-04 17:28:02 +02:00
John Kleinschmidt
523b4cb27a
build: free up macos disk space as soon as possible (#43538) 
* chore: free up macos disk space as soon as possible

* build: free up disk space on gn check too
 2024-09-04 12:19:30 +02:00
trop[bot]
16a8ac15be
chore: speed up cache only reclient for fork PRs (#43504) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-09-03 21:40:20 -04:00
trop[bot]
f7404bceea
fix: devtools dock state with WCO on linux (#43500) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2024-08-29 13:27:14 -04:00
trop[bot]
0fa92e0fea
refactor: simplify KeyWeakMap impl (#43484) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-26 18:10:34 -04:00
trop[bot]
44e57c6cbb
chore: remove unused WinFrameView::kInactiveTitlebarFeatureAlpha (#43475) 
added in Aug 2021 (41646d11, #29600) but never used

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-24 00:11:00 -05:00
trop[bot]
3251f84328
chore: remove unused method asar::ClearArchives() (#43469) 
chore: remove unused asar::ClearArchives()

last use removed in Jun 2021 (b1d1ac65, #29293)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-23 17:02:34 -05:00
trop[bot]
62c63ea35a
docs: titleBarOverlay is defined as a BaseWindow ctor option (#43458) 
docs: titleBarOverlay is defined as a BaseWindow ctor option

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-23 10:39:06 -05:00
trop[bot]
a373ab027b
fix: menu should allow focused BaseWindow where possible (#43439) 
fix: menu should allow focused BaseWindow

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-22 18:33:44 -05:00
trop[bot]
557d5c901a
fix: documentation spelling errors (#43434) 
chore: fix typos in 'docs/' folder.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Alexander Cyon <alex.cyon@gmail.com>
 2024-08-22 16:04:06 +02:00
trop[bot]
1b657869c2
fix: touch bar functionality on BaseWindow (#43420) 
* fix: touch bar functionality on BaseWindow

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* test: add test for BaseWindow.setTouchBar

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-22 15:43:47 +02:00
trop[bot]
a7459bc93b
refactor: move impl functions into private namespace (#43410) 
* refactor: move into unnamed namespace: IsKillURL()

refactor: move into unnamed namespace: ResolvePossiblyRelativeURL()

refactor: move into unnamed namespace: AllowFileAccess()

refactor: move into unnamed namespace: PrepareURLForNavigation()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: GetMonitors()

refactor: move into unnamed namespace: GetEDIDProperty()

refactor: move into unnamed namespace: MonitorAtomIdToDisplayId()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: GetPermissionInfos() } refactor: move into unnamed namespace: GetPermissionAliases()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: OnOpenExternal()

refactor: move into unnamed namespace: HandleExternalProtocolInUI()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: BindMimeHandlerService()

refactor: move into unnamed namespace: BindBeforeUnloadControl()

refactor: move into unnamed namespace: BindBadgeServiceForServiceWorker()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: GetClientIdPath()

refactor: move into unnamed namespace: ReadClientId()

refactor: move into unnamed namespace: WriteClientId()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: HasExplicitLogFile()

refactor: move into unnamed namespace: DetermineLoggingDestination()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: GetArchiveCache()

refactor: move into unnamed namespace: GetArchiveCacheLock()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: GetParameters()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: GetDoomed()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: move into unnamed namespace: EncodeToken()

refactor: move into unnamed namespace: PortInfoToValue()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-21 21:29:25 -05:00
trop[bot]
5080b647c8
refactor: NodeBindings::Create() returns a unique_ptr (#43393) 
refactor: NodeBindings::Create() returns a unique_ptr (#43361)

* refactor: NodeBindings::Create() returns a unique_ptr

* empty commit

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-21 10:56:59 -04:00
Charles Kerr
aa47f3efc3
refactor: remove unused SetWMSpecState (#43383) 
refactor: remove unused SetWMSpecState (#43347)

last use removed in Aug 2022 by 53cd2315 #35179
 2024-08-21 10:26:30 +02:00
Charles Kerr
3596197562
chore: remove unused method Erase() (#43382) 
chore: remove unused method Erase() (#43348)

Last use removed in Mar 2018 by 4b39d17e
 2024-08-21 10:15:17 +02:00
Keeley Hammond
054679ee99
chore: cherry-pick 9797576 from v8 (#43386) 
* chore: cherry-pick 9797576 from v8 (#43376)

* chore: update patches

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-20 17:05:47 -07:00
Shelley Vohr
7df2211c30
build: use smaller instances for gn-check (#43359) 
build: use smaller instances for gn-check (#43187)

Co-authored-by: Samuel Attard <sam@electronjs.org>
 2024-08-20 09:58:11 +02:00
trop[bot]
b80d708fc1
feat: accept-encoding zstd (#43301) 
* fix: accept-encoding zstd

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* Update shell/browser/net/system_network_context_manager.cc

Co-authored-by: Sam Maddock <smaddock@slack-corp.com>

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: make lint happy

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-16 11:24:07 +02:00
trop[bot]
a959476dc2
fix: blank page when printing pdf (#43327) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-15 10:30:22 -04:00
trop[bot]
bd70c3a740
refactor: update chrome.scripting extensions api impls (#43290) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-12 12:09:34 +02:00
trop[bot]
997afe62f2
chore: remove unused Notification fields icon_path_, has_icon_ (#43295) 
Last use of `icon_path_` was removed on May 29, 2017 (c741b584)
Last use of `has_icon_` was removed on May 30, 2017 (5048425e)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-12 12:09:25 +02:00
trop[bot]
dd1dcad81c
fix: system-context-menu with frameless BrowserWindows (#43274) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-11 21:30:37 +02:00
trop[bot]
10dd33c16e
fix: check screen capture permissions in desktopCapturer (#43271) 
fix: check screen capture permissions in desktopCapturer

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-11 21:30:27 +02:00
trop[bot]
c3a7f0001c
fix: accidental handle copying in a range loop (#43281) 
fix: accidental handle copying

Xref: https://github.com/electron/electron/pull/37857

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-10 09:59:36 +02:00
trop[bot]
a780a75dec
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled (#43250) 
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-08 10:59:15 +02:00
electron-roller[bot]
6e69cb0191
chore: bump chromium to 126.0.6478.234 (31-x-y) (#43252) 
chore: bump chromium in DEPS to 126.0.6478.234

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
 2024-08-08 01:10:00 +09:00
trop[bot]
520a147244
docs: Document ideal iconPath size (#43241) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
 2024-08-07 11:57:17 +02:00
trop[bot]
36cebb95c6
refactor: simplify window moveAbove/moveTop impl on macOS (#43201) 
refactor: simplify window moveAbove/moveTop impl on macOS

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-06 16:41:49 -04:00
trop[bot]
be842d6267
perf: avoid redundant calls to GetView() (#43229) 
* perf: avoid double-calls to GetView()

There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:

if (auto* view = foo->GetView())
  view->DoSomething();

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* perf: avoid discarded GetView() call

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-06 13:23:21 -05:00
trop[bot]
8fb3a04eee
fix: potential draggable regions crash in DevTools (#43200) 
* fix: potential draggable regions crash in DevTools

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: update patch after rebase

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-08-06 20:12:16 +02:00
trop[bot]
17cb664e39
perf: don't build unused vectors in HidChooserContext (#43214) 
* refactor: remove unused code in HidChooserContext::DeviceRemoved()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: use structured bindings for readability

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-06 09:57:00 -05:00
trop[bot]
54b31f153c
fix: gin_helper::MicrotasksScope instantiation (#43209) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-05 21:46:51 -05:00
Charles Kerr
cbf1adb1b7
fix: 31-x-y gn sync fail when patching dawn, dxc (#43215) 
* chore: remove reland_deps_update_dxc_to_patched_branch.patch

Xref: https://dawn-review.googlesource.com/c/dawn/+/200494

This patch has (re)landed upstream

* chore: remove cherry-pick-9463ce9cd8d9.patch

Xref: https://chromium-review.googlesource.com/c/external/github.com/microsoft/DirectXShaderCompiler/+/5715228

* chore: remove unused patch dirs

h/t @jkleinsc

* fixup! chore: remove unused patch dirs

fix: oops
 2024-08-05 15:41:43 -04:00
Keeley Hammond
3f0dcb75df
chore: cherry-pick 1 change from 3-M126 (#43140) 
* chore: [31-x-y] cherry-pick 9 changes from 3-M126

* d54105311590 from chromium
* c5dd8839bfaf from chromium
* cdbc1d9684a3 from v8
* 38e4483e47f9 from chromium
* 70d2fe6b7c47 from v8
* 901377bb2f3b from v8
* 1b9040817119 from chromium
* 99cafbf4b4b9 from chromium
* bc545b15a0ee from v8

* chore: update patches

* 5639725: [wasm] Fix scanning of wasm-to-js params | https://chromium-review.googlesource.com/c/v8/v8/+/5639725

Fix was already applied upstream

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-02 15:17:25 +02:00
electron-roller[bot]
7da10ffced
chore: bump chromium to 126.0.6478.226 (31-x-y) (#43164) 
chore: bump chromium in DEPS to 126.0.6478.226

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
 2024-08-02 14:54:08 +02:00
Pedro Pontes
a9f81e63c4
chore: cherry-pick 3 changes from 0-M127 (#43158) 
* chore: [31-x-y] cherry-pick 3 changes from 0-M127

* 44b7fbf35b10 from chromium
* c9815acd5a88 from dawn
* 9463ce9cd8d9 from DirectXShaderCompiler

* chore: e patches all

---------

Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-02 10:11:13 +02:00
trop[bot]
1c368f13f8
fix: take bluetooth serial ports into account in serial.getPorts() (#43170) 
* fix: take bluetooth serial ports into account in serial.getPorts()

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: remove port.path.LossyDisplayName()

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-01 23:10:46 -07:00
trop[bot]
2ad5d1ff71
chore: remove unused internal env.unSetVar() (#43175) 
chore: remove unused unSetVar JS binding

Added in Oct 2020 (b33f2260, #25623) but never used

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-01 21:32:17 -05:00
trop[bot]
f3fc1e626d
docs: fixed broken electron-fiddle links in the "Tutorial - Publishing and Updating" doc (#43178) 
fixed electron-fiddle build and config links

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: terrence-ou <outerrencedl@gmail.com>
 2024-08-01 20:47:41 -05:00
electron-roller[bot]
05fbbebca5
chore: bump node to v20.16.0 (31-x-y) (#43026) 
chore: bump node in DEPS to v20.16.0

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-01 15:34:51 +02:00
trop[bot]
cdb0540cf0
fix: handle failing to enter fullscreen on macOS (#43154) 
* fix: handle failing to enter/exit fullscreen on macOS

On macOS, failing to enter/exit fullscreen can fail. If this happens,
properly restore the original window state.

Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>

* refactor: remove fail to exit fullscreen handlers

Seem to be unnecessary since the window exits fullscreen anyway.

Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>
 2024-08-01 14:50:23 +02:00
Shelley Vohr
832090d01c
feat: add transparency checking to nativeTheme (#43137) 
feat: add transparency checking to nativeTheme
 2024-08-01 12:14:07 +02:00
trop[bot]
8e21aad444
chore: remove unused & undocumented function v8Util.deleteHiddenValue() (#43114) 
chore: remove unused v8Util.deleteHiddenValue()

Its last use was removed in Nov 2020 by c8d77cae4a (#26659)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-07-31 20:07:30 -05:00
trop[bot]
31551aba9d
fix: vibrant view is inserted into Views API hierarchy (#43128) 
* fix: vibrant view is inserted into Views API hierarchy (#42263)

Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu>

* Update shell/browser/native_window_mac.mm

Co-authored-by: Charles Kerr <charles@charleskerr.com>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-07-31 19:59:27 -05:00
trop[bot]
dbcd56209a
chore: remove unused KeyWeakMap JS bindings (#43144) 
The last three pieces of code that used it were removed in:

- Oct 2020 (8df4faa8 #25711)
- Jun 2020 (e1e73fa5 #24115)
- Jun 2020 (c0182bca #24116).

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-07-31 18:56:54 -05:00
trop[bot]
ce426cd957
docs: update Node.js stable release policy (#43134) 
* docs: update Node.js stable release policy

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* Update docs/tutorial/electron-timelines.md

Co-authored-by: Erick Zhao <erick@hotmail.ca>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-07-31 10:44:23 -04:00
trop[bot]
1fe01eb0b1
build: fixup ffmpeg release on x64 macOS (#43121) 
chore: fixup arch on x64 macOS ffmpeg

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-07-30 19:28:48 -05:00
Keeley Hammond
24db198d52
fix: remove InspectableWebContentsViewMac (#43096) 
* fix: remove InspectableWebContentsViewMac (#43033)

* Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326)"

This reverts commit e67ab9a93d.

* build: fix gn check

* chore: implement setCornerRadii in inspectable_web_contents_view_mac

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* fix: pass in cornerRadii value in setCornerRadii

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* fix: forward declaration

* 5578714: Remove 0-arg (default) constructor for views::Widget::InitParams.

https://chromium-review.googlesource.com/c/chromium/src/+/5578714

* fix: contents_web_view_ -> contents_view_

* chore: remove extraneous includes

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* fix: remove custom border radius feat (#42320)

* fix: fix views::Widget::InitParams params

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-07-30 14:51:51 -04:00
trop[bot]
b1921b362e
chore: remove unused class electron::ObjectLifeMonitor (#43109) 
chore: remove unused class `electron::ObjectLifeMonitor` (#43089)

The last users were removed in June 2020 e1e73fa5f (#24115)
and May 2020 9d7ba982 (#23592).

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-07-30 13:27:12 -05:00
trop[bot]
35b73514b7
fix: showInactive window not showing (#43102) 
fix: showInactive window not showing

Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-07-30 13:02:03 -05:00