Commit graph

74 commits

Author SHA1 Message Date
Charles Kerr
dd2c2660b9
Fix desktop-id notification edge case (#12216)
* Fix desktop-id notification edge case

* Extract-method platform_util::GetDesktopName()

This removes duplicated code from libnotify_notifications.cc
and atom/common/linux/application_info.cc.

* Check for empty case in GetDesktopName().

* Move GetDesktopName() to brightray::util

* Remove unnecessary changes in platform_util

* Add a brightray::platform_util namespace
2018-03-12 16:02:47 +09:00
Charles Kerr
86af20ded0
Linux named notifications (#12192)
* Set name & desktop-entry on Linux notifications

* DBusMock now honors verbose mode flag

* Disable DBus Notification tests on ia32
2018-03-12 09:33:06 +09:00
Charles Kerr
2a16b28be4
Cache libnotify server caps (#11965)
* cache libnotify server capabilities

* fix broken production cache in NotifierSupportsActions()

* log a warning if LibnotifyNotification::Initialize() fails
2018-02-20 07:53:10 -06:00
Samuel Attard
7eb14243eb Refactor notification options 2017-06-24 21:39:06 +10:00
Samuel Attard
4f0d48f164 Add support for notification actions on macOS 2017-06-23 20:50:20 +10:00
Samuel Attard
5048425e6e
Update implementation as per feedback 2017-05-30 19:06:51 +10:00
Samuel Attard
058bdfbced Use NotificationPresenter - macOS 2017-05-29 20:02:33 +10:00
Kevin Sawicki
d7321ed980 Add brightray prefix to include paths from within brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37 Fix build/include_alpha linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
f193b2b2a6 Fix build/include_what_you_use linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
cfb5b6ac89 Fix build/header_guard linter violations in brightray 2017-05-19 08:46:15 -07:00
Ales Pergl
0bba5b9b41 Address cpplint issue "Lines should be <= 80 characters long [whitespace/line_length] [2]" 2017-04-05 14:30:15 +02:00
Ales Pergl
e6a30388da Make Notification factory function a member of NotificationPresenter so that we can create different types of notifications based on runtime conditions. 2017-04-05 14:30:15 +02:00
Kevin Sawicki
2ece711c2e Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
Kevin Sawicki
be0c0e278a Remove cpplint errors 2017-03-23 12:48:27 -07:00
Cheng Zhao
abececd78b libgtk2ui => libgtkui 2017-01-26 20:02:01 +09:00
Kevin Sawicki
7cb8c1fdb9 Add dismiss notification guard on Linux 2016-10-28 11:24:47 -07:00
deepak1556
ee4442f964 set notification close callback before requesting user permission 2016-10-25 19:04:09 +05:30
Cheng Zhao
a45af78b15 Remove unneeded lines when importing code 2016-05-18 09:42:14 +09:00
Cheng Zhao
eb215c173c Try linking with libnotify.so.5 2016-05-17 20:30:53 +09:00
Cheng Zhao
aafc48ae2c Merge pull request #213 from 3v1n0/linux-notifications-append
Linux notifications append
2016-04-15 20:57:02 +09:00
Cheng Zhao
f4c27c6d29 Store weak ref to Notification in ToastEventHandler 2016-04-15 16:14:13 +09:00
Marco Trevisan (Treviño)
83cbc1182d LibnotifyNotification: use "append" when supported
This behavior can be overridden by just providing unique tags to notifications
2016-04-14 18:31:02 +02:00
Marco Trevisan (Treviño)
8962da380b LibnotifyLoader: add notify_notification_set_hint_string 2016-04-14 18:29:00 +02:00
Marco Trevisan (Treviño)
8dd7a8d7fe LibNotifyLoader: implement generic HasCapability 2016-04-14 18:24:00 +02:00
Cheng Zhao
2f107fcbe1 Merge pull request #211 from 3v1n0/notifications-tags
Notifications tags
2016-04-13 20:12:37 +09:00
Marco Trevisan (Treviño)
1ce34fb8d2 LibnotifyNotification: add support for notification tag
We set the id of the notification if tag is provided.
As per the protocol, this should cause the old notification with same ID to be replaced.
2016-04-13 06:12:46 +02:00
Marco Trevisan (Treviño)
59ed6ad413 Notification: pass tag to Show method 2016-04-13 06:12:46 +02:00
Marco Trevisan (Treviño)
743ceed780 LibnotifyNotification: verify if the "actions" capability is supported before adding actions
This would prevent to add actions to notifier such as Ubuntu's Notify-OSD
which doesn't support them.
2016-04-13 04:43:22 +02:00
Marco Trevisan (Treviño)
a22dc8676f LibnotifyLoader: add notify_get_server_caps support 2016-04-13 04:42:01 +02:00
Marco Trevisan (Treviño)
4e7f478d1e LibnotifyLoader: add notify_get_server_info support 2016-04-13 04:02:23 +02:00
Felix Rieseberg
728f0f985b 🏁 🍎 Add Silent Notification Support
* Implements support for silent notifications on Windows and OS X
 * Exposes bool `silent` to Linux notification presenters
2016-01-21 09:24:42 -08:00
Cheng Zhao
870e6a6f89 linux: Adapt to new Notification style 2015-12-25 11:52:19 +08:00
Cheng Zhao
862f3c21f6 Load libnotify dynamically 2015-12-24 11:12:51 +08:00
Cheng Zhao
5a97cfaa64 Code cleanup 2015-10-01 17:30:59 +08:00
Paul Betts
1a8377b198 Add environment variable as escape hatch 2015-09-30 09:14:31 -07:00
Paul Betts
50a95792a1 Rewrite unity check to look for libunity SOs 2015-09-30 09:09:35 -07:00
Cheng Zhao
bb7cd8f261 Guard agains empty notification 2015-08-04 16:44:32 +08:00
Cheng Zhao
81ba4e3a3e Guard against empty image 2015-08-04 16:43:46 +08:00
Cheng Zhao
95d28c398e Update cpplint 2015-06-05 12:07:27 +08:00
Cheng Zhao
37bd7fe331 Remove parameter |by_user| in NotificationClosed 2015-05-22 14:51:16 +08:00
Paul Betts
a0e5d36305 Free some stuff 2015-04-21 14:09:48 -07:00
Paul Betts
5d82bab10d Use DBus to detect indicator, not testing for files like an animal 2015-04-20 15:31:24 -07:00
Paul Betts
3357dc0ef7 Set icon for notification, and disable action on Ubuntu 2015-04-20 13:22:18 -07:00
Paul Betts
b8689dc6cc Add a parameter to ShowNotification for the icon 2015-04-20 13:20:50 -07:00
Cheng Zhao
54e58ae255 Fix compilation on Linux 2015-03-16 14:45:19 +08:00
Cheng Zhao
5e4c90f264 NotificationError is discarded 2015-02-03 10:57:33 -08:00
Cheng Zhao
f809fef22d OVERRIDE => override 2014-10-23 11:10:39 +08:00
Cheng Zhao
6d62b0960e Fix building on Linux 2014-10-13 11:03:37 +08:00
Cheng Zhao
6dd580526e Refactor notification presenter for new desktop notification interface. 2014-07-27 11:27:04 +00:00