taoky
4f76fff978
fix: don't do self-destroy in LibnotifyNotification::Dismiss() ( #41691 )
...
Callers of Notification::Dismiss() assume that the notification
instance is not deleted after the call, but this was not the case
for LibnotifyNotification:
- Destroy() would get `this` deleted.
- notify_notification_close() in portal environment triggers
LibnotifyNotification::OnNotificationClosed(), and finally calls
Destroy()
This patch removes all Destroy() in Dismiss(), and adds a boolean
to tell whether notify_notification_close() is running, to avoid crash
under portal environment.
Fixes #40461 .
2024-03-27 10:53:23 +01:00
Shelley Vohr
32b44aa5c8
fix: crash on extension unload when script validation finishes ( #41686 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5225796
2024-03-26 14:32:06 +01:00
Shelley Vohr
7032c0d03c
test: add test and api_feature definition for chrome.scripting.globalParams ( #41685 )
...
chore: add test and api_feature for chrome.scripting.globalParams
2024-03-26 12:33:47 +01:00
Shelley Vohr
8c427253b3
refactor: update gin_helper/function_template ( #41534 )
...
* refactor: update gin_helper/function_template
* fix: crash in Node.js Worker threads
2024-03-25 10:01:54 +01:00
Piotr Płaczek
90a7e5acae
fix: normalize path before calling showItemInFolder and openPath ( #41642 )
...
* fix: normalize path before calling ShowItemInFolder
* fix: normalize path before calling OpenPath
2024-03-22 10:28:44 -04:00
Shelley Vohr
707b9a58cc
fix: app.setLoginItemSettings error getting swallowed by gin conversion ( #41647 )
...
* fix: errors getting swallowed by gin conversion
* fix: Windows build
* test: re-enable disabled test
2024-03-22 09:00:21 -04:00
Shelley Vohr
a32705fd30
test: add test for setJumpList arguments ( #41650 )
...
test: add test for setJumpList arguments
2024-03-21 19:01:54 -04:00
Alice Zhao
00e3445f8a
feat: add navigationHistory.getEntryAtIndex(int index) method ( #41577 )
2024-03-21 14:59:23 -07:00
Shelley Vohr
66dec24e32
fix: serial-port-added should respect filters ( #41621 )
...
fix: serial-port-added should respect filters
2024-03-20 10:18:41 -04:00
Shelley Vohr
433d6c33d8
fix: missing badge text on Windows ( #41618 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5053607
2024-03-19 12:50:30 +01:00
Shelley Vohr
1cd7419718
build: work around ScreenCaptureKit bad feature flag parsing in Chromium ( #41622 )
2024-03-19 10:49:41 +01:00
electron-roller[bot]
193e162ec6
chore: bump chromium to 124.0.6359.0 (main) ( #41584 )
...
* chore: bump chromium in DEPS to 124.0.6355.0
* 5341411: view-transition: Ensure resources are cleaned up in all cases.
https://chromium-review.googlesource.com/c/chromium/src/+/5341411
* chore: fixup patch indices
* 5354013: Return nullopt on error from ProcessMetrics CPU measurements
https://chromium-review.googlesource.com/c/chromium/src/+/5354013
* chore: bump chromium in DEPS to 124.0.6357.0
* chore: update patches
* 5368769: Reland "[mojo] Use large worker for mojom_parser action"
https://chromium-review.googlesource.com/c/chromium/src/+/5368769
* 5336171: [Extensions] Introduce a CoreExtensionsRendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5336171
* 5367334: [FS Shortcut] Refactor ExclusiveAccessManager
https://chromium-review.googlesource.com/c/chromium/src/+/5367334
* 5354161: Rename GeolocationManager to GeolocationSystemPermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5354161
* fixup: [Extensions] Introduce a CoreExtensionsRendererAPIProvider
* chore: bump chromium in DEPS to 124.0.6359.0
* chore: update patches
* 5371370: [Extensions] Move core NativeHandler registration
https://chromium-review.googlesource.com/c/chromium/src/+/5371370
* 5370702: [Extensions] Introduce ShellExtensionsRendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5370702
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-03-15 14:03:42 -04:00
Shelley Vohr
1bfd3e0631
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain ( #41538 )
...
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-03-14 09:50:52 +01:00
Shelley Vohr
1840d7b7ee
fix: improve caption button appearance on Windows 11 ( #41561 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/4428171
2024-03-13 10:58:48 -04:00
electron-roller[bot]
26752d3a06
chore: bump chromium to 124.0.6353.0 (main) ( #41566 )
...
* chore: bump chromium in DEPS to 124.0.6353.0
* chore: update patches
* 5365462: Add missing perfetto::Flow and TRACE_EVENT includes
https://chromium-review.googlesource.com/c/chromium/src/+/5365462
* 5356336: Ensure destruction of mojo channel when destructing KeySystemsImpl
https://chromium-review.googlesource.com/c/chromium/src/+/5356336
* 5332839: [Extensions] Register NativeHandlers with the RendererAPIProvider
https://chromium-review.googlesource.com/c/chromium/src/+/5332839
* 5148827: Add permission types for keyboard lock and pointer lock [1/N]
https://chromium-review.googlesource.com/c/chromium/src/+/5148827
* 5358818: Revert "[object] Fast path for adding props with existing transition"
https://chromium-review.googlesource.com/c/v8/v8/+/5358818
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-13 09:44:49 +01:00
electron-roller[bot]
150c2bcef9
chore: bump chromium to 124.0.6351.0 (main) ( #41514 )
...
* chore: bump chromium in DEPS to 124.0.6339.0
* chore: update patches
* chore: bump chromium in DEPS to 124.0.6341.0
* chore: update patches
* chore: bump chromium in DEPS to 124.0.6343.0
* chore: bump chromium in DEPS to 124.0.6345.0
* chore: update patches
* build: temporarily patch out usage of reclient inputs cfg
* chore: implement missing OnPortConnectedStateChanged
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5039155
* fix: move NativeHandlers in extensions to new RendererAPIProvider
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5332839
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5334058
* chore: add missing websocket method
* refactor: use std::erase instead of base::Erase
Ref: https://issues.chromium.org/issues/40256229
* build: fix reclient inputs processor bug (workaround)
* fix: delay extensions::Dispatcher construction
* chore: bump chromium in DEPS to 124.0.6347.0
* chore: bump chromium in DEPS to 124.0.6349.0
* 5326217: [ViewsAX] Remove WebAXPlatformTreeManagerDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/5326217
* 5347916: Get origin from parent for process-isolated srcdoc.
https://chromium-review.googlesource.com/c/chromium/src/+/5347916
* chore: patches fixup
* 4866222: [api] Deprecate vector<v8::Local>, part 1
https://chromium-review.googlesource.com/c/v8/v8/+/4866222
* 5337304: Remove DXDiag telemetry code.
https://chromium-review.googlesource.com/c/chromium/src/+/5337304
* 5328275: Implement watermark routing to the BrowserView
https://chromium-review.googlesource.com/c/chromium/src/+/5328275
* [libc++] Rename __fwd/hash.h to __fwd/functional.h and add reference_wrapper
* chore: bump chromium in DEPS to 124.0.6351.0
* chore: update patches
* 5342763: [object] Fast path for adding props with existing transition
https://chromium-review.googlesource.com/c/v8/v8/+/5342763
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-12 10:15:41 +01:00
Shelley Vohr
62331f5ac1
chore: add missing gin::Wrappable GetTypeName overrides ( #41512 )
...
chore: add missing gin::Wrappable GetTypeName overrides
2024-03-06 12:45:28 +01:00
Shelley Vohr
a7d664e3a3
fix: user-did-{resign|become}-active events on macOS ( #41506 )
...
fix: user-did-{resign|become}-active events on macOS
2024-03-06 12:43:39 +01:00
electron-roller[bot]
9f673c859d
chore: bump chromium to 124.0.6331.0 (main) ( #41474 )
...
* chore: bump chromium in DEPS to 124.0.6329.0
* chore: update patches
* 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
* 5321532: [//ui] Remove ContextFactory::SharedMainThreadContextProvider() | https://chromium-review.googlesource.com/c/chromium/src/+/5321532
* fixup! 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
* 5319141: [OOPIF PDF] Create PdfNavigationThrottle for main frame navigations | https://chromium-review.googlesource.com/c/chromium/src/+/5319141
* test: disable webview.capturePage test for mac arm64
* chore: bump chromium in DEPS to 124.0.6337.0
* chore: update patches
* build: roll back DEPS to 124.0.6331.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
2024-03-05 11:47:48 -05:00
Jeremy Rose
e67ab9a93d
refactor: remove InspectableWebContentsViewMac in favor of the Views version ( #41326 )
2024-03-04 09:32:40 -08:00
Cheng Zhao
814ba71dc1
chore: update src_preload_function_for_environment.patch ( #41500 )
2024-03-04 13:11:14 +01:00
electron-roller[bot]
04df5ce492
chore: bump chromium to 124.0.6323.0 (main) ( #41412 )
...
* chore: bump chromium in DEPS to 124.0.6315.0
* chore: update patches
* 5279678: Stream AIDA responses
https://chromium-review.googlesource.com/c/chromium/src/+/5279678
* 5276439: Remove non_network_url_loader_factory_remotes_
https://chromium-review.googlesource.com/c/chromium/src/+/5276439
* 5310165: Add DevTools API to show search results
https://chromium-review.googlesource.com/c/chromium/src/+/5310165
* chore: bump chromium in DEPS to 124.0.6317.0
* chore: update patches
* Remove Setup.Install.CumulativeDiskUsage2 and supporting code
https://chromium-review.googlesource.com/c/chromium/src/+/5314269
* browser: Make cmd line non-const in process singleton callback
https://chromium-review.googlesource.com/c/chromium/src/+/5311256
* chore: bump chromium in DEPS to 124.0.6319.0
* chore: bump chromium in DEPS to 124.0.6321.0
* chore: bump chromium in DEPS to 124.0.6323.0
* 5318335: Roll src/third_party/boringssl/src 23824fa0f..4fe29ebc7
https://chromium-review.googlesource.com/c/chromium/src/+/5318335
* 5318051: [CBE Watermarking] Hoist `watermark_view` to a member variable.
https://chromium-review.googlesource.com/c/chromium/src/+/5318051
* chore: fixup patch indices
* 4946553: Delegate HID permission to Chrome App in webview
https://chromium-review.googlesource.com/c/chromium/src/+/4946553
* 5310001: DevTools UI binding for reporting client events to AIDA
https://chromium-review.googlesource.com/c/chromium/src/+/5310001
* [libc++] Refactor the predicate taking variant of `__cxx_atomic_wait`
* chore: fix browser_view patch harder
* 5293937: Reland "[gUM] Use preferred device if more than one is eligible"
https://chromium-review.googlesource.com/c/chromium/src/+/5293937
* fix: filter {video|audio} devices by eligible device id
* 5267921: enable speak content under the pointer on PWA and WV2
https://chromium-review.googlesource.com/c/chromium/src/+/5267921
* 5310195: heap: Remove Blink's GCTaskRunner
https://chromium-review.googlesource.com/c/chromium/src/+/5310195
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-02-29 10:31:13 +01:00
Milan Burda
3885011220
chore: remove deprecated inputFieldType ( #41239 )
...
chore: remove deprecated inputFieldType
2024-02-26 07:47:16 -05:00
Calvin
12d7a8ff66
feat: Session#clearData API ( #40983 )
...
* WIP: Session.clearBrowsingData API
* impl API method
* clean up
* tidy types and comments
* add docs
* add barebones test
* forgot a `#` :(
* tidy: address review comments
* use format macro for cross-platform build
* add another test
* amend docs to disambiguate
* Rename to `clearData`
2024-02-26 09:39:17 +09:00
Shelley Vohr
e95673b052
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance} ( #41400 )
...
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance}
2024-02-23 10:35:20 +01:00
Robo
26131b23b8
feat: add support for configuring system network context proxies ( #41335 )
...
* feat: add support for configuring system network context proxies
* chore: add specs
* chore: fix lint
* fix: address review feedback
2024-02-22 12:08:25 -05:00
Samuel Attard
ddd93529d5
fix: use ScreenCaptureKit exclusively on macOS 14.4 and higher ( #41397 )
...
This fixes a nasty warning / permission dialog that pops up to end-users
when consuming legacy APIs. Chrome has flipped these flags via field trials
as have other Electron apps. It should just be the default.
2024-02-21 12:59:49 -08:00
electron-roller[bot]
e72f4f7f26
chore: bump chromium to 123.0.6312.5 (main) ( #41337 )
...
* chore: bump chromium in DEPS to 123.0.6300.2
* chore: bump chromium in DEPS to 123.0.6301.2
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6302.0
* chore: bump chromium in DEPS to 123.0.6304.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6306.2
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6308.0
* chore: update patches
* Refactor //components/pdf/common constants
https://chromium-review.googlesource.com/c/chromium/src/+/5292816
* Rename URLLoaderFactoryParams::is_corb_enabled to is_orb_enabled.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5277040
* Add placeholder of speaker-selection permission.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5278243
* Move kPdfMimeType to //components/pdf/common/constants.h
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5293155
* chore: gen-libc++-filenames.js
* Make GetClassName non virtual
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5293075
Refs https://issues.chromium.org/issues/324596267
* chore: bump chromium in DEPS to 123.0.6310.0
* chore: update filenames.libcxx.gni
* 5282732: Compute input region using correct pixel size.
https://chromium-review.googlesource.com/c/chromium/src/+/5282732
* fixup: Make GetClassName non virtual
* chore: bump chromium in DEPS to 123.0.6312.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6312.5
* fixup: Make GetClassName non virtual
* docs: document speaker-selection
https://chromium-review.googlesource.com/c/chromium/src/+/5278243
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-02-21 15:27:05 -05:00
Keeley Hammond
136d7e7e6a
fix: check for draggable regions outside of main frame ( #41377 )
2024-02-20 19:10:43 -08:00
Charles Kerr
7cd23a4900
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient() ( #41347 )
...
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient()
- (perf) GetBlinkPreferences() returns a const&, so we can use that
reference instead of making a temporary copy
- (perf) Don't create url object unless it's needed.
- (refactor) Move is_main_world() and is_isolated_world() from the
header into an anonymous namespace in the .cc file so they can
be inlined and made constexpr
2024-02-20 13:29:11 +01:00
Shelley Vohr
d4413a8e53
chore: remove unused anonymous namespace methods ( #41333 )
2024-02-16 10:31:34 -06:00
Samuel Attard
7d6a754d47
fix: skip the first two invalid updates when SCK is enabled ( #41340 )
2024-02-14 11:56:29 -08:00
electron-roller[bot]
0dad99561b
chore: bump chromium to 123.0.6296.0 (main) ( #41204 )
...
* chore: bump chromium in DEPS to 123.0.6273.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6274.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6276.0
* chore: update patches
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* chore: bump chromium in DEPS to 123.0.6278.0
* chore: bump chromium in DEPS to 123.0.6280.0
* chore: update patches
* chore: use net::CanonicalCookie::SecureAttribute()
renamed from IsSecure()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5245913
* refactor: handle multiple requested device ids
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5132210
* refactor: trigger View layouts async with View::InvalidateLayout()
Upstream has introduced a PassKey to restrict who can call Layout()
directly. I've opted for calling `InvalidateLayout()` which is the
approach that upstream recommends.
If for some reason this approach doesn't work for us, we could use
`DeprecatedLayoutImmediately()` as a stopgap.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5239586
Xref: https://chromium.googlesource.com/chromium/src/+/main/ui/views/view.h#809
Xref: https://chromium.googlesource.com/chromium/src/+/main/docs/ui/learn/bestpractices/layout.md?pli=1#don_t-invoke-layout_directly
* chore: bump chromium in DEPS to 123.0.6282.0
* chore: bump chromium in DEPS to 123.0.6284.0
* chore: update patches
* refactor: remove use of blink::MainThreadIsolate() pt 1/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 2/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 3/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* chore: update enum name to ui::AXMode::kPDFPrinting
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5270301
* chore: rebuild filenames.libcxx.gni
* chore: sync with upstream rename of PortProvider.TaskForHandle()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5259103
* chore: bump chromium in DEPS to 123.0.6286.0
* chore: bump chromium in DEPS to 123.0.6288.0
* WebPreferences: Initialize in declaration.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5277099
* chore: update webview_fullscreen.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5053508
Simple update to fix patch shear
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5254861
Simple update to fix patch shear
* chore: add IWC::Delegate::RecordResize() stub to fix FTBFS
https://chromium-review.googlesource.com/c/chromium/src/+/5268963
* chore: add FormControlType::kButtonPopover to the FormControlType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5230929
* chore: e patches all
* chore: node script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 123.0.6290.0
* chore: bump chromium in DEPS to 123.0.6291.0
* chore: bump chromium in DEPS to 123.0.6292.0
* chore: bump chromium in DEPS to 123.0.6294.0
* chore: update fix_aspect_ratio_with_max_size.patch
Xref: fix_aspect_ratio_with_max_size.patch
note: simple absl::optional -> std::optional conversion
* chore: update feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5272337
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; just adjusting line patch offsets
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5258688
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5281322
* chore: update fix_select_The_first_menu_item_when_opened_via_keyboard.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5279376
note: simple absl::optional -> std::optional conversion
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5268792
* chore: script/export_all_patches.py
* chore: bump chromium in DEPS to 123.0.6296.0
* chore: update patches
* fixup! chore: update feat_allow_code_cache_in_custom_schemes.patch
* fix: restore MessagePort close event
* spec: fix CORB testing
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5231506
* fix: use sync layout when content view changes
* fixup! chore: update feat_configure_launch_options_for_service_process.patch
* Add remote-cocoa support for context menus.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5259806
* Rename //net/base/mac directory to //net/base/apple (1/n)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5211389
* fixup! Add remote-cocoa support for context menus.
* [Clipboard] Don't add meta charset tag for async write() method on Mac.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5187335
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-02-14 12:33:32 -05:00
Mikhail Leliakin
79147e4dd8
fix: Ignore -webkit-app-region: drag; when window is in full screen mode. ( #41307 )
...
Co-authored-by: Mikhail Leliakin <lelyakin.aus@gmail.com>
2024-02-14 11:12:41 +01:00
Samuel Attard
32920af4b7
fix: add capability to use ScreenCaptureKit for thumbnail generation ( #41328 )
...
This aligns us with Chromiums flags / capabilities in regards to using SCK for
everything. Currently on 14.4 Electron apps will pop warnings for usage of
deprecated APIs. With this change and a few "enable-features" toggles.
`--enable-features="ScreenCaptureKitMac,ScreenCaptureKitStreamPickerSonoma,ThumbnailCapturerMac:capture_mode/sc_screenshot_manager"`
As Chromium enables these by default Electron will inherit those changes, apps wishing to skip ahead can apply these flags early.
2024-02-13 20:46:51 -08:00
Shelley Vohr
5f785f213e
revert: add BrowserWindow.isOccluded()
...
This reverts commit 768ece6b54
2024-02-12 09:35:34 +01:00
Shelley Vohr
4ded4d16a8
fix: destroy NodeService message pipe last ( #41277 )
...
refactor: destroy NodeService message pipe last
2024-02-09 22:44:35 +01:00
Shelley Vohr
c894645ac6
fix: crash on macOS non-programmatic close ( #41264 )
2024-02-09 22:44:24 +01:00
Charles Kerr
cee51785e1
refactor: inline simple getters, pt . 2 ( #41254 )
...
* refactor: inline AutofillPopup::line_count()
refactor: inline AutofillPopup::value_at()
refactor: inline AutofillPopup::label_at()
* refactor: inline NativeWindow::aspect_ratio()
refactor: inline NativeWindow::aspect_ratio_extra_size()
* refactor: inline BrowserProcessImpl::linux_storage_backend()
* refactor: inline ElectronMenuModel::sharing_item()
* refactor: inline Browser::badge_count()
* refactor: inline WebContents::is_guest()
refactor: inline InspectableWebContents::is_guest()
* refactor: inline InspectableWebContents::dev_tool_bounds()
* refactor: inline WebContents::type()
2024-02-09 10:29:14 +01:00
Cheng Zhao
92c5ff30a7
build: add flag for setting vendor version ( #41247 )
2024-02-06 14:23:17 -08:00
Charles Kerr
5686f88bd2
refactor: KeyWeakMap cleanup ( #41242 )
...
* refactor: make KeyWeakMap::KeyObject private
* perf: avoid redundant map lookup
* refactor: remove unused KeyWeakMap::Has()
* refactor: make KeyWeakMap dtor nonvirtual
no inheritance used, so no need for virtual dtor?
* chore: fix KeyWeakMap code comment
* refactor: use if statement in KeyWeakMap::Get()
* refactor: use better variable names in KeyWeakMap::Values()
2024-02-06 09:18:05 -06:00
Shelley Vohr
768ece6b54
feat: add BrowserWindow.isOccluded() ( #38982 )
...
feat: add BrowserWindow.isOccluded()
2024-02-06 11:30:35 +01:00
Charles Kerr
08236f7a9e
refactor: remove deprecated BrowserContext::ResourceContext ( #41221 )
...
* refactor: remove ResourceContext* arg from GetNSSCertDatabaseForResourceContext()
* refactor: remove ResourceContext* arg from CertificateManagerModel::GetCertDBOnIOThread()
* refactor: remove BrowserContext* arg from CertificateManagerModel::Create()
* refactor: remove unused forward declarations
* refactor: rename method to GetNSSCertDatabase()
* fixup! refactor: remove BrowserContext* arg from CertificateManagerModel::Create()
chore: remove unneeded line
2024-02-05 18:12:34 -06:00
Charles Kerr
2ebaebb603
refactor: replace use of deprecated base::JSONWriter::WriteJson() ( #41215 )
...
* refactor: use base::WriteJson() in ListValueToNSArray()
refactor: use base::WriteJson() in DictionaryValueToNSDictionary()
* refactor: use base::WriteJson() in Debugger::SendCommand()
* refactor: use base::WriteJson() in ScriptingExecuteScriptFunction::Run()
* refactor: use base::WriteJson() in HandleAccessibilityRequestCallback()
2024-02-02 12:25:58 -06:00
electron-roller[bot]
bccb7b572a
chore: bump chromium to 123.0.6272.0 (main) ( #41130 )
...
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: move nut-js to optional spec deps (#41199 )
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: typescript error for optional dependency
(cherry picked from commit ea17105c8c01bd1f4c1df5e72190a687d92f93cc)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
2024-01-31 17:04:13 -06:00
Shelley Vohr
e4d5dc138f
fix: select-usb-device should respect filters option ( #41166 )
...
fix: select-usb-device should respect filters option
2024-01-31 09:53:30 -05:00
Charles Kerr
0e0a0bf724
fix: avoid potential CHECK() failure in DictionaryToRect() ( #41160 )
...
refactor: use gfx::Rect::Contains() instead of reinventing the wheel
perf: use base::Value::FindInt() to avoid redundant map lookups
2024-01-30 14:48:47 -06:00
Charles Kerr
08615b2d4e
refactor: simplify code by using base::Value::EnsureList() ( #41162 )
2024-01-30 14:48:09 -06:00
Shelley Vohr
90c7d6c823
fix: shouldPrintBackgrounds -> printBackground in webContents.printToPDF ( #41161 )
...
fix: shouldPrintBackgrounds -> printBackground
2024-01-30 14:47:55 -06:00
Shelley Vohr
fc917985ae
fix: ensure WebContents before checking draggable region ( #41154 )
...
fix: ensure WebContents before checking draggable region
2024-01-30 11:53:19 +01:00
