Shelley Vohr
93df164485
add const and other small edits
2017-10-31 23:42:25 -04:00
Shelley Vohr
a538e47994
complete GetParameters method & all tests passing
2017-10-31 18:19:04 -04:00
Shelley Vohr
3136f833a5
fixes and updates to GetParameters
2017-10-31 13:51:44 -04:00
Felix Rieseberg
58708d6242
🔧 Lowercase
2017-10-31 10:31:05 -07:00
Shelley Vohr
a9c13359dc
first attempt to add new GetParameters method to CrashReporter
2017-10-31 13:06:54 -04:00
Felix Rieseberg
08b8f2df55
📝 Typo!
2017-10-31 08:38:33 -07:00
Shelley Vohr
06075c4499
extrapolate removeExtraParameter into new method
2017-10-30 23:12:04 -04:00
Felix Rieseberg
91414dde62
🔧 I can't believe this helps
2017-10-30 11:22:07 -07:00
Samuel Attard
c9926bed9f
Merge pull request #10954 from electron/less-process-metrics-warnings
...
fix: Don't call idleWakeupsPerSecond on Windows
2017-10-28 12:36:45 +13:00
Samuel Attard
dc8b583363
Merge pull request #10944 from electron/fix-notification-ref-crash
...
Close the previous notification on multiple calls to show
2017-10-28 12:33:30 +13:00
Felix Rieseberg
da21d6cdda
🔧 Don't call idleWakeupsPerSecond on Windows
2017-10-27 14:23:06 -07:00
Matt Crocker
b6fb016a9a
Cleanup per review comment
2017-10-27 00:07:54 -07:00
Matt Crocker
77a26882a3
Make linter happy
2017-10-27 00:04:19 -07:00
Matt Crocker
c5914516c8
Upstream good ideas from Muon
2017-10-27 00:04:19 -07:00
Matt Crocker
ca8f45a501
Notifications should emit close on close, not eventual GC
2017-10-27 00:04:19 -07:00
Samuel Attard
8719e9f098
Definitely didn't forget to push the header file
2017-10-27 16:27:37 +13:00
Samuel Attard
fe9069c028
Close the previous notification on multiple calls to show
2017-10-27 16:22:21 +13:00
Charles Kerr
c72e0c1508
Merge pull request #10902 from mattlyons0/master
...
🐧 Don't wait for xdg-open to exit
2017-10-26 09:43:34 -05:00
Paul Frazee
c2d9e082cb
Fix crash in custom protocols caused by bad callback exec
2017-10-25 21:01:53 -05:00
Matt Lyons
424f9aeae6
🐧 Don't wait for xdg-open to exit
...
Waiting for xdg-open to return freezes Electron application.
Some file managers (ex: Nemo) don't return until some time after they are closed, this freezes the Electron application until the process returns.
The same is true about any application that can potentially be opened with OpenItem
2017-10-24 19:39:54 -07:00
John Kleinschmidt
67f0eb7b3b
Merge pull request #10873 from ahmedmohamedali/fix_issue_10697
...
Fixes #10697
2017-10-23 09:32:28 -04:00
Ahmed Mohamed Ali
463260b249
Electron crashes if user clicks Dev Tools & Zoom options #10697
2017-10-21 22:21:24 +02:00
Ted Kim
4119da607f
Implement login helper to manage login item in Mac App Store build
2017-10-20 11:44:19 +09:00
Ahmed Mohamed Ali
9f3cfa2dbd
Fix crash that happens when the PDF viewer is refreshed.
...
The root cause is the PdfViewerHandler instanceis destroyed but not removed from the list of observer in WebContentsZoomController
2017-10-19 16:27:08 +02:00
John Kleinschmidt
90e7d7e112
v1.8.2-beta.1
2017-10-18 16:49:32 -04:00
Ahmed Mohamed Ali
05035eb1e3
Fix linefeeds
2017-10-18 17:36:56 +02:00
John Kleinschmidt
57537ea10e
Merge pull request #10810 from qazbnm456/add_error_code_to_session_set_certificate_verify_proc
...
Add error code to session.setCertificateVerifyProc
2017-10-18 09:33:37 -04:00
John Kleinschmidt
cbda307ebf
Merge pull request #10696 from primalmotion/patch-1
...
🍎 skip tabbing category if macOS < Sierra
2017-10-17 10:24:11 -04:00
Boik
f40cc5ab54
add error code to session.setCertificateVerifyProc
2017-10-16 17:17:21 +08:00
Ahmed Mohamed Ali
8763e8ee35
Fixing coding style
2017-10-14 11:17:52 +02:00
Ahmed Mohamed Ali
5030db000a
Applying changes requested by @deepak1556 after the review:
...
- Move RenderFrameHost methods in the UI thread
- Check GetAssociatedRenderFrame return value
2017-10-14 11:09:05 +02:00
Ahmed Mohamed Ali
1ad95eca4a
Add support for pdf in sub frames ( https://github.com/electron/electron/issues/9192#issuecomment-335543866 )
2017-10-13 19:56:20 +02:00
Birunthan Mohanathas
13b9b5c0c0
Merge pull request #10746 from electron/removeuserdefault
...
Add systemPreferences.removeUserDefault()
2017-10-12 16:08:57 +03:00
Samuel Attard
bdf3552be6
Merge pull request #10727 from electron/named-nativeimage
...
Add an API to get a nativeImage from a named NSImage
2017-10-12 10:02:07 +11:00
Birunthan Mohanathas
06d782279c
Add systemPreferences.removeUserDefault()
...
This can be used to restore the default or global value of a `key`
previously set with `setUserDefault`.
2017-10-10 22:57:47 +03:00
Samuel Attard
2c7787900f
Follow style guide
2017-10-10 17:20:55 +11:00
Samuel Attard
9308c96f95
Appease the linting overlords
2017-10-10 17:17:51 +11:00
Samuel Attard
b5ba8699f3
Enable hsl shifting of named images
2017-10-10 17:05:13 +11:00
Samuel Attard
767a178bd1
Do not throw if the named image can not be found
2017-10-10 03:18:44 +11:00
Samuel Attard
e027ba9c47
Add nativeImage.createFromNamedImage API
2017-10-10 03:13:40 +11:00
Samuel Attard
d350134c4f
Ensure that the touchbar's esape item can be set before setting it
2017-10-10 02:24:49 +11:00
Shelley Vohr
242e097e9b
Merge pull request #10670 from electron/add-linuxdefaultprotocol
...
add setAsDefaultProtocolClient for Linux
2017-10-07 10:07:02 -05:00
Shelley Vohr
443c30890b
remove dummy check
2017-10-07 10:38:08 -04:00
Shelley Vohr
35eea8bea5
remove unused xdg setting
2017-10-07 00:38:25 -04:00
Shelley Vohr
66827755e7
remove chrome check and change protocol handler
2017-10-07 00:36:18 -04:00
Shelley Vohr
a1347f67a1
remove a space from a comment wow thanks linter
2017-10-06 23:40:58 -04:00
Shelley Vohr
c9da806c84
slight refactor and lin cleanup
2017-10-06 23:32:46 -04:00
Antoine
5e6b683cfb
fixed: trying to fix the build
2017-10-05 15:57:27 -07:00
Antoine
8e1945f768
🍎 skip tabbing category if macOS < Sierra
...
Previously, the macro was ensuring the` MAC_OS_X_VERSION_10_12` was not defined to decide to compile a `NSWindow` category back porting native tabs or not.
This patch ensures to compile the `NSWindow` category only if the min required version is lesser than 1012 (`MAC_OS_X_VERSION_10_12`)
2017-10-05 14:11:58 -07:00
Shelley Vohr
f8f21815eb
syntax updates and pointer conversion
2017-10-05 00:30:14 -04:00
