Jeremy Apthorp
136105e353
fix: wrong list index type in file_dialog_gtk.cc ( #12952 )
2018-05-15 13:22:52 -05:00
Cheng Zhao
ea97f43145
check content view in SetMenuBarVisibility
2018-05-15 14:12:47 +09:00
Cheng Zhao
640877ebf8
attach native view after widget is created
2018-05-15 14:03:21 +09:00
Heilig Benedek
eae0674f61
Match chromium's workaround when setting size of unresizable windows
2018-05-12 17:37:31 +02:00
Cheng Zhao
5547df6073
report correct content size in AtomNSWindow
...
The views framework relies on NSWindow to return content size of window,
since we don't use the borderless window, the original result would
include titlebar. We have to override the function to return correct
result for frameless window.
2018-05-04 09:55:09 +09:00
Cheng Zhao
28fc58067b
remove usage of FullSizeContentView
2018-05-04 09:55:09 +09:00
Cheng Zhao
a9709a635c
display WebContents as views::View on macOS
2018-05-04 09:55:09 +09:00
Jeremy Apthorp
cdc5022305
Fix chromium-style errors ( #12802 )
2018-05-03 09:04:22 -05:00
Cheng Zhao
c67d1b62e3
refactor: NativeWindowViews should not be a View ( #12750 )
2018-05-01 13:28:22 +09:00
Cheng Zhao
cf70267871
remove unnecessary overrides
2018-04-26 09:48:12 +09:00
Cheng Zhao
39242c978f
fix failed BrowserWindow tests
2018-04-25 15:10:29 +09:00
Cheng Zhao
75a624434c
refactor: use views::Widget on macOS
2018-04-25 15:10:29 +09:00
Shelley Vohr
12a57ff1c2
clang-format objc files ( #12673 )
2018-04-20 11:47:04 -07:00
Cheng Zhao
c44279bb10
Move AtomNSWindow to a new file
2018-04-20 19:26:20 +09:00
Cheng Zhao
569967ac21
Move QLPreviewPanelDataSource to AtomNSWindowDelegate
2018-04-20 19:17:08 +09:00
Cheng Zhao
f6a7e5ea23
Move NSTouchBarDelegate to AtomNSWindowDelegate
2018-04-20 19:15:45 +09:00
Cheng Zhao
ce54fd334d
Move AtomNSWindowDelegate to a new file
2018-04-20 19:12:17 +09:00
Cheng Zhao
9bc79f840e
mac: Override NativeWidgetMac
2018-04-20 19:10:37 +09:00
Cheng Zhao
37a7df49d6
mac: Provide ViewsDelegate
2018-04-20 19:10:37 +09:00
deepak1556
30f1d0991b
enable chromium style checker plugin for electron and brightray targets
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
eb7ccf8afa
Bring mac code into conformance with -Wobjc-missing-property-synthesis
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f3c00e96aa
Bring mac code into conformance with -Wunguarded-availability
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
27cee90e5e
[chromium-style] move methods out of headers
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f1587da480
[chromium-style] out-of-line default constructors and destructors
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
e6695cf2ec
[chromium-style] override / virtual warnings
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Shelley Vohr
53bdf22c85
clang-format atom files
2018-04-18 20:48:45 -04:00
Shelley Vohr
d722008367
remove unnecessary ptr_util.h include
2018-04-12 22:34:26 -04:00
Shelley Vohr
b05932310b
replace base::MakeUnique with std::make_unique
2018-04-12 08:48:32 -04:00
Cheng Zhao
97e8800677
Remove web_contents from NativeWindow's constructor
2018-04-11 15:12:53 +09:00
Cheng Zhao
41134f52d9
Fix memory leaks in file_dialog_mac.mm
2018-04-09 16:51:25 +09:00
Yuya Ochiai
2131dc839a
Show file filter name for accessory view of file dialog
...
- Respect filters option of dialog.showOpenDialog() and
dialog.showSaveDialog(). (#10335 )
- Show "All Files" for <input> apart from "accept" attribute. (#11456 )
2018-04-09 16:50:21 +09:00
Charles Kerr
f8b8dc1494
Simplify views/menu_bar focus management ( #12536 )
...
* Simplify views/menu_bar focus management
* Make the linter happy
* Remove NativeWindowView focus manager listener API
* remove unnecessary change
* MenuBar ctor now takes a views::View
2018-04-05 21:53:08 -05:00
Heilig Benedek
a14ebc80d2
Disable chromium's redraw locking on Windows when DWM is disabled ( #12501 )
...
* disable redraw locking on windows
* update libcc ref
2018-04-05 15:55:26 +09:00
Cheng Zhao
c75dd93b92
Move AutofillPopup from NativeWindow to WebContents ( #12514 )
2018-04-05 09:53:51 +09:00
Cheng Zhao
8fc5c6c862
Refactor NativeWindow (Part 3): Remove is_offscreen_dummy from NativeWindow ( #12503 )
...
* Don't use is_offscreen_dummy in MessageBox
* Don't use is_offscreen_dummy in DownloadManagerDelegate
* Don't use is_offscreen_dummy in CommonWebContentsDelegate
* Remove is_offscreen_dummy from NativeWindow
2018-04-03 12:19:35 +09:00
Zhuo Lu
c50a460ce6
Do not block main process for async dialog ( #12404 )
2018-03-22 08:57:33 -04:00
Shelley Vohr
05dc04dacc
don't check darkmode for drawStatusBarBackgroundInRect ( #12395 )
2018-03-21 19:03:57 -04:00
Charles Kerr
0d7becff87
Use the appname as the tray icon's default tooltip ( #12388 )
...
This makes an upstream DCHECK happy in AppIndicatorIcon::SetToolTip.
Empty tooltip strings are discouraged, as discussed in commit log
b6c510aa543193337041517c2d70113840189b06.
Fixes #12386 .
2018-03-21 12:15:30 -05:00
deepak1556
e24c0dda5d
add features module to detect availability of build time features at runtime
2018-03-20 10:13:17 +03:00
deepak1556
4b39d17e5f
move pdf viewer behind feature flag
2018-03-20 10:13:17 +03:00
Shelley Vohr
9599615b23
Fix nil tray title crash ( #12352 )
...
* Add check for title_ being nil
* remove print stub
2018-03-19 10:49:39 -05:00
Charles Kerr
558ef7352d
Better GTK+ Menu color support ( #12300 )
...
* Better GTK+ Menu color support
* Fix 'invisible menu' issue (#12275 )
* Now updates menu text color when focus changes!
* Better caching of colors when system theme changes
* Removed all GTK+ deprecation warnings from menubar
* Don't highlight menu text on mouseover in GTK+
* Fix textColor declaration scope error
* Simplify FocusManager connection management a bit
* Make the linter happy
* Decouple MenuBar view recoloring from rebuilding
This way we don't need to rebuild the subview each time a recolor
is needed, e.g. when window focus changes or the system theme changes
* Don't iterate child views if we don't need to
* Move variable declaration outside of a loop
* More efficient iteration of MenuBar children
* Cleaner MenuButton bounds testing
* Fix oops
* Add a nullptr check in MenuBar::GetItemCount()
* Simplify iteration in MenuBar::RebuildChildren()
* Make the linter happy
* Fix signed-unsigned comparison
* Remove declarations of nonexistent methods
* Make SubmenuButton accessor const
* Cleaner accelerator iteration
* Windows fixes
2018-03-17 06:37:36 +09:00
Cheng Zhao
f7786a9e48
Merge pull request #11230 from electron/upgrade-to-chromium-62
...
Upgrade to Chromium 62
2018-02-26 14:20:21 +09:00
kaylie
da9f12d1e2
restore old cb
2018-02-25 14:19:40 -08:00
Aleksei Kuzmin
9fa08fdbc0
Merge views::CustomButton into views::Button.
...
https://chromium-review.googlesource.com/617407
2018-02-23 10:21:24 +09:00
deepak1556
25d966110e
FIXME: PDF component IPC should be converted to Mojo.
...
https://codereview.chromium.org/2455543002
2018-02-23 10:21:23 +09:00
Charles Kerr
56859531cd
fix floating reference glib warning ( #11948 )
...
use gtk_widget_destroy() rather than g_object_unref() on the floating temporary menubar widget that we use to calculate colors
2018-02-19 00:12:54 -06:00
John Kleinschmidt
78ccfa0612
Merge pull request #11879 from electron/fix-gtk-deprecations
...
Fix GTK+ 3 deprecations
2018-02-16 10:01:01 -05:00