Milan Burda
2337237d58
Refactoring: use C++11 class member variable initialization
2018-05-22 00:18:38 +02:00
Cheng Zhao
595b0663b2
WebContents may be managed by multiple owners
2018-05-21 10:53:09 +09:00
Cheng Zhao
3b81312cf7
clear pointer when WebContents is closed
2018-05-21 10:53:09 +09:00
Cheng Zhao
51db1efb8a
prevent double-adding a WebContents to view
2018-05-21 10:53:09 +09:00
Cheng Zhao
aeeb2a259f
destruct objects in stack order
2018-05-21 10:53:09 +09:00
Cheng Zhao
fd4a0626c5
destroy WebContents when view is destroyed
2018-05-21 10:53:08 +09:00
htk3
7c2303c758
Correct app-command name of APPCOMMAND_MEDIA_PLAY_PAUSE ( #12408 )
...
* correct app-command name
* add compatibility with old app-command name
* add temporary compatibility with old app-command name
* add a comment saying that media-play_pause is deprecated
* fix lint
2018-05-21 10:52:04 +09:00
Heilig Benedek
8b2bffcf9e
Only expand maximum size constraint if there was a constraint originally ( #13003 )
2018-05-21 10:56:45 +10:00
Jeremy Apthorp
156a97b80d
fix: Menu.setApplicationMenu(null) crash on Linux ( #12983 )
2018-05-18 10:29:28 -07:00
Milan Burda
850051463b
don't use native_mate/compat.h macros ( #12984 )
2018-05-18 09:08:28 +09:00
Zhuo Lu
d2653e8192
Fix: Prevent menu update while it's open ( #12809 )
...
* Update application menu on default runloop
Menu change should be prevented while the menu is open
* Fix code style
* Memory safety
2018-05-17 11:19:28 +10:00
Jeremy Apthorp
da0fd10423
refactor: chromium-style warnings in linux code ( #12949 )
2018-05-16 14:12:45 -05:00
John Kleinschmidt
9488ef4867
Merge pull request #12496 from mikeykhalil/8952-ignore-tray-double-click-events
...
8952 option to ignore tray double click events
2018-05-16 10:17:36 -04:00
John Kleinschmidt
e1c374de6e
Merge pull request #12954 from electron/web-dialog-helper
...
Fix empty description when only one extension is given (GetFileTypesFromAcceptType)
2018-05-16 10:15:54 -04:00
Milan Burda
211d7825d3
feat: DIP <-> screen coordinate conversions ( #12879 )
2018-05-16 18:34:09 +09:00
Milan Burda
9d9d6ca20b
Fix empty description when only one extension is given
2018-05-16 01:58:58 +02:00
Jeremy Apthorp
73eb5af2cc
refactor: remove unnecessary std::moves in linux code ( #12951 )
...
The compiler was complaining that the move was preventing copy elision.
2018-05-15 14:33:47 -07:00
Jeremy Apthorp
8fa48d1c04
fix: unused variable warnings in linux code ( #12950 )
2018-05-15 13:49:27 -05:00
Jeremy Apthorp
c4134c3516
refactor: breakpad #includes to work with GN and GYP ( #12953 )
2018-05-15 11:33:19 -07:00
Jeremy Apthorp
136105e353
fix: wrong list index type in file_dialog_gtk.cc ( #12952 )
2018-05-15 13:22:52 -05:00
Milan Burda
6a4d9309b2
Remove unnecessary heap allocations of atom::V8ValueConverter instances ( #12924 )
2018-05-15 09:21:23 -05:00
Cheng Zhao
2f3fcb9dbe
give window a default content view
...
Certain APIs are expecting the window to have a content view, having a
default one simplifies our design.
2018-05-15 14:12:47 +09:00
Cheng Zhao
ea97f43145
check content view in SetMenuBarVisibility
2018-05-15 14:12:47 +09:00
Cheng Zhao
bb2715e7a5
feat: add TopLevelWindow.setContentView API
2018-05-15 14:12:47 +09:00
Cheng Zhao
2b24b26e59
refactor: do not pass WebContents to NativeWindow
2018-05-15 14:03:21 +09:00
Cheng Zhao
640877ebf8
attach native view after widget is created
2018-05-15 14:03:21 +09:00
Cheng Zhao
5a320222e2
feat: add WebContentsView API
2018-05-15 14:03:21 +09:00
Cheng Zhao
e058d11657
feat: add View API
2018-05-15 14:03:21 +09:00
John Kleinschmidt
fe7947da90
Merge pull request #12805 from electron/update-blacklist-switches
...
update command-line backlist switches
2018-05-14 13:31:26 -04:00
John Kleinschmidt
0fd8513c80
Merge pull request #12904 from electron/fix-12875
...
Allow frameless transparent windows to be sized smaller than 64x64 on Windows
2018-05-14 10:46:40 -04:00
Heilig Benedek
ce8af7d499
#else instead of #elif
2018-05-12 22:05:25 +02:00
Heilig Benedek
c6bf39b283
Only include windows headers on windows
2018-05-12 21:33:47 +02:00
Heilig Benedek
f1fd457411
Format code with clang-format
2018-05-12 19:51:19 +02:00
Heilig Benedek
eae0674f61
Match chromium's workaround when setting size of unresizable windows
2018-05-12 17:37:31 +02:00
Jeremy Apthorp
cc386f2345
Merge pull request #12884 from nornagon/views-defines
...
Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code
2018-05-10 14:13:19 -07:00
Jeremy Apthorp
72057bf7ef
clang-format atom_api_web_contents.cc
2018-05-10 14:11:19 -07:00
Jeremy Apthorp
87d0175c76
Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code
2018-05-10 14:11:19 -07:00
Jeremy Apthorp
73ac019882
Fix up #includes to work with both GYP and GN
2018-05-10 13:38:40 -07:00
Samuel Attard
5b5c161601
feat: new makeSingleInstance API ( #12782 )
...
* Refactor app.makeSingleInstance
* new API `app.isPrimaryInstance()`
* new API `app.isSingleInstance()`
* new event `app.on('second-instance')`
* deprecated old syntax `app.makeSingleInstance(cb)`
* deprecated old syntax of `app.makeSingleInstance() --> bool` in favor
of `app.isPrimaryInstance()`
* Fix spec, we don't need process.nextTick hacks any more
* Make deprecation TODO for the return value of makeSingleInstance
* Refactor makeSingleInstance to requestSingleInstanceLock and add appropriate deprecation comments
* I swear this isn't tricking the linter
* Make const
* Add deprecation warnings for release, and add to planned-breaking-changes
BREAKING CHANGE
2018-05-08 01:29:18 +10:00
Jeremy Apthorp
118da36b52
Send document-start/end to the right context when contextIsolation=true ( #12738 )
2018-05-04 23:39:54 -07:00
Jeremy Apthorp
b280ea5579
chromium-style fixes ( #12826 )
2018-05-03 23:45:12 -07:00
Cheng Zhao
a2c3db666e
viewDidMoveToSuperview may not be implemented
2018-05-04 09:55:09 +09:00
Cheng Zhao
5547df6073
report correct content size in AtomNSWindow
...
The views framework relies on NSWindow to return content size of window,
since we don't use the borderless window, the original result would
include titlebar. We have to override the function to return correct
result for frameless window.
2018-05-04 09:55:09 +09:00
Cheng Zhao
28fc58067b
remove usage of FullSizeContentView
2018-05-04 09:55:09 +09:00
Cheng Zhao
a9709a635c
display WebContents as views::View on macOS
2018-05-04 09:55:09 +09:00
Cheng Zhao
ada884a129
refactor: setup contentView on initialization
2018-05-04 09:55:09 +09:00
mikeykhalil
94ffd4bfc0
add getter for ignoreDoubleClickEvents field
2018-05-03 13:49:33 -07:00
mikeykhalil
208374afa4
clean up ignore double click event implementation
2018-05-03 13:49:33 -07:00
mikeykhalil
1f29124d11
updated Tray API to ignore double click events on macOS ( #8952 )
2018-05-03 13:49:32 -07:00
Alexey Kuzmin
3fd0ec99ae
Better OSR tests ( #12817 )
...
* Add features.isOffscreenRenderingEnabled()
* Use .isOffscreenRenderingEnabled() to determine if OSR is available
* Add a helper closeTheWindow() function
* Skip OSR tests if they are disabled
2018-05-03 11:10:25 -05:00