Charlie Hess
f6410d3b77
Assert that listener count decreases after a remove event.
2017-01-25 12:36:55 -08:00
Charlie Hess
c213971a2d
Write a warning instead of crashing.
2017-01-25 12:36:55 -08:00
Charlie Hess
bc2f1e8199
Argh.
2017-01-25 12:36:55 -08:00
Charlie Hess
63d8137da2
Use EventEmitter public methods instead of _events.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
45986405b8
Assert remote event names
2017-01-25 12:36:55 -08:00
Charlie Hess
a0b24bd155
Simplify.
2017-01-25 12:36:55 -08:00
Charlie Hess
67f7a60524
Review CommentZ
2017-01-25 12:36:55 -08:00
Charlie Hess
41ea169784
L I N T I N G P T I I
2017-01-25 12:36:55 -08:00
Charlie Hess
49c6446267
L I N T I N G
2017-01-25 12:36:55 -08:00
Charlie Hess
26e3ad3c2e
Display more information about remote event crashes.
...
If possible, we'll dig into the function args and print the ones that are attached remotely.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
d6eb0d6629
Implement insertCSS on webFrame
2017-01-19 09:05:59 +02:00
Kevin Sawicki
6bcfd0630c
Document implemented APIs at the top
2017-01-16 12:38:16 -08:00
Kevin Sawicki
f4f0174746
Parse guestInstanceId and opener as ints
2017-01-16 12:38:16 -08:00
Kevin Sawicki
fbcbfbda6a
Add back BrowserWindowProxy location property
2017-01-16 12:38:16 -08:00
Kevin Sawicki
de4be56b09
Use internal open event name with fully parsed options
2017-01-16 12:38:16 -08:00
Kevin Sawicki
f3852c57fc
Use empty string for comparison
2017-01-16 12:38:16 -08:00
Kevin Sawicki
2e6d08c652
Remove unneeded this prefix
2017-01-16 12:38:16 -08:00
Kevin Sawicki
bb260343de
Move more functions to outer scope
2017-01-16 12:38:16 -08:00
Kevin Sawicki
3f7b3c4bd7
Implement window overrides in main context
2017-01-16 12:38:16 -08:00
Kevin Sawicki
95054f443f
Enable context isolation on child windows
2017-01-16 12:38:16 -08:00
Javan Makhmali
a64bdbd306
Add "context-menu" DOM event to <webview>
2017-01-13 17:04:09 -05:00
Kevin Sawicki
1944fdc962
Track visited parents and null out cycles
2017-01-06 09:58:40 -08:00
Kevin Sawicki
5f862effaa
Access directly on options object
2017-01-06 09:17:32 -08:00
Kevin Sawicki
eb533e04b9
Add option to normalize dialog access keys
2017-01-06 08:56:24 -08:00
Kevin Sawicki
2bd8ef83d1
Use != null to handle undefined
2016-12-12 16:25:56 -08:00
Daniel Pham
4b53cd9c3c
🐛 Allow buttons to be optional in 'showMessageBox'
2016-12-12 13:25:32 -05:00
Kevin Sawicki
820fb3b82b
Guard against no devtools web contents
2016-12-06 10:36:59 -08:00
Kevin Sawicki
d6d85ade8e
🎨 Assign binding as const
2016-12-02 13:40:31 -08:00
Kevin Sawicki
1278e8cebc
Remove unused variable
2016-12-02 13:40:31 -08:00
Kevin Sawicki
3b99827540
Coerce features to string
2016-12-02 13:40:31 -08:00
Kevin Sawicki
635c909aab
Implement window.alert/confirm/close in main process
2016-12-02 13:40:31 -08:00
Kevin Sawicki
f894da13b0
Pass args array instead of arguments object
2016-12-02 13:40:31 -08:00
Kevin Sawicki
ec43dd067c
Co-locate with other private methods
2016-12-02 10:41:42 -08:00
Kevin Sawicki
f3d391e3f2
Don't clear until render view is deleted for process id
2016-12-02 10:41:42 -08:00
Kevin Sawicki
07f99c06ea
Don't write back to passed in options object
2016-12-01 17:16:18 -08:00
Kevin Sawicki
f56b00718b
Remove unused method
2016-12-01 14:56:00 -08:00
Kevin Sawicki
af555bd879
Use spread syntax instead of apply
2016-12-01 14:56:00 -08:00
Kevin Sawicki
c8ff67ab75
Use spread syntax instead of function apply
2016-12-01 14:56:00 -08:00
Kevin Sawicki
36371357cd
buttonLabel -> Button label for consistency
2016-12-01 14:16:33 -08:00
Kevin Sawicki
477ac313ab
Merge pull request #8086 from deepak1556/devtools_remove_workspace_patch
...
override window.confirm in devtools
2016-11-29 13:31:21 -08:00
Kevin Sawicki
72e559458f
Inline buttons and cancelId values
2016-11-29 13:30:28 -08:00
Kevin Sawicki
bb9876bd6e
Remove deprecation warning for autoSubmit
2016-11-28 15:08:28 -08:00
Samuel Attard
2bf6f28152
shouldUpload --> uploadToServer
2016-11-28 15:08:28 -08:00
Samuel Attard
4b61a4d3de
Fix linting
2016-11-28 15:08:28 -08:00
Samuel Attard
285a36f9de
Use GetUploadsEnabled to return GetShouldUpload
2016-11-28 15:08:28 -08:00
Samuel Attard
5a1a2616aa
Fix build issues
2016-11-28 15:08:12 -08:00
Samuel Attard
0d1804b2a0
Fix issues and deprecate the old prop
2016-11-28 15:08:12 -08:00
Samuel Attard
7b8eb3e09c
Rename autoUpload to shouldUpload
2016-11-28 15:08:12 -08:00
Kevin Sawicki
6f6c5c07f0
Remove unintended returns
2016-11-28 10:56:23 -08:00
Kevin Sawicki
3a29555772
Access URL through webContents directly
2016-11-28 10:56:23 -08:00
deepak1556
3ac9858726
override window.confirm in devtools
2016-11-28 01:08:48 +05:30
Cheng Zhao
bbaab755e3
Merge pull request #8049 from electron/prevent-remove-all-ipc
...
Throw an error when users attempt to remove all listeners from the IPC modules
2016-11-27 14:29:49 +08:00
Kevin Sawicki
0593696344
Remove unnecessary escape characters
2016-11-23 14:27:54 -08:00
Kevin Sawicki
0134d62681
Always use guest contents for canAccessWindow check
2016-11-23 12:01:09 -08:00
Kevin Sawicki
9a5df9da41
Expose setVisualZoomLevelLimits on webContents and <web-view>
2016-11-22 08:07:55 -08:00
Samuel Attard
db729b5b52
Throw an error when users attempt to remove all listeners from the IPC modules
2016-11-22 18:30:58 +11:00
Paul Betts
e2649ce7d8
Add new method to set layout-based zoom level limit
2016-11-21 14:59:55 -05:00
Kevin Sawicki
996ddba715
Add rpc error for ELECTRON_BROWSER_MEMBER_GET
2016-11-17 12:29:23 -08:00
Kevin Sawicki
88959079bd
Add toggledevtools menu item role
2016-11-17 10:57:20 -08:00
Kevin Sawicki
0698b5f1be
Add reload menu item role
2016-11-17 10:57:20 -08:00
Kevin Sawicki
28c39d5151
Merge pull request #8003 from electron/missing-remote-object-error
...
Throw custom error when remote object is missing from registry
2016-11-17 10:57:03 -08:00
Kevin Sawicki
5427ec4844
Negate code as per node docs
2016-11-17 10:22:29 -08:00
Kevin Sawicki
aef898ad93
Set errno on RPC error
2016-11-17 10:09:29 -08:00
Kevin Sawicki
c05ca68811
Throw custom error when remote object is missing from registry
2016-11-17 09:55:13 -08:00
Cheng Zhao
3834f0c6a6
Merge pull request #7974 from electron/chrome-runtime-response-callback
...
Implement chrome.runtime.onMessage response callback
2016-11-17 13:01:38 +09:00
Samuel Attard
7c26ec8bd4
Remove semicolon
2016-11-17 14:56:44 +11:00
Kevin Sawicki
651eaec64f
Use sender.id instead of sender.webContents.id
2016-11-16 07:50:30 -08:00
Kevin Sawicki
92577c37c8
Don't log blocked messages when guestWindow is null
2016-11-16 07:50:30 -08:00
Cheng Zhao
18fca785c4
Print error messages
2016-11-16 07:50:30 -08:00
Cheng Zhao
a1066617a8
Do permission check when calling guest window methods
2016-11-16 07:50:30 -08:00
Kevin Sawicki
5167ccd147
Guard against missing members in setObjectMembers
2016-11-16 07:45:34 -08:00
Kevin Sawicki
bea1a0643c
Memoize ELECTRON_NO_ASAR env var check
2016-11-16 07:37:53 -08:00
Birunthan Mohanathas
2986b7bc4a
Allow webview guests to be resized manually
...
This adds the `disableguestresize` property for webviews to prevent the
webview guest from reacting to size changes of the webview element. This
also partially documents the `webContents.setSize` function in order to
manually control the webview guest size.
These two features can be combined to improve resize performance for
e.g. webviews that span the entire window. This greatly reduces the lag
described in #6905 .
2016-11-15 11:00:09 -08:00
Kevin Sawicki
eeffa42513
Merge pull request #7923 from jhen0409/patch-1
...
Add support remove / clear for chrome.storage
2016-11-15 09:04:45 -08:00
Samuel Attard
01005688b6
Implement chrome.runtime.onMessage response callback
2016-11-15 21:30:40 +11:00
Kevin Sawicki
50019f39e9
🎨
2016-11-11 10:54:01 -08:00
deepak1556
5f596b22c7
specify content type depending on post data
2016-11-11 10:54:01 -08:00
deepak1556
2d7ceae320
fix js lint error
2016-11-11 10:53:00 -08:00
deepak1556
0410a184ce
webContents: handle POST navigation for new windows
2016-11-11 10:53:00 -08:00
Jhen
b86dff45d7
Add support remove / clear for chrome.storage
2016-11-12 02:16:51 +08:00
Kevin Sawicki
6fda4fc45c
Guard against attachedCallback firing while handling detachedCallback
2016-11-07 13:42:36 -08:00
Kevin Sawicki
133ad6e18b
Only set size and load URL on first attach
2016-11-07 13:42:36 -08:00
Kevin Sawicki
a737732521
Only remove guest from embedder when view id changes
2016-11-07 13:42:36 -08:00
Kevin Sawicki
73774f21b7
🎨
2016-11-07 08:28:02 -08:00
Kevin Sawicki
3c18de9c5a
Only return when guestInstance is non-null
2016-11-07 08:25:01 -08:00
Kevin Sawicki
0485069c7b
Use spread operator
2016-11-07 08:25:01 -08:00
Kevin Sawicki
e4d6aa30a1
Do truthy check in if block
2016-11-07 08:25:01 -08:00
Kevin Sawicki
89a26684e5
Return webContents directly
2016-11-07 08:25:01 -08:00
Kevin Sawicki
0e1c2b0fcb
Use for/of and remove loop variables
2016-11-07 08:25:01 -08:00
Kevin Sawicki
6eab14359c
Use ES6 style class for WebViewImpl
2016-11-07 08:25:01 -08:00
Kevin Sawicki
76f96bd99c
Destructure requires
2016-11-07 08:25:01 -08:00
Kevin Sawicki
48bcad87c2
Use template strings
2016-11-07 08:25:01 -08:00
Kevin Sawicki
712b15286c
Use let/const instead of var
2016-11-07 08:25:01 -08:00
Kevin Sawicki
3053be345b
Remove unneeded returns
2016-11-07 08:25:01 -08:00
Kevin Sawicki
e0afb814aa
Only call browserify when one of sandbox sources change
2016-11-07 08:19:59 -08:00
Kevin Sawicki
8e203592e2
🎨 Remove extra returns
2016-11-03 09:51:01 -07:00
Samuel Attard
9f18a6e65c
Use ES6 template strings, fix docs and remove _ERROR_ IPC event
2016-11-03 09:33:47 -07:00
Samuel Attard
857e1da6a3
Make executeJavaScript return a Promise so that caught errors can be sent to the caller
2016-11-03 09:33:47 -07:00
Samuel Attard
75b010ce63
Add sync executeJavaScript test
2016-11-03 09:33:47 -07:00
Samuel Attard
124fbdbd74
Allow web frame methods to return async promises
2016-11-03 09:33:47 -07:00
Brendan Forster
651b0c0f82
fixed a couple of typos
2016-10-31 08:59:26 -07:00
Cheng Zhao
dfefa00a50
Merge pull request #7577 from thomsonreuters/net_module
...
net module
2016-10-31 10:31:56 +09:00
ali.ibrahim
bdb3f4d4cb
Fixing code review issues: adding some test cases for partition/session options.
2016-10-25 16:19:26 +02:00
ali.ibrahim
b44d5290e2
Fixing code review issues: adding a partition options and making the session option only takes Session objects.
2016-10-25 15:47:54 +02:00
ali.ibrahim
61278f9ace
Fixing code review issues.
2016-10-25 12:41:01 +02:00
Kevin Sawicki
1718697ef0
Read/write find pasteboard text via IPC in renderer process
2016-10-25 14:15:54 +09:00
Kevin Sawicki
68c2c9825f
Remove lint warnings
2016-10-25 10:36:43 +09:00
Kevin Sawicki
3aad6a0c99
Use forEach and destructuring for parsing features
2016-10-25 10:31:50 +09:00
Paul Frazee
f35536bdc5
factor out parse-features-string.js
2016-10-24 20:21:42 -05:00
ali.ibrahim
7f8b180f70
Fixing authentication cancel with null/undefined credentials.
2016-10-20 11:43:26 +02:00
ali.ibrahim
c198828e58
Adding gc tests: fixing a memory leak with C++ URLRequest objects.
2016-10-17 19:02:25 +02:00
Paul Frazee
e7962c7ba2
fixes and tests for webview 'webpreferences' attr
2016-10-14 18:04:33 -05:00
Paul Frazee
194b14100e
add the 'webpreferences' attribute to webviews
2016-10-14 17:16:39 -05:00
ali.ibrahim
0e13b8dd01
making the net module usable only after the ready event.
2016-10-14 17:57:37 +02:00
ali.ibrahim
6f5b0a28c5
Fixing code review issues: function call formatting, renaming JS member variables, refactoring response headers conversion.
2016-10-13 17:14:23 +02:00
Samuel Attard
a9d5699a52
Update standard to v8 to be inline with standard-markdown
2016-10-13 12:46:00 +11:00
Kevin Sawicki
fefc7c23f9
Merge pull request #7479 from bpasero/process-no-asar
...
Introduce ELECTRON_NO_ASAR
2016-10-12 13:48:03 -07:00
Kevin Sawicki
f553d16539
Only support ELECTRON_NO_ASAR in non browser/renderer processes
2016-10-12 11:11:27 -07:00
Benjamin Pasero
656ee0d9c3
introduce ELECTRON_NO_ASAR
2016-10-12 11:11:27 -07:00
ali.ibrahim
ae1c33b863
fixing linter issues.
2016-10-12 14:54:32 +02:00
ali.ibrahim
a5c508d2d7
Adding abort, webRequest interception and creation tests.
2016-10-12 14:54:31 +02:00
ali.ibrahim
4eb9fc1bb6
Adding chunked uploading test.
2016-10-12 14:54:29 +02:00
ali.ibrahim
9b94dfcbdc
Adding basic http tests, fixing issues in ClientRequest constructor.
2016-10-12 14:54:29 +02:00
ali.ibrahim
42bae9d71d
Making the HTTP response a full-fledged Readable stream.
2016-10-12 14:54:27 +02:00
ali.ibrahim
ec1fc5a17b
Implementing error, close, finish, abort events management.
2016-10-12 14:54:24 +02:00
ali.ibrahim
42adb2afd4
Fixing lint-js issues.
2016-10-12 14:54:22 +02:00
ali.ibrahim
08947682b0
Implementing abort workflow, emitting error events.
2016-10-12 14:54:21 +02:00
ali.ibrahim
cbbc4376ca
Adding support for upload chunked encoding.
2016-10-12 14:54:20 +02:00
ali.ibrahim
9498a5738a
Refactoring net module, adding a ClientRequest and IncomingMessage classes.
2016-10-12 14:54:20 +02:00
ali.ibrahim
fcaf9cb031
Some code cleaning.
2016-10-12 14:54:19 +02:00
ali.ibrahim
f7525d7877
Adding support for POST requests.
2016-10-12 14:54:18 +02:00
ali.ibrahim
2b3b41d5f9
Implementing authentication callback.
2016-10-12 14:54:18 +02:00
ali.ibrahim
2d9d4af98d
Implementing URLRequest API, getting response body.
2016-10-12 14:54:17 +02:00
ali.ibrahim
81eab9887b
Adding URLResponse to emit response events, implementing status code.
2016-10-12 14:54:16 +02:00
ali.ibrahim
7521aeea09
Implement URLRequest::Delegate, handle thread sync.
2016-10-12 14:54:15 +02:00
ali.ibrahim
e8d4abe78f
Adding net module and URLRequest class.
2016-10-12 14:54:15 +02:00
Zeke Sikelianos
d4a8a64ba7
Merge pull request #7498 from electron/custom-props-in-menu-item-constructor
...
Preserve custom properties passed to MenuItem constructor
2016-10-11 14:24:13 -07:00
Zeke Sikelianos
8aaf029e55
remove unused var
2016-10-10 15:38:27 -07:00
Zeke Sikelianos
b575055d7e
inherit user-specific MenuItem properties more safely
2016-10-10 14:40:49 -07:00
Zeke Sikelianos
2cd10d339f
remove duplicated prop copying
2016-10-10 11:07:01 -07:00
Cheng Zhao
91591f37e6
Merge pull request #7500 from electron/store-crashes-in-configured-temp-dir
...
Store crash reports in configured temp dir
2016-10-10 10:19:02 +09:00
Samuel Attard
09e5035ab5
Default webPreferences to empty object always
2016-10-07 11:45:13 +11:00
Zeke Sikelianos
b7e078e98d
sanitize MenuItem options
2016-10-06 14:37:13 -07:00
Kevin Sawicki
d39182b41a
Pass crashes directory instead of product name and temp dir
2016-10-06 10:55:11 -07:00
Kevin Sawicki
16e3991ffa
Guard against app.getPath throwing with OS fallback
2016-10-06 10:07:40 -07:00
Kevin Sawicki
883c4b63d0
temp_path -> temp_dir
2016-10-06 09:02:02 -07:00
Kevin Sawicki
0380d3ae50
Pass crashes directory to crash service process
2016-10-06 09:02:02 -07:00
Kevin Sawicki
43702e0f8e
Support calling getUploadedReports on unstarted crash reporter
2016-10-06 09:02:02 -07:00
Kevin Sawicki
a0db484510
Use app.getPath directly for temp path
2016-10-06 09:02:02 -07:00
Kevin Sawicki
f282b51c98
🎨 Use ES6 class, destructuring, and let/const
2016-10-06 09:02:01 -07:00
Kevin Sawicki
ac0658bbf1
Use PathService for temp dir path for crashes
2016-10-06 09:02:01 -07:00
Zeke Sikelianos
16b3962b66
preserve custom properties passed to MenuItem constructor
2016-10-05 12:24:08 -07:00
Michael Vasseur
3dd41bc09a
Fix errors
2016-10-05 11:46:55 +02:00
Michael Vasseur
9490ec7686
Fix JS Lint issues
2016-10-05 09:47:39 +02:00
Michael Vasseur
a2b3cf95a7
Sets correct openerId in mergeBrowserWindowOptions() to give correct options to 'new-window' event handler
2016-10-05 09:47:39 +02:00
Michael Vasseur
cc7f4fedf6
Rebase with recent changes
2016-10-05 09:47:39 +02:00
Michael Vasseur
3408c8038e
Fix indentation
2016-10-05 09:47:38 +02:00
Michael Vasseur
5a4cdcfde1
'new-window' event handlers can return their window when default behavior is prevented
2016-10-05 09:46:54 +02:00
Michael Vasseur
c811188e22
Updated required code to handle missing additional features for popup windows
2016-10-04 14:38:32 +09:00
Kevin Sawicki
24bcf6ac16
Add initial cookie changed event support
2016-09-29 09:16:29 -07:00
Cheng Zhao
734f42b5f9
Merge pull request #7319 from Menci/master
...
Workaround for electron/electron#5050
2016-09-29 16:42:30 +08:00
Menci
ca68dfe097
🎨 Remove extra semicolon
2016-09-28 06:45:15 +08:00
Cheng Zhao
458c4dd129
Merge branch 'support-chromium-sandbox' of https://github.com/tarruda/electron into tarruda-support-chromium-sandbox
2016-09-27 20:02:23 +08:00
Menci
ef45b67dbf
🐧 🐛 Move the workaround to lib/browser/init.js
2016-09-27 19:19:52 +08:00
Thiago de Arruda
a64978b812
Use the routing id on api::WebContents::GetID
...
The sandbox option allows multiple webContents in one renderer process, so using
the only the renderer id to identify WebContents instances is no longer an
option.
WebContents::GetID now returns a 64-bit integer, which is composed of both the
process id(high 32), and the RenderViewHost routing id(low 32). Also add a
`GetProcessID` that retrieves the renderer process id, a requirement in some of
our javascript code.
2016-09-27 06:01:47 -03:00
Thiago de Arruda
72154b64ed
Embed setup bundle for preload scripts in sandboxed renderers.
...
Add a gyp target that creates a browserify bundle starting with
`lib/sandboxed_renderer/init.js`, which is embedded into the executable using
the `atom_js2c` target.
The goal of this bundle is to provide a very basic environment for preload
scripts where a `require` function is available.
2016-09-27 06:01:47 -03:00
Thiago de Arruda
695509e267
Add browser side support for reading files from renderer.
2016-09-27 06:01:46 -03:00
Thiago de Arruda
0f7652dc85
Move code that defines ipcRenderer methods into another file.
2016-09-27 06:01:46 -03:00
Thiago de Arruda
06cc9a44fe
Add support for native chromium popups on sandboxed renderers.
...
- Allow `api::Window` instances to be created from existing `api::WebContents`.
- Override `WebContentsCreated` and `AddNewContents` to wrap renderer-created
`content::WebContents` into `api::WebContents`.
- For `content::WebContents` that should be displayed in new windows, pass the
wrapped `api::WebContents` object to window manager.
2016-09-27 06:01:46 -03:00
Menci
938b9e897a
🐧 🐛 Workaround for electron/electron#5050
...
Chromium only show the Tray icon with libappindicator when the env `XDG_CURRENT_DESKTOP`'s value is `Unity`. But under elementaryOS its value is 'Pantheon'.
Set it to `Unity` before app startup make the tray icon show under elementaryOS.
2016-09-23 18:07:43 +08:00
Zeke Sikelianos
56d62ff589
add html doctype
2016-09-22 14:47:20 -07:00
Zeke Sikelianos
62375663ab
add type to webview style tag
2016-09-22 14:34:03 -07:00
Cheng Zhao
e3e450613d
Merge pull request #7157 from Mossop/moveguest
...
Allow moving a webcontents to a different webview
2016-09-20 14:28:42 +09:00
Kevin Sawicki
48fd2bd35f
binding -> bindings
2016-09-19 09:31:59 -07:00
Felix Rieseberg
29fa48d8c3
🔧 Ensure correct types for commandLine
...
This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding.
2016-09-19 09:31:59 -07:00
Felix Rieseberg
90bff4d9de
🔧 Ensure correct types for commandLine
...
This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding.
2016-09-19 09:31:59 -07:00
Cheng Zhao
0ac4b89a0a
Merge pull request #7236 from yuya-oc/accelerator-for-redo
...
Use Ctrl+Y as the accelerator of redo on Windows
2016-09-19 15:53:44 +09:00
Yuya Ochiai
43f955194e
🏁 Use Ctrl+Y as the accelerator of redo on Windows
2016-09-18 17:07:34 +09:00
Kevin Sawicki
e77d7e7f62
🎨
2016-09-16 11:41:53 -07:00
Kevin Sawicki
5d0f3534eb
Rethrow binding errors
2016-09-16 11:34:52 -07:00
Kevin Sawicki
eef42770c6
Don't load remote properties until they are accessed
2016-09-14 13:29:49 -07:00
Kevin Sawicki
359ab2f9b3
Only set members when members exist
2016-09-14 10:54:23 -07:00
Cheng Zhao
df3f0a4516
Merge pull request #7175 from bsuh/fix-twitch-navigation
...
Fix navigation controller
2016-09-13 16:01:00 +09:00
Cheng Zhao
9a56959647
Merge pull request #7140 from liusy182/url-fix
...
fix a bug in navigation-controller where string is used as object
2016-09-12 14:46:05 +09:00
Brian Suh
5fc1f57fb5
Fix navigation controller
...
In-page navigation has not actually started if the current entry is
being replaced. Do not set inPageIndex if replaceEntry is true.
2016-09-11 14:46:17 -07:00
Dave Townsend
313b2faa3c
Add a guestinstance attribute to webviews reflecting their current guest
...
instance ID and allowing moving a guest instance to a new webview.
2016-09-09 10:32:05 -07:00
Cheng Zhao
693ba1375b
Merge pull request #7146 from electron/resolve-empty-url-values
...
Tweak how empty URLs are resolved
2016-09-09 19:58:41 +09:00
Kevin Sawicki
daf1eec5ec
Use === for string comparison
2016-09-08 17:11:10 -07:00
Kevin Sawicki
1dbaf4987e
Don't resolve empty src/preload attribute values
2016-09-08 16:48:30 -07:00
Kevin Sawicki
9829baed46
Open about:blank when window.open is called with no URL
2016-09-08 16:10:21 -07:00
Kevin Sawicki
d476227e16
Remove unneeded return
2016-09-08 10:20:39 -07:00
Kevin Sawicki
902bd0564e
Require Buffer explicitly instead of relying on global
2016-09-08 10:17:06 -07:00
liusy182
2c7690be45
simplify logic
2016-09-08 21:36:39 +08:00
liusy182
180a77e671
fix a minor bug in navigation-controller where a string is used as an object
2016-09-08 21:31:42 +08:00
Kevin Sawicki
28b33074cf
Setup stdin in both processes on Windows
2016-09-07 14:45:56 -07:00
Cheng Zhao
e561608c0d
Merge pull request #7116 from electron/restore-no-asar
...
Restore process.noAsar in finally block
2016-09-07 16:50:26 +09:00
Kevin Sawicki
46fbb6ed61
Reset process.noAsar in finally block
2016-09-06 13:40:25 -07:00
Kevin Sawicki
b54b74c310
Prevent missing Menu.buildFromTemplate function
2016-09-06 11:31:14 -07:00
Cheng Zhao
f854b27bfb
Merge pull request #6867 from electron/remote-function-properties
...
Allow accessing remote function properties
2016-08-31 17:28:09 +09:00
Kevin Sawicki
01e69353d5
Don't serialize ArrayBuffer as Array
2016-08-24 15:18:42 -07:00
Kevin Sawicki
ec44a5d198
Add tests for setting remote function properties
2016-08-22 17:07:18 -07:00
Kevin Sawicki
666a668d91
Support remote function keys and property descriptors
2016-08-22 17:07:18 -07:00
Kevin Sawicki
d226b7bc6c
Use Proxy for accessing properties of remote function
2016-08-22 17:07:18 -07:00
Kevin Sawicki
8b38018ab4
Add helper for including function properties
2016-08-22 17:07:17 -07:00
Kevin Sawicki
3245bb99b2
Only register methods with members
2016-08-22 17:07:17 -07:00
Kevin Sawicki
d333cc5e38
Support remote function properties
2016-08-22 17:07:17 -07:00
Cheng Zhao
faebe5259d
Merge pull request #6861 from megahertz/bug_window_location
...
Apply resolveURL when set a location of a window opened by window.open()
2016-08-17 22:04:46 +09:00
Alexey Prokhorov
16f2702495
Apply resolveURL when set a location of a window opened by window.open()
2016-08-16 16:24:49 +05:00
bridiver
3b11bf5e41
clear the storage for the webContentsId when the render view is deleted
2016-08-15 21:53:58 -07:00
Samuel Attard
5b07e8dd5b
Send isMainFrame as argument to did-navigate-in-page event
2016-08-12 01:27:50 +10:00
Cheng Zhao
01f92a83ab
Merge pull request #6780 from electron/update-available-check
...
Mark update available until restart
2016-08-09 20:44:26 +09:00
Kevin Sawicki
dd6c69c90b
Use const instead of var
2016-08-08 13:07:01 -07:00
Kevin Sawicki
49908fd818
Keep update available flag set until restart
2016-08-08 13:03:02 -07:00
Kevin Sawicki
af607f8b67
🎨 function -> =>
2016-08-08 11:09:30 -07:00
Kevin Sawicki
bcc372568f
Add zoom menu item roles
2016-08-08 11:09:30 -07:00
Milan Burda
edc1a9614c
Add macOS specific speaking roles for MenuItem
2016-08-08 00:02:32 +02:00
Cheng Zhao
8c0a033b6f
Fix lint errors of using __proto__
2016-08-02 21:02:28 +09:00
Cheng Zhao
edb573d69e
Make WebContents inherit NavigationController
2016-08-02 20:55:56 +09:00
Cheng Zhao
025034127a
Set JavaScript APIs on prototype of WebContents
2016-08-02 20:52:07 +09:00
Cheng Zhao
844f32aa36
Set prototype of constructor directly
2016-08-02 20:38:35 +09:00
Cheng Zhao
895b8b47ee
Save the prototype of EventEmitter
2016-08-02 18:07:58 +09:00
Cheng Zhao
892026458d
Cleanup init.js
2016-08-02 17:45:46 +09:00
Cheng Zhao
6e0cde5b24
All native objects have prototype now
2016-08-02 17:12:17 +09:00
Cheng Zhao
56b1abd64a
Merge pull request #6685 from electron/document-contents-zoom
...
Implement and Document the zoom methods that are mapped to the webContents object
2016-08-02 14:41:09 +09:00
Samuel Attard
a498cf5b79
Fix linting issues
2016-08-02 13:13:17 +10:00
Samuel Attard
e4f6083753
Implement asynchronous versions of getZoomFactor and GetZoomLevel on the webContents object
2016-08-02 13:02:55 +10:00
Gabriel Handford
7bde92deb9
Add isVisible() to app.dock
2016-08-01 15:22:37 -07:00
Cheng Zhao
ffed3e9c0c
Move the code to native
2016-08-01 20:11:17 +09:00
Cheng Zhao
d23d9dcf01
Do not garbage collect sessions
2016-08-01 19:35:51 +09:00
Cheng Zhao
1e61743242
Merge pull request #6602 from electron/appusermodelid-remove-spaces
...
Remove all spaces from potential appUserModelID as it isn't allowed by the spec
2016-07-27 10:53:52 +09:00
Samuel Attard
9f0299cc31
Use better regex to match spaces
2016-07-27 09:38:49 +10:00
Cheng Zhao
8d941a6559
Merge pull request #6566 from electron/win-autoupdater-es6
...
Move autoUpdater to ES6
2016-07-26 12:46:00 +09:00
Cheng Zhao
b139d5ad1c
Merge pull request #6598 from electron/fs-access-asar
...
Add asar implementation of fs.access/accessSync
2016-07-26 12:42:59 +09:00
Samuel Attard
12dba2cb67
Remove all spaces from potential appUserModelID as it isn't allowed by the spec
2016-07-26 11:44:01 +10:00
Samuel Attard
20e26a9639
Move auto-updater-win to ES6
2016-07-26 11:40:55 +10:00
Feross Aboukhadijeh
d6a7ced32c
MenuItem: Use 'Close Window' for 'close' role label
...
On OS X, the standard label that's used for the 'close' role is 'Close
Window'. You can see this in the default macOS apps from Apple.
2016-07-25 15:13:17 -07:00
Kevin Sawicki
8eca019157
Support paths as Buffers
2016-07-25 11:10:36 -07:00
Kevin Sawicki
30fbe92970
Add asar-supported fs.accessSync implementation
2016-07-25 11:05:18 -07:00
Kevin Sawicki
3ad5504194
Add asar-supported fs.access implementation
2016-07-25 10:50:30 -07:00
Kevin Sawicki
a518c47f4c
Use let/const instead of var
2016-07-25 10:43:38 -07:00
Cheng Zhao
9ddb62c42a
Use Buffer.from instead of deprecated new Buffer
2016-07-25 16:40:22 +09:00
Cheng Zhao
1c9421bc89
Use ArrayBuffer.isView to detect Buffer and ArrayBuffer
2016-07-25 16:39:09 +09:00
Cheng Zhao
200d09cc70
Merge pull request #6572 from haadcode/master
...
Add support for TypedArrays in IPC.
2016-07-25 16:22:29 +09:00
Cheng Zhao
751ee53683
Do not throw exception when channel name is "error"
2016-07-24 21:08:25 +09:00
haad
fac330fb50
Fix TypedArray check, add check when instanceof doesn't work for TypedArrays.
2016-07-23 12:43:49 +01:00
haad
2757046e71
Add isTypedArray to Electron exports
2016-07-23 11:30:14 +01:00
haad
e6c8900a18
Fix linting
2016-07-22 20:20:24 +01:00
haad
c717cd9192
🐛 Add support for TypedArrays in IPC.
...
Fixes https://github.com/electron/electron/issues/2104 .
2016-07-22 19:44:19 +01:00
Cheng Zhao
9eacd07eda
Merge pull request #6489 from electron/webcontents-static-api
...
Document static methods on webContents
2016-07-15 11:02:00 +09:00
Cheng Zhao
2791f71c03
webContents is now a public module
2016-07-15 10:59:19 +09:00